Sinjae Lee [Thu, 3 Jul 2014 07:43:39 +0000 (16:43 +0900)]
(ItemView) Modified scroll speed and flick animation duration calculation for gallery application
[problem] Flick sensitivity is different with Reference device
[solution] Used squared pan velocity for scroll speed calculation to get longer move distance & duration
Applied min/max flick animation duration
Change-Id: I4a5b3639dbd4ce56e2f9a5b837728c70c23fc265
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Agnelo Vaz [Mon, 30 Jun 2014 15:04:54 +0000 (16:04 +0100)]
Scrollview Ensure Overshoot is shown even if Y ruler is the same as Scrollview height
[problem] Bug meant overshoot was not shown if a y ruler was set that did not allow vertical scrolling
[solution] Replace erronous line of code
Change-Id: I0edb22ce015e01dde02e3c8ddf94921799fcd550
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Julien Heanley [Tue, 10 Jun 2014 15:25:20 +0000 (16:25 +0100)]
ScrollView - Remove separate X and Y scroll properties as these are now redundant and only mirror the pre position Vector3 property.
This removes 2 constraints and 2 properties from ScrollView
Change-Id: I63c6efd6d7f934e8f013733ac078b681ecac237a
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Julien Heanley [Tue, 10 Jun 2014 15:12:28 +0000 (16:12 +0100)]
ScrollView - Set pan start position directly into panning constraint when creating it, reducing touch distance in certain cases
[problem] Displacement value passed into constraint could be a frame behind, meaning we lose the initial pan started frame displacement
[cause] Update thread was already running at same time as event thread called ApplyConstraint
[solution] Instead of passing in displacement as a property input, create the constraint with event side pan start position
Change-Id: I0ee55c79b8450cdc68f8e04dad4019001b65966f
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Agnelo Vaz [Tue, 24 Jun 2014 14:54:59 +0000 (15:54 +0100)]
TextInput Popup scrolling fixed after GUI changes. GUI settings changed.
[problem] Scrolling would cause the buttons to leave the popup area. Change language to French to see issue
[cause] Regression
[solution] Popup sizes amended so buttons scroll again if do not fit. Popup max width reduced to look more like Tizen apps.
Change-Id: Ibac5b243fd30a5c2f5bd58d0a4884676ae3aae5c
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Julien Heanley [Mon, 30 Jun 2014 09:51:33 +0000 (10:51 +0100)]
ScrollView - Fix wrapping issue in FixedRuler::GetPageFromPosition
[problem] Incorrect page would be returned from FixedRuler::GatePageFromPosition when continuously panning right
[cause] An unwrapped value is passed in since the scrolling never finishes
[solution] Wrap the value internally before checking position against domain size
Change-Id: I4eaad7a2bfc7c711b53ed310372fd85f6ee77bfb
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Fri, 27 Jun 2014 09:23:02 +0000 (18:23 +0900)]
(ScrollView) Removed unnecessary scale constraints from scroll-view
[problem] ScrollView should not scale itself or its children
[solution] Remove constraints that do this
Change-Id: I9259643006e4b2d7dc7030bbebe3856e1073a5f8
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Fri, 27 Jun 2014 07:06:31 +0000 (16:06 +0900)]
(ScrollView) Remove redundant scaling & rotation functionality
[problem] ScrollView, as the name suggests, should only scroll, not scale or rotate.
Scaling and rotation does not work propertly so there are a lot of calculations
which are not needed.
[solution] Remove scaling functionality and deprecate APIs.
Change-Id: I22bc2755cfe74753c0063cc9644995c2388eeab0
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Julien Heanley [Wed, 25 Jun 2014 13:23:31 +0000 (14:23 +0100)]
ScrollView - Added APIs for minimum pan speed/distance before being considered a flick
[problem] Application could not change minimum flick speed and distance
[solution] Added APIs to change minimum flick speed/distance
Change-Id: Ia1941662a04fe8ec3d058bd926c9e0f6a4b73b23
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Fri, 27 Jun 2014 12:29:45 +0000 (21:29 +0900)]
(ScrollView) Check for an interrupted event and finish transform
[problem] Scroll-view can get stuck if it doesn't receive an up event after it receives a down
[cause] It is no longer the hit-actor (or a parent of the hit-actor).
[solution] Together with the core change (Emit Up to down consumer) -> comes as interrupted
React to interrupted event now in a similar manner to up event
Change-Id: I3c44276e3f8168fb2d9e9016e11f6ce497b40761
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Richard Huang [Fri, 27 Jun 2014 10:40:35 +0000 (11:40 +0100)]
ItemView cache should always be refreshed during scrolling
[problem] When ItemView is scrolling, activate a new layout and no new items are
created.
[cause] Caching extra items are avoided when activating new layout in order to
improve the performance. However, new layout can be activated during
scrolling, and no new items are created in that case.
[solution] Always refresh the cache with extra items while scrolling.
Change-Id: I12a5810b2c35891d1928a9853a6ed1d21e1eada4
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Fri, 27 Jun 2014 04:51:33 +0000 (13:51 +0900)]
(ScrollView) Remove unused member variables
[problem] Some member variables that are declared in the header are not used.
[solution] Remove.
Change-Id: I8278643b612731e53211a96ff68d7d198eeac1b5
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Mon, 23 Jun 2014 14:26:04 +0000 (23:26 +0900)]
(ScrollView) Ensure we emit the signal if scroll is stopped on touch-down
[problem] When interrupting pan on touch-down, scroll-completed signal is not emitted.
[cause] We clear the scroll animation flags and then check if we were scrolling.
[solution] Create a local copy of the flags first so that comparisons are valid with actual
state.
Change-Id: I8f98b9d4cd9d1342f9505156b8bbb55da7942557
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Richard Huang [Wed, 25 Jun 2014 17:33:38 +0000 (18:33 +0100)]
Prevent fighting of setting scroll position property by ItemView and ScrollBar
[problem] When ItemView is still scrolling, touch and drag the fast scroll bar,
the fast scroll bar is not responsive for some time and ItemView scrolls
to the wrong position sometimes.
[cause] When scroll position property is being animated by ItemView, if something
else (e.g. ScrollBar) tries to modify the scroll position property at the
same time, there is a fighting of setting the same property between the two.
[solution] Cancel scroll animation when it is in fast scroll mode.
Change-Id: I3de03d7b21b929fe527b907e58464896b774c489
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Julien Heanley [Thu, 26 Jun 2014 12:10:16 +0000 (13:10 +0100)]
ScrollView - Increased the angle range for a flick to allow snapping to next snap point
[problem] Near vertical flick on a ScrollView with only horizontal panning would not result in snapping to next snap point
[cause] Angle of flick had to be within 60 degrees of the axis to snap on
[solution] Increased angle to 75 degrees
Change-Id: I5ebc95378a35436f1fc8cabe72b9602061ec4324
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Thu, 26 Jun 2014 02:40:08 +0000 (11:40 +0900)]
(Build) Remove unrequired utilX dependency
[problem] UtilX is included in spec file but it is not required.
[solution] Remove dependency.
Change-Id: I285cce9286c92393ea0c7cf3753262d2d963a837
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Richard Huang [Tue, 24 Jun 2014 15:09:07 +0000 (16:09 +0100)]
Stop caching extra items while activating layout in ItemView
[problem] While activating new layout, ItemView tries to cache extra items.
But this can block the event thread if it takes very long time to
create these extra items.
[solution] Only create visible items while activating layout, and cache extra
items only when scrolling.
Change-Id: I04eba3ae0d1f05c470d330dac52bd602a406df56
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
jonghyun.ho [Tue, 24 Jun 2014 11:41:08 +0000 (20:41 +0900)]
Remove valgrind warning of SuperBlurView #2
Change-Id: I406cb58c9fae1432ff63698fd7c62bbaf2a49a5d
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Agnelo Vaz [Mon, 23 Jun 2014 20:52:40 +0000 (21:52 +0100)]
TextInput Popup is parented to TextInput so moves with it. Tail flips if Popup in lower position
[problem] Popup Tail points down even if highlighted text is above it. Popup does not move with TextInput.
[cause] Missing code.
[solution] Use different image in this case and reposition.
Change-Id: I15236fb02b7bc09a1e8c012bae4c93735cf24dd7
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
jonghyun.ho [Tue, 24 Jun 2014 08:06:36 +0000 (17:06 +0900)]
Remove valgrind warning of SuperBlurView
Change-Id: I73d81f484f8fe8c22f5796adf746e9b03540dd8c
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
jonghyun.ho [Mon, 23 Jun 2014 09:30:19 +0000 (18:30 +0900)]
Reset mGestureStackDepth when panning is interrupted by ScrollTo
[problem] ScrollView is stopped and not snapped
[cause] mGestureStackDepth is not zero so FinishTransform is not called
[solution] Reset mGestureStackDepth when panning is interrupted by ScrollTo
Change-Id: I694cc769279c1e25039dbe0660eda542dfdd9a8e
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Xiangyin Ma [Wed, 11 Jun 2014 11:09:47 +0000 (12:09 +0100)]
New Bouncing Effect
Patch 1: Add API CreateBouncingEffectActor to creates a Dali::Actor to display the bouncing effect for overshoot
Patch 5: Integrate with ScrollView, ItemView
Patch 7: Add PROPERTY_OVERSHOOT_EFFECT_COLOR to allow the StyleManager to apply the theme color
Reduce the height of the effect when the width of scrollable is less than 180px
patch 9: Add the script for overshoot-effect-color
patch 14: fix the size bug
Change-Id: I2f979ff59ab78b4ce8931b36d0bc2dff48dc7901
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Richard Huang [Fri, 20 Jun 2014 18:31:35 +0000 (19:31 +0100)]
Allow configurable speed factor when ItemView is being swiped.
[problem] No way to configure scroll speed factor separately while panning or flicking.
Therefore for some layouts you can't get a value to make both panning and
flicking work.
[cause] Only one scroll speed factor for both panning and flicking.
[solution] New API for configurable speed factor while flicking.
Change-Id: Ia58a4346db0923410fd61005efb38f4d1ca4a843
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
daemyung jang [Sat, 21 Jun 2014 10:09:24 +0000 (19:09 +0900)]
No use the animation when text input popup is pressed.
[problem] The speed of the pressed effect is too slow than the efl.
[cause] The text input popup has a animation duration.
[solution] Make the duration is zero.
Change-Id: Iec9a0e215cb24157ceb7ebecde519de5da29dea8
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Victor Cebollada [Fri, 20 Jun 2014 07:47:24 +0000 (08:47 +0100)]
Optimization to reduce Handle size by 50%
[problem] Memory usage is too high, event-thread operations are too heavy.
[cause] Too much Dali::Handle data copied around.
[solution] Remove all virtual methods from handles, to avoid needing a C++ vptr
Change-Id: I87c8c526be53413e895a88ac8a355083a4797d8e
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Richard Huang [Wed, 18 Jun 2014 13:30:55 +0000 (14:30 +0100)]
Notify ItemFactory when an item is removed from ItemView
Change-Id: I0620a480d54d5fc78b7e032957f30829f5ae9feb
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Richard Huang [Wed, 18 Jun 2014 12:23:25 +0000 (13:23 +0100)]
New API to get the range of items in the current ItemView cache
Change-Id: I559963ec022f6bd2d4c607da6c2a0ce19190aacf
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Kimmo Hoikka [Thu, 19 Jun 2014 15:56:39 +0000 (16:56 +0100)]
size optimization on Control::Impl, reduces size from 232b to 200b on 64bit x86, saving a bit over 1k RAM in Dali-demo case
Change-Id: I0fba95320e1ebbf07538dd0dfadc5890c0311d6d
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
daemyung jang [Thu, 19 Jun 2014 14:12:32 +0000 (23:12 +0900)]
Update the text input popup GUI.
[problem] The text input popup is expired.
[cause] The new gui guide is published.
[solution] Update the new gui.
Change-Id: I9a3bf7348be0138803f1e8978303449c53bc696d
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Thu, 19 Jun 2014 13:36:27 +0000 (22:36 +0900)]
(ScrollView) Panning is disabled if ScrollTo is called while panning
[problem] If application calls ScrollTo while we're panning we go into an incorrect state.
[cause] When we're panning, and the application calls ScrollTo, swiftly followed by a call
to disable scroll-sensitivity, the panning value is never cleared.
When scroll-sensitivity is enabled, we start animating to a wrong position.
Also trying to use the property value when we set sensitivity which can be out-of-date.
[solution] Clear the panning value when we want to animate to another position.
Use event-side panning value when changing scroll-sensitivity.
Change-Id: I3cc2200839ad3a2ec1fc705f542bd8df41502462
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Lee Morgan [Thu, 19 Jun 2014 14:19:30 +0000 (15:19 +0100)]
Prevent valgrind error with Json parser
Change-Id: Iad91a8d2cf5ec0c7d1cfa41786a1e95a8c56d065
Signed-off-by: Lee Morgan <Lee.morgan@partner.samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Wed, 18 Jun 2014 10:12:53 +0000 (19:12 +0900)]
(ScrollView) If animation duration is 0, then return final position in completed signal
[problem] If the animation duration is 0, we still return the current scroll position. This is
wrong as in the next frame, we will be at the requested position.
[cause] N/A
[solution] If we do not kick off an animation, then we should check whether the duration was 0.
If it was, we should return the target-position instead.
Change-Id: I3e1a96b3de7ca2685a16f6dd6b8ce5aebc1c78af
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Agnelo Vaz [Tue, 17 Jun 2014 23:35:45 +0000 (00:35 +0100)]
TextInput PopUp now appears in between handles or at Grabhandle, improved Tail positioning
Change-Id: Ic71a0a493bd46c531c2cd8c0bac84a9927dfb3be
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Agnelo Vaz [Tue, 17 Jun 2014 14:10:11 +0000 (15:10 +0100)]
TextInput Popup border colour styling and missing offset property registration.
[problem] Scripting can not be used to change the border colour of the popup
[solution] Add Property for border colour
Change-Id: I99f45fee20c1ba26c75155cae53e924a09fd802f
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Xiangyin Ma [Fri, 13 Jun 2014 18:52:00 +0000 (19:52 +0100)]
Add color lookup into Builder & apply changeable color on TextInput
Change-Id: I4720b85f7df61ead9f1b1e0486792d6770b6c070
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Agnelo Vaz [Mon, 16 Jun 2014 16:02:11 +0000 (17:02 +0100)]
TextInput Popup has a tail which points to the TextInput
[problem] User may not know the cut and paste popup applies to the current TextInput
[solution] Display a tail which points to the TextInput.
Change-Id: I712eb34ce00fbf3a02e7fe4bd975fc556b5c97e6
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
jonghyun.ho [Tue, 17 Jun 2014 04:53:15 +0000 (13:53 +0900)]
Add more logs to ScrollView especially in ScrollTo, TransformTo
[problem] ScrollView returns the invalid position on each scroll signals
[solution] Add more logs to ScrollView especially in ScrollTo, TransformTo
Change-Id: I691ba76c16c72975c426338632304b54efca460c
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Jonghyun Ho [Sat, 14 Jun 2014 03:21:32 +0000 (12:21 +0900)]
Revert "ScrollView - Store properties in local values for GetCurrentScrollPosition"
Change-Id: I50d5d429f72c8fc58d3053fb8c493f38c87a228b
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Kimmo Hoikka [Fri, 13 Jun 2014 12:22:11 +0000 (13:22 +0100)]
Reducing control size from 256 bytes to 224 by reordering data members and bitfielding enums
Change-Id: Ic008566812f3445105f85912a6860fe0d960bb06
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Agnelo Vaz [Wed, 11 Jun 2014 20:39:37 +0000 (21:39 +0100)]
TextInput PopUp supports scrolling if buttons do not fit in visible area.
[problem] If too many buttons in popup then part of it can be off screen
[solution] Popup using a scroll view and allows scrolling of the buttons
Change-Id: I92b269c24a81d891ffa4ab4011dd86d0f9fc96e4
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Victor Cebollada [Thu, 12 Jun 2014 13:27:34 +0000 (14:27 +0100)]
Replace deprecated TextStyle methods.
Change-Id: I67ff44822a70e3279796be2a67efe635e24f3c82
Signed-off-by: Victor Cebollada <v.cebollada@samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Kimmo Hoikka [Fri, 13 Jun 2014 10:08:48 +0000 (11:08 +0100)]
Optimized size negotiation
1. Remove size negotiation from scrollable things as they are not layout containers (yes, ItemView does not do size negotiations)
2. Make size negotiation containers members of relayout controller so we avoid hundreds of memory allocations per frame
3. Reduce the overhead of size negotiation request by having a static flag instead of hundreds of handle creations and dynamic casts etc
Change-Id: I9f11a45a70b262c0c6a07358350a8203c21fc2ce
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Julien Heanley [Thu, 12 Jun 2014 10:43:42 +0000 (11:43 +0100)]
ScrollView - Store properties in local values for GetCurrentScrollPosition
[problem] If application performs more than one ScrollTo operation with the first having duration of 0 seconds, the second ScrollTo could have wrapping issues
[cause] Internally scroll view uses current scroll position from property to check wrapping and perform correct animation, in case where this is done twice before an update the property may be incorrect for the second ScrollTo
[solution] Store result of first ScrollTo if it is set immediately due to 0 second duration and use that value for next ScrollTo calculations
Change-Id: I5230e00140c3cb75df8b14fc5e9227c16928406f
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Julien Heanley [Thu, 12 Jun 2014 10:13:08 +0000 (11:13 +0100)]
ScrollView - Second part of overshoot fix, overshoot will now only animate if pre scroll and post scroll values are different, preventing updating when not needed and saving power
[problem] If wrapping is on, the overshoot animation would still be animated for 0.35s
[cause] Values used to compare were at opposite ends of scroll view due to wrapping
[solution] Wrap the correct value back round so in wrapping mode they were both the same, in this case Snapping overshoot is avoided
Change-Id: I4d85cc5cb814a4cdc48c3edca66a7d4e6bc945ad
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Kimmo Hoikka [Thu, 12 Jun 2014 09:58:19 +0000 (10:58 +0100)]
Fix activate action on Control
Change-Id: Ia3d2c920984a2dc322a9a9765818835706f1bc6d
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Thu, 12 Jun 2014 12:30:11 +0000 (13:30 +0100)]
(ScrollView) Disable ALWAYS-ON logging.
[problem] Logging is always on in scroll-view
[solution] Disable, comment out to enable it on local builds
Change-Id: I5780f0783182d77e6d6dbe330f890a47a1505810
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Julien Heanley [Wed, 11 Jun 2014 12:37:11 +0000 (13:37 +0100)]
ScrollView - Fix for scroll effect issues found due to ruler disabling not updating min/max scroll positions
[problem] Scrolling could result in page disappearing during scrolling due to incorrect scroll domain (change homescreen scroll effect to outer cube/spiral)
[solution] Added code to deal with ruler being disabled, now the min/max values for that ruler are reset to 0
Change-Id: I34e95761fb58dfe4d2bc3580671415f1f6f2e707
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
jonghyun.ho [Thu, 12 Jun 2014 05:31:46 +0000 (14:31 +0900)]
Add some logs to find out cause of once happened scrollview issue #2
Change-Id: Ife0241d7258973eeaf59c3853e698b2a1c400949
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Julien Heanley [Thu, 22 May 2014 16:10:27 +0000 (17:10 +0100)]
ScrollView - Stop Timer running in homescreen idle state
[problem] Load analyzer shows homescreen is running in idle state
[cause] ScrollView refresh timer is running continuously
[solution] Replaced Timer with PropertyNotification, added new API's for ScrollUpdateDistance instead of RefreshInterval
Change-Id: Id5a0dfa15752d805703d2d88845f1462d2b07030
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
jonghyun.ho [Tue, 10 Jun 2014 12:11:21 +0000 (21:11 +0900)]
Add some logs to find out cause of once happened scrollview issue
Change-Id: I80e242dc036b6191f74fee5acf4a3c02af1b6481
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Julien Heanley [Tue, 10 Jun 2014 18:34:53 +0000 (19:34 +0100)]
ScrollView - Fix for incorrect min/max scroll property values
[problem] Scroll min/max property values would be incorrect
[cause] UpdatePropertyDomain attempts to avoid setting values if ones requested are the same as current properties. If SetRulerX/Y is called once with incorrect value and a second time with correct value, but same as value before first call, the property value retrieved will still be the old value and evaluate as the same, even though after next update frame this value is changed to same value as the first call
[solution] Store last set values locally and check against these instead of actual properties.
Change-Id: I62bc6fd3b5f9d8e9cbbb000b90b46fc90c0dd51a
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Francisco Santos [Mon, 9 Jun 2014 02:17:16 +0000 (11:17 +0900)]
Remove animation while panning.
Change-Id: Ic9fe7891e97908798e771ec1895013d09424c0f8
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
David Steele [Wed, 11 Jun 2014 13:21:25 +0000 (14:21 +0100)]
Fixed RPM Lint errors
Change-Id: Ia9401138e54d403bc0c1a6048bd4d3ca50f5e74d
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Agnelo Vaz [Fri, 30 May 2014 13:44:46 +0000 (14:44 +0100)]
TextInput uses style properties for PopUp and Highlight
[problem] Popup button order, colour of background, colour of pressed buttons and highlight predefined in internal code
[solution] Dali Properties now represent the above settings so can be defined in a JSON file or via the Public API.
Change-Id: Ia33d63d95cfdcbfb095a31c1cf514368f2683814
Julien Heanley [Tue, 10 Jun 2014 10:03:42 +0000 (11:03 +0100)]
ScrollView - Overshoot Fix
[problem] Overshoot would appear even when no scrolling is possible
[cause] Was not checking the 'can scroll' property
[solution] Check 'can scroll' property
Change-Id: I289986ae1fd16150641298cb33532114150749c5
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Julien Heanley [Tue, 10 Jun 2014 07:53:24 +0000 (08:53 +0100)]
ScrollView - Fix for pixel value used as animation time
[problem] Animation from scroll view had large time preventing update thread from sleeping
[solution] Clamp animation time
Change-Id: I0d8a26aee100cedf6fb04f69724446dfe3f60354
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Paul Wisbey [Tue, 10 Jun 2014 04:36:21 +0000 (13:36 +0900)]
Stop rendering during idle state
[problem] Sometimes rendering continues forever (even in idle state).
[cause] ScrollView AnimateInternalXTo is playing Animations with
invalid durations. It either uses a large duration which causes the
issue, otherwise it plays with duration zero (also incorrect).
[solution] Remove the redundant animation logic (since animating
mPropertyPrePosition to itself is a NOOP)
David Steele [Mon, 9 Jun 2014 16:08:18 +0000 (17:08 +0100)]
Updated test scripts to allow executing smaller numbers of tests
[problem] Executing test cases takes too long
[cause] Granularity is too high
[solution] Add option to run tests from a specific test case file
Change-Id: I1023fd50f65d903c16e36965370f3777293a1271
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Agnelo Vaz [Mon, 9 Jun 2014 15:14:41 +0000 (16:14 +0100)]
Builder support for unsigned int property conversion
[problem] Builder was unable to convert property values to unsigned int
[cause] Used integer comparison
[solution] Added a property to unsigned int conversion
Change-Id: I6ccfac3561d016c197e18e518df35ccf9783c505
Julien Heanley [Fri, 21 Feb 2014 11:09:08 +0000 (11:09 +0000)]
(ScrollView) Updates to scroll view internals to improve responsiveness and smoothness of visual actions
[Problem] Overshoot indicator could occasionally remain on screen, overshoot would prevent panning in opposite direction until pan returned to point where overshoot started
[Solution] Replaced numerous constraints with property notifications.
Implemented the new vector component animation to remove need for separate internal x/y components.
First stage of constraint reduction on ScrollView, more to follow
Pre clamp scroll value is now snapped back to clamped position using animation and no longer needs a constraint to follow old internal x/y components
Made functionality of overshoot more solid by making it directly dependant on pre clamped scroll and post clamp scroll values now that animation is done elsewhere.
Overshoot no longer instantly flicks back to 0 if user releases and restarts a gesture before values have finished animating back
If a pan has locked to an axis it now remains locked if user releases and starts another pan before scrolling has completed, preventing issue where a vertical page scroll could be started in the middle of a horizontal page scroll, which brakes the appearance of all page scroll effects.
Change-Id: I73e8ca71f5ffd8eb3c8a1fbf91823881ac4bb2ce
Signed-off-by: Julien Heanley <j.heanley@partner.samsung.com>
Richard Huang [Thu, 5 Jun 2014 14:52:41 +0000 (15:52 +0100)]
Fixed wrong scroll direction for mouse wheel event in ItemView and ScrollView
[problem] ScrollView and ItemView are moving in the wrong direction for mouse wheel event.
[solution] Fixed the scroll direction for mouse wheel event in ItemView and ScrollView.
Taeyoon [Tue, 3 Jun 2014 10:02:53 +0000 (19:02 +0900)]
Conversion to Apache 2.0 license
Change-Id: Ieba1af3439cf87694a6893c684b78dc13de0ede9
jonghyun.ho [Thu, 5 Jun 2014 01:35:45 +0000 (10:35 +0900)]
Upload package dali-toolkit_0.9.21
Paul Wisbey [Tue, 3 Jun 2014 10:42:21 +0000 (19:42 +0900)]
ScrollView: Avoid animating in wrong direction during fast flick
[problem] When flicking pages quickly, it sometimes jumps backwards
[cause] Incorrect (infinite) velocity calculation in ScrollView::OnTouchEvent()
[solution] Don't interrupt snap-animation immediately during TouchPoint::Down i.e. allow
time for pan gesture to occur.
Kingsley Stephens [Thu, 29 May 2014 14:27:41 +0000 (15:27 +0100)]
(StyleManager) Add style monitor signal into StyleManager
[problem] The StyleManager was missing the StyleMonitor signal
[solution] Connect StyleManager to StyleMonitor style change signal
patch 2: combine ThemeChangeSignal and StyleChangeSignal into one
Change-Id: I8141b0b71091b42b6c0a2db047272ded6d21b273
Adeel Kazmi [Thu, 29 May 2014 13:13:50 +0000 (22:13 +0900)]
Revert "Revert "[SRUK] (StyleManager) Create a style manager""
Change-Id: I35a410e4a1b1979f2f1738b1457190f415fca43c
Agnelo Vaz [Fri, 30 May 2014 13:15:25 +0000 (14:15 +0100)]
TextInput Adding Highlight Class to be used by Decorator
[problem] Highlight class previously stubbed.
[cause] Part of incremental refactor
[solution] Implement Hightlight class, currently built but not used in existing TextInput. Will be used in future patch.
Change-Id: I6ab0e63fcfdd4f3ad667ce5a83fb708d751fd476
Francisco Santos [Thu, 29 May 2014 05:47:29 +0000 (14:47 +0900)]
Add new API to ScrollBar to set background and indicator images.
[problem] API forces application to provide a border even when using automatic 9 patch images.
[cause] API was designed for old nine patch.
[solution] Provide new API and deprecate old API.
Change-Id: Ie223643e8334f77e836ebcdd78cbf0b106a340c5
Signed-off-by: Francisco Santos <f1.santos@samsung.com>
jonghyun.ho [Mon, 2 Jun 2014 00:40:04 +0000 (09:40 +0900)]
Upload package dali-toolkit_0.9.20
Paul Wisbey [Sat, 31 May 2014 03:09:21 +0000 (12:09 +0900)]
ScrollView: Avoid unintentional contraints on X/Y properties
[problem] Snap animation is not working in homescreen ScrollView
[cause] Whilst the X/Y properties are animated, they are unintentionally
constrained to match the position from previous pan
[solution] More logic to ensure constraints are removed after pan finishes.
Sinjae Lee [Sat, 24 May 2014 07:24:40 +0000 (16:24 +0900)]
(FocusManager) Updated Accessibility features (Part2)
jonghyun.ho [Thu, 29 May 2014 01:47:02 +0000 (10:47 +0900)]
Upload package dali-toolkit_0.9.19
Francisco Santos [Wed, 28 May 2014 02:11:25 +0000 (11:11 +0900)]
Fix boost includes
Change-Id: Ib105bf32700dec8c5f70396c62970493303254df
Signed-off-by: Francisco Santos <f1.santos@samsung.com>
Jonghyun Ho [Tue, 27 May 2014 01:43:03 +0000 (10:43 +0900)]
Easier page switching with Accessibility pan
Allow a gentle left-right pan to switch homescreen pages.
Adeel Kazmi [Wed, 28 May 2014 17:38:58 +0000 (02:38 +0900)]
Revert "[SRUK] (StyleManager) Create a style manager"
Font change no longer delivered.
This reverts commit
9df291f3bec83cbbe26ae2d9b988e688d27a8b84.
Change-Id: I44fc0574eb11bac748437f8c78b1502d80effca8
Kingsley Stephens [Wed, 28 May 2014 14:32:00 +0000 (15:32 +0100)]
(StyleManager) Remove StyleManager header include form CAPI
[problem] Control-impl.h was including StyleManager.h
[solution] Remove the header file
Change-Id: I63d70842ed505516776b8e287aecf741018c16ad
David Steele [Tue, 27 May 2014 17:38:47 +0000 (18:38 +0100)]
Fixed dependencies for building on other architectures
[problem] Dali is exclusive to Arm architecture at the moment
[cause] Broken dependencies on i586/x86_64 builds
[solution] Fix the dependencies and remove exclusivity
Change-Id: I71ef589fb0591eaf3d5b40d1b1b2ae0515652417
Signed-off-by: David Steele <david.steele@partner.samsung.com>
David Steele [Tue, 27 May 2014 14:36:47 +0000 (15:36 +0100)]
Removing unnecessary boost dependency.
Change-Id: I446bb55b31f586972d918c8cefbce36cdbead922
Signed-off-by: David Steele <david.steele@partner.samsung.com>
Kingsley Stephens [Thu, 3 Apr 2014 16:08:51 +0000 (17:08 +0100)]
(StyleManager) Create a style manager
Change-Id: Ibb82ca3f21a77899cb14e6296bc245befe8928f6
Adeel Kazmi [Wed, 11 Jun 2014 07:46:30 +0000 (08:46 +0100)]
Merge branch 'master' into tizen
Adeel Kazmi [Wed, 11 Jun 2014 07:41:58 +0000 (00:41 -0700)]
Revert "License conversion from Flora to Apache 2.0"
This reverts commit
a881757839b7abb008873a68c67e17b3ba39669b.
Change-Id: Ic5cbf8f706245f7439b91ea22a3b116a8b9a1535
Sunhyun Kim [Mon, 26 May 2014 07:22:37 +0000 (16:22 +0900)]
Add comment to SetMarkupProcessingEnabled()
Application developer can confuse using SetMarkupProcessingEnabled().
i add one example.
1) TextView text = Toolkit::TextView::New( MarkupText[] );
2) text.SetMarkupProcessingEnabled(true);
developer can think MarkupText already enable markupProcessing.
but SetMarkupProcessingEnabled is adapted after SetText().
so i added simply comment to SetMarkupProcessingEnabled().
Paul Wisbey [Fri, 23 May 2014 14:54:39 +0000 (15:54 +0100)]
Partial fix for homescreen panning issue
[problem] When flicking left-right quickly, sometimes homescreen page does not move
[cause] In some cases this is caused by ScrollView using a value before the update
thread has had time to react.
[solution] Added guard logic in positionSnap calculation.
jonghyun.ho [Sat, 24 May 2014 02:36:57 +0000 (11:36 +0900)]
Upload package dali-toolkit_0.9.18.
Paul Wisbey [Thu, 22 May 2014 17:45:52 +0000 (18:45 +0100)]
Fix for flick gesture in Screen Reader mode
[problem] Flick gestures do not work with 2 fingers
[cause] Incorrect velocity calculation
[solution] Use correct 'previous position' in Gesture::Finished event
Victor Cebollada [Fri, 16 May 2014 16:33:58 +0000 (17:33 +0100)]
TextView - Update programming guide.
Change-Id: I3825f3aca4d0f1e2d52d119f2c5868e29ce14ad1
Signed-off-by: Victor Cebollada <v.cebollada@samsung.com>
Agnelo Vaz [Wed, 21 May 2014 13:46:29 +0000 (14:46 +0100)]
TextInput Ensure EmitTextModified occurs with special keys like BACKSPACE
Change-Id: I9ee79797fd33724c48f0c4521485c1a833cc6c37
Wang Qingli [Wed, 21 May 2014 07:27:38 +0000 (15:27 +0800)]
Remove the old constraint from indicator of scrollbar.
Change-Id: I1a65bd64e102c63dab1c11db926ab2aebdc276e0
jonghyun.ho [Wed, 21 May 2014 05:22:57 +0000 (14:22 +0900)]
Upload package dali-toolkit-0.9.17.
Agnelo Vaz [Tue, 20 May 2014 20:37:10 +0000 (21:37 +0100)]
TextInput Emit signal when text is modified.
TextInput emits signal when text is modified, developer can query number of characters on
receiving this signal and behaviour accordingly.
Change-Id: Ie4794493ec3d724e522475bc53ae43a5dbea8697
Sinjae Lee [Fri, 16 May 2014 06:02:32 +0000 (15:02 +0900)]
(FocusManager) Updated accessibility features
1. Shoot accessibility pan to hit-actor instead of currently focused actor (done)
2. Added sound resources (done)
Play sound for focus, end of focus list
3. Added Get/SetEndcapFeedbackEnabled api to handle the feedback
In case of evas-plugin usage, need to disable endcap feedback since EFL will do.
4. TODO: support tap & hold event on focused actor (NEXT PATCH)
Adeel Kazmi [Wed, 14 May 2014 18:49:00 +0000 (19:49 +0100)]
Moved ControlImpl to Internal namespace & renamed to Control
[problem] TypeRegistry does not have an entry for ControlImpl but that is what all
ControlImpl objects are set to when using GetTypeName() etc.
[cause] This means we cannot use control properly with the type-registry.
Everywhere else, the namespaces are stripped from the typeid name so for
Internal::ImageActor we just have ImageActor and this matches the entry
for ImageActor in the type-registry.
However, for Control, we only have an entry for Control, not ControlImpl so there
is no match.
[solution] By moving ControlImpl to Internal::Control we will have the match in the
type-registry.
Added typedef for ControlImpl so applications will only have to be recompiled.
Change-Id: I50d63b27f0fc6af0e8de1c59757e0a9324354c63
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Adeel Kazmi [Fri, 16 May 2014 16:19:17 +0000 (17:19 +0100)]
(Tests) Removed dependency on Ecore
Change-Id: Ibd6314a3d377506b1723ff3804763986a00c4577
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
Richard Huang [Mon, 19 May 2014 16:41:00 +0000 (17:41 +0100)]
Added new API to set fixed height for the scroll bar
[problem] When fast scroll is enabled, the height of the scroll bar should be fixed.
[cause] The height of scroll bar is dynamically changed according to the length of
scroll content. There is no API to set fixed height for the scroll bar.
[solution] Implemented new API to set fixed height for the scroll bar, so that the
the height of the scroll bar will keep the same regardless of the length
of scroll content.
Victor Cebollada [Wed, 14 May 2014 08:57:49 +0000 (09:57 +0100)]
TextView - Initialize alpha value with text's color alpha.
[problem] Text color always use alpha 1.f
[cause] The alpha value set in the text style was not send to the text actor.
[solution] Send the alpha value.
Change-Id: I313ace7de02ed8bb59981288bc969b19c6558c32
Signed-off-by: Victor Cebollada <v.cebollada@samsung.com>
Richard Huang [Thu, 15 May 2014 18:03:53 +0000 (19:03 +0100)]
New focus indicator should be added to the current focused actor immediately
[problem] When focus indicator is changed, it is not immediately reflected.
[cause] It doesn't remove the old indicator from the current focused actor
and add the new one to.
[solution] Remove the original focus indicator and add the new indicator to
the current focused actor.
Victor Cebollada [Thu, 15 May 2014 10:49:45 +0000 (11:49 +0100)]
TextView - Split width exceed policy and EllipsizeEnd height exceed policy combination added.
Change-Id: I0ccbedc95504857f4bd17615e163d2b6db478c2f
Signed-off-by: Victor Cebollada <v.cebollada@samsung.com>
Agnelo Vaz [Thu, 15 May 2014 10:45:17 +0000 (11:45 +0100)]
TextInput Adding new Handles class and matching API in Decorator
[problem] Handles class previously stubbed
[cause] Part of a TextInput Refactor
[solution] Implement in Text-Input-Handles class and amend Decorator to work with it.
Code is built but not currently used in TextInput until all part are merged.
Change-Id: I05e03c99b1178853e05073564436e2ca9c5b7b0d
jonghyun.ho [Wed, 14 May 2014 08:06:56 +0000 (17:06 +0900)]
Upload pacakge dali-toolkit_0.9.16.
Richard Huang [Wed, 14 May 2014 16:52:19 +0000 (17:52 +0100)]
Fixed crash when KeyboardFocusManager clears the focus
[problem] There is crash if focus indicator is empty but KeyboardFocusManager
tries to clear the focus.
[cause] It doesn't check whether focus indicator exists before remove it from
the current focused actor.
[solution] Check whether focus indicator exists before remove it.