Merge tag 'v3.14.26' into backport/v3.14.24-ltsi-rc1+v3.14.26/snapshot-merge.wip
authorSimon Horman <horms+renesas@verge.net.au>
Wed, 10 Dec 2014 00:41:35 +0000 (09:41 +0900)
committerSimon Horman <horms+renesas@verge.net.au>
Wed, 10 Dec 2014 00:41:35 +0000 (09:41 +0900)
This is the 3.14.26 stable release

Conflicts:
Makefile

1  2 
Makefile
drivers/usb/host/xhci-pci.c
drivers/usb/host/xhci-plat.c
drivers/usb/host/xhci.c
drivers/usb/host/xhci.h
sound/soc/sh/fsi.c

diff --combined Makefile
+++ b/Makefile
@@@ -1,7 -1,7 +1,7 @@@
  VERSION = 3
  PATCHLEVEL = 14
- SUBLEVEL = 25
+ SUBLEVEL = 26
 -EXTRAVERSION =
 +EXTRAVERSION = -ltsi
  NAME = Remembering Coco
  
  # *DOCUMENTATION*
@@@ -40,8 -40,6 +40,8 @@@
  
  static const char hcd_name[] = "xhci_hcd";
  
 +static struct hc_driver __read_mostly xhci_pci_hc_driver;
 +
  /* called after powerup, by probe or system-pm "wakeup" */
  static int xhci_pci_reinit(struct xhci_hcd *xhci, struct pci_dev *pdev)
  {
@@@ -283,7 -281,7 +283,7 @@@ static int xhci_pci_suspend(struct usb_
        if (xhci_compliance_mode_recovery_timer_quirk_check())
                pdev->no_d3cold = true;
  
-       return xhci_suspend(xhci);
+       return xhci_suspend(xhci, do_wakeup);
  }
  
  static int xhci_pci_resume(struct usb_hcd *hcd, bool hibernated)
  }
  #endif /* CONFIG_PM */
  
 -static const struct hc_driver xhci_pci_hc_driver = {
 -      .description =          hcd_name,
 -      .product_desc =         "xHCI Host Controller",
 -      .hcd_priv_size =        sizeof(struct xhci_hcd *),
 -
 -      /*
 -       * generic hardware linkage
 -       */
 -      .irq =                  xhci_irq,
 -      .flags =                HCD_MEMORY | HCD_USB3 | HCD_SHARED,
 -
 -      /*
 -       * basic lifecycle operations
 -       */
 -      .reset =                xhci_pci_setup,
 -      .start =                xhci_run,
 -#ifdef CONFIG_PM
 -      .pci_suspend =          xhci_pci_suspend,
 -      .pci_resume =           xhci_pci_resume,
 -#endif
 -      .stop =                 xhci_stop,
 -      .shutdown =             xhci_shutdown,
 -
 -      /*
 -       * managing i/o requests and associated device resources
 -       */
 -      .urb_enqueue =          xhci_urb_enqueue,
 -      .urb_dequeue =          xhci_urb_dequeue,
 -      .alloc_dev =            xhci_alloc_dev,
 -      .free_dev =             xhci_free_dev,
 -      .alloc_streams =        xhci_alloc_streams,
 -      .free_streams =         xhci_free_streams,
 -      .add_endpoint =         xhci_add_endpoint,
 -      .drop_endpoint =        xhci_drop_endpoint,
 -      .endpoint_reset =       xhci_endpoint_reset,
 -      .check_bandwidth =      xhci_check_bandwidth,
 -      .reset_bandwidth =      xhci_reset_bandwidth,
 -      .address_device =       xhci_address_device,
 -      .enable_device =        xhci_enable_device,
 -      .update_hub_device =    xhci_update_hub_device,
 -      .reset_device =         xhci_discover_or_reset_device,
 -
 -      /*
 -       * scheduling support
 -       */
 -      .get_frame_number =     xhci_get_frame,
 -
 -      /* Root hub support */
 -      .hub_control =          xhci_hub_control,
 -      .hub_status_data =      xhci_hub_status_data,
 -      .bus_suspend =          xhci_bus_suspend,
 -      .bus_resume =           xhci_bus_resume,
 -      /*
 -       * call back when device connected and addressed
 -       */
 -      .update_device =        xhci_update_device,
 -      .set_usb2_hw_lpm =      xhci_set_usb2_hardware_lpm,
 -      .enable_usb3_lpm_timeout =      xhci_enable_usb3_lpm_timeout,
 -      .disable_usb3_lpm_timeout =     xhci_disable_usb3_lpm_timeout,
 -      .find_raw_port_number = xhci_find_raw_port_number,
 -};
 -
  /*-------------------------------------------------------------------------*/
  
  /* PCI driver selection metadata; PCI hotplugging uses this */
@@@ -349,11 -409,6 +349,11 @@@ static struct pci_driver xhci_pci_drive
  
  int __init xhci_register_pci(void)
  {
 +      xhci_init_driver(&xhci_pci_hc_driver, xhci_pci_setup);
 +#ifdef CONFIG_PM
 +      xhci_pci_hc_driver.pci_suspend = xhci_pci_suspend;
 +      xhci_pci_hc_driver.pci_resume = xhci_pci_resume;
 +#endif
        return pci_register_driver(&xhci_pci_driver);
  }
  
   * version 2 as published by the Free Software Foundation.
   */
  
 -#include <linux/platform_device.h>
 +#include <linux/clk.h>
 +#include <linux/dma-mapping.h>
  #include <linux/module.h>
 -#include <linux/slab.h>
  #include <linux/of.h>
 -#include <linux/dma-mapping.h>
 +#include <linux/platform_device.h>
 +#include <linux/slab.h>
 +#include <linux/usb/xhci_pdriver.h>
  
  #include "xhci.h"
 +#include "xhci-mvebu.h"
 +#include "xhci-rcar.h"
 +
 +static struct hc_driver __read_mostly xhci_plat_hc_driver;
  
  static void xhci_plat_quirks(struct device *dev, struct xhci_hcd *xhci)
  {
  /* called during probe() after chip reset completes */
  static int xhci_plat_setup(struct usb_hcd *hcd)
  {
 +      struct device_node *of_node = hcd->self.controller->of_node;
 +      int ret;
 +
 +      if (of_device_is_compatible(of_node, "renesas,xhci-r8a7790") ||
 +          of_device_is_compatible(of_node, "renesas,xhci-r8a7791")) {
 +              ret = xhci_rcar_init_quirk(hcd);
 +              if (ret)
 +                      return ret;
 +      }
 +
        return xhci_gen_setup(hcd, xhci_plat_quirks);
  }
  
 -static const struct hc_driver xhci_plat_xhci_driver = {
 -      .description =          "xhci-hcd",
 -      .product_desc =         "xHCI Host Controller",
 -      .hcd_priv_size =        sizeof(struct xhci_hcd *),
 -
 -      /*
 -       * generic hardware linkage
 -       */
 -      .irq =                  xhci_irq,
 -      .flags =                HCD_MEMORY | HCD_USB3 | HCD_SHARED,
 -
 -      /*
 -       * basic lifecycle operations
 -       */
 -      .reset =                xhci_plat_setup,
 -      .start =                xhci_run,
 -      .stop =                 xhci_stop,
 -      .shutdown =             xhci_shutdown,
 +static int xhci_plat_start(struct usb_hcd *hcd)
 +{
 +      struct device_node *of_node = hcd->self.controller->of_node;
  
 -      /*
 -       * managing i/o requests and associated device resources
 -       */
 -      .urb_enqueue =          xhci_urb_enqueue,
 -      .urb_dequeue =          xhci_urb_dequeue,
 -      .alloc_dev =            xhci_alloc_dev,
 -      .free_dev =             xhci_free_dev,
 -      .alloc_streams =        xhci_alloc_streams,
 -      .free_streams =         xhci_free_streams,
 -      .add_endpoint =         xhci_add_endpoint,
 -      .drop_endpoint =        xhci_drop_endpoint,
 -      .endpoint_reset =       xhci_endpoint_reset,
 -      .check_bandwidth =      xhci_check_bandwidth,
 -      .reset_bandwidth =      xhci_reset_bandwidth,
 -      .address_device =       xhci_address_device,
 -      .enable_device =        xhci_enable_device,
 -      .update_hub_device =    xhci_update_hub_device,
 -      .reset_device =         xhci_discover_or_reset_device,
 +      if (of_device_is_compatible(of_node, "renesas,xhci-r8a7790") ||
 +          of_device_is_compatible(of_node, "renesas,xhci-r8a7791"))
 +              xhci_rcar_start(hcd);
  
 -      /*
 -       * scheduling support
 -       */
 -      .get_frame_number =     xhci_get_frame,
 -
 -      /* Root hub support */
 -      .hub_control =          xhci_hub_control,
 -      .hub_status_data =      xhci_hub_status_data,
 -      .bus_suspend =          xhci_bus_suspend,
 -      .bus_resume =           xhci_bus_resume,
 -};
 +      return xhci_run(hcd);
 +}
  
  static int xhci_plat_probe(struct platform_device *pdev)
  {
 +      struct device_node      *node = pdev->dev.of_node;
 +      struct usb_xhci_pdata   *pdata = dev_get_platdata(&pdev->dev);
        const struct hc_driver  *driver;
        struct xhci_hcd         *xhci;
        struct resource         *res;
        struct usb_hcd          *hcd;
 +      struct clk              *clk;
        int                     ret;
        int                     irq;
  
        if (usb_disabled())
                return -ENODEV;
  
 -      driver = &xhci_plat_xhci_driver;
 +      driver = &xhci_plat_hc_driver;
  
        irq = platform_get_irq(pdev, 0);
        if (irq < 0)
        if (!res)
                return -ENODEV;
  
 +      if (of_device_is_compatible(pdev->dev.of_node,
 +                                  "marvell,armada-375-xhci") ||
 +          of_device_is_compatible(pdev->dev.of_node,
 +                                  "marvell,armada-380-xhci")) {
 +              ret = xhci_mvebu_mbus_init_quirk(pdev);
 +              if (ret)
 +                      return ret;
 +      }
 +
        /* Initialize dma_mask and coherent_dma_mask to 32-bits */
        ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
        if (ret)
        hcd->rsrc_start = res->start;
        hcd->rsrc_len = resource_size(res);
  
 -      if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len,
 -                              driver->description)) {
 -              dev_dbg(&pdev->dev, "controller already in use\n");
 -              ret = -EBUSY;
 +      hcd->regs = devm_ioremap_resource(&pdev->dev, res);
 +      if (IS_ERR(hcd->regs)) {
 +              ret = PTR_ERR(hcd->regs);
                goto put_hcd;
        }
  
 -      hcd->regs = ioremap_nocache(hcd->rsrc_start, hcd->rsrc_len);
 -      if (!hcd->regs) {
 -              dev_dbg(&pdev->dev, "error mapping memory\n");
 -              ret = -EFAULT;
 -              goto release_mem_region;
 +      /*
 +       * Not all platforms have a clk so it is not an error if the
 +       * clock does not exists.
 +       */
 +      clk = devm_clk_get(&pdev->dev, NULL);
 +      if (!IS_ERR(clk)) {
 +              ret = clk_prepare_enable(clk);
 +              if (ret)
 +                      goto put_hcd;
        }
  
        ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
        if (ret)
 -              goto unmap_registers;
 +              goto disable_clk;
 +
        device_wakeup_enable(hcd->self.controller);
  
        /* USB 2.0 roothub is stored in the platform_device now. */
        hcd = platform_get_drvdata(pdev);
        xhci = hcd_to_xhci(hcd);
 +      xhci->clk = clk;
        xhci->shared_hcd = usb_create_shared_hcd(driver, &pdev->dev,
                        dev_name(&pdev->dev), hcd);
        if (!xhci->shared_hcd) {
                goto dealloc_usb2_hcd;
        }
  
 +      if ((node && of_property_read_bool(node, "usb3-lpm-capable")) ||
 +                      (pdata && pdata->usb3_lpm_capable))
 +              xhci->quirks |= XHCI_LPM_SUPPORT;
        /*
         * Set the xHCI pointer before xhci_plat_setup() (aka hcd_driver.reset)
         * is called by usb_add_hcd().
@@@ -167,9 -170,11 +167,9 @@@ put_usb3_hcd
  dealloc_usb2_hcd:
        usb_remove_hcd(hcd);
  
 -unmap_registers:
 -      iounmap(hcd->regs);
 -
 -release_mem_region:
 -      release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
 +disable_clk:
 +      if (!IS_ERR(clk))
 +              clk_disable_unprepare(clk);
  
  put_hcd:
        usb_put_hcd(hcd);
@@@ -181,27 -186,34 +181,35 @@@ static int xhci_plat_remove(struct plat
  {
        struct usb_hcd  *hcd = platform_get_drvdata(dev);
        struct xhci_hcd *xhci = hcd_to_xhci(hcd);
 +      struct clk *clk = xhci->clk;
  
        usb_remove_hcd(xhci->shared_hcd);
        usb_put_hcd(xhci->shared_hcd);
  
        usb_remove_hcd(hcd);
 -      iounmap(hcd->regs);
 -      release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
 +      if (!IS_ERR(clk))
 +              clk_disable_unprepare(clk);
        usb_put_hcd(hcd);
        kfree(xhci);
  
        return 0;
  }
  
 -#ifdef CONFIG_PM
 +#ifdef CONFIG_PM_SLEEP
  static int xhci_plat_suspend(struct device *dev)
  {
        struct usb_hcd  *hcd = dev_get_drvdata(dev);
        struct xhci_hcd *xhci = hcd_to_xhci(hcd);
  
-       return xhci_suspend(xhci);
+       /*
+        * xhci_suspend() needs `do_wakeup` to know whether host is allowed
+        * to do wakeup during suspend. Since xhci_plat_suspend is currently
+        * only designed for system suspend, device_may_wakeup() is enough
+        * to dertermine whether host is allowed to do wakeup. Need to
+        * reconsider this when xhci_plat_suspend enlarges its scope, e.g.,
+        * also applies to runtime suspend.
+        */
+       return xhci_suspend(xhci, device_may_wakeup(dev));
  }
  
  static int xhci_plat_resume(struct device *dev)
@@@ -222,12 -234,7 +230,12 @@@ static const struct dev_pm_ops xhci_pla
  
  #ifdef CONFIG_OF
  static const struct of_device_id usb_xhci_of_match[] = {
 +      { .compatible = "generic-xhci" },
        { .compatible = "xhci-platform" },
 +      { .compatible = "marvell,armada-375-xhci"},
 +      { .compatible = "marvell,armada-380-xhci"},
 +      { .compatible = "renesas,xhci-r8a7790"},
 +      { .compatible = "renesas,xhci-r8a7791"},
        { },
  };
  MODULE_DEVICE_TABLE(of, usb_xhci_of_match);
@@@ -246,8 -253,6 +254,8 @@@ MODULE_ALIAS("platform:xhci-hcd")
  
  int xhci_register_plat(void)
  {
 +      xhci_init_driver(&xhci_plat_hc_driver, xhci_plat_setup);
 +      xhci_plat_hc_driver.start = xhci_plat_start;
        return platform_driver_register(&usb_xhci_driver);
  }
  
diff --combined drivers/usb/host/xhci.c
@@@ -35,6 -35,8 +35,8 @@@
  #define DRIVER_AUTHOR "Sarah Sharp"
  #define DRIVER_DESC "'eXtensible' Host Controller (xHC) Driver"
  
+ #define       PORT_WAKE_BITS  (PORT_WKOC_E | PORT_WKDISC_E | PORT_WKCONN_E)
  /* Some 0.95 hardware can't handle the chain bit on a Link TRB being cleared */
  static int link_quirk;
  module_param(link_quirk, int, S_IRUGO | S_IWUSR);
@@@ -842,13 -844,47 +844,47 @@@ static void xhci_clear_command_ring(str
        xhci_set_cmd_ring_deq(xhci);
  }
  
+ static void xhci_disable_port_wake_on_bits(struct xhci_hcd *xhci)
+ {
+       int port_index;
+       __le32 __iomem **port_array;
+       unsigned long flags;
+       u32 t1, t2;
+       spin_lock_irqsave(&xhci->lock, flags);
+       /* disble usb3 ports Wake bits*/
+       port_index = xhci->num_usb3_ports;
+       port_array = xhci->usb3_ports;
+       while (port_index--) {
+               t1 = readl(port_array[port_index]);
+               t1 = xhci_port_state_to_neutral(t1);
+               t2 = t1 & ~PORT_WAKE_BITS;
+               if (t1 != t2)
+                       writel(t2, port_array[port_index]);
+       }
+       /* disble usb2 ports Wake bits*/
+       port_index = xhci->num_usb2_ports;
+       port_array = xhci->usb2_ports;
+       while (port_index--) {
+               t1 = readl(port_array[port_index]);
+               t1 = xhci_port_state_to_neutral(t1);
+               t2 = t1 & ~PORT_WAKE_BITS;
+               if (t1 != t2)
+                       writel(t2, port_array[port_index]);
+       }
+       spin_unlock_irqrestore(&xhci->lock, flags);
+ }
  /*
   * Stop HC (not bus-specific)
   *
   * This is called when the machine transition into S3/S4 mode.
   *
   */
- int xhci_suspend(struct xhci_hcd *xhci)
+ int xhci_suspend(struct xhci_hcd *xhci, bool do_wakeup)
  {
        int                     rc = 0;
        unsigned int            delay = XHCI_MAX_HALT_USEC;
                        xhci->shared_hcd->state != HC_STATE_SUSPENDED)
                return -EINVAL;
  
+       /* Clear root port wake on bits if wakeup not allowed. */
+       if (!do_wakeup)
+               xhci_disable_port_wake_on_bits(xhci);
        /* Don't poll the roothubs on bus suspend. */
        xhci_dbg(xhci, "%s: stopping port polling.\n", __func__);
        clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
@@@ -4831,75 -4871,6 +4871,75 @@@ error
        return retval;
  }
  
 +static const struct hc_driver xhci_hc_driver = {
 +      .description =          "xhci-hcd",
 +      .product_desc =         "xHCI Host Controller",
 +      .hcd_priv_size =        sizeof(struct xhci_hcd *),
 +
 +      /*
 +       * generic hardware linkage
 +       */
 +      .irq =                  xhci_irq,
 +      .flags =                HCD_MEMORY | HCD_USB3 | HCD_SHARED,
 +
 +      /*
 +       * basic lifecycle operations
 +       */
 +      .reset =                NULL, /* set in xhci_init_driver() */
 +      .start =                xhci_run,
 +      .stop =                 xhci_stop,
 +      .shutdown =             xhci_shutdown,
 +
 +      /*
 +       * managing i/o requests and associated device resources
 +       */
 +      .urb_enqueue =          xhci_urb_enqueue,
 +      .urb_dequeue =          xhci_urb_dequeue,
 +      .alloc_dev =            xhci_alloc_dev,
 +      .free_dev =             xhci_free_dev,
 +      .alloc_streams =        xhci_alloc_streams,
 +      .free_streams =         xhci_free_streams,
 +      .add_endpoint =         xhci_add_endpoint,
 +      .drop_endpoint =        xhci_drop_endpoint,
 +      .endpoint_reset =       xhci_endpoint_reset,
 +      .check_bandwidth =      xhci_check_bandwidth,
 +      .reset_bandwidth =      xhci_reset_bandwidth,
 +      .address_device =       xhci_address_device,
 +      .enable_device =        xhci_enable_device,
 +      .update_hub_device =    xhci_update_hub_device,
 +      .reset_device =         xhci_discover_or_reset_device,
 +
 +      /*
 +       * scheduling support
 +       */
 +      .get_frame_number =     xhci_get_frame,
 +
 +      /*
 +       * root hub support
 +       */
 +      .hub_control =          xhci_hub_control,
 +      .hub_status_data =      xhci_hub_status_data,
 +      .bus_suspend =          xhci_bus_suspend,
 +      .bus_resume =           xhci_bus_resume,
 +
 +      /*
 +       * call back when device connected and addressed
 +       */
 +      .update_device =        xhci_update_device,
 +      .set_usb2_hw_lpm =      xhci_set_usb2_hardware_lpm,
 +      .enable_usb3_lpm_timeout =      xhci_enable_usb3_lpm_timeout,
 +      .disable_usb3_lpm_timeout =     xhci_disable_usb3_lpm_timeout,
 +      .find_raw_port_number = xhci_find_raw_port_number,
 +};
 +
 +void xhci_init_driver(struct hc_driver *drv, int (*setup_fn)(struct usb_hcd *))
 +{
 +      BUG_ON(!setup_fn);
 +      *drv = xhci_hc_driver;
 +      drv->reset = setup_fn;
 +}
 +EXPORT_SYMBOL_GPL(xhci_init_driver);
 +
  MODULE_DESCRIPTION(DRIVER_DESC);
  MODULE_AUTHOR(DRIVER_AUTHOR);
  MODULE_LICENSE("GPL");
diff --combined drivers/usb/host/xhci.h
@@@ -1473,8 -1473,6 +1473,8 @@@ struct xhci_hcd 
        /* msi-x vectors */
        int             msix_count;
        struct msix_entry       *msix_entries;
 +      /* optional clock */
 +      struct clk              *clk;
        /* data structures */
        struct xhci_device_context_array *dcbaa;
        struct xhci_ring        *cmd_ring;
@@@ -1760,10 -1758,9 +1760,10 @@@ int xhci_run(struct usb_hcd *hcd)
  void xhci_stop(struct usb_hcd *hcd);
  void xhci_shutdown(struct usb_hcd *hcd);
  int xhci_gen_setup(struct usb_hcd *hcd, xhci_get_quirks_t get_quirks);
 +void xhci_init_driver(struct hc_driver *drv, int (*setup_fn)(struct usb_hcd *));
  
  #ifdef        CONFIG_PM
- int xhci_suspend(struct xhci_hcd *xhci);
+ int xhci_suspend(struct xhci_hcd *xhci, bool do_wakeup);
  int xhci_resume(struct xhci_hcd *xhci, bool hibernated);
  #else
  #define       xhci_suspend    NULL
diff --combined sound/soc/sh/fsi.c
@@@ -233,6 -233,7 +233,6 @@@ struct fsi_stream 
         */
        struct dma_chan         *chan;
        struct work_struct      work;
 -      dma_addr_t              dma;
        int                     dma_id;
        int                     loop_cnt;
        int                     additional_pos;
@@@ -1278,6 -1279,11 +1278,6 @@@ static irqreturn_t fsi_interrupt(int ir
   */
  static int fsi_dma_init(struct fsi_priv *fsi, struct fsi_stream *io)
  {
 -      struct snd_pcm_runtime *runtime = io->substream->runtime;
 -      struct snd_soc_dai *dai = fsi_get_dai(io->substream);
 -      enum dma_data_direction dir = fsi_stream_is_play(fsi, io) ?
 -                              DMA_TO_DEVICE : DMA_FROM_DEVICE;
 -
        /*
         * 24bit data : 24bit bus / package in back
         * 16bit data : 16bit bus / stream mode
  
        io->loop_cnt = 2; /* push 1st, 2nd period first, then 3rd, 4th... */
        io->additional_pos = 0;
 -      io->dma = dma_map_single(dai->dev, runtime->dma_area,
 -                               snd_pcm_lib_buffer_bytes(io->substream), dir);
 -      return 0;
 -}
 -
 -static int fsi_dma_quit(struct fsi_priv *fsi, struct fsi_stream *io)
 -{
 -      struct snd_soc_dai *dai = fsi_get_dai(io->substream);
 -      enum dma_data_direction dir = fsi_stream_is_play(fsi, io) ?
 -              DMA_TO_DEVICE : DMA_FROM_DEVICE;
  
 -      dma_unmap_single(dai->dev, io->dma,
 -                       snd_pcm_lib_buffer_bytes(io->substream), dir);
        return 0;
  }
  
@@@ -1299,8 -1317,7 +1299,8 @@@ static dma_addr_t fsi_dma_get_area(stru
        if (period >= runtime->periods)
                period = 0;
  
 -      return io->dma + samples_to_bytes(runtime, period * io->period_samples);
 +      return runtime->dma_addr +
 +              samples_to_bytes(runtime, period * io->period_samples);
  }
  
  static void fsi_dma_complete(void *data)
        struct fsi_stream *io = (struct fsi_stream *)data;
        struct fsi_priv *fsi = fsi_stream_to_priv(io);
        struct snd_pcm_runtime *runtime = io->substream->runtime;
 -      struct snd_soc_dai *dai = fsi_get_dai(io->substream);
 -      enum dma_data_direction dir = fsi_stream_is_play(fsi, io) ?
 -              DMA_TO_DEVICE : DMA_FROM_DEVICE;
 -
 -      dma_sync_single_for_cpu(dai->dev, fsi_dma_get_area(io, 0),
 -                      samples_to_bytes(runtime, io->period_samples), dir);
  
        io->buff_sample_pos += io->period_samples;
        io->period_pos++;
@@@ -1346,6 -1369,8 +1346,6 @@@ static void fsi_dma_do_work(struct work
        for (i = 0; i < io->loop_cnt; i++) {
                buf     = fsi_dma_get_area(io, io->additional_pos);
  
 -              dma_sync_single_for_device(dai->dev, buf, len, dir);
 -
                desc = dmaengine_prep_slave_single(io->chan, buf, len, dir,
                                        DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
                if (!desc) {
@@@ -1470,6 -1495,7 +1470,6 @@@ static int fsi_dma_remove(struct fsi_pr
  
  static struct fsi_stream_handler fsi_dma_push_handler = {
        .init           = fsi_dma_init,
 -      .quit           = fsi_dma_quit,
        .probe          = fsi_dma_probe,
        .transfer       = fsi_dma_transfer,
        .remove         = fsi_dma_remove,
@@@ -1685,9 -1711,9 +1685,9 @@@ static int fsi_dai_set_fmt(struct snd_s
        /* set master/slave audio interface */
        switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
        case SND_SOC_DAIFMT_CBM_CFM:
 -              fsi->clk_master = 1;
                break;
        case SND_SOC_DAIFMT_CBS_CFS:
 +              fsi->clk_master = 1; /* codec is slave, cpu is master */
                break;
        default:
                return -EINVAL;
@@@ -1759,8 -1785,7 +1759,7 @@@ static const struct snd_soc_dai_ops fsi
  static struct snd_pcm_hardware fsi_pcm_hardware = {
        .info =         SNDRV_PCM_INFO_INTERLEAVED      |
                        SNDRV_PCM_INFO_MMAP             |
-                       SNDRV_PCM_INFO_MMAP_VALID       |
-                       SNDRV_PCM_INFO_PAUSE,
+                       SNDRV_PCM_INFO_MMAP_VALID,
        .buffer_bytes_max       = 64 * 1024,
        .period_bytes_min       = 32,
        .period_bytes_max       = 8192,
@@@ -1824,10 -1849,16 +1823,10 @@@ static void fsi_pcm_free(struct snd_pc
  
  static int fsi_pcm_new(struct snd_soc_pcm_runtime *rtd)
  {
 -      struct snd_pcm *pcm = rtd->pcm;
 -
 -      /*
 -       * dont use SNDRV_DMA_TYPE_DEV, since it will oops the SH kernel
 -       * in MMAP mode (i.e. aplay -M)
 -       */
        return snd_pcm_lib_preallocate_pages_for_all(
 -              pcm,
 -              SNDRV_DMA_TYPE_CONTINUOUS,
 -              snd_dma_continuous_data(GFP_KERNEL),
 +              rtd->pcm,
 +              SNDRV_DMA_TYPE_DEV,
 +              rtd->card->snd_card->dev,
                PREALLOC_BUFFER, PREALLOC_BUFFER_MAX);
  }