Mike Gorse [Mon, 28 Oct 2013 22:43:36 +0000 (17:43 -0500)]
Release v2.11.1
Mike Gorse [Wed, 23 Oct 2013 20:43:58 +0000 (15:43 -0500)]
Fix atk_component_contains wrapper
The method call should be called Contains, not contains, per the D-Bus and
AT-SPI specs.
https://bugzilla.gnome.org/show_bug.cgi?id=710730
Mike Gorse [Mon, 23 Sep 2013 22:04:39 +0000 (17:04 -0500)]
Release as v2.10.0
Mike Gorse [Mon, 16 Sep 2013 21:39:45 +0000 (16:39 -0500)]
Release v2.9.92
Mike Gorse [Sun, 15 Sep 2013 16:59:03 +0000 (11:59 -0500)]
Allow a :-separated list of attribute values when reading match rules
https://bugzilla.gnome.org/show_bug.cgi?id=700865
Mike Gorse [Thu, 5 Sep 2013 03:29:15 +0000 (22:29 -0500)]
Properly clean up when timing out on a keystroke listener
If we time out waiting for a keystroke listener, then exit the main
loop, and reset the DBus connections' main loop contexts becak to the
default loop.
https://bugzilla.gnome.org/show_big.cgi?id=707218
Mike Gorse [Mon, 19 Aug 2013 21:45:47 +0000 (16:45 -0500)]
Release v2.9.90
Mario Sanchez Prada [Tue, 6 Aug 2013 11:06:36 +0000 (13:06 +0200)]
Implemented GetStringAtOffset in the text adaptor in the ATK bridge
Also, raised the version of the ATK dependency up to 2.9.4.
https://bugzilla.gnome.org/show_bug.cgi?id=705581
Mike Gorse [Tue, 9 Jul 2013 17:45:20 +0000 (12:45 -0500)]
Fix another crash when we're initialized/shut down repeatedly
Mike Gorse [Mon, 8 Jul 2013 21:37:26 +0000 (16:37 -0500)]
Release v2.9.4
Mike Gorse [Mon, 1 Jul 2013 19:35:04 +0000 (14:35 -0500)]
Fix deadlock with key event listeners in our own process
If a key event was sent out and there was also a listener in the same
process, then the listener would never see the event, since the main
loop was being run in a separate context, while libatspi would defer
handling of the event, adding an idle handler into the default context.
We should call atspi_set_main_context (new function) to let libatspi
know which context to use when adding an idle callback. This was
previously hacked around by setting ATSPI_CLIENT in pyatspi and avoiding
switching main loop contexts if it was set, but this was specific to
pyatspi (ie, did not take into account direct usage of libatspi or use
directly through introspection, such as in Javascript), so this check
was removed in 2.9.3.
Mike Gorse [Mon, 17 Jun 2013 21:43:11 +0000 (16:43 -0500)]
Release v2.9.3
Mike Gorse [Sun, 16 Jun 2013 19:04:01 +0000 (14:04 -0500)]
Use atspi_is_initialized to decide whether to expose p2p connection
Previously, direct D-Bus connections were not exposed if AT_SPI_CLIENT
was set in the environment, since they are causing deadlock if the
application and the AT are in the same process. However, AT_SPI_CLIENT
was only being set by pyatspi, meaning that libatspi consumers not using
pyatspi (Javascript embedded in gnome-shell that uses the libatspi
introspection bindings directly, for instance) would still have problems
when attempting to inspect their own accessibles.
Also removed the code in event.c to disable main loop context switching
when AT_SPI_CLIENT was set. Modifying it to also check
atspi_is_initialized would cause deadlock with gnome-shell when Orca is
running. Hopefully that code is not needed anymore.
Mike Gorse [Tue, 28 May 2013 16:06:10 +0000 (11:06 -0500)]
Release v2.9.2
Mike Gorse [Mon, 20 May 2013 21:25:46 +0000 (16:25 -0500)]
Don't warn if an app returns NULL when referencing a child
If atk_object_ref_accessible_child returns NULL when creating the cache,
then don't attempt to process/unref the NULL item, although applications
probably shouldn't be returning NULL in response to a call to
atk_object_ref_accessible_child, so it seems debatable whether we should
be printing a warning here.
Mike Gorse [Fri, 3 May 2013 14:48:50 +0000 (09:48 -0500)]
Add a NULL check into register_reply
Register_reply could access invalid memory if it is called after
atk_bridge_adaptor_cleanup() has been called.
This code should probably be refactored to make the instance act as a
GObject, but committing this for now to fix the crash.
https://bugzilla.gnome.org/show_bug.cgi?id=699554
Mike Gorse [Thu, 2 May 2013 20:24:22 +0000 (15:24 -0500)]
More DBusError leak fixes
Mike Gorse [Tue, 30 Apr 2013 19:12:05 +0000 (14:12 -0500)]
Ensure that DBus errors are freed
Call dbus_error_free in some cases where it is needed. Just pass NULL to
dbus_message_get_args where we aren't using the error.
https://bugzilla.gnome.org/show_bug.cgi?id=698951
Mike Gorse [Wed, 10 Apr 2013 17:40:47 +0000 (12:40 -0500)]
Add NULL check to fix crash when receiving a dbus reply after cleanup
Xan Lopez [Wed, 27 Mar 2013 20:40:12 +0000 (21:40 +0100)]
socket-adaptor: fix memory leak
Set a destructor for the object data. Other than fixing a leak this
also allows to simplify the code a bit.
https://bugzilla.gnome.org/show_bug.cgi?id=696733
Mike Gorse [Mon, 25 Mar 2013 22:23:36 +0000 (17:23 -0500)]
Release as v2.8.0
Mike Gorse [Mon, 4 Mar 2013 21:53:55 +0000 (15:53 -0600)]
Release v2.7.91
Mike Gorse [Tue, 26 Feb 2013 00:39:08 +0000 (18:39 -0600)]
Add Locale property, mapped to atk_object_get_object_locale
https://bugzilla.gnome.org/show_bug.cgi?id=694368
Mike Gorse [Mon, 18 Feb 2013 22:57:03 +0000 (16:57 -0600)]
Release v2.7.90
Dominique Leuenberger [Tue, 5 Feb 2013 09:05:16 +0000 (10:05 +0100)]
configure: bump atk dependency to 2.7.5 in order to enusre ATK_ROLE_LEVEL_BAR is available.
Fixes bug 693189.
Mike Gorse [Mon, 4 Feb 2013 22:35:28 +0000 (16:35 -0600)]
Release v2.7.5
Mike Gorse [Mon, 4 Feb 2013 19:34:48 +0000 (13:34 -0600)]
Update README
The README was very outdated.
Mike Gorse [Mon, 4 Feb 2013 18:36:16 +0000 (12:36 -0600)]
Fix various warnings
Mike Gorse [Thu, 31 Jan 2013 22:31:52 +0000 (16:31 -0600)]
Support ATK_ROLE_LEVEL_BAR
Mike Gorse [Fri, 4 Jan 2013 18:10:55 +0000 (12:10 -0600)]
Simplify autogen.sh
Simply calling autoreconf will do most of what is needed; we don't need
the full gnome-autogen.sh script, and this eliminates incompatibilities
with new versions of automake (ie, 1.13) that the GNOME script did not
check for.
Mike Gorse [Mon, 17 Dec 2012 22:12:54 +0000 (17:12 -0500)]
Release v2.7.3
Jasper St. Pierre [Sat, 8 Dec 2012 08:21:08 +0000 (03:21 -0500)]
droute: Fix another memory few memory leaks
We need to free the pointer array here, along with the path.
https://bugzilla.gnome.org/show_bug.cgi?id=689887
Mike Gorse [Mon, 26 Nov 2012 20:04:05 +0000 (14:04 -0600)]
Stop using deprecated glib functions
GStaticRecMutex is deprecated. Use GRecMutex instead. Also, this means
that we need at least glib 2.32, so specify that in configure.ac.
Mike Gorse [Tue, 20 Nov 2012 22:29:23 +0000 (16:29 -0600)]
Re-register if the registry goes away and later returns
Mike Gorse [Tue, 20 Nov 2012 21:18:12 +0000 (15:18 -0600)]
Don't return DBUS_HANDLER_RESULT_HANDLED for NameOwnerChanged signals
NameOwnerChanged signals are generic signals sent out by dbus-daemon,
not really specific to this code, so the filter should return
DBUS_HANDLER_RESULT_NOT_YET_HANDLED for them so that libdbus will
propagate them to other filters (specifically the one in at-spi2-core,
which shares a D-Bus connection with at-spi2-atk).
Mike Gorse [Mon, 19 Nov 2012 16:59:46 +0000 (10:59 -0600)]
Release v2.7.2
Andrew Potter [Mon, 19 Nov 2012 16:33:40 +0000 (10:33 -0600)]
droute: Fix memory leak in path cleanup
Frees all allocated memory.
g_ptr_array_free(..., FALSE) was probably being called to avoid a destructor being called on the elements of the array that point to static data. But that method returns an array that must still be g_free()d.
https://bugzilla.gnome.org/show_bug.cgi?id=688363
Joanmarie Diggs [Sat, 17 Nov 2012 21:36:28 +0000 (16:36 -0500)]
socket_embed_hook() should return immediately if spi_global_register is NULL
Mike Gorse [Mon, 12 Nov 2012 17:50:43 +0000 (11:50 -0600)]
Remove dbind
Dbind was unused here except formerly in the droute test.
Mike Gorse [Mon, 12 Nov 2012 17:34:53 +0000 (11:34 -0600)]
Fix droute test, and remove dbind dependency
The droute test was broken (it had not been updated for recent API
changes and also did not return a non-zero exit code on failure). Also,
it is the only thing in at-spi2-atk that uses dbind, so re-worked it to
call libdbus directly, so that we can remove dbind / avoid having it
both here and in at-spi2-core.
Giovanni Campagna [Tue, 18 Sep 2012 23:10:28 +0000 (01:10 +0200)]
atk-adaptor: don't emit a critical in case the bridge was not initialized
Fixes running with NO_AT_BRIDGE=1
https://bugzilla.gnome.org/show_bug.cgi?id=684334
Mike Gorse [Mon, 29 Oct 2012 01:37:58 +0000 (20:37 -0500)]
Up libatspi dependency to 2.5.92
At-spi2-atk fetches a shared D-Bus connection via libatspi and now
expects this connection to be private, so it is incompatible with
versions of at-spi2-core older than 2.5.92.
https://bugzilla.gnome.org/show_bug.cgi?id=686667
Mike Gorse [Mon, 22 Oct 2012 16:30:56 +0000 (11:30 -0500)]
Release v2.7.1
Bastien Nocera [Wed, 13 Jun 2012 17:08:15 +0000 (18:08 +0100)]
Fix unused functions when compiling w/o debug
https://bugzilla.gnome.org/show_bug.cgi?id=678045
Bastien Nocera [Wed, 13 Jun 2012 17:07:51 +0000 (18:07 +0100)]
Remove empty spi_cache_dispose() function
https://bugzilla.gnome.org/show_bug.cgi?id=678045
Bastien Nocera [Wed, 13 Jun 2012 17:05:49 +0000 (18:05 +0100)]
droute: Fix compile-time warnings
Unused variables and discarding 'const' qualifier.
https://bugzilla.gnome.org/show_bug.cgi?id=678045
Mike Gorse [Wed, 26 Sep 2012 23:48:24 +0000 (18:48 -0500)]
Remove schema
Setting atk-bridge-location can cause problems on multilib builds and
should now be unnecessary since atk-bridge is installed into the normal
library path. No other keys were present in the schema, so removing it.
Mike Gorse [Mon, 24 Sep 2012 20:53:28 +0000 (15:53 -0500)]
Release v2.6.0
Mike Gorse [Thu, 20 Sep 2012 18:28:00 +0000 (13:28 -0500)]
Register the cache on the main D-Bus connection
In atk_bridge_adaptor_cleanup, droute will deregister the cache object
path from the main DBusConnection, causing libdbus to complain since it
was not registered. Fixes a regression introduced when deferring
registration of the cache.
Mike Gorse [Thu, 20 Sep 2012 18:26:12 +0000 (13:26 -0500)]
Fix crashes in atk_bridge_adaptor_cleanup
When freeing data, atk_bridge_adaptor_cleanup frees the wrong pointer,
resulting in a crash. Also, we need to close D-Bus connections before
removing the last reference, or libdbus will abort.
https://bugzilla.gnome.org/show_bug.cgi?id=684434
Mike Gorse [Tue, 18 Sep 2012 03:07:55 +0000 (22:07 -0500)]
Release v2.5.92
Mike Gorse [Tue, 18 Sep 2012 00:06:40 +0000 (19:06 -0500)]
Fix an errant g_object_unref
If an object is deregistered but not in the cache, then only unref it if
it was found in the queue of objects to be added (ie, it is possible
that it is leased, rather than queued to be cached, in which case it
should not be unrefed).
William Jon McCann [Fri, 14 Sep 2012 21:29:10 +0000 (17:29 -0400)]
Don't leak pending calls
https://bugzilla.gnome.org/show_bug.cgi?id=684077
William Jon McCann [Fri, 14 Sep 2012 21:11:37 +0000 (17:11 -0400)]
Don't leak message
https://bugzilla.gnome.org/show_bug.cgi?id=684077
William Jon McCann [Fri, 14 Sep 2012 20:39:58 +0000 (16:39 -0400)]
Don't leak strings
https://bugzilla.gnome.org/show_bug.cgi?id=684077
William Jon McCann [Fri, 14 Sep 2012 20:28:48 +0000 (16:28 -0400)]
Close the connection when we are done with it
Since it is no longer a shared connection
https://bugzilla.gnome.org/show_bug.cgi?id=684077
William Jon McCann [Fri, 14 Sep 2012 18:20:51 +0000 (14:20 -0400)]
Make cleanup more robust
https://bugzilla.gnome.org/show_bug.cgi?id=684042
Cosimo Cecchi [Thu, 13 Sep 2012 17:37:50 +0000 (13:37 -0400)]
atk-adaptor: plug some refcount leaks
cache->add_traversal holds GObject references, so when we remove/pop
items from it, we should also drop the reference, unless it's transfered
to another queue.
https://bugzilla.gnome.org/show_bug.cgi?id=683979
Mike Gorse [Thu, 13 Sep 2012 17:59:20 +0000 (12:59 -0500)]
Remove erroneous debug print introduced in last commit
Mike Gorse [Thu, 13 Sep 2012 17:55:36 +0000 (12:55 -0500)]
Only initialize the cache when an AT is running
If no AT is running, we shouldn't need to be maintaining the cache, so
only initialize when an AT is active. Note that this change does not
deinitialize the cache when an AT is no longer running. Deinitializing
and setting spi_global_cache to NULL might be a good idea, but trying to
keep risk to a minimum this close to 3.6.
Colin Walters [Thu, 6 Sep 2012 17:46:47 +0000 (13:46 -0400)]
Fix build for removal of po/ directory
Various things missed.
Claude Paroz [Thu, 6 Sep 2012 16:13:08 +0000 (18:13 +0200)]
Removed po directory
i18n support has been removed from at-spi2-atk
(See commits ed260a6 and bc07db9, bug #678035)
Mike Gorse [Tue, 4 Sep 2012 21:01:06 +0000 (16:01 -0500)]
Correctly cast hyperlinks in GetURI
https://bugzilla.gnome.org/show_bug.cgi?id=683182
Mike Gorse [Mon, 3 Sep 2012 23:12:03 +0000 (18:12 -0500)]
Release v2.5.91
Piotr Drąg [Sat, 1 Sep 2012 18:50:35 +0000 (20:50 +0200)]
Updated Polish translation
Rūdolfs Mazurs [Fri, 31 Aug 2012 21:09:41 +0000 (00:09 +0300)]
Updated Latvian translation
Alejandro Piñeiro [Tue, 21 Aug 2012 16:05:17 +0000 (18:05 +0200)]
Removing gtk+3 directory from AC_CONFIG_FILES on configure.ac
That directory was removed on a previous commit
https://bugzilla.gnome.org/show_bug.cgi?id=678315
Joanmarie Diggs [Mon, 18 Jun 2012 13:01:09 +0000 (09:01 -0400)]
Fix for Bug 678315 - Remove the bridge module for Gtk+ 3
Mike Gorse [Mon, 20 Aug 2012 20:19:19 +0000 (15:19 -0500)]
Release v2.5.90
Mike Gorse [Mon, 20 Aug 2012 19:40:43 +0000 (14:40 -0500)]
When a client is removed, don't continue looking through the list of clients
https://bugzilla.gnome.org/show_bug.cgi?id=679297
Mike Gorse [Mon, 20 Aug 2012 19:36:52 +0000 (14:36 -0500)]
Don't leak GError when option parsing fails
https://bugzilla.gnome.org/show_bug.cgi?id=679296
Mike Gorse [Mon, 20 Aug 2012 19:29:22 +0000 (14:29 -0500)]
Don't iterate over the list twice when removing events
https://bugzilla.gnome.org/show_bug.cgi?id=679295
Mike Gorse [Mon, 6 Aug 2012 20:59:01 +0000 (15:59 -0500)]
Release v2.5.5
Daniel Narvaez [Thu, 19 Jul 2012 20:12:04 +0000 (22:12 +0200)]
Allow to build out of source directory
https://bugzilla.gnome.org/show_bug.cgi?id=680280
Mike Gorse [Mon, 30 Jul 2012 17:03:25 +0000 (12:03 -0500)]
Implement GetLocalizedName for actions
https://bugzilla.gnome.org/show_bug.cgi?id=680598
Mike Gorse [Mon, 16 Jul 2012 21:41:07 +0000 (16:41 -0500)]
Release v2.5.4
Mike Gorse [Mon, 9 Jul 2012 22:41:38 +0000 (17:41 -0500)]
Only send property-change signals relevant for caching, absent listeners
Previously, all property-change signals were passed on, regardless of any
registered listeners, because some of them are used by libatspi to keep the
cache up-to-date. However, gtk sends many notifications for property changes
that would have no impact on libatspi's caching code, so we should not waste
time building and sending D-Bus messages for them unless something is
interested in the event.
https://bugzilla.gnome.org/show_bug.cgi?id=674719
Mike Gorse [Mon, 9 Jul 2012 22:36:26 +0000 (17:36 -0500)]
Only add items to the cache on children-changed if they are passed in
Gtk tree views, for instance, send children-changed signals without passing
an object. If a toolkit does this, then assume that it is doing so because
fetching the object would be expensive, and/or the object is transient, so
just have the cache bypass the signal rather than ref the child in order to
add it. Helps with performance when creating large gtk+ tree views.
https://bugzilla.gnome.org/show_bug.cgi?id=674719
Mike Gorse [Fri, 6 Jul 2012 19:37:29 +0000 (14:37 -0500)]
Don't try to set up the server with a main loop if there's no server
Mike Gorse [Fri, 6 Jul 2012 00:58:43 +0000 (19:58 -0500)]
Only create a directory and a socket when requested
Currently, atk-bridge clutters XDG_RUNTIME_DIR with directories for sockets,
which is especially annoying since gtk currently does not call
atk_bridge_adaptor_cleanup, so the directories never go away. This change does
not really solve the problem--it only hides it from users who do not really
need AT-SPI--but, nevertheless, there is no reason to create a directory or a
socket if nothing has requested it, so doing this lazily makes sense.
Cosimo Cecchi [Mon, 2 Jul 2012 20:14:48 +0000 (16:14 -0400)]
atk-adaptor: plug a refcount leak
https://bugzilla.gnome.org/show_bug.cgi?id=679285
Cosimo Cecchi [Mon, 2 Jul 2012 20:14:12 +0000 (16:14 -0400)]
atk-adaptor: plug a refcount leak
https://bugzilla.gnome.org/show_bug.cgi?id=679285
Mike Gorse [Wed, 4 Jul 2012 01:52:25 +0000 (20:52 -0500)]
Don't create a sub-directory for the socket when running as root
If an application is running as root but within a user's runtime directory,
then creating a temporary directory will result in the directory being owned
by root, and the user will not have permission to search the directory to
access the socket, so an AT running as the normal user will not be able to
connect to the application running as root.
Fixes regression introduced by the fix for BGO#678348.
Joanmarie Diggs [Wed, 27 Jun 2012 21:42:25 +0000 (17:42 -0400)]
Fix for bug #679013 - AtspiCollection should be implemented for all containers
Mike Gorse [Mon, 25 Jun 2012 23:21:36 +0000 (18:21 -0500)]
Release v2.5.3
Mike Gorse [Mon, 25 Jun 2012 23:14:57 +0000 (18:14 -0500)]
Add atkbridge.symbols to EXTRA_DIST
Mike Gorse [Mon, 25 Jun 2012 22:49:17 +0000 (17:49 -0500)]
Fix some more warnings
Mike Gorse [Mon, 25 Jun 2012 22:36:28 +0000 (17:36 -0500)]
Reinstate gnome_accessibility_module_init/shutdown for the gtk 3 module
Removing gnome_accessibility_module_init/shutdown will break Unity, for one,
and there is no real reason to remove it, other than it being an old API that
is to be deprecated and should not be needed anymore, but the new API is not
necessarily finalized, so might as well reinstate the old method for now until
we are certain what the new API will be and can then request that, ie, Unity be
patched accordingly.
Mike Gorse [Thu, 21 Jun 2012 21:56:40 +0000 (16:56 -0500)]
Use XDG_RUNTIME_DIR to hold sockets, and do not make a world-writable dir
If we use XDG_RUNTIME_DIR, then the directory should be owned by the
appropriate user, so it should not need to be world-writable. Hopefully this
won't break accessibility for administrative apps on some distro.
https://bugzilla.gnome.org/show_bug.cgi?id=678348
Alejandro Piñeiro [Mon, 18 Jun 2012 13:06:42 +0000 (15:06 +0200)]
Only register events at beginning if AT is listening
https://bugzilla.gnome.org/show_bug.cgi?id=678475
John Ralls [Sun, 17 Jun 2012 20:24:00 +0000 (21:24 +0100)]
Make extern the globals in introspection.h
To fix duplicate symbol _spi_org_a11y_atspi_Accessible in
../atk-adaptor/adaptors/.libs/libatk-bridge-adaptors.a(libatk_bridge_adaptors_la-accessible-adaptor.o)
and .libs/libatk_bridge_2_0_la-introspection.o
Ryan Lortie [Sun, 17 Jun 2012 00:01:04 +0000 (20:01 -0400)]
more uint -> guint fixes
Missed one with the last commit.
Ryan Lortie [Sat, 16 Jun 2012 23:59:12 +0000 (19:59 -0400)]
bridge.c: change 'uint' for 'guint'
'uint' seems to work on Linux (GNU extension?) but it breaks on Mac OS,
so use 'guint' instead.
Bastien Nocera [Fri, 15 Jun 2012 16:01:43 +0000 (17:01 +0100)]
Remove duplicate code from GTK+ modules
Now that the AT_NO_BRIDGE check lives in atk-bridge-2.0
Bastien Nocera [Fri, 15 Jun 2012 16:00:20 +0000 (17:00 +0100)]
Put declarations at the beginning of the block
Bastien Nocera [Fri, 15 Jun 2012 15:58:54 +0000 (16:58 +0100)]
Reset inited variable on cleanup
Alejandro Piñeiro [Thu, 14 Jun 2012 19:41:57 +0000 (21:41 +0200)]
Move NO_AT_BRIDGE test to the library
https://bugzilla.gnome.org/show_bug.cgi?id=678125
Bastien Nocera [Thu, 14 Jun 2012 18:43:54 +0000 (19:43 +0100)]
Fix undeclared G_BEGIN_DECL usage
Bastien Nocera [Wed, 13 Jun 2012 17:10:02 +0000 (18:10 +0100)]
Fix compile-time warnings
Unused variables, assignment used as truth values and unused functions.
https://bugzilla.gnome.org/show_bug.cgi?id=678045
Bastien Nocera [Wed, 13 Jun 2012 18:22:48 +0000 (19:22 +0100)]
Namespace the exported API
https://bugzilla.gnome.org/show_bug.cgi?id=678051