Remove unnecessary include dependency of privilege-control.h

[Issue#]    N/A
[Bug]       N/A
[Cause]     N/A
[Solution]  Remove the include from security-server.h
[Problem]   N/A

[Verification] build

Change-Id: I25f568c142b9f0959eccc1c71f32fc9e2f1da7c2
Signed-off-by: Radoslaw Bartosiak <r.bartosiak@samsung.com>

fix build in x86_64

Change-Id: I294e913ab5f2d481e9c7187ec5885b92a7eb8424
Signed-off-by: Stephane Desneux <stephane.desneux@open.eurogiciel.org>

Remove services open-for and app-permissions.

[Issue#]   N/A
[Bug]      N/A
[Cause]    This services were not used on tizen.org
[Solution] N/A

[Verification] N/A

Change-Id: Iae627af04af789fd3219ce85c3e5131f112dbb08

Add missing descriptions in security-server.h

[Issue#]   N/A
[Bug]      N/A
[Cause]    N/A
[Solution] N/A
[Problem]  N/A

[Verification] N/A

Change-Id: Iecdf65af3cbdf17a5128cd2e94738d9f00127493

Fix error code return by shared memory service.

[Issue#]   N/A
[Bug]      Security-server returns SECURITY_SERVER_API_BAD_REQUEST
           instead of SECURITY_SERVER_API_ERROR_GETTING_SOCKET_LABEL_FAILED
[Cause]    N/A
[Solution] Fix in code.

[Verification] Build, run security-server tests.

Change-Id: I39db4da7cf8ccb81f6dceb958bc090b618f0d52e

Remove fsync in audit-smack-log

Synchronization kernel buffer by a fsync call is unnecessary

[Issue#]   N/A
[Bug]      N/A
[Cause]    N/A
[Verfication] Build

Change-Id: Ife04d92f108adc4a29facebd710d0ced1521702c

Correct security_server_reset_pwd description in header.

[Issue#]        PSDAC-106
[Bug]           security_server_reset_pwd performed no checks connected with new password. Header
                didn't include this information in security_server_reset_pwd description.
[Cause]         N/A
[Solution]      Correct information included in security-server.h header.
[Verification]  N/A

Change-Id: I38e8b565121a8b5f3d087fbe0425042a59f73ae0

Added checking for binary path in case of reused cookie

[Issue#]        N/A
[Bug/Feature]   Protection aganist reuse cookie
[Cause]         Possible use cookie of other process
[Solution]      Added process path checking
[Verification]  Compile, run tests

Change-Id: I0b34eab693026c5e63f269dfc912890a5e5c5dd8

Documentation comments correction.

[Issue#]    N/A
[Bug]       N/A
[Cause]     N/A
[Problem]   N/A
[Solution]  N/A

[Verifcation] Build, generate documentation.

Change-Id: I8b6c19b6b2fd2b854cc29d2072101dee5a65b5a8

Data-share service test wrong value returned from smack_new_label_from_socket.

[Issue#]    PSDAC-46
[Bug]       Failing tests:
            * tc01a_security_server_app_give_access
            * tc07_check_API_data_share_allow
[Cause]     Wrong check of return value.
[Solution]  Check proper return value from smack_new_label_from_socket

[Verifcation] Build, run tests.

Prepare release for tizen.org

Changes:
 * Reset manifest.
 * Security policy for security-server sockets has been removed.
 * Minor fixes required by g++ 4.8.
 * Removed unused code.
 * Version update.
 * Fix conflicts in manifest file.

[Issue#]   SSDWSSP-816
[Bug]      N/A
[Cause]    N/A
[Solution] N/A

[Verification] N/A

Change-Id: I39e55c0355f561465b8f3ae777e6bcd46097ec86

Fix implementation and rename FstreamHelper to FstreamAccessros.

[Issue#]    N/A
[Bug]       FstreamHelper always inherited from fstream::__filebuf but it gets
            as param ofstream and should inherits from
            ofstream::__filebuf.
[Cause]     Name FstreamHelper was miningless.
[Solution]  N/A

[Verfication] Build, run tests.

Change-Id: I2a884860032d84f7cac05084dab4d3e3a2a5bbe9

Add FstreamHelper class to get FD from fstream objects

Rewrite the way of fsync calls, and add fsync in SmackAuditLog

    [Issue#]   N/A
    [Bug]      N/A
    [Cause]    N/A

[Verfication] Build, test fsync(DPL::FstreamHelper::getFd) on local pc.

Change-Id: I835df13a3b6b988afda7bade35fb5020d46efacd

Remove errors reported by Prevent.

[Issue#]   N/A
[Bug]      Lack of break in switch.
[Cause]    N/A

[Verfication] Build, run tests.

Change-Id: I2c05d0256c2ed0c323d220796d55f176e342f5b7

Removed temporary systemd socket

[Issue#]        N/A
[Bug/Feature]   After enabled smack protection for security-server
                API temporary unprotected socket is no longer needed
[Cause]         Deprecated temporary socket used
[Solution]      Socket removed
[Verification]  Compiule, run tests

Change-Id: Ifef2aefc0b017b208f2d64a93f68d7ee95be6050

Clean up password service.

* Remove PASSWORD_INFINITE_EXPIRATION_TIME from protocol* files.
* Add anonymous namespace in password-file.cpp
* Change PASSWORD_INFINITE_EXPIRATION_TIME value from -1 to max time_t.
* Remove cast between int/unsigned int/time_t in the code.

[Issue#]    N/A
[Bug]       N/A
[Cause]     N/A
[Problem]   N/A
[Solution]  N/A

[Verifcation] Build, run tests.

Change-Id: If41b690a7f4ac882281fc17bcdb79d20bfa9cb8d

Fix compilation under gcc 4.8

[Issue#]        N/A
[Bug/Feature]   Security-server does not build under GCC 4.8
[Cause]         * monotonic_clock was renamed in gcc 4.7 to steady_clock
                * lack of header files
                * invalid use of lambda capture
[Solution]      N/A
[Verification]  Build, run tests

Change-Id: I0c9235131e082eb7d053f13be4ead9b1ff044f4a

Extensions to security_server_open_for function.

Base function extended by new argument 'reader_label':

* int security_server_sharedfile_open(const char *filename, const char *reader_label, int *fd);

Introduced two new functions:

* int security_server_sharedfile_reopen(const char *filename, int *fd);
* int security_server_sharedfile_delete(const char *filename);

[Issue#]        SSDWSSP-398
[Bug/Feature]   New SS API functions.
[Cause]         *open_for* needed more security.
[Solution]      Added new functions.
[Verification]  Build and run new tests:
                security-server-tests-server --output=text --regexp='open_for'

Change-Id: I00dcf1c24c4a2186942b2dff4511e6667a6c5188

Replaced std::unique_lock with std::lock_quard.

[Issue#]        N/A
[Bug]           N/A
[Cause]         lock_quard is simpler and security-server does not used
                additional benefits from unique_lock.
[Solution]      N/A

[Verification]  Build, run ss tests

Change-Id: I91c626760c13b58e7909752252c86892815fadd7

Add missing header files.

[Issue#]    N/A
[Problem]   Build break.
[Cause]     Lack of header file unistd.h (function unlink was
            undefined) in open-for-manager.cpp and password-file.cpp
            (function close was undefined).
[Solution]  Fix header list.

[Verification] Build.

Change-Id: If5b4d4f76677431162fded7f833fcaf915f65db9

Add security-server.target unit.

Service key-storage requires security-server but it should not use
security-server.socket in Requires field because it's part of private
implementation. This commit creates synchronization point
security-server.target that should be used by other services to add
requirement to security-server.

[Issue#]     N/A
[Bug/Cause]  N/A
[Problem]    key-storage is not able to start because new
             security-server does not create security-server.socket.
[Solution]   create synchronization point for key-storage

[Verification] Build, install, reboot device.

Change-Id: Id54e9187edf671eec047787bdeb27a8c2acca29e

Password file versioning, support for old versions

[Issue#]        SSDWSSP-711
[Bug/Feature]   Security server crashes after update to version with a
                new password file format.
[Cause]         There was no backward compatibility support.
[Solution]      Introduce a new password file format with versioning and
                algorithm identifier associated with every password
                entry. Additionally security server can read all old
                password file formats, but can only save in the newest.
                Also incorrect file mask was fixed.
[Verification]  Build, install, run tests. Check migration from old
                password file formats to the new one (folder:
                /opt/data/security-server, old file name: password.pwd,
                new file name: password).

Change-Id: If25952ddc467172fc8032fb98a31e9413762882e

Secure all critical sockets with smack label.

[Issue#]     721
[Bug]        Sockets were not secured.
[Cause]      We need to wait for platform developers to adopt.
[Solution]   All critical sockets were secured.

[Verification] Build, run tests.

Change-Id: Ide775b00427b4848718e16e0b60aec2c4368fc7d

Fix incorrect security server service description.

[Issue#]        N/A
[Bug]           Service description had a spelling error - "Scoket" instead of "Socket".
[Cause]         N/A
[Solution]      Correct service description.
[Verification]  Build, install, reboot target. Call "journalctl | grep security". You should
                see informations with all sockets being started.

Change-Id: I3abb0d82f0d553dd00e594c26d9945665ff26930

Remove retry timeout check

[Issue#]       SSDWSSP-709
[Feature/Bug]  Retry timeout check is not required
[Problem]      Rapid password check sequences should be possible.
[Cause]        Retry timeout check cause may cause unnecessary failure.
[Solution]     Remove retry timeout check.
[Verification] Succesfull build and run of tests:
               security-tests.sh ss-password --output=text
               --regexp=no_retry_timeout

Change-Id: I802e5e067792182fcf7a5833f608bfb63e84b468

Fix isPwdValid. Correct logs. Change history related function names.

[Issue#]        N/A
[Bug]           Wrong value returned by isPwdValid. Some logs showed up incorrectly as error.
                History related functions had misleading names.
[Cause]         Incorrect casting in isPwdValid.
[Solution]      Add condition correcting returned time by isPwdValid. Correct log types. Change
                historySize related functions to maxHistorySize.
[Verification]  Build, run tests. Test tc43 should pass, others should work as earlier. Commit with
                tc43 - http://slp-info.sec.samsung.net/gerrit/#/c/357776/

Change-Id: Ic9ce0423f2ec233f3c1d8703dba8ab92e998632d

Fix improper description in header

[Issue#] N/A
[Feature/Bug] N/A
[Cause] Header contained wrong information about rules needed for
using security_server_check_privilege_by_sockfd
[Solution] Fixed description in header.
[Verification] Build.

Change-Id: I4ce035086268eff6f0d9d46834fe297206788923

Add flag checking if password is set. Correct history behaviour

[Issue#]        N/A
[Bug]           N/A
[Cause]         N/A
[Solution]      N/A
[Verification]  Build, install, run tests. Should pass as they passed earlier.

Change-Id: I1ab45c23564e0592c8f5912c03a96dc4cb146ead

Increase attempt count before checking max attempts.

[Issue#]        N/A
[Bug]           N/A
[Cause]         N/A
[Solution]      N/A
[Verification]  Build, install, run tests. Tests which checked for correctly returned attempt count
                should return error due to incorrect attempt count. Others should pass.

Change-Id: I120e7339e3af591374ddad5207ab8c0c8894b973

Add new constants to password service. Change infinite expiration time.

[Issue#]        SSDWSSP-700
[Feature/Bug]   Add PASSWORD_INFINITE_EXPIRATION_TIME and PASSWORD_INFINITE_ATTEMPT_COUNT constant
                to password service. Change infinite expiration time.
[Cause]         Infinite expiration time and infinite attempt count were inputed directly to
                variables in multiple places. Other infinite expiration time
[Solution]      Constants were added for simplier switching between different infinite expiration
                times and infinite attempt  counts.
[Verification]  Build, install, run tests. All should pass, except tests that treated infinite
                expiration time as 0 value.

Change-Id: I49877154e97f57ac444dbc37924bb571f4fa3abe

Change debug flag from TIZEN_ENGINEER_MODE to TIZEN_DEBUG_ENABLE

Also changes in spec file reflecting flag change.

[Issue#]      SSDWSSP-697
[Feature/Bug] N/A
[Problem]     Many issues in user binaries.
[Cause]       N/A
[Solution]    Add debug not only for engineering packages.

[Verification] Build with debug flag, run tests.

Change-Id: I0de009b02813785fd540e555b8c6dd5de7d0cec5

Remove deprecated code related to sockets.

Socket "exec-path" was deprecated and was not used.
Service "echo" was removed and definition in protocol.h is not required.

[Issue#]       N/A
[Bug/Solution] N/A
[Problem]      Security-server have got 1 additional socket open.
[Solution]     Remove deprecated code and systemd configuration.

[Verification] Build, run tests.

Change-Id: If1ce352b2ecfa5e9d14e5367d4e3b1b2f8f85d07

Change label of security-server binary.

[Issue#]   N/A
[Bug]      N/A
[Cause]    N/A
[Solution] N/A

[Verification] Build, run tests.

Change-Id: I1280be4bd12f07d3b9752ada06e65362374eca83

Fix errors reported by prevent.

[Issue#]    N/A
[Bug/Cuase] Error code was not checked.
[Solution]  N/A

[Verification] Build, run tests.

Change-Id: I33c2f0b31416a0720d5dcccb7408b7c6efc569fc

Separate password_set and password_reset APIs on socket level.

[Issue#]        SSDWSSP-691
[Bug/Feature]   N/A
[Cause]         Applications should have access only to those functions they
                need.
[Solution]      Moving password_reset to new socket with different label.
[Verification]  Build and install. Run security-server password tests.

Change-Id: I318e649314fd7410ccfa065124b7d6175cf6687e

Removed echo service leftovers

[Issue#] N/A
[Feature/Bug] N/A
[Problem] Echo service has been removed but some leftovers are still present in
code
[Cause] N/A
[Solution] Removed

[Verification] Succesfull compilation

Change-Id: I26728971dd610f103dfcaaf7dcc47f9028ffc42d

Correct socket paths in protocols.cpp

[Issue#]        SSDWSSP-686
[Bug]           Constants which contained paths to password sockets had incorrect paths.
[Cause]         N/A
[Solution]      Correct socket paths.
[Verification]  Build, install, run tests. All should pass.

Change-Id: I410d50a8ac42517a74bfdeba1e6990bd7ce169d2

Change exec-label from "none" to "security-server"

[Issue#]    N/A
[Bug]       N/A
[Cause]     N/A
[Solution]  N/A

[Verification] Build, run tests.

Change-Id: I50868c0d0a6a0eb56ab4ab9e16c59656a8a4d8b6

Update systemd configuration.

seucurity-server.socket is no logner used. All confituration connected
with this socket has been removed.

[Issue#]      N/A
[Bug/Problem] Unused socket was created by systemd.
[Solution]    Remove configuration.

[Verification] Build, run tests.

Change-Id: I4c7d588d6189cca129f7d4ac4b45b290dc1fbb8d

Elimination of floor (_) labeled executables and relative command paths

[Issue#]       SSDWSSP-684
[Bug/Feature]  A security vulnerability to attacks fixed.
[Cause]        1) Using an floor labaled exec, a malicious process can pollute the floor labelled resources.
               2) If a relative path is used a different, malicious command might be executed (PATH change)
[Solution]     The floor labaled executables and relative command paths were eliminated.
[Verification] 1) Build, install and run tests.
               2) Verify that no executables from the package has the floor label.
               3) Verify that there are no relative command paths in scripts installed by the package.

Change-Id: Ic5b948d38406c47bc424077779303636bcdc8969

Remove API function security_server_get_object_name.

This function provides same functionality as getgrgid and was not used
on the platform.

[Issue#]      N/A
[Bug/Problem] N/A
[Cause]       N/A
[Solution]    N/A

[Verification] Build platform.

Change-Id: Id7cc0acf83c7e9a7f2329eb475dc3f1fa8982899

Change timeout in clinet from 1 secont to 2 seconds.

[Issue#]      N/A
[Feature/Bug] N/A
[Problem]     N/A
[Cause]       N/A
[Solution]    N/A

[Verification] Build, run tests.

Change-Id: I6f82c20889d1a19a0f43ebf1bcf29c90151dc2f7

Remove unused header file.

[Issue#]      N/A
[Bug/Problem] N/A
[Cause]       N/A
[Solution]    N/A

[Verification] N/A

Change-Id: I2e759f6ecdc7c49d5efc8e9a8d12712242f7a4ec

Move init of SmackAuditLog to security-server.

In old implementation SmackAuditLog was always added to provider list
and it cause problem inside security-server-client library because
process that loaded this library was not allowed to access smack log
files.

[Issue#]      N/A
[Problem/Bug] Lots of SMACK deny logs in audit files.
[Cause]       Unecessary initialization of SmackAuditLog inside client-library.
[Solution]    Remove SmackAuditLog from client.

[Verification] Build, run tests.

Change-Id: I08b5bcfe0a539d73f8c38b0fe234476b5c679631

Flush files with security server passwords data

[Issue#]       SSDWSSP-683
[Bug/Feature]  Information about putting password attempts was not flushed.
[Solution]     Flush that information to file. Test shown, that only using
               fsynch gives proper result.
[Veryfication] Build, install, run tests.

Change-Id: I96ee50186253d3efd1c74f3e2821dbc4f845a056

Remove all legacy code from security-server

[Issue#]   SSDWSSP-424
[Bug]      N/A
[Problem]  Old code was not immune for interupts and have many
           synchronization issues.
[Solution] N/A

[Verification] Build, run tests.

Conflicts:

src/communication/security-server-comm.c
src/include/security-server-comm.h
src/server/main/security-server-util.cpp

Change-Id: Ifc091f4dd8994b53c76f90898e5d39ec2c12547a

API function try/catch decoration

[Issue#] SSDWSSP-636
[Feature/Bug] N/A
[Problem] Lot of duplicated try/catch code in every API function
[Cause] N/A
[Solution] Use lambda expressions and a decorator function.

[Verification] Successfull compilation and passing security-server-tests-*

Conflicts:

src/server2/client/client-password.cpp
src/server2/client/client-socket-privilege.cpp
src/server2/client/client-common.cpp
src/server2/client/client-common.h

Change-Id: I0097d8e02e28b8f50d88f74bed900e5761e8b4a6

Rewrite security-server password service to security-server 2

[Issue#]        SSDWSSP-366
[Feature]       New password service to security-server 2 API
[Cause]         N/A
[Solution]      N/A
[Verification]  Build, install, run security-server-tests-password --output=text. With commit that
                adapts tests to this framework ( http://slp-info.sec.samsung.net/gerrit/#/c/339854 )
                all tests should pass.

Conflicts:

packaging/security-server.spec
src/CMakeLists.txt
src/server2/client/client-common.h
src/server2/common/protocols.cpp
src/server2/common/protocols.h
src/server2/main/server2-main.cpp
src/server2/service/cookie.h
systemd/CMakeLists.txt
systemd/security-server.service
src/server/security-server-password.c

Change-Id: Id1534e2cac06b499580d0ba94ff117275f7c00e8

Service connection info refactoring

[Issue#] N/A
[Feature/Bug] N/A
[Problem] Services use similar connection info maps.
[Cause] N/A
[Solution] Commonly used types moved to common header. Service specific types
renamed and moved to class internals.

[Verification] Successfull compilation

Change-Id: I5296bbc7b23b2ed4183a11213398ca8cd85d3691

New Security Server security_server_open_for function.

This function allows to create, if doesn't exist, or open existing file by
Security Server on behalf of calling process in secured directory.

[Issue#]        SSDWSSP-398
[Bug/Feature]   New SS API function.
[Cause]         DataControl issues.
[Solution]      Proposal for DataControl issues.
[Verification]  Build and run new tests:
                security-server-tests-server --output=text --regexp='open_for'

Change-Id: I9eaa69d37c20a2eb8aa3f8ba9e3aa6ef6291bae7

Security-server new API for privilege checking

[Issue#]       SSDWSSP-527
[Feature]      Introduce two new SS API functions.
[Cause]        New API will improve the performance while checking
               app privileges.
[Solution]     Two new functions in client API enable to check whether a given
               app or caller app has enabled permission specified by name.
               Modified service: app-permissions.
               Two new sockets added to systemd and affected service.
[Verification] Build, install & run tests.
               Verify together with new libprivilege database.

Change-Id: If8d4efd30bbf22f82cd1442256ccbe7efb68a8aa

Remove unused service.

[Issue#]    N/A
[Bug]       N/A
[Cause]     Code that was using exec serivice was removed.
[Problem]   Service exec path was not used.
[Solution]  Deprecated code has been removed.

[Verification] Build, run tests.

Change-Id: I33e5ba64486d4b631a8a92a8a1af65e1e2ca096b

Store smack deny logs into files

SS logs smack deny access into file in /var/log/audit/
Files are create sequential, if max file number in config is reach
it deleted oldest file and creates new one.

Configuration file security-server-audit.conf at
/etc/security/ containing number of files log and max size in bytes peer
file.

    [Issue#]        SSDWSSP-614
    [Bug/Feature]   SS creates log files on runtime and sequential
                    loging smack access
    [Cause]         N/A
    [Solution]      Add AuditSmackLog Class to manage log files
    [Verification]  Compile, run tests

Change-Id: I5d3e9c436bda6d545748da525cb3507488c47380

Security-server documentation and manifest update

[Issue#]        SSDWSSP-505
[Bug/Feature]   SS manifest update
[Cause]         SS manifest out of date
[Solution]      Manifest and header updated
[Verification]  Compile, run tests

Change-Id: Ic1358611a6d13d820407a672cc200b1074d8f536

Fixing some security-server cookie service functions to work on smack disabled.

[Issue#]        SSDWSSP-603
[Bug/Feature]   Nosmack security-server client tests fail due to incorrect
                security-server implementation for smack disabled.
[Cause]         Security-server cookie service generates incorrect label for
                nosmack and privilegeByCookieRequest does not check for smack.
[Solution]      Changing label to empty string and adding smack_check().
[Verification]  Running nosmack security-server client tests. Test
                tc05_check_privilege_by_cookie_nosmack and
                tc_security_server_get_smacklabel_cookie_nosmack should pass.

Change-Id: Ibf1ea7976d9442c56f718f8e4ca11939391cc8cd

Remove false alarm from prevent.

[Issue#]   N/A
[Bug]      N/A
[Cause]    Prevent reported that readlink may return value 4096 and
           instruction path[retval] = 0 will cause segmentation fault.
[Problem]  Prevent.

[Verification] Build, run tests.

Change-Id: I5eebb22f00bb43f30024b0da297a6ec2465d6454

Add suppor for sendmsg to security-server.

[Issue#]   SSDWSSP-598
[Problem]  OpenFor service must use sendmsg for communication.
[Cause]    OpenFor service must pass descriptor to client.
[Solution] Add support for sendmsg.

[Verification] Build, run tests.

Change-Id: I1650c6d98692985bf16b32134950b5c750c56a70

Remove deprecated SS_SMACK logs.

Each api privided by security-server uses separate socket. Each socket
is secured with diffrent smack label (for example socket:
security-server-api-data-share.sock is secured with label
security-server::api-data-share). In this way all deny logs connected
with smack were moved from dlog to dmesg. Also secure mechanism
connected with SMACK was removed from security-server code. Now,
secuirty-server is using SMACK check provided by linux kernel.

[Issue#]   N/A
[Bug]      N/A
[Cause]    N/A
[Problem]  N/A
[Solution] N/A

[Verification] Build, run tests.

Change-Id: Id9b6f05731e281a6187d3c5696a44f04a754041e

Security-server was not restarded after update.

[Issue#]    N/A
[Bug]       New sockets were not activated after update.
[Cause]     N/A
[Problem]   Lots of tests fails after security server update.

[Verification] Build, run tests.

Change-Id: I225bac131d0f2fa24d23051528189672346793f2

Adopt for gcc 4.8. Remove multiple static_cast from code.

[Issue#]   N/A
[Bug]      N/A
[Cause]    N/A
[Solution] N/A

[Verification] Build, run tests.

Change-Id: Ia8f73f4bf4c92a825325885f8c42a8ddfe391998

Fix synchronization problem during application closing

[Issue#]        N/A
[Bug]           Application may not close imediately in rare cases.
[Cause]         Synchronization issue.
[Solution]      Fixed synchronization issue.
[Verification]  Build secutiry server, run tests.

Change-Id: I70bf075c38c312731ec5fb360644068e056ae000

Rename methods read and readOne in each service

[Issue#]        SSDWSSP-577
[Feature]       Method read and readOne should be renames to process and
                processOne.
[Cause]         There is nothing to read in this methods.
[Solution]      Method was renames.
[Verification]  Build security server and run tests on target.

Change-Id: I1c67834e73f021402b1bfb45323ba5d5370a9f2f

Removed unused virtual method Event(ErrorEvent) from GenericSocketService and all it's implementations.
[Issue#] SSDWSSP-480 /3
[Feature] Method Event(ErrorEvent) should be removed.
[Cause] It is not used so it is not needed.
[Solution] Method was removed.
[Verification] Build security-server and run security server tests on target.

Change-Id: If933780083e2bc8c0e644427c1e8ad768e2b4c1a

Renamed class SocketBuffer to MessageBuffer and all its usages.
[Issue#] SSDWSSP-480 /1
[Feature] SocketBuffer class needed to be renamed to MessageBuffer.
[Cause] SocketBuffer is not right name for this class.
[Solution] Class was renamed.
[Verification] Build security-server and run security server tests on target.

Change-Id: I8fce6aef14308389e1148599e89b3e11939a36fd

Add README file

    [Issue#]       SSDWSSP-528
    [Bug/Feature]  Added README file.
    [Cause]        N/A
    [Solution]     N/A
    [Verification] N/A

Change-Id: I00a8654ab2589013e4f8849352f7d8c231c8caf5

Fix problem with security-server build with tizen 3.0 toolchain

[Issue#]        SSDWSSP-549
[Bug/Feature]   Fix errors in build
[Cause]         Required static cast in switch statement
[Solution]      Static cast added
[Verification]  Build

Change-Id: If3d354e87ed8d7edd1c485c98b1a8023876c4abd

Compilation flags 'verbose' mode

[Issue#]       SSDWSSP-496
[Bug/Feature]  N/A
[Cause]        CMAKE_VERBOSE_MAKEFILE flag turned OFF in packaging spec file
[Solution]     Turn ON the flag.
[Verification] Build, verify that compile flags passed to gcc are visible
               using different build types (in gbs: --define "build_type ...").

Change-Id: I939916fabb47bfba864aba0d1e526db0ba4bdfc8

Fix security server API argument validation

[Issue#]       SSDWSSP-332
[Bug]          Potential bug, bad parameters (f.e. pid) may be used in two
               functions.
[Cause]        Two API functions does not validate all given arguments.
               Also there is a risk of unsigned int overflow when calculating
               password validity (when changing from days to seconds).
[Solution]     Checking existence of a process with given pid added.
               Unsigned int overflow protection is added.
               Also argument validation added to API function.
[Verification] Build, install and run tests.

Change-Id: Ia8e9528462e31220faf88c72c111b7f0efc03681

Making security-server buildable under GCC 4.8.

    [Issue#]        SSDWSSP-523
    [Bug/Feature]   Security-server does not build under GCC 4.8.
    [Cause]         switch() does not accept int to enum conversion.
    [Solution]      Applying static_cast.
    [Verification]  Building under GCC 4.8.

Change-Id: Ib28b21058d6e6a63925e933aa936b8197f553393

Security-server symbols hidden by default

[Issue#] N/A
[Feature/Bug] N/A
[Problem] Security-server unnecessarily exports its symbols
[Cause] N/A
[Solution] Symbols hidden by default

[Verification] Successful compilation. Tests should pass as before. Security-server binary size should be ~50KB smaller.

Change-Id: Ifc82fc7dcae75a7619be0a416296d3835652aeef

Password validity argument check added

[Issue#] N/A
[Feature/Bug] N/A
[Problem] tc10_security_server_set_pwd_current_pwd_max_valid_period_in_days fails
[Cause] Password validity argument was not checked
[Solution] Check added

[Verification] Run security-server-tests-password. All should pass.

Change-Id: I564ec3fcfa905c8b3ed9af620f67dec47f86fc87

Include external header files with isystem.

[Issue#]   N/A
[Bug]      N/A
[Cause]    N/A
[Problem]  Waning from external libraries may cause build break when
           security-server is compiled with -Werror flag.
[Solution] Include external headers path with -isystem option.

[Verification] Successful build.

Change-Id: I97994d39fc5d466d1b6bda83b55d21ee398cd0ac

Clean-up logging

Change logging in ss1, now in RELEASE build log only errors

    [Issue#]        SSDWSSP-457
    [Bug/Feature]   Clean-up logging
    [Cause]         N/A
    [Solution]      N/A
    [Verification]  Build

Change-Id: I1584eafdcaec478cc6ccab40bcb55a8969e21b1a

Add Garbage Collector in cookie module

[Issue#]   SSDWSSP-495
[Bug]      N/A
[Cause]    N/A
[Solution] Add GC,gc is called each GET_COOKIE API call
[Verification] build

Change-Id: I8c64dec020174025a355ae067cb59ca5f140c117

Reduce false defects reported by prevent.

[Issue#]   N/A
[Bug]      N/A
[Problem]  N/A
[Solution] N/A

[Verification] Build.

Change-Id: I13bd90c0815caf6018824359d203afee8e4ca1f2

Synchronize repositories.

[Issue#]   N/A
[Bug]      N/A
[Problem]  N/A
[Solution] N/A

[Verification] N/A

Fix api get-cookie-uid/get-cookie-gid.

[Issue#]   N/A
[Bug]      Client was using wrong server socket and all
           request were ignored.
[Problem]  N/A
[Solution] N/A

[Verification] Build, run tests.

Change-Id: Ibee05c2be476f96756ae6cdbfcd17a454115a8b9

Implement new API for get GID and UID by cookie

[Issue#]        SSDWSSP-399
[Bug/Feature]   New API to security-server
[Cause]         Missing API to get UID and GID by cookie
[Solution]      New API added
[Verification]  Compile, run tests

Change-Id: Ie6f65378a31e65840b682b3a6dc2c9ab3f931ec2

Remove support for DPL_USE_OLD_STYLE_* environment values in RELEASE build.

This environment values will be supported in DEBUG build only:
 * DPL_USE_OLD_STYLE_LOGS
 * DPL_USE_OLD_STYLE_PEDANTIC_LOGS
 * DPL_USE_OLD_STYLE_LOGS_MASK

This commit turn off all logs except Error logs in RELEASE build.

[Issue#]   SSDWSSP-447
[Problem]  Security-server generates too many logs in RELEASE build.
           Debug logs may be turn on by environment values.
[Solution] Remove support for environment values.

[Verification] Successful build.

Change-Id: I557a69c007e4d916b2b2ac2f92e21572a9fb9f37

Enabling compilation under GCC-4.8.

[Issue#]   N/A
[Bug]      Build break.
[Problem]  Lack of header files.
           Space is required between strings that will be concatenated.
           Remove compilation warning.
[Solution] N/A

[Verification] Build. Run tests.

Change-Id: I7c34508a17ccd539d987d887a530959b3f257b87

Add missing header files in cookie module.

[Issue#]   N/A
[Bug]      Missing include sys/smack.h in cookie module.
[Cause]    N/A
[Solution] Add missing header.

[Verification] Build, run tests.

Change-Id: I66809021fd99f4fed5fe9548e9662910d958530a

Remove deprecated and unused code.

Service responsible for function security_server_check_privileges_by_pid
was written some time ago. This commit removes old implementation of
this function.

[Issue#]   SSDWSSP-424
[Bug]      N/A
[Cause]    N/A
[Solution] N/A

[Verification] Build. Run all tests.

Change-Id: I69706853b0851e1c686a543b61a4e5d8d45b1b3f

After SIGTERM security-server crashes.

[Issue#]   N/A
[Problem]  NULL poiter dereference in SocketManager.
[Cause]    Pointer to SocketManager was not set in SignalService.
[Solution] Set pointer in SignalService.

[Verification] Run command "systemctl restart security-server.service".
               Security-server should restart without any errors.

Change-Id: I79e8c581c5a1d6479509713634a81521a947bfeb

Move security server cookie API to new framework

[Issue#]        SSDWSSP-365
[Bug/Feature]   Rewrite cookie functions to new security-server framework
[Cause]         API functions in deprecated framework
[Solution]      API functions moved to the new framework
[Verification]  No tests should fail

Change-Id: If0a12680c8d966a78a940c3656920da1beaf4285

This patch enable compilation under GCC-4.8

[Issue#]   N/A
[Bug]      Build break under GCC-4.8
[Cause]    Services does not included required header files.
[Solution] Add headers to cpp files.

[Verification] Build.

Change-Id: I114ffb5592e6c7d600c0047fc1fb2d4dbceeb913

Adding cap check after smack_have_access in security-server and displaying logs
regarding this call.

[Issue#]        SSDWSSP-454
[Bug/Feature]   SECURE_SLOG* macros used after smack_have_access() and its wrapper
                don't write messages to dlog and CAP_MAC_OVERRIDE is not checked.
[Cause]         SECURE_SLOG* macros depend on TIZEN_ENGINEER_MODE flag in dlog.h
                which is turned off.
[Solution]      Changing SECURE_SLOG* to SEC_SVR_* and Log* macros and adding check for
                CAP_MAC_OVERRIDE after smack_have_access.
[Verification]  Check dlogutil for those logs.

Change-Id: I167dea72f9c1bcbcc2c4ea7008eea3a6bbbd9c82

Adapt security-server for a new libsmack API

    [Issue#]   SSDWSSP-433
    [Bug]      N/A
    [Cause]    Changed API of libsmack.
    [Problem]  Function smack_new_label_from_socket() is now returning value greater than 0 on success, not 0 as it was before.
    [Solution] Changes of expected function results
    [Verification] Run tests.

Change-Id: I89aa91e69fccb0091dfb1eccd2fc2d6347cfcf3b

Turn off environment CFLAGS cleaning.

CMAKE_C_FLAGS options will overwritten default environment flags.
This commit comments out this value so default evfironment values won't
be overwritten.

[Issue#]   N/A
[Bug]      N/A
[Cause]    Enable executable tuning for cortex-a8.
[Solution] N/A

[Verfication] Successful compilation.

Change-Id: Id582c07c45d7042b4fcab73f68bda8de21872321

Unused code causing buildbreak removed

[Issue#] N/A
[Feature/Bug] N/A
[Problem] Buildbreak
[Cause] Ignored return value warning
[Solution] Code causing buildbreak is unused. It has been removed.

[Verification] Succesfull compilation. Tests should pass

Change-Id: Ibf4299964c091f478de384c7b7b4f2e6186ae0dd

Conflicts:

src/server/security-server-main.c

Fix for proc/<pid>/status line extraction crash

[Issue#] SSDWSSP-448
[Feature/Bug] N/A
[Problem] Crash during cookie creation
[Cause] Buffer overflow
[Solution] Line extraction code rewritten to use getline

[Verification] Compile and run tests.

Change-Id: Ib69bc601847c93f8ea7f21f9520fa4c0f229bf32

Clean up after SIGTERM.

[Issue#]   N/A
[Bug]      N/A
[Cause]    Lack of SIGTERM support.
[Problem]  N/A
[Solution] Add support for SIGTERM signal.

[Verification] Use "systemctl restart security-server.service" command.
               Security server should be killed and restarted.

Change-Id: Ic41957bf3aaee60afb98cae6de841a057f3ad49a

Empty string password bug fixed.

[Issue#]        SSDWSSP-422
[Bug/Feature]   Empty password should not be set.
[Cause]         N/A
[Solution]      N/A
[Verification]  Running ss-pasword tests from http://slp-info.sec.samsung.net/gerrit/#/c/259674/ commit.

Change-Id: I0063f8b315e0f0be2631a9d51d3834f070f3eb2c

Removing bug regarding security-server first use.

[Issue#]        SSDWSSP-449
[Bug/Feature]   There should be difference between initiated password time and
                first function call regarding password so that difference should
                not cause SECURITY_SERVER_ERROR_PASSWORD_RETRY_TIMER error.
[Cause]         While security-server is called for the first time, it initiates
                itself.
[Solution]      N/A
[Verification]  Running security-server ss-password tests. There should be no
                error with SECURITY_SERVER_ERROR_PASSWORD_RETRY_TIMER (value -17).

Change-Id: I67243269fc8ed0476f614ab4143d81f4c12e24ee

Reduce number of logs.

Now core of security-server2 won't log any information
about timeouts. All debug logs in socket-manager were
removed. This patch should reduce number of logs for 50%.

[Issue#]      SSDWSSP-447
[Bug/Problem] Security-server generates too many logs.
[Cause]       New implementation was tested.
[Solution]    Decrease number of logs.

[Verification] Build, run tests.

Change-Id: I9c3cec96f1ca4899e8a95c988cd9dc56cf2d9db5

Add support for EINTR in client.

[Issue#]     N/A
[Bug]        Poll did not support EINTR code. This error
             may break communication between security-server and client.
[Solution]   Add support for EINTR.

[Verification] Compile, run tests.

Change-Id: I0c052f3895f351adf80908db0b7c1ac826f3c0e0

Fix for unused variable warning/error

[Issue#] N/A
[Feature/Bug] N/A
[Problem] Buildbreak caused by unused variables
[Cause] Dlog logging macros have been recently disabled
[Solution] Variables marked as unused

[Verification] Successfull compilation

Change-Id: Idbbc5741ed14dda4484daac0edc2dbc4759c99e9

Get rid of build warnings

[Issue#] SSDWSSP-397
[Bug] Several warnings was appearing during package build
[Cause] These warnings mainly concern implicit functions declarations
and comparisons between variables of different types
[Solution] Adding function declarations, header file inclusions,
explicit cast operators.
Also 'Werror' flag is added to CMakeLists.txt .

[Verification] Successful compilation & all security tests successfully
completed on target device

Change-Id: I2387b829835319354097384497abd9f1eaec9636

Fix bug in app-permissions module.

[Issue#]    N/A
[Bug/Cause] Function security_server_app_disable_permissions
            did not propagate success code.
[Solution]  Add return in security_server_app_disable_permissions.

[Verification] Build, run tests.

Change-Id: I389e6a65ae4f3d2e1496bf14a048274ef6263def

Fix latest prevent defects

[Issue#] SSDWSSP-435
[Bug/Feature] Unitialized scalar variable.
[Cause] Using uninitialized value "cr.pid" when calling "get_exec_path(pid_t, std::string &)".
[Solution] Change of program execution flow and logging, change unique_ptr deleter.
[Verification] Analyzing execution flow, running prevent tests.

Change-Id: Iaaf0f938e6f7111419325898436245e399d652bd

Added API for APP enable and disable permissions

[Issue#]        SSDWSSP-155
[Bug/Feature]   Implement API for removing/adding API feature rules from
                applications SMACK profile
[Cause]         Need new API
[Solution]      New API added
[Verification]  Compile. No new tests should fail

Change-Id: Ib6e95f32fa0cf0ebb2fdfd787b1c1f156b5a96b6