Data-share service test wrong value returned from smack_new_label_from_socket.
authorZbigniew Jasinski <z.jasinski@samsung.com>
Mon, 17 Feb 2014 12:42:11 +0000 (13:42 +0100)
committerBartlomiej Grzelewski <b.grzelewski@samsung.com>
Mon, 24 Feb 2014 10:18:56 +0000 (11:18 +0100)
[Issue#]    PSDAC-46
[Bug]       Failing tests:
            * tc01a_security_server_app_give_access
            * tc07_check_API_data_share_allow
[Cause]     Wrong check of return value.
[Solution]  Check proper return value from smack_new_label_from_socket

[Verifcation] Build, run tests.

src/server/service/data-share.cpp

index 0c64a60..6dcee6a 100644 (file)
@@ -77,7 +77,7 @@ bool SharedMemoryService::processOne(const ConnectionID &conn, MessageBuffer &bu
     }
 
     if (smack_check()) {
-        if (0 != smack_new_label_from_socket(conn.sock, &providerLabel)) {
+        if (0 > smack_new_label_from_socket(conn.sock, &providerLabel)) {
             LogDebug("Error in smack_new_label_from_socket");
             retCode = SECURITY_SERVER_API_ERROR_BAD_REQUEST;
             goto end;