From: Zbigniew Jasinski <z.jasinski@samsung.com>
Date: Mon, 17 Feb 2014 12:42:11 +0000 (+0100)
Subject: Data-share service test wrong value returned from smack_new_label_from_socket.
X-Git-Tag: accepted/tizen/generic/20140307.163312~7
X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fsecurity%2Fsecurity-server.git;a=commitdiff_plain;h=925999de3c17c3441f5bcdea689dc3c821be4843

Data-share service test wrong value returned from smack_new_label_from_socket.

[Issue#]    PSDAC-46
[Bug]       Failing tests:
            * tc01a_security_server_app_give_access
            * tc07_check_API_data_share_allow
[Cause]     Wrong check of return value.
[Solution]  Check proper return value from smack_new_label_from_socket

[Verifcation] Build, run tests.
---

diff --git a/src/server/service/data-share.cpp b/src/server/service/data-share.cpp
index 0c64a60..6dcee6a 100644
--- a/src/server/service/data-share.cpp
+++ b/src/server/service/data-share.cpp
@@ -77,7 +77,7 @@ bool SharedMemoryService::processOne(const ConnectionID &conn, MessageBuffer &bu
     }
 
     if (smack_check()) {
-        if (0 != smack_new_label_from_socket(conn.sock, &providerLabel)) {
+        if (0 > smack_new_label_from_socket(conn.sock, &providerLabel)) {
             LogDebug("Error in smack_new_label_from_socket");
             retCode = SECURITY_SERVER_API_ERROR_BAD_REQUEST;
             goto end;