platform/core/multimedia/libmm-sound.git
3 years agoRemove sound_server in build packages 29/234129/7 accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.114452 accepted/tizen/6.0/unified/hotfix/20201103.003757 accepted/tizen/unified/20200619.121806 submit/tizen/20200617.070830 submit/tizen/20200618.010303 submit/tizen/20200618.073641 submit/tizen_6.0/20201029.205104 submit/tizen_6.0_hotfix/20201102.192504 submit/tizen_6.0_hotfix/20201103.114804 tizen_6.0.m2_release
Jaechul Lee [Fri, 22 May 2020 06:08:04 +0000 (15:08 +0900)]
Remove sound_server in build packages

tone-player and wav-player in sound-server were moved to pulseaudio.
sound_server is not necessary to play sound/tone. Tizen_HW_Touch.ogg is
moved to pulseaudio-modules-tizen package.

[Version] 0.13.0
[Issue Type] Improvement

Change-Id: I06f5088db6381d5ca79d73d45bcfa143bc4a3923
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoSupport gcov build for coverage check 18/232418/2 submit/tizen/20200518.104736
Seungbae Shin [Mon, 4 May 2020 10:13:38 +0000 (19:13 +0900)]
Support gcov build for coverage check

gcov build enabled by gbs define option '--define "gcov 1"'

[Version] 0.12.73
[Issue Type] Add

Change-Id: I3e0dc35573f4aa6119004ad60462f8d8493ab126

4 years agoFix build warnings 15/232415/1
Seungbae Shin [Mon, 4 May 2020 10:04:22 +0000 (19:04 +0900)]
Fix build warnings

Change-Id: Idcf9b5a32c18912aef01ab9580c2812243e86297

4 years agoAdds mm_sound_tone_stop for tone-player 41/230641/7 accepted/tizen/unified/20200417.152650 submit/tizen/20200417.044433
Jaechul Lee [Mon, 13 Apr 2020 06:34:20 +0000 (15:34 +0900)]
Adds mm_sound_tone_stop for tone-player

Tone-player and wav-player use mm_sound_stop API for stopping sound. So,
sound-play module in pulseadio received tone-player stop message through
dbus. Another problem was a stream handle that must have under
CLIENT_HANDLE_MAX(256) value. The handle from pulseaudio are increased
every creation.

[Version] 0.12.72
[Issue Type] Bug

Change-Id: I355aaf592413ec94730c0b206ea8d50a190a7281
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoAdds checking file existence 77/230577/4
Jaechul Lee [Mon, 13 Apr 2020 00:54:31 +0000 (09:54 +0900)]
Adds checking file existence

[Version] 0.12.71
[Issue Type] Bug

Change-Id: I3f8450ec6431851cb84e205d9d5b90e30a645859
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoAdds checking dbus error messages 13/230113/2
Jaechul Lee [Wed, 8 Apr 2020 05:02:14 +0000 (14:02 +0900)]
Adds checking dbus error messages

It can't check error messages properly because dbus error message has a
space before org.tizen.bla. Besides, the messages are little difference
between sound-server and pulseaudio.

e.g)
a error message from sound-server(g_dbus api)
GDBus.Error:org.tizen.multimedia.audio.Internal: failed

a error message from pulseaudio(dbus api)
GDBus.Error:org.freedesktop.DBus.Error.Failed: org.tizen.multimedia.audio.Internal

[Version] 0.12.70
[Issue Type] Bug

Change-Id: I1f0ba391dd3645cac3a6bd7006ed8ca51b9c4a28
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoAdds checking a invalid handle 34/229834/2 submit/tizen/20200406.030837 submit/tizen/20200407.002130
Jaechul Lee [Mon, 6 Apr 2020 01:53:32 +0000 (10:53 +0900)]
Adds checking a invalid handle

It needs to check the handle that is returned from pulseaudio.

[Version] 0.12.69
[Issue Type] Bug

Change-Id: I245579aa282452dba352ad6356b882d072a894d3
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoChanges playback interface to org.pulseaudio.SoundPlayer 05/228905/5 submit/tizen/20200403.080755
Jaechul Lee [Thu, 26 Mar 2020 08:10:39 +0000 (17:10 +0900)]
Changes playback interface to org.pulseaudio.SoundPlayer

[Version] 0.12.68
[Issue Type] Improvement

Change-Id: I7301167c3bf0bb6101a7e2064fdba863b5f383dc
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agofixup! Fix mismatching function prototype 33/229033/1 accepted/tizen/unified/20200402.155346 submit/tizen/20200327.075055
Seungbae Shin [Fri, 27 Mar 2020 07:23:26 +0000 (16:23 +0900)]
fixup! Fix mismatching function prototype

Change-Id: Id158547ac10b3ceeabc8473ce10986d7c0d484fe

4 years agoFix mismatching function prototype 59/228759/3 submit/tizen/20200326.082511
Seungbae Shin [Wed, 25 Mar 2020 08:13:34 +0000 (17:13 +0900)]
Fix mismatching function prototype

avoid unexpected complete callback for tone playback
fixup missing data type for volume_type in internal keysound function

[Version] 0.12.67
[Issue Type] Bug

Change-Id: I3bf44c8abcbd239ae867ba427d193268729762ee

4 years agoFix memory leak 41/228541/1 submit/tizen/20200325.060410
INSUN PYO [Mon, 23 Mar 2020 23:21:55 +0000 (08:21 +0900)]
Fix memory leak

Change-Id: Idd7046f37979ac6041eac1b6b6df87c9a31d8f98

4 years agoAdd mm_sound_stop_keysound() 21/227321/7 accepted/tizen/unified/20200323.172912 submit/tizen/20200323.095035
Seungbae Shin [Wed, 11 Mar 2020 07:32:48 +0000 (16:32 +0900)]
Add mm_sound_stop_keysound()

[Version] 0.12.66
[Issue Type] Add

Change-Id: I2e17159bcafabc4056fcae7cff62ec1a70403c95

4 years agoFix NULL pointer dereference 41/228241/1
Jaechul Lee [Thu, 19 Mar 2020 07:02:31 +0000 (16:02 +0900)]
Fix NULL pointer dereference

g_variant_unref is called with a NULL argument.

[Version] 0.12.65
[Issue Type] Bug

Change-Id: I2f65a076f2c54a35ffcbe756b846a2f8c14edb21
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoFix double unlock of slot mutex in user stops scneario 23/226223/1 accepted/tizen/unified/20200310.151130 submit/tizen/20200228.053650 submit/tizen/20200228.144704 submit/tizen/20200229.153002 submit/tizen/20200305.021956 submit/tizen/20200309.043014
Seungbae Shin [Fri, 28 Feb 2020 05:00:19 +0000 (14:00 +0900)]
Fix double unlock of slot mutex in user stops scneario

In addition, stream started callback and written data log are added for convienent debugging

[Version] 0.12.64
[Issue Type] Bug

Change-Id: I1f444f9ff2920156407c4baa11aa655116d241f6

4 years agoRevise code related to coding conventions and adjust some log levels 22/226222/1
Seungbae Shin [Fri, 28 Feb 2020 04:54:45 +0000 (13:54 +0900)]
Revise code related to coding conventions and adjust some log levels

[Version] 0.12.63
[Issue Type] Revision

Change-Id: I5ac7e618fbab8f2d972a9fd94748ccd10c5776b4

4 years agoFix to start stream corked to avoid early drain complete 00/226200/4
Seungbae Shin [Thu, 27 Feb 2020 11:34:14 +0000 (20:34 +0900)]
Fix to start stream corked to avoid early drain complete

For short file playback, drain operation can be completed to early prior to actual stream start.
This is due to connecting playback stream with uncorked.
In this situation, stream handle will not be valid any more and finally crash occurred.
To fix this issue, stream should be started with corked state.

[Version] 0.12.62
[Issue Type] Bug

Change-Id: I32f0748dc64ce822a4fa277d957792dfecb5a323

4 years agoFix coverity (Negative array index write) defects 44/225044/1 accepted/tizen/unified/20200218.145857 submit/tizen/20200217.053323 submit/tizen/20200217.171406
Seungbae Shin [Mon, 17 Feb 2020 04:29:21 +0000 (13:29 +0900)]
Fix coverity (Negative array index write) defects

[Version] 0.12.61
[Issue Type] Vulnerability

Change-Id: I9ce6cd2c12fce3224a3bd4da99008a562cca076a

4 years agoFix coverity (Incorrect deallocator used) defects 96/224496/1 accepted/tizen/unified/20200212.125901 submit/tizen/20200211.061055
Seungbae Shin [Tue, 11 Feb 2020 04:59:01 +0000 (13:59 +0900)]
Fix coverity (Incorrect deallocator used) defects

[Version] 0.12.60
[Issue Type] Vulnerability

Change-Id: Ia5ef3506a39748ebb12dc89e60917ec48f8f89b0

4 years agofixup! Fix some vulnerability (Null Pointer Dereference) defects 51/222451/1 submit/tizen/20200115.070647 submit/tizen/20200116.104148 submit/tizen/20200121.063631 submit/tizen/20200129.111655 submit/tizen/20200130.111236 submit/tizen/20200203.120903
Seungbae Shin [Mon, 13 Jan 2020 10:21:58 +0000 (19:21 +0900)]
fixup! Fix some vulnerability (Null Pointer Dereference) defects

Change-Id: Ic82ab59660ba7976789b06bc8da6c61ba5317d21
(cherry picked from commit 7852719f0a4cae043f7a6c13787d0aa0310c1721)

4 years agoFix some vulnerability (Null Pointer Dereference) defects 78/222278/1 accepted/tizen/unified/20200114.130704 submit/tizen/20200113.074205
Seungbae Shin [Wed, 18 Dec 2019 02:31:24 +0000 (11:31 +0900)]
Fix some vulnerability (Null Pointer Dereference) defects

[Version] 0.12.59
[Issue Type] Vulnerability

Change-Id: I0d4ddd518dad40e4306cbc8f4200ccaa6f00ea78
(cherry picked from commit 38b3c36fd75409a72a7f2da8e3c27f15ef1ba7b9)

4 years agofocus_server: Check symbolic link before opening a file 57/222257/1
Sangchul Lee [Mon, 13 Jan 2020 03:40:26 +0000 (12:40 +0900)]
focus_server: Check symbolic link before opening a file

[Version] 0.12.58
[Issue Type] Security vulnerability

Change-Id: I84f699be4b1b6e82e33aeaf03f9181ddac9f0fbf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agomm_sound_plugin_codec_wave: Set client pid to PulseAudio property 41/222241/2
Sangchul Lee [Mon, 13 Jan 2020 01:11:32 +0000 (10:11 +0900)]
mm_sound_plugin_codec_wave: Set client pid to PulseAudio property

[Version] 0.12.57
[Issue Type] Improvement

Change-Id: I756323dcfaa05eaf7584c4d6d16814242d137400
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agoAdd internal volume API set 70/218770/1 accepted/tizen/unified/20191204.042030 submit/tizen/20191202.063949
Sangchul Lee [Tue, 12 Nov 2019 05:16:06 +0000 (14:16 +0900)]
Add internal volume API set

Initially, this patch supports the bixby volume type.

[Version] 0.12.56
[Issue Type] New feature

Change-Id: Ib6739238356dd52aa2d519154ece65a892254dfa
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agoRetry when writing to keysound pipe is failed with 'Resource temporarily unavailable' 54/218154/3 accepted/tizen/unified/20191122.053233 submit/tizen/20191121.114011
Seungbae Shin [Wed, 20 Nov 2019 04:54:48 +0000 (13:54 +0900)]
Retry when writing to keysound pipe is failed with 'Resource temporarily unavailable'

[Version] 0.12.55
[Issue Type] Improvement

Change-Id: Ib9e43afca246832b81b8e7dc4e559d66ba13194c

4 years agoRemove the validation check of volume level in the client side 53/217553/2 accepted/tizen/unified/20191118.122950 submit/tizen/20191115.044113
Sangchul Lee [Tue, 12 Nov 2019 09:11:04 +0000 (18:11 +0900)]
Remove the validation check of volume level in the client side

It was the only hard-coded condition which limits the maxium
volume level per each volume type. The rest of volume policy
has been implemented with fixing the maximum level by the values
in the volume table loaded inside of the PulseAudio.

[Version] 0.12.54
[Issue Type] Improvement

Change-Id: Id34f818764062da0060a8288f16e4281fd7aae05
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agomm_sound: Remove deprecated symbol - mm_sound_volume_remove_callback() 76/217476/1
Sangchul Lee [Mon, 11 Nov 2019 02:01:49 +0000 (11:01 +0900)]
mm_sound: Remove deprecated symbol - mm_sound_volume_remove_callback()

[Version] 0.12.53
[Issue Type] Clean-up

Change-Id: I45db42cae27ff0537e747118b85cbff5c241684c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agomm_sound_server: fix not to nofity complete callback in case of stopping wav playback 51/214551/1 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/20191031.022817 accepted/tizen/5.5/unified/mobile/hotfix/20201027.084622 accepted/tizen/unified/20190926.065714 submit/tizen/20190925.044646 submit/tizen/20190925.121113 submit/tizen_5.5/20191031.000004 submit/tizen_5.5_mobile_hotfix/20201026.185103 tizen_5.5.m2_release
Seungbae Shin [Tue, 24 Sep 2019 03:30:41 +0000 (12:30 +0900)]
mm_sound_server: fix not to nofity complete callback in case of stopping wav playback

[Version] 0.12.52
[Issue Type] Bug

Change-Id: I89d6c270511a1f51f8c048484dda24226c0cd43b

4 years agomm_sound_server: Terminate the server when MMSoundThreadPoolRun() is failed 23/214323/2 accepted/tizen/unified/20190923.011207 submit/tizen/20190920.075442
Sangchul Lee [Fri, 20 Sep 2019 07:24:46 +0000 (16:24 +0900)]
mm_sound_server: Terminate the server when MMSoundThreadPoolRun() is failed

[Version] 0.12.51
[Issue Type] Crash

Change-Id: Ia58555507d775426dd1b4633e296f57c4635af2f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agoAdd new function to update taken_info of nodes used right after invoking user callback 85/213785/2 accepted/tizen/unified/20190917.034037 submit/tizen/20190916.053415
Sangchul Lee [Wed, 11 Sep 2019 08:09:27 +0000 (17:09 +0900)]
Add new function to update taken_info of nodes used right after invoking user callback

It'll reduce cyclomatic complexity of SAM.

[Version] 0.12.50
[Issue Type] Refactoring

Change-Id: Ife68840f015f82ab7cfd25dc3d54ecc792a197da
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agoAdd new function to check if it needs to trigger focus callback or not 40/213740/1 accepted/tizen/unified/20190916.043539 submit/tizen/20190911.081829
Sangchul Lee [Wed, 11 Sep 2019 02:32:26 +0000 (11:32 +0900)]
Add new function to check if it needs to trigger focus callback or not

It'll reduce cyclomatic complexity of SAM.

[Version] 0.12.49
[Issue Type] Refactoring

Change-Id: Ibc71f4192ffed181d1d9999dc5a3f48b512c5929
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agoAdd new function to get my focus node and apply it 95/213695/4
Sangchul Lee [Tue, 10 Sep 2019 08:02:03 +0000 (17:02 +0900)]
Add new function to get my focus node and apply it

It'll reduce cyclomatic complexity of SAM.

[Version] 0.12.48
[Issue Type] Refactoring

Change-Id: I3cc8ae7160161c3d2e52078fab268f8a710b99d7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agoUse static keyword for global variables 63/212863/1 accepted/tizen/unified/20190901.225935 submit/tizen/20190830.101834
Seungbae Shin [Tue, 27 Aug 2019 11:39:28 +0000 (20:39 +0900)]
Use static keyword for global variables

[Version] 0.12.47
[Issue Type] Refactorying

Change-Id: I00460fb797eb41492c6b8223dce6fc39610a2fea

4 years agoRemove unused handle mode enum for pa_client 58/212858/2
Seungbae Shin [Tue, 27 Aug 2019 10:40:55 +0000 (19:40 +0900)]
Remove unused handle mode enum for pa_client

[Version] 0.12.46
[Issue Type] Refactorying

Change-Id: I208d23d0bb9318d3a7b21de49ca1ee7f6968550c

4 years agoAdd new functions to support ducking state changed callback 92/209792/1 accepted/tizen/unified/20190716.111223 submit/tizen/20190716.020521
Jeongmo Yang [Thu, 11 Jul 2019 05:59:40 +0000 (14:59 +0900)]
Add new functions to support ducking state changed callback

[Version] 0.12.45
[Profile] Common
[Issue Type] New feature

Change-Id: Ia4664b74e810320c39a268c7f5de1c829ef874e6
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agoRemove unused dependency of tizen-system.target 62/209562/1
Hyotaek Shim [Tue, 9 Jul 2019 02:23:24 +0000 (11:23 +0900)]
Remove unused dependency of tizen-system.target

Change-Id: Iac2ed749279512e559f01df44ae7436e699af053
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
4 years agoAdjust the position of focus-server.path 11/208411/1 accepted/tizen/unified/20190626.040920 submit/tizen/20190625.070900
INSUN PYO [Mon, 24 Jun 2019 06:01:22 +0000 (15:01 +0900)]
Adjust the position of focus-server.path

Change-Id: I4afcb31ea237dfd2e0a379a1ff942a634624e6d3

4 years agoChange the config value of the systemd service ("false" -> "no") 77/208377/1
INSUN PYO [Mon, 24 Jun 2019 02:23:46 +0000 (11:23 +0900)]
Change the config value of the systemd service ("false" -> "no")

"no" and "false" have the same meaning, but the document has "no".
Also, since the parsing order is "no" first, there is some performance gain.

Change-Id: Ia619d43197cdf42c6a430b9c32700e99483662af

4 years agoUse MM_SOUND_DEVICE_TYPE_NETWORK renamed from _TYPE_RAOP 68/208068/1 accepted/tizen/unified/20190621.121851 submit/tizen/20190619.053430 submit/tizen/20190620.095920
Sangchul Lee [Tue, 18 Jun 2019 00:17:00 +0000 (09:17 +0900)]
Use MM_SOUND_DEVICE_TYPE_NETWORK renamed from _TYPE_RAOP

[Version] 0.12.44
[Issue Type] Improvement

Change-Id: I77ab3317bca9ae4d75d7c3e09ae735d1a9a188e1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agoGet stream list again if it doesn't seem to have done it before 30/206730/2 accepted/tizen/unified/20190530.043054 submit/tizen/20190524.073023
Sangchul Lee [Fri, 24 May 2019 04:47:11 +0000 (13:47 +0900)]
Get stream list again if it doesn't seem to have done it before

stream list is obtained from PulseAudio via DBus during the initialization
of the focus server. Normally, PulseAudio is launched before this focus
server. It has no problem with the normal situation. If the sequence is
reversed for some reason, these new codes can get a chance to make it right.

[Version] 0.12.43
[Issue Type] Fault tolerance

Change-Id: I95007aa7ea8aecbf9f7212c6b0d2daaf6bee7806
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoImprove logic regarding focus reacquisition change in the callback 74/204874/1 accepted/tizen/unified/20190430.113437 submit/tizen/20190429.054338
Sangchul Lee [Mon, 29 Apr 2019 01:03:52 +0000 (10:03 +0900)]
Improve logic regarding focus reacquisition change in the callback

If reacquisition value is changed in the focus callback, taken_by_id
/taken_backup structures for both playback/capture of the node should
be updated.

[Version] 0.12.42
[Issue Type] Bug fix

Change-Id: I0161d0af91878909ae5c60b3072382d576955a80
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoManage focus cb thread and focus watch cb thread separately 18/202018/1 accepted/tizen/unified/20190325.070904 submit/tizen/20190322.072428
Sangchul Lee [Fri, 22 Mar 2019 01:25:30 +0000 (10:25 +0900)]
Manage focus cb thread and focus watch cb thread separately

API is revised as below.
 - int mm_sound_focus_is_cb_thread(bool *result)
 + int mm_sound_focus_is_cb_thread(bool *result, bool *is_for_watching)

[Version] 0.12.41
[Issue Type] Enhancement

Change-Id: Ib2cfa6b7b2425d5a37db224bb242c7c2a1651d14
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoAdd to check the condition before unlocking mutex in focus watch callback handler 44/201744/1
Sangchul Lee [Tue, 19 Mar 2019 06:25:32 +0000 (15:25 +0900)]
Add to check the condition before unlocking mutex in focus watch callback handler

[Version] 0.12.40
[Issue Type] Bug fix

Change-Id: I767b8d1593ee92f8196a9bbdba9ade0ccdbdafa9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoAdd support for mute API set 23/199823/5 accepted/tizen/unified/20190221.015446 submit/tizen/20190220.021455
Sangchul Lee [Thu, 14 Feb 2019 08:25:14 +0000 (17:25 +0900)]
Add support for mute API set

[Version] 0.12.39
[Issue Type] New feature

Change-Id: I53276fe8e860eb97ba1b6aa4864ac10552ebf494
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoRemove unused symbols 31/199831/2 accepted/tizen/unified/20190219.154303 submit/tizen/20190215.051940
Sangchul Lee [Fri, 15 Feb 2019 01:23:24 +0000 (10:23 +0900)]
Remove unused symbols

[Version] 0.12.38
[Issue Type] Clean up

Change-Id: Iad1ca7700177a193390b1c2b6410c3080fce6577
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoAdd mm_sound_is_stream_on_device_by_id() 60/199660/2 accepted/tizen/unified/20190215.055043 submit/tizen/20190214.074524
Sangchul Lee [Wed, 13 Feb 2019 02:29:39 +0000 (11:29 +0900)]
Add mm_sound_is_stream_on_device_by_id()

[Version] 0.12.37
[Issue Type] API

Change-Id: I897d2198ec9fb592a0f75b5905cfad8568514ae1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoApply -fPIC -pie on focus-server always due to non-prelink 80/197980/1 accepted/tizen/unified/20190128.061159 submit/tizen/20190117.114021 submit/tizen/20190118.030701
Seungbae Shin [Thu, 10 Jan 2019 03:52:48 +0000 (12:52 +0900)]
Apply -fPIC -pie on focus-server always due to non-prelink

[Version] 0.12.36
[Issue Type] Build

Change-Id: I1f04948b721abd973f8da7c92536a5480ed490aa

5 years agoFix SVACE defects : OP_PRECEDENCE_ASSIGN_CMP 79/197979/1
Seungbae Shin [Thu, 17 Jan 2019 10:52:33 +0000 (19:52 +0900)]
Fix SVACE defects : OP_PRECEDENCE_ASSIGN_CMP

[Version] 0.12.35
[Issue Type] Security vulnerability

Change-Id: I594c7f33c95500141c27d830b9b4cbb92b10f87f

5 years agoCheck for symbolic link vulnerability 01/197601/2 accepted/tizen/unified/20190117.151758 submit/tizen/20190116.014210
Sangchul Lee [Mon, 14 Jan 2019 09:53:43 +0000 (18:53 +0900)]
Check for symbolic link vulnerability

Verfiy the absolute path by using realpath() and
unlink it if it seems to be unexpected symbolic link.

[Version] 0.12.34
[Issue Type] Security vulnerability

Change-Id: I82d85f1b2d3c218985f59463461dfc005ade5ccf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoFix improper errno handling 91/195991/1 accepted/tizen/unified/20181221.125511 submit/tizen/20181221.024839
Seungbae Shin [Thu, 20 Dec 2018 10:46:32 +0000 (19:46 +0900)]
Fix improper errno handling

[Version] 0.12.33
[Issue Type] Bug

Change-Id: If13ea55bbce212bf96581a66b9e464019e7b8819

5 years agofixup! Fix invalid format string 88/195488/1 accepted/tizen/unified/20181214.111008 submit/tizen/20181214.020244
Seungbae Shin [Fri, 14 Dec 2018 01:57:46 +0000 (10:57 +0900)]
fixup! Fix invalid format string

[Version] 0.12.32
[Issue Type] Build

Change-Id: Iff9e7ab2701743640c605867849b502a700c03e0

5 years agoFix invalid format string 77/194777/1 accepted/tizen/unified/20181210.060221 submit/tizen/20181207.090553
Seungbae Shin [Fri, 7 Dec 2018 06:52:04 +0000 (15:52 +0900)]
Fix invalid format string

[Version] 0.12.31
[Issue Type] Build

Change-Id: I17a4f2603d215e69864042c172c51d5c7db3c377

5 years agoAdd initial unittest 99/193599/2
Seungbae Shin [Thu, 22 Nov 2018 05:45:15 +0000 (14:45 +0900)]
Add initial unittest

[Version] 0.12.30
[Issue Type] Test

Change-Id: I67946e26c90492d9d39cb6ee080be8e1d6a4e8bf

5 years agoEnhance error handling in case of failure in focus_init_context() 41/192641/2 accepted/tizen/unified/20181108.074556 submit/tizen/20181107.105006
Sangchul Lee [Wed, 7 Nov 2018 07:42:04 +0000 (16:42 +0900)]
Enhance error handling in case of failure in focus_init_context()

operations of quitting mainloop and joining focus thread are added to error handling codes.
timeout for waiting run state of mainloop is also changed to 2.5 sec.

[Version] 0.12.29
[Issue Type] Enhancement

Change-Id: Ide47c174b531395d69a1aa9f45a4b381f4d505af
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoAdd MM_SOUND_DEVICE_TYPE_RAOP 98/188798/2 accepted/tizen/5.0/unified/20181102.015736 accepted/tizen/unified/20180928.142117 submit/tizen/20180919.075319 submit/tizen/20180928.040923 submit/tizen_5.0/20181101.000003
Seungbae Shin [Tue, 10 Jul 2018 07:44:17 +0000 (16:44 +0900)]
Add MM_SOUND_DEVICE_TYPE_RAOP

[Version] 0.12.28
[Issue Type] Feature

Change-Id: I1533f03e174490ecf9ae4d64ef8c0d72c13617f4

5 years agoFix ASAN build break 89/187089/1 accepted/tizen/unified/20180821.090933 submit/tizen/20180820.053222
Sangchul Lee [Mon, 20 Aug 2018 01:49:17 +0000 (10:49 +0900)]
Fix ASAN build break

Declaration of g_focus_sound_handle array is moved to mm_sound_focus_private.c

[Version] 0.12.27
[Issue Type] Bug fix

Change-Id: Idc5a03f7df22763b4cf71762489d7f4c0d7df45b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoFix coverity issues 20/186220/3 accepted/tizen/unified/20180809.074745 submit/tizen/20180808.083139
Sangchul Lee [Wed, 8 Aug 2018 06:41:04 +0000 (15:41 +0900)]
Fix coverity issues

[Version] 0.12.26
[Issue Type] Coverity

Change-Id: Ibea05053ed04c21c347471d9e885206ca944afc9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoFix not to shutdown when playing streams. 15/185915/2
Seungbae Shin [Fri, 3 Aug 2018 10:44:27 +0000 (19:44 +0900)]
Fix not to shutdown when playing streams.

[Version] 0.12.25
[Issue Type] Bug

Change-Id: I63ed17dce2a220c2374c0cdbff68bae0663ac1cd

5 years agoRemove undefined symbol 56/185756/1 accepted/tizen/unified/20180802.135009 submit/tizen/20180802.055654
Sangchul Lee [Thu, 2 Aug 2018 05:48:33 +0000 (14:48 +0900)]
Remove undefined symbol

The function has been already removed.

[Version] 0.12.24
[Issue Type] VD Build break

Change-Id: I7b5ad7eb825682c7be591c3a21053ead1a865edf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoRevise error handling in mm_sound_proxy.c 06/185006/2
Sangchul Lee [Wed, 25 Jul 2018 06:55:37 +0000 (15:55 +0900)]
Revise error handling in mm_sound_proxy.c

[Version] 0.12.23
[Issue Type] Refactor and bug fix

Change-Id: If0b5bfa27d2d434b5a126df6a9d7ecd66e06e691
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoFix stack-buffer-overflow bug issued by ASAN 49/182949/3 accepted/tizen/unified/20180705.081200 submit/tizen/20180702.071334 submit/tizen/20180704.063726
Seungbae Shin [Fri, 29 Jun 2018 05:50:26 +0000 (14:50 +0900)]
Fix stack-buffer-overflow bug issued by ASAN

[Version] 0.12.22
[Issue Type] Bug

Change-Id: If94c462f9e586a56a3e26bfdfe4256c1894df6f1

5 years agoFix use-after-free bug issued by ASAN 06/182906/4
Seungbae Shin [Thu, 28 Jun 2018 12:11:08 +0000 (21:11 +0900)]
Fix use-after-free bug issued by ASAN

[Version] 0.12.21
[Issue Type] Bug

Change-Id: I324875fd1aedfec9f91560b701c1062c7fb52b20

5 years agoUse socket for IPC of focus APIs instead of the DBus 06/164106/9 accepted/tizen/unified/20180702.062852 submit/tizen/20180626.044608
Sangchul Lee [Fri, 15 Dec 2017 09:05:12 +0000 (18:05 +0900)]
Use socket for IPC of focus APIs instead of the DBus

The benefits of this change are here.
 - Connection is established when registering a focus node. This leads to
   remove the previous signal handler for cleaning focus resources.
 - Response time is enhanced as per the change of IPC.(DBus to socket)

[Version] 0.12.20
[Issue Type] Enhancement

Change-Id: Ifbc3ecde29985e9150ed7429b8616ef6cbe99d92
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoFix Wformat build error 72/180472/1 accepted/tizen/unified/20180611.015437 submit/tizen/20180530.034612 submit/tizen/20180607.021137
Jungsup Lee [Wed, 30 May 2018 02:06:02 +0000 (11:06 +0900)]
Fix Wformat build error

[Version] 0.12.19
[Issue Type] Build break

Change-Id: I65a370861867d2630b84d8d6f7ce09554fe658e3
Signed-off-by: Jungsup Lee <jungsup4.lee@samsung.com>
5 years agoFix unchecked return value 09/178409/2 accepted/tizen/unified/20180511.073905 submit/tizen/20180510.054548
Sangchul Lee [Thu, 10 May 2018 02:35:26 +0000 (11:35 +0900)]
Fix unchecked return value

[Version] 0.12.18
[Issue Type] Coverity (CID 118319)

Change-Id: I04aa31259c6a7f6d433ee91517d8aa9adf591148
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoCorrect signature of internal function that does not require return value 15/178415/1
Sangchul Lee [Thu, 10 May 2018 03:21:22 +0000 (12:21 +0900)]
Correct signature of internal function that does not require return value

svace info : Redundant comparison 'ret' == '0' (0 == 0) is always true at
mm_sound_plugin_codec_wave.c:604.

[Version] 0.12.17
[Issue Type] SVACE (WGID 34314)

Change-Id: I9e89b3fca2b98f45a5e97ae30fb6a122ed2689d5
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agoApply deny policy for default context in dbus conf 09/177909/3 accepted/tizen/unified/20180508.134730 submit/tizen/20180508.021954
Seungbae Shin [Fri, 4 May 2018 09:06:50 +0000 (18:06 +0900)]
Apply deny policy for default context in dbus conf

Applied to both sound-server / focus-server

[Version] 0.12.16
[Issue Type] Security

Change-Id: Idb3c93ae5397269089eed1f0f351d5ff467b0878

6 years agoFix float->int(short) clipping issue when playing ogg content 11/177311/1
Seungbae Shin [Thu, 26 Apr 2018 12:47:55 +0000 (21:47 +0900)]
Fix float->int(short) clipping issue when playing ogg content

related reference:
  http://www.mega-nerd.com/libsndfile/api.html#note2
  https://github.com/erikd/libsndfile/issues/194

[Version] 0.12.15
[Issue Type] Bug Fix

Change-Id: I60894d8286c53999c5d907c486a10ca7a88dd95a

6 years agoFix coverity defects 05/177005/1 accepted/tizen/unified/20180426.062531 submit/tizen/20180425.084522
Seungbae Shin [Tue, 24 Apr 2018 11:36:26 +0000 (20:36 +0900)]
Fix coverity defects

fix minor build warning

[Version] 0.12.14
[Issue Type] Security

Change-Id: I5eee1290de2fb381f61078e099e566ae166e530e

6 years agoFix for TV product build macro 76/176776/1 accepted/tizen/unified/20180424.165725 submit/tizen/20180424.071740
Seungbae Shin [Mon, 23 Apr 2018 10:14:06 +0000 (19:14 +0900)]
Fix for TV product build macro

[Version] 0.12.13
[Issue Type] Build

Change-Id: Ib717c739ef11c46425ee9163394a3ebdbcc7c3b2

6 years agoRemove deprecated APIs and codes for session backward compatibility 63/160463/13 submit/tizen/20180315.034548
Sangchul Lee [Thu, 16 Nov 2017 08:20:56 +0000 (17:20 +0900)]
Remove deprecated APIs and codes for session backward compatibility

[Version] 0.12.12
[Issue Type] Clean-up

Change-Id: I7545981ceafe13d56e9c4fa9d99227d6e326f631
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agoFix SVACE defects 20/172320/1 accepted/tizen/unified/20180316.062436 submit/tizen/20180313.074314
Seungbae Shin [Tue, 13 Mar 2018 07:38:16 +0000 (16:38 +0900)]
Fix SVACE defects

[Version] 0.12.12
[Issue Type] Security

Change-Id: Id681c147e6b346e7391e0f635d5ff92d49ca6b48

6 years agoCheck pulseaudio ready file in _mm_sound_play_keysound 24/170924/1 accepted/tizen/unified/20180227.062923 submit/tizen/20180226.072000
Jungsup Lee [Tue, 20 Feb 2018 04:43:12 +0000 (13:43 +0900)]
Check pulseaudio ready file in _mm_sound_play_keysound

Check "/tmp/.pulseaudio_ready" file before access "/tmp/keytone"

[Version] 0.12.11
[Issue Type] Bug Fix

Signed-off-by: Jungsup Lee <jungsup4.lee@samsung.com>
Change-Id: Ib5d91e2733bdf390f277faf1efcb2d4cdfbbec48

6 years agoExtend timeout period of waiting for mainloop running 23/170923/1
Sangchul Lee [Tue, 16 Jan 2018 00:25:49 +0000 (09:25 +0900)]
Extend timeout period of waiting for mainloop running

Sometimes it takes long time to change its state to "running" especially on TV target.

[Version] 0.12.10
[Issue Type] Enhancement

Change-Id: I2192047295794fbd21ca2a541826eaac1ed7c5f9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agoAdd TV BT device when current device list query 22/170922/1
Seungbae Shin [Wed, 10 Jan 2018 12:58:07 +0000 (21:58 +0900)]
Add TV BT device when current device list query

[Version] 0.12.9
[Profile] TV
[Issue Type] Bug

Change-Id: I74998313adbd54ac99094a1f68f34e983723d767

6 years agoRevise service file to add capabilities option 21/170921/1
Sangchul Lee [Wed, 20 Dec 2017 02:45:53 +0000 (11:45 +0900)]
Revise service file to add capabilities option

[Version] 0.12.8
[Issue Type] Enhancement

Change-Id: Ieefd933534c94d4af36678cd78d05fe8659fb7bb
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agoRemove unused / unnecessary usage of pa simple 03/169403/1
Seungbae Shin [Tue, 6 Feb 2018 09:22:13 +0000 (18:22 +0900)]
Remove unused / unnecessary usage of pa simple

[Version] 0.12.7
[Issue Type] Build

Change-Id: I8f593a868df18d458aec256c44b5e2ece187c5d9

6 years agoRemove dlog prints on signal handler / dotnet cleanup 65/164665/1
Seungbae Shin [Fri, 15 Dec 2017 04:40:14 +0000 (13:40 +0900)]
Remove dlog prints on signal handler / dotnet cleanup

[Version] 0.12.6
[Issue Type] Enhancement

Change-Id: Ib73de0cbd07d3648d4aa500a9a2d8f5ea1670275

6 years agoFix memory leak after wav playback 45/163545/1 accepted/tizen/unified/20171214.154153 submit/tizen/20171214.052526
Seungbae Shin [Thu, 7 Dec 2017 11:28:15 +0000 (20:28 +0900)]
Fix memory leak after wav playback

threaded_mainloop was not removed after wav playback,
now it will be removed on seperate temporal thread
(we can't remove from inside of mainloop thread)

in addition, change shutdown timeout from 10 to 60 sec.
(I think 10 sec. might be too short)

[Version] 0.12.5
[Issue Type] Bug Fix

Change-Id: Ic3a0053812fc3f31c344b9170a0684c656a97648

6 years agofixup! Fix build warnings 91/161491/1 accepted/tizen/unified/20171124.172654 submit/tizen/20171124.042202
Seungbae Shin [Thu, 23 Nov 2017 14:32:39 +0000 (23:32 +0900)]
fixup! Fix build warnings

[Version] 0.12.4
[Issue Type] Warning

Change-Id: Ie402f9bfa739dfba422ecffc9993a258b5cb39f8

6 years agoFix build warnings 45/160245/1
Seungbae Shin [Tue, 14 Nov 2017 09:13:11 +0000 (18:13 +0900)]
Fix build warnings

[Version] 0.12.3
[Issue Type] Warning

Change-Id: I16f7dafeb0a7fb70971255ffedeb8490b4b1d6f3

6 years agoRemove unused argument 92/159092/1 accepted/tizen/unified/20171108.063447 submit/tizen/20171107.074009
Sangchul Lee [Tue, 7 Nov 2017 02:47:07 +0000 (11:47 +0900)]
Remove unused argument

[Version] 0.12.2
[Issue Type] Fix warning

Change-Id: Ie55d69f874d27664489ad72b47394e45d871fb36
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agoAdd support for device running changed callback 31/158131/5
Sangchul Lee [Wed, 27 Sep 2017 02:51:46 +0000 (11:51 +0900)]
Add support for device running changed callback

 - mm_sound_add_device_running_changed_callback()
 - mm_sound_remove_device_running_changed_callback()
 - mm_sound_is_device_running()

Functions for change of running state are added. Previous device functions
including callback could not represent a device state related to its audio streams.
Now, these new APIs provide functionality regarding the 'running' state based on
the fundamental rule of that a device will be changed to 'running' only if
any stream go through the device.

[Version] 0.12.1
[Issue Type] New APIs

Change-Id: I79c164f706a5903cd2c6c76902d69c11a55ddbc3
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agofocus_server: copy pid of node that will be used for session backward compatibility 35/158435/2
Sangchul Lee [Wed, 1 Nov 2017 00:31:14 +0000 (09:31 +0900)]
focus_server: copy pid of node that will be used for session backward compatibility

This pid information will be used to each multimedia framework to keep session behavior.

[Version] 0.11.31
[Issue Type] backward compatibility

Change-Id: I4f52b7f29d28b1f5d3ad0388e2df42f6d3bf32aa
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agofixup! Fix Coverity defects 35/157935/2 submit/tizen/20171027.024111
Seungbae Shin [Thu, 26 Oct 2017 05:47:08 +0000 (14:47 +0900)]
fixup! Fix Coverity defects

[Version] 0.11.30
[Issue Type] Bug Fix

Change-Id: I3931e5811379eaae5596a893c39c26d11e971872
(cherry picked from commit ec308faabad9c5b5c06b68438b391c38ce9716b5)

6 years agoModification for Tizen Coding Rule 34/157934/1
Seungbae Shin [Tue, 12 Sep 2017 06:02:59 +0000 (15:02 +0900)]
Modification for Tizen Coding Rule

Change-Id: I05fe4103c333f75b0ac85387c197ad2899026dfa
(cherry picked from commit 0f3a484264047bcccb8804e72db68420f3509a27)

6 years agodisable signal handler for VD dotnet application, cleanup will be done by external... 64/156364/1 accepted/tizen/unified/20171020.091642 submit/tizen/20171018.063752 submit/tizen/20171019.095903
Seungbae Shin [Mon, 16 Oct 2017 11:39:53 +0000 (20:39 +0900)]
disable signal handler for VD dotnet application, cleanup will be done by external call

fix for coding rule included

[Version] 0.11.29
[Issue Type] Product / Dotnet

Change-Id: I5ed9ec1bc21bfddfd553d577bb048870123c8c50
(cherry picked from commit c5426e625d881fa2e75e2e5ba5d404c8c9166169)

6 years agoForward error from dbus method properly in mm_sound_proxy.c 90/156290/1
Sangchul Lee [Wed, 18 Oct 2017 01:27:48 +0000 (10:27 +0900)]
Forward error from dbus method properly in mm_sound_proxy.c

[Version] 0.11.28
[Issue Type] Bug Fix

Change-Id: I1c4531df4983658f58db8b50a57fb32153015f9e
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agoFree device list from first node 69/156269/1
Sangchul Lee [Mon, 16 Oct 2017 01:59:02 +0000 (10:59 +0900)]
Free device list from first node

[Version] 0.11.27
[Issue Type] Memory leak

Change-Id: Ibc10c0f2f7619bd92d927c546f9922b456adfa71
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agoFix Coverity defects 02/154502/2 accepted/tizen/unified/20171013.193024 submit/tizen/20171012.130939
Seungbae Shin [Tue, 10 Oct 2017 10:14:13 +0000 (19:14 +0900)]
Fix Coverity defects

[Version] 0.11.26
[Issue Type] Security

Change-Id: I83114daea560103ce66ee03fc0f86399c891fcc1

6 years agofocus_server: Fix bug regarding update of reacquisition information within focus... 81/151281/5 accepted/tizen/unified/20170925.151022 submit/tizen/20170925.071433
Sangchul Lee [Wed, 20 Sep 2017 09:45:12 +0000 (18:45 +0900)]
focus_server: Fix bug regarding update of reacquisition information within focus callback

It is also modified regarding conding convention

[Version] 0.11.25
[Issue Type] Bug fix

Change-Id: Id6a84b0c2f392aea4aa5c390a783720f95c038a3
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agoRemove useless build config 76/150076/1 submit/tizen/20170918.074757 submit/tizen/20170919.005040 submit/tizen/20170920.104141
Sangchul Lee [Thu, 14 Sep 2017 08:01:23 +0000 (17:01 +0900)]
Remove useless build config

exclude MM_DEBUG_FLAG from CFLAGS

[Version] 0.11.24
[Issue Type] Cleanup

Change-Id: Iaf26d9c1a95b8dd8b29ded787b2b3012a2246faf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agoRemove dependency of libmm-log 26/150026/2 accepted/tizen/unified/20170914.230142 submit/tizen/20170914.083817
Sangchul Lee [Thu, 14 Sep 2017 03:22:30 +0000 (12:22 +0900)]
Remove dependency of libmm-log

[Version] 0.11.23
[Issue Type] Cleanup

Change-Id: I8ffb472f6ce7b119afd5c5f2ce2e538512ab659d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agoRevise dbus error handling codes to be more defensive 86/147386/1
Sangchul Lee [Mon, 4 Sep 2017 06:59:30 +0000 (15:59 +0900)]
Revise dbus error handling codes to be more defensive

[Version] 0.11.22
[Issue Type] Enhancement

Change-Id: Ic433b6e794efc9256799a4bc09cdb535655b8e76
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agoUse mutex for focus index only when it is not for session in mm_sound_client_set_focu... 91/146491/3 accepted/tizen/unified/20170901.201019 submit/tizen/20170901.030803
Sangchul Lee [Tue, 29 Aug 2017 04:56:00 +0000 (13:56 +0900)]
Use mutex for focus index only when it is not for session in mm_sound_client_set_focus_reacquisition()

Since the muse server which uses this library for multiple handles executes requests from clients serially,
we can skip locking/unlocking the mutex for this case.

[Version] 0.11.21
[Issue Type] Enhancement

Change-Id: Ib90eb2c5f20086c048c7cae52ee9e4037cab265b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agofixup! Do not raise() inside signal handler 98/145298/2 accepted/tizen/4.0/unified/20170829.020318 accepted/tizen/unified/20170822.182805 submit/tizen/20170822.051906 submit/tizen_4.0/20170828.100004 submit/tizen_4.0/20170828.110004
Seungbae Shin [Tue, 22 Aug 2017 04:47:04 +0000 (13:47 +0900)]
fixup! Do not raise() inside signal handler

[Version] 0.11.20
[Issue Type] Revise

Change-Id: I62f9cb32009421810581ca689e5e194b5492c645

6 years agofixup! focus-server: Apply umask(0) to change access permissions of its files 97/145297/2
Seungbae Shin [Tue, 22 Aug 2017 04:45:37 +0000 (13:45 +0900)]
fixup! focus-server: Apply umask(0) to change access permissions of its files

Change-Id: Ie36dc6e99bc06f7d38220208f920fe7d22b9f491

6 years agoDo not raise() inside signal handler 93/144893/3 accepted/tizen/unified/20170822.023847 submit/tizen/20170821.085338
Seungbae Shin [Fri, 18 Aug 2017 08:05:02 +0000 (17:05 +0900)]
Do not raise() inside signal handler

[Version] 0.11.19
[Issue Type] Cleanup

Change-Id: I17e3d04d75b54bdec9a29aa45575f32e0de89903

6 years agofocus-server: Apply umask(0) to change access permissions of its files 87/144987/2
Sangchul Lee [Mon, 21 Aug 2017 00:56:12 +0000 (09:56 +0900)]
focus-server: Apply umask(0) to change access permissions of its files

[Version] 0.11.18
[Issue Type] Enhancement

Change-Id: I7a46d3ea7df6cef23301175dccc5d6c4a553fecb
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agofocus-server: fix bug of invoking monitor callback of other nodes 01/144601/1
Sangchul Lee [Thu, 17 Aug 2017 08:05:29 +0000 (17:05 +0900)]
focus-server: fix bug of invoking monitor callback of other nodes

[Version] 0.11.17
[Issue Type] Bug

Change-Id: I630cb5420f2addb4666e398f3fcd38af3143ae51
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
6 years agofix invalid parameter in error log 99/144499/1
Sangchul Lee [Thu, 17 Aug 2017 04:35:06 +0000 (13:35 +0900)]
fix invalid parameter in error log

[Version] 0.11.16
[Issue Type] Bug

Change-Id: Ib825e9c02459b5d498d50d4045e1899721710b82
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>