Fix coverity issues

[Version] 0.12.26
[Issue Type] Coverity

Change-Id: Ibea05053ed04c21c347471d9e885206ca944afc9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>

diff --git a/focus_server/mm_sound_mgr_focus_socket.c b/focus_server/mm_sound_mgr_focus_socket.c
index ae5f6b7..dabe22c 100644 (file)
--- a/focus_server/mm_sound_mgr_focus_socket.c
+++ b/focus_server/mm_sound_mgr_focus_socket.c
@@ -400,7 +400,8 @@ static void* ready_thread_func(void *data)
 LEAVE:
        debug_fleave();
        pthread_attr_destroy(&attr);
-       close(fd);
+       if (fd != -1)
+               close(fd);
        pthread_exit(NULL);
 }
 

diff --git a/mm_sound_focus_socket.c b/mm_sound_focus_socket.c
index 1e7c0db..152e203 100644 (file)
--- a/mm_sound_focus_socket.c
+++ b/mm_sound_focus_socket.c
@@ -193,7 +193,7 @@ int mm_sound_focus_socket_register(int pid, const char *stream_type, int *client
        memset(&data, 0x00, sizeof(_mm_sound_focus_socket_param_t));
        memset(&result, 0x00, sizeof(_mm_sound_focus_socket_result_t));
        FILL_SOCKET_PARAM_REGISTER(data, FOCUS_FUNC_NAME_REGISTER, pid, stream_type);
-       if ((ret = _send_data_to_server(*client_fd, &data, &result)) < 0) {
+       if ((ret = _send_data_to_server(*client_fd, &data, &result))) {
                debug_error("failed to _send_data_to_server(), ret[0x%x]", ret);
                close(*client_fd);
                return ret;
@@ -257,7 +257,7 @@ int mm_sound_focus_socket_add_watch_cb(int pid, mm_sound_focus_type_e focus_type
        memset(&data, 0x00, sizeof(_mm_sound_focus_socket_param_t));
        memset(&result, 0x00, sizeof(_mm_sound_focus_socket_result_t));
        FILL_SOCKET_PARAM_ADD_WATCH(data, FOCUS_FUNC_NAME_ADD_WATCH, pid, focus_type);
-       if ((ret = _send_data_to_server(*client_fd, &data, &result)) < 0) {
+       if ((ret = _send_data_to_server(*client_fd, &data, &result))) {
                debug_error("failed to _send_data_to_server(), ret[0x%x]", ret);
                close(*client_fd);
                return ret;

diff --git a/packaging/libmm-sound.spec b/packaging/libmm-sound.spec
index 00d815b..a2e2273 100644 (file)
--- a/packaging/libmm-sound.spec
+++ b/packaging/libmm-sound.spec
@@ -1,6 +1,6 @@
 Name:       libmm-sound
 Summary:    MMSound Package contains client lib and sound_server binary
-Version:    0.12.25
+Version:    0.12.26
 Release:    0
 Group:      System/Libraries
 License:    Apache-2.0