platform/core/multimedia/libmm-fileinfo.git
3 years agoFrame related code cleanup 80/233480/3
Minje Ahn [Fri, 15 May 2020 04:11:33 +0000 (13:11 +0900)]
Frame related code cleanup

Change-Id: Ic9a410660cf7ae9a349b811ece339df23e7a5fc9
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoVersion up(0.6.87 -> 0.6.88) 93/234693/2 accepted/tizen/unified/20200529.124312 submit/tizen/20200528.061116
hj kim [Thu, 28 May 2020 04:49:20 +0000 (13:49 +0900)]
Version up(0.6.87 -> 0.6.88)

Change-Id: Iedbe0d4ef65d7bd5013c916dbf181b08c89a9ba5

3 years agoRemove unnecessary define 32/233332/4
Minje Ahn [Thu, 14 May 2020 02:51:47 +0000 (11:51 +0900)]
Remove unnecessary define

Change-Id: Ifbd4d89cfa0e14e29b4d5e688cd07834899195b1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoformat IMELODY cleanup 22/233222/2
Minje Ahn [Wed, 13 May 2020 06:08:46 +0000 (15:08 +0900)]
format IMELODY cleanup

Change-Id: I581d81b7b4b7043adadbf9759535721ba39c4712
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoFormat MMF cleanup 82/232982/2
Minje Ahn [Mon, 11 May 2020 06:18:28 +0000 (15:18 +0900)]
Format MMF cleanup

Change-Id: I59f5636051b3c0606204e00859e0c7388c63e2c6
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoFormat MIDI cleanup 84/232884/3
Minje Ahn [Fri, 8 May 2020 06:26:23 +0000 (15:26 +0900)]
Format MIDI cleanup

Change-Id: I14f8bc26ebe25f94841e9b6fe9b444e89ba0b386
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove unused files 28/232828/4
Minje Ahn [Fri, 8 May 2020 01:09:42 +0000 (10:09 +0900)]
Remove unused files

Change-Id: I2df45ccb64285f8fffac9543efdaa51adae37d11
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoFormat WAV cleanup 27/232827/2
Minje Ahn [Fri, 8 May 2020 00:40:20 +0000 (09:40 +0900)]
Format WAV cleanup

Change-Id: I9d22133e4dc7f49bb4cbc227cf56ab9132b35345
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove test code for directory support 23/232823/1
Minje Ahn [Thu, 7 May 2020 23:26:17 +0000 (08:26 +0900)]
Remove test code for directory support

Change-Id: I176b6b188bacc38591a1c8ee7257d045eb13b87d
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove memtrace 15/232715/1
Minje Ahn [Thu, 7 May 2020 08:20:52 +0000 (17:20 +0900)]
Remove memtrace

Change-Id: I674cc520cada75203dbdf58f3b2ab42e0d4f9bd5
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove format dummy 03/232703/1
Minje Ahn [Thu, 7 May 2020 07:36:55 +0000 (16:36 +0900)]
Remove format dummy

Change-Id: I1105b369d120b12051091cfa74ce0e9c9963879e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoFormat AMR cleanup 99/232699/1
Minje Ahn [Thu, 7 May 2020 07:27:42 +0000 (16:27 +0900)]
Format AMR cleanup

Change-Id: If3f3a99f621f9119a22ca7a05758708aaab8cd63
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoFormat AAC cleanup 58/232658/2
Minje Ahn [Thu, 7 May 2020 05:53:07 +0000 (14:53 +0900)]
Format AAC cleanup

Change-Id: I41aff76fbc3fe6232ced2a086c8cebd0688355ab
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoInternal functions cleanup 57/232657/2
Minje Ahn [Thu, 7 May 2020 05:51:18 +0000 (14:51 +0900)]
Internal functions cleanup

Change-Id: I6383006f55209ac298bbf6cffacba371a8d497ac
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoChange image buf type 00/232600/2
Minje Ahn [Thu, 7 May 2020 00:39:53 +0000 (09:39 +0900)]
Change image buf type

Change-Id: I0dcebf05e1517855785d6dc8f8f019844eb06657
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove timestamp 39/232539/4
Minje Ahn [Wed, 6 May 2020 07:24:07 +0000 (16:24 +0900)]
Remove timestamp

Change-Id: I3c98f7da11f5a460333f3403e96d0dbfc5f37b15
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove codec related code 03/232503/5
Minje Ahn [Wed, 6 May 2020 05:03:31 +0000 (14:03 +0900)]
Remove codec related code

'bCompressed' is false always.
So, codec related code are never called.

Change-Id: I014e6ee44e317d8fc575d2b750ba40b558a6a526
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove EXPORT_API 79/232479/3
Minje Ahn [Wed, 6 May 2020 00:41:50 +0000 (09:41 +0900)]
Remove EXPORT_API

Change-Id: I9fcbab71b378ae58d2fa434dcffc3349c9bed8e6
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoImprove allocation related code 78/232478/3
Minje Ahn [Wed, 6 May 2020 00:24:09 +0000 (09:24 +0900)]
Improve allocation related code

Change-Id: I1c296b0d36420c47edf27ae232f4026b26f70292
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agofunction in mm_file_util_string cleanup 80/232380/2 submit/tizen/20200506.061601
Minje Ahn [Mon, 4 May 2020 01:44:10 +0000 (10:44 +0900)]
function in mm_file_util_string cleanup

Change-Id: I2e9fe3ad4113dec5feb2ec98f56157c8b8db0a25
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoChange return value 77/232377/2
Minje Ahn [Mon, 4 May 2020 01:06:10 +0000 (10:06 +0900)]
Change return value

Change-Id: If166672ee78e765b2b1831de1c3aa9f3ab4b9cd2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUse macro instead 89/232089/3
Minje Ahn [Tue, 28 Apr 2020 06:44:32 +0000 (15:44 +0900)]
Use macro instead

Change-Id: Icc7875387e0cd21eebca93b6b8ced1414e2c47e2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoCheck file before dlopen 45/232045/4
Minje Ahn [Tue, 28 Apr 2020 01:22:32 +0000 (10:22 +0900)]
Check file before dlopen

Change-Id: Ie5691150dc0ee7bd76d138a417726ad20b1af307
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove duplicated condition for checking the frame length 58/229858/2
jiyong.min [Mon, 6 Apr 2020 05:28:27 +0000 (14:28 +0900)]
Remove duplicated condition for checking the frame length

Change-Id: I1be9feb05291cbd12719d8b7fef6270caf35a88c

4 years agoFix crash issue due to garbage value 07/227307/1 accepted/tizen/unified/20200407.043020 submit/tizen/20200406.033132
jiyong.min [Wed, 11 Mar 2020 06:17:09 +0000 (15:17 +0900)]
Fix crash issue due to garbage value

  - If the result of g_convert() is empty string, the written_len is 0.
    Then (unsigned int)'written_len - 1' became garbage value and
    checking carriage return make crash.

(gdb)bt full
mmfile_string_convert ...mm_file_util_string.c:189
        i = 1395696
        result = 0xae45a410 ""
        err = 0x0
        written_len = 0

Change-Id: I61b4c3e4a6b938ce549844e163dc46f47398aa98

4 years agoUnify duplicated codes regarding getting file size 17/226117/7
hj kim [Thu, 27 Feb 2020 04:05:12 +0000 (13:05 +0900)]
Unify duplicated codes regarding getting file size

Change-Id: I357be69f82a03b9e8ac6d7ba94cc9341d40a4e0a

4 years agoUnify duplicate codes regarding content attribute 87/225987/3
hj kim [Wed, 26 Feb 2020 04:44:17 +0000 (13:44 +0900)]
Unify duplicate codes regarding content attribute

Change-Id: I9bc54faeb45eed7ea86275d5ceb990f61781b5fe

4 years agoFix typo 14/226014/2 submit/tizen/20200226.080940
hj kim [Wed, 26 Feb 2020 06:52:59 +0000 (15:52 +0900)]
Fix typo

Change-Id: Ifac06fd27ff239f23444b99fff7bef1407b71d10

4 years agoReplace return value to define instead of hardcoded number 47/224747/1
jiyong.min [Thu, 13 Feb 2020 00:10:30 +0000 (09:10 +0900)]
Replace return value to define instead of hardcoded number

Change-Id: Ia58d2d95a717fc962ef32f6e1c70698f60c35bb8

4 years agodefine enum for ID3tag to make codes simple 55/223855/26 accepted/tizen/unified/20200213.121600 submit/tizen/20200212.003832
hj kim [Tue, 4 Feb 2020 09:10:17 +0000 (18:10 +0900)]
define enum for ID3tag to make codes simple

Change-Id: If2ebbfd36565d8878ad0f11da1e18742db4373d6

4 years agoBump to 0.6.85 82/224182/1
jiyong.min [Fri, 7 Feb 2020 02:59:35 +0000 (11:59 +0900)]
Bump to 0.6.85

Change-Id: Ia88c259d3110e21eb206cadb5951af5f3bf0590e

4 years agoRemove unused code and apply coding rule 76/224176/2 accepted/tizen/unified/20200210.131829 submit/tizen/20200207.024848
jiyong.min [Fri, 7 Feb 2020 02:17:48 +0000 (11:17 +0900)]
Remove unused code and apply coding rule

Change-Id: I13287f489082df64e03fb06208b60b588a3f4d5c

4 years agoReinforce comment and '__AvGetLastID3v2Offset' function 62/224162/4
jiyong.min [Fri, 7 Feb 2020 00:54:37 +0000 (09:54 +0900)]
Reinforce comment and '__AvGetLastID3v2Offset' function

Change-Id: I8fc9af5c7003715aa8968a56203047a251d68c10

4 years ago[code cleanup] Add to check hard return value for file_read 83/224083/4
jiyong.min [Thu, 6 Feb 2020 06:28:30 +0000 (15:28 +0900)]
[code cleanup] Add to check hard return value for file_read

Change-Id: I329980a09b6be133d374376a6bbe7b833afcf271

4 years ago[code cleanup] Remove duplicated buffer allocation & file read 62/224062/7
jiyong.min [Thu, 6 Feb 2020 05:27:04 +0000 (14:27 +0900)]
[code cleanup] Remove duplicated buffer allocation & file read
and remove unnecessary code

Change-Id: I57ec5316e4bd26d14d83ded18007bb5d209c33cb

4 years agoSeperate getting mp3 information into getting mp3_tag_info and mp3_stream_info 34/224034/14
jiyong.min [Wed, 5 Feb 2020 08:33:44 +0000 (17:33 +0900)]
Seperate getting mp3 information into getting mp3_tag_info and mp3_stream_info

  - When 'mmfile_format_open' function is called, it read mp3 file
    to get mp3 information. Because scanning mp3 file call the function
    2~3 times, there was a loss in performance.
    So we changed the function call from open to read and
    seperated into two sub_function.

Change-Id: Ica77bed739c89e41e3643889e29ada6eadb7fd28

4 years ago[code cleanup] Improved code readability for getting ID3Tag 33/224033/7
jiyong.min [Wed, 5 Feb 2020 07:36:17 +0000 (16:36 +0900)]
[code cleanup] Improved code readability for getting ID3Tag

Change-Id: I1be3ab6b95a7e0c75e349b6de365769ef8e3944e

4 years agoUnify duplicated ID3v2header getting code 36/223936/9
jiyong.min [Wed, 5 Feb 2020 06:13:16 +0000 (15:13 +0900)]
Unify duplicated ID3v2header getting code

Change-Id: Ib875c1e2421632dfb69f864df037a9e2f82d6258

4 years agoRemove redundant condition check code 76/223976/1
hj kim [Wed, 5 Feb 2020 08:17:07 +0000 (17:17 +0900)]
Remove redundant condition check code

Change-Id: I774056be4f064d0a6cc0f5160aba6f5cacc12fd9

4 years agoRemove useless parameter v2numOfFrames 43/223943/3
hj kim [Wed, 5 Feb 2020 06:46:02 +0000 (15:46 +0900)]
Remove useless parameter v2numOfFrames

Change-Id: I6967a9637c370a884247104b93a89ff8d2272b73

4 years agoUnify duplicated ID3tag extracting code 27/223927/4
hj kim [Wed, 5 Feb 2020 05:39:46 +0000 (14:39 +0900)]
Unify duplicated ID3tag extracting code

Change-Id: Idde219a2231733c90e70cd55c90d6b6f9325ab86

4 years agoRemove id3 version specific 'mmfile_string_convert_v224' function and unreachable... 95/223895/11
jiyong.min [Wed, 5 Feb 2020 01:00:15 +0000 (10:00 +0900)]
Remove id3 version specific 'mmfile_string_convert_v224' function and unreachable code

Change-Id: Ib528a6811d8197b51bb990e655e07a06062e4b4f

4 years agoRemove duplicated code and unused parameter pre_checked 04/223904/4
hj kim [Wed, 5 Feb 2020 02:07:02 +0000 (11:07 +0900)]
Remove duplicated code and unused parameter pre_checked

Change-Id: I6118f7dabce399f4fd731ac4bede1fef4462de50

4 years agoRemove unused parameter pAuthor 56/223856/4
hj kim [Tue, 4 Feb 2020 09:18:01 +0000 (18:18 +0900)]
Remove unused parameter pAuthor

Change-Id: I0ce1a7838763f26576c048035322752c835f221e

4 years agoRemove unreachable code 36/223436/2 accepted/tizen/unified/20200130.214707 submit/tizen/20200130.013933
jiyong.min [Thu, 30 Jan 2020 00:38:36 +0000 (09:38 +0900)]
Remove unreachable code

 - Fix svace WGID 425086

 Varaible 'pForamtCtx' can't be null because of
 'NULL == formatContext->privateFormatData' checker.

Change-Id: I6e18ffad655bb3de10a8379257e65d473226dbb3

4 years agoUpdate test code for macro refactoring 80/222980/2 submit/tizen/20200122.230050
jiyong.min [Wed, 22 Jan 2020 01:20:21 +0000 (10:20 +0900)]
Update test code for macro refactoring

Change-Id: I4bc0fd5b84d0f97fdf924722477bb505cd7bdeb5

4 years agoFix coverity issue 54/222854/2
jiyong.min [Tue, 21 Jan 2020 01:20:20 +0000 (10:20 +0900)]
Fix coverity issue

  - Argument cannot be negative

  'ftell' returns signed long and it can be negative(-1).
  Unsigned int 'file_size(size)' can get tainted value.
  So signed long for ftell has been added and check if it is below zero.

Change-Id: Ibe651c19465acc57b2e4e31b705644887c18a623

4 years agoFix coverity issue 47/222847/1 submit/tizen/20200122.012604
jiyong.min [Mon, 20 Jan 2020 23:58:07 +0000 (08:58 +0900)]
Fix coverity issue

  - Resource leak
  Variable 'err_attr_name' should be freed by caller, but it is not used and freed.
  So, remove unused(useless) 'err_attr_name'.

Change-Id: I201c216828a05a0e620799145960de925c9ce524

4 years agoFix wrong duration for mpeg-ts 02/221402/3
jiyong.min [Thu, 2 Jan 2020 05:25:20 +0000 (14:25 +0900)]
Fix wrong duration for mpeg-ts

 Generally, mpegts has wrong start time(positive large value).
 So duration do not use start time for mpeg-ts.

Change-Id: I97ddc31860bdeb489abe41f4fbc7e9b61d2572d5

4 years agoFix build error due to toolchain upgrade (gcc6->gcc9) 67/220967/3 accepted/tizen/unified/20191227.142821 submit/tizen/20191226.093041
jiyong.min [Thu, 26 Dec 2019 05:59:15 +0000 (14:59 +0900)]
Fix build error due to toolchain upgrade (gcc6->gcc9)

  error: output trucated before the last format character [-Werror=format-truncation=]

Change-Id: I9a0c7460e1afc81e46d14a4190c89a644943bf64

4 years agoRemove unused functions 53/219453/1
jiyong.min [Thu, 5 Dec 2019 05:00:50 +0000 (14:00 +0900)]
Remove unused functions

Change-Id: Ib7ccc1e9da5c9793d0b2169c502e3df82e79a947

4 years agoReplace SAFE_STRLCPY to mmfile_strdup 32/217632/7
jiyong.min [Wed, 13 Nov 2019 05:05:43 +0000 (14:05 +0900)]
Replace SAFE_STRLCPY to mmfile_strdup

Change-Id: I81a8687b35b6066a7c6454e0af8242ec357b4f20

4 years agoRemove unused variables 00/217600/5
jiyong.min [Wed, 13 Nov 2019 03:22:07 +0000 (12:22 +0900)]
Remove unused variables

 - descriptionLen
 - pDescription
 - pRating
 - bTagVer2Found
 - bGenreUTF16

Change-Id: Id0ae4c97533d7a466686eacaf35af919d157e9f1

4 years agoCode Cleanup for duplicated code of getting text encoding type 59/217359/8 accepted/tizen/unified/20191114.042534 submit/tizen/20191113.015438
jiyong.min [Thu, 7 Nov 2019 05:01:52 +0000 (14:01 +0900)]
Code Cleanup for duplicated code of getting text encoding type

 - Add new funtion to get text encoding type

Change-Id: I33d11fa4f59c52f25b20b221bfe02a8a0bb5231d

4 years agoCode Cleanup for duplicated code of getting synclyric 62/217362/4
jiyong.min [Mon, 11 Nov 2019 01:21:08 +0000 (10:21 +0900)]
Code Cleanup for duplicated code of getting synclyric

Change-Id: I20ab23c9cb0b3ad99121397cc402695f7961ee12

4 years agoCode Cleanup for 'break' and add function to count the number of streams 28/216428/3
jiyong.min [Fri, 25 Oct 2019 01:03:13 +0000 (10:03 +0900)]
Code Cleanup for 'break' and add function to count the number of streams

Change-Id: I48131561ecded342993344d7198915ed9b935a75

4 years agoChange global variable '_mm_file_format_mimetype_table' to static 98/214998/1
jiyong.min [Mon, 30 Sep 2019 22:08:21 +0000 (07:08 +0900)]
Change global variable '_mm_file_format_mimetype_table' to static

Change-Id: I66368de864551766a51133c30f4b35827a2167d2

4 years agoImprove id3tag parsing for duplicated code(skip new line) 97/214997/1
jiyong.min [Tue, 24 Sep 2019 03:21:38 +0000 (12:21 +0900)]
Improve id3tag parsing for duplicated code(skip new line)

Change-Id: I4914f579dadb63713efc8c37cce61a73db5b3c32

4 years agoFix coverity issue (memory leak) 24/214524/2 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/20191031.021511 accepted/tizen/5.5/unified/mobile/hotfix/20201027.083703 accepted/tizen/unified/20190925.033559 submit/tizen/20190924.014546 submit/tizen_5.5/20191031.000004 submit/tizen_5.5_mobile_hotfix/20201026.185103 tizen_5.5.m2_release
jiyong.min [Tue, 24 Sep 2019 00:17:56 +0000 (09:17 +0900)]
Fix coverity issue (memory leak)

Change-Id: I2494d0d8543ab3dc4fa88cd4520e0bbd20c7397a

4 years agoRemove unused header file (duplicated with mm_util.h) 23/214523/2
jiyong.min [Tue, 24 Sep 2019 00:06:37 +0000 (09:06 +0900)]
Remove unused header file (duplicated with mm_util.h)

Change-Id: I6fb8771a23f61f1ed7aaf38d6daacefab5776eb3

4 years agoBump version to 0.6.80 11/214111/2 accepted/tizen/unified/20190919.065333 submit/tizen/20190918.230109
jiyong.min [Wed, 18 Sep 2019 06:56:30 +0000 (15:56 +0900)]
Bump version to 0.6.80

 - Since this version, TC test value change is necessary.

Change-Id: Icd42fc0f7c2cef10e8e134fa21e353bb8128226c

4 years agoImprove 'mm_file_id3tag_parse_v224' function to reduce Cyclomatic Complexity 87/214087/7
jiyong.min [Wed, 18 Sep 2019 02:20:12 +0000 (11:20 +0900)]
Improve 'mm_file_id3tag_parse_v224' function to reduce Cyclomatic Complexity

 - It needs below UTC changes.
  https://review.tizen.org/gerrit/#/c/test/tct/native/api/+/214107/

Change-Id: Ie9ab72aa8d663ff759d12f2219edfa07c32c2f4c

4 years agoUpdate global variable to static 73/214073/1 accepted/tizen/unified/20190919.010649 submit/tizen/20190918.070547
jiyong.min [Wed, 18 Sep 2019 00:25:12 +0000 (09:25 +0900)]
Update global variable to static

Change-Id: Iad7002eb2932136ead5609d767620cc704d8f005

4 years agoBump version to 0.6.79 72/214072/1
jiyong.min [Wed, 18 Sep 2019 00:21:13 +0000 (09:21 +0900)]
Bump version to 0.6.79

Change-Id: I8e2d044f79fcb07933ec6637174ed6902863ce0d

4 years agoImprove PIC/APIC parsing of ID3tag to reduce CC and DC 56/213956/4
jiyong.min [Mon, 16 Sep 2019 03:54:50 +0000 (12:54 +0900)]
Improve PIC/APIC parsing of ID3tag to reduce CC and DC

Change-Id: Ibb0edee2b18f6ee03863686a39da700d43e7c852

4 years agoImprove functions to reduce Duplicate Code 76/213676/1
jiyong.min [Tue, 10 Sep 2019 05:44:28 +0000 (14:44 +0900)]
Improve functions to reduce Duplicate Code

Change-Id: Ifc5191726c11039a818ecda28aeba609c5c02042

4 years agoImprove '__mmfile_get_frame' function to reduce Cyclomatic Complexity 18/213618/2 accepted/tizen/unified/20190910.043227 submit/tizen/20190910.020543
jiyong.min [Mon, 9 Sep 2019 07:28:09 +0000 (16:28 +0900)]
Improve '__mmfile_get_frame' function to reduce Cyclomatic Complexity

Change-Id: Ia0335b309420605b39dadef3b63c114e94f2564d

4 years agoImprove '_get_contents_info' function to reduce Cyclomatic Complexity 77/213577/1
jiyong.min [Mon, 9 Sep 2019 03:31:21 +0000 (12:31 +0900)]
Improve '_get_contents_info' function to reduce Cyclomatic Complexity

Change-Id: I9b86b5432904d9475bc28a4f7e18ad42a1e42ea5

4 years ago[DF190903-00975] Add code to support mpeg audio version 2, layer 1 24/213324/1 accepted/tizen/unified/20190905.060539 submit/tizen/20190904.082658
hj kim [Wed, 4 Sep 2019 08:22:49 +0000 (17:22 +0900)]
[DF190903-00975] Add code to support mpeg audio version 2, layer 1

Change-Id: I86c355baa73bb57285764f02ed00b7de2593c537

4 years agoImprove 'MMFileFormatIsValidXXX' function to reduce DC 01/213201/1 accepted/tizen/unified/20190904.224430 submit/tizen/20190903.022206
jiyong.min [Mon, 2 Sep 2019 23:55:12 +0000 (08:55 +0900)]
Improve 'MMFileFormatIsValidXXX' function to reduce DC

Change-Id: Id9ba66477f0b8766db1b33efb8d09bbb805b3b51

4 years agoImprove '__AvConvertIMelody2MIDI' function to reduce DC 99/213199/4
jiyong.min [Mon, 2 Sep 2019 22:58:06 +0000 (07:58 +0900)]
Improve '__AvConvertIMelody2MIDI' function to reduce DC

Change-Id: Ic751574c6677a1520121f36560d7b6762d2c8928

4 years agoImprove '_mmf_MalibNextChunk' function and remove unused code 77/212877/8
jiyong.min [Tue, 27 Aug 2019 23:09:27 +0000 (08:09 +0900)]
Improve '_mmf_MalibNextChunk' function and remove unused code

 - change 'switch ~ case' to 'looping const table'
 - remove unused function
 - remove unuseful condition (null check)

Change-Id: I227f94c6da3f6563c2ff05d1815bfee004634fa7

4 years agoRemove unneccessary null check 80/212880/3
jiyong.min [Wed, 28 Aug 2019 00:23:39 +0000 (09:23 +0900)]
Remove unneccessary null check

 - 'mm_attrs_set_string/data_by_name' can set null string/data
 - artwork & thumbnail should null check due to memcpy

Change-Id: I219c365925eb03ddaffdbefa96677c7eb956aac8

4 years agoAdd new function to add bracket at genre tag 25/212825/9
jiyong.min [Tue, 27 Aug 2019 05:43:11 +0000 (14:43 +0900)]
Add new function to add bracket at genre tag

Change-Id: I2f9c9da246d573c53e2f364fb750afbf52f4e020

4 years agoReplace duplicate '__getMimeType' and 'getMimeType' to 'mmfile_util_get_mimetype' 10/212810/3
jiyong.min [Tue, 27 Aug 2019 04:07:05 +0000 (13:07 +0900)]
Replace duplicate '__getMimeType' and 'getMimeType' to 'mmfile_util_get_mimetype'

Change-Id: Ie01859409d1b6044c093c2de47f1e4449cf7b2aa

4 years agoImprove 'mmfile_format_read_tag_ffmpg' function 09/212809/4
jiyong.min [Tue, 27 Aug 2019 02:08:10 +0000 (11:08 +0900)]
Improve 'mmfile_format_read_tag_ffmpg' function

Change-Id: I2edf99b08d29631d0363e1ce3493004ad99bfa21

4 years agoUpdate debug msg 00/208300/1 accepted/tizen/unified/20190624.075133 submit/tizen/20190624.012801
hj kim [Fri, 21 Jun 2019 08:17:00 +0000 (17:17 +0900)]
Update debug msg

Change-Id: I4ca482bb7afb313de76f79a4624c563c197c679d

4 years agoUpdate pkg version 79/205979/1 submit/tizen/20190513.045956
hj kim [Mon, 13 May 2019 02:46:26 +0000 (11:46 +0900)]
Update pkg version

Change-Id: I0f336e2e2cb9c5eeab27469aa465974496e58b5f

4 years agoChange strcasecmp() to g_ascii_strcasecmp() because strcasecmp is locale sensitive. 77/205977/2
hj kim [Mon, 13 May 2019 02:43:42 +0000 (11:43 +0900)]
Change strcasecmp() to g_ascii_strcasecmp() because strcasecmp is locale sensitive.

Change-Id: Iff51728241d047f0af6f4dc2addbeecd5f573899

5 years agoMerge "Support TPOS (Part of a Set)" into tizen accepted/tizen/unified/20190307.231009 submit/tizen/20190304.011603
Jiyong Min [Mon, 4 Mar 2019 00:05:31 +0000 (00:05 +0000)]
Merge "Support TPOS (Part of a Set)" into tizen

5 years agoMerge "Just add description for the smta" into tizen
Jiyong Min [Mon, 4 Mar 2019 00:05:23 +0000 (00:05 +0000)]
Merge "Just add description for the smta" into tizen

5 years agoIncrease _RETRY_SEARCH_LIMIT to 250. some contents need search count this much 66/200666/1
hj kim [Thu, 28 Feb 2019 02:12:11 +0000 (11:12 +0900)]
Increase _RETRY_SEARCH_LIMIT to 250. some contents need search count this much

Change-Id: I6825cea3e9a0a2a895b2e13af78940889c602744

5 years agoSupport TPOS (Part of a Set) 64/200664/6
hj kim [Thu, 28 Feb 2019 01:32:12 +0000 (10:32 +0900)]
Support TPOS (Part of a Set)

The ‘Part of a set’ frame is a numeric string that describes which part of a set the audio came from.
This frame is used if the source described in the “TALB” frame is divided into several mediums,
e.g. a double CD. The value MAY be extended with a “/” character and a numeric string containing the total number of parts in the set. E.g. “1/2”.

Change-Id: Ic0613adda4b54834892e7592df34598b9d14be9b

5 years agoJust add description for the smta 65/200665/2
hj kim [Thu, 28 Feb 2019 01:38:43 +0000 (10:38 +0900)]
Just add description for the smta

Change-Id: I661cd6fe8667e3716e1269574836af63a61ac263

5 years agoSupport smta value 0x02 27/200527/2
hj kim [Tue, 26 Feb 2019 07:36:40 +0000 (16:36 +0900)]
Support smta value 0x02

Change-Id: I7dc1f10917a706e03447a97b5ef69d945064d664

5 years agoChange the size and nmemb of fread() to check the return value 13/199013/1
jiyong.min [Fri, 1 Feb 2019 00:39:25 +0000 (09:39 +0900)]
Change the size and nmemb of fread() to check the return value

Change-Id: Icff42f9f037df9b44cd5ab07420dab1037747463

5 years agoAdd to check the return of fseek() 87/198687/1 accepted/tizen/unified/20190207.120249 submit/tizen/20190131.041045
jiyong.min [Tue, 29 Jan 2019 00:37:27 +0000 (09:37 +0900)]
Add to check the return of fseek()

 - If fseek() is failed, -1 is returned and errno is set to indicate the errors.

Change-Id: I7174ca625da1026ebe07cb72fd97459d89c05d75

5 years agoAdd to check the file permission before mm_file access a file. 25/197225/4 accepted/tizen/unified/20190114.060054 submit/tizen/20190111.015801
jiyong.min [Thu, 10 Jan 2019 08:25:19 +0000 (17:25 +0900)]
Add to check the file permission before mm_file access a file.

- error case
Metadata-extractor did not return Permission denied.

Change-Id: I5ef74a95dcca60e451d9c1e55aab67694f7f208e

5 years agoCoverity issue fix 34/196034/1 accepted/tizen/unified/20181227.062028 submit/tizen/20181226.064859
hj kim [Fri, 21 Dec 2018 02:44:31 +0000 (11:44 +0900)]
Coverity issue fix

Change-Id: Id90eb786575e82376fd0535ea11fd0fadfcd5470

5 years agoFix format error in logs 81/194681/1 accepted/tizen/unified/20181210.060034 submit/tizen/20181207.051909
jiyong.min [Fri, 7 Dec 2018 03:45:39 +0000 (12:45 +0900)]
Fix format error in logs

Change-Id: I024c8d532c47c3a58aa13f4b6e5fa5c6a647d7a2

5 years agoFix build error without gtests 47/193747/1 accepted/tizen/unified/20181127.073258 submit/tizen/20181126.011146
jiyong.min [Mon, 26 Nov 2018 02:10:06 +0000 (11:10 +0900)]
Fix build error without gtests

Change-Id: I7eb22626683c57234d272302228beb831093d434

5 years agoMerge "Adding initial structure for unittest" into tizen
hj kim [Mon, 26 Nov 2018 01:13:54 +0000 (01:13 +0000)]
Merge "Adding initial structure for unittest" into tizen

5 years agoAdding initial structure for unittest 93/193493/5
jiyong.min [Wed, 21 Nov 2018 08:00:08 +0000 (17:00 +0900)]
Adding initial structure for unittest

- It has only one testcases for libmedia_utils of unittest
- It would be enabled by gtest build with '--define "gtests 1"'
- Two test contents would be copyied to '/usr/bin' directory

Change-Id: I6988de63bfd3c2cea7aa8518bf83d700d09d38cd

5 years agoApply new attribute API of libmm-common 40/192940/1
Sangchul Lee [Mon, 5 Nov 2018 07:20:30 +0000 (16:20 +0900)]
Apply new attribute API of libmm-common

- Remove dependency of mm_attrs_private.h.
- Use new API set in mm_attrs.h instead of those.

Change-Id: Icd720cc02b677b881e4266c8a4a0cd79f72ab5ce
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoRemove dlog from Requires 72/192172/1 accepted/tizen/unified/20181107.081919 submit/tizen/20181105.235320
hj kim [Wed, 31 Oct 2018 06:45:07 +0000 (15:45 +0900)]
Remove dlog from Requires

Change-Id: Ie270508a787cc45064acfc7a3c5f1b17d658c8d2

5 years agoRemove duplicate verification code 87/184987/3 accepted/tizen/5.0/unified/20181102.014853 accepted/tizen/unified/20180730.142100 submit/tizen/20180727.055504 submit/tizen_5.0/20181101.000003
Minje Ahn [Wed, 25 Jul 2018 03:55:18 +0000 (12:55 +0900)]
Remove duplicate verification code

Use mmfile_free instead of FREE_EX
Remove duplicate null check

Change-Id: I73101a08098966b1e026d2d0c384632abc1c74d9
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
5 years ago[PLM P180706-00145]Fix character set issue for some languages used in Europe. And... 69/183869/1 submit/tizen/20180712.041051
hj kim [Thu, 12 Jul 2018 03:57:19 +0000 (12:57 +0900)]
[PLM P180706-00145]Fix character set issue for some languages used in Europe. And svace issues

Change-Id: I90bdeb4d5ba89b0f130995bfe575766a24ce37bb

6 years agoAdd fortify, stack canary option 28/175628/1 accepted/tizen/unified/20180516.065459 submit/tizen/20180511.003859 submit/tizen/20180515.044502
Minje Ahn [Wed, 11 Apr 2018 07:29:46 +0000 (16:29 +0900)]
Add fortify, stack canary option

Change-Id: I52c4da8092619c3d0d165082bb8a9be64766fab0
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
6 years agoImplement Spherical video metadata V2 extraction in MKV/WebM 01/155001/9
Mykola Alieksieiev [Fri, 29 Sep 2017 15:18:02 +0000 (18:18 +0300)]
Implement Spherical video metadata V2 extraction in MKV/WebM

- No stereo-mode support added as far as it is stored using the
  existing StereoMode element specified in the Matroska spec. and
  can be supported in the Matroska format parser

- WebM files prepared with MKVMerge tool with "-w" option turned on
  (force WebM sub-format) are not recognized by libmm-fileinfo

- Ambisonic audio is not specified in Google's RFC v2

Change-Id: I4935602afb658bfa6971be247a4ffd1e3332fe55
Signed-off-by: Mykola Alieksieiev <m.alieksieie@samsung.com>
6 years agosupport webm format 13/169613/2 accepted/tizen/unified/20180213.132804 submit/tizen/20180208.063721
yujie.cheng [Thu, 8 Feb 2018 02:47:26 +0000 (10:47 +0800)]
support webm format

Change-Id: I4154332ff696b0efc060ad58876ad4d892e1715c