platform/core/multimedia/libmm-fileinfo.git
4 years agoImprove '_get_contents_info' function to reduce Cyclomatic Complexity 77/213577/1
jiyong.min [Mon, 9 Sep 2019 03:31:21 +0000 (12:31 +0900)]
Improve '_get_contents_info' function to reduce Cyclomatic Complexity

Change-Id: I9b86b5432904d9475bc28a4f7e18ad42a1e42ea5

4 years ago[DF190903-00975] Add code to support mpeg audio version 2, layer 1 24/213324/1 accepted/tizen/unified/20190905.060539 submit/tizen/20190904.082658
hj kim [Wed, 4 Sep 2019 08:22:49 +0000 (17:22 +0900)]
[DF190903-00975] Add code to support mpeg audio version 2, layer 1

Change-Id: I86c355baa73bb57285764f02ed00b7de2593c537

4 years agoImprove 'MMFileFormatIsValidXXX' function to reduce DC 01/213201/1 accepted/tizen/unified/20190904.224430 submit/tizen/20190903.022206
jiyong.min [Mon, 2 Sep 2019 23:55:12 +0000 (08:55 +0900)]
Improve 'MMFileFormatIsValidXXX' function to reduce DC

Change-Id: Id9ba66477f0b8766db1b33efb8d09bbb805b3b51

4 years agoImprove '__AvConvertIMelody2MIDI' function to reduce DC 99/213199/4
jiyong.min [Mon, 2 Sep 2019 22:58:06 +0000 (07:58 +0900)]
Improve '__AvConvertIMelody2MIDI' function to reduce DC

Change-Id: Ic751574c6677a1520121f36560d7b6762d2c8928

4 years agoImprove '_mmf_MalibNextChunk' function and remove unused code 77/212877/8
jiyong.min [Tue, 27 Aug 2019 23:09:27 +0000 (08:09 +0900)]
Improve '_mmf_MalibNextChunk' function and remove unused code

 - change 'switch ~ case' to 'looping const table'
 - remove unused function
 - remove unuseful condition (null check)

Change-Id: I227f94c6da3f6563c2ff05d1815bfee004634fa7

4 years agoRemove unneccessary null check 80/212880/3
jiyong.min [Wed, 28 Aug 2019 00:23:39 +0000 (09:23 +0900)]
Remove unneccessary null check

 - 'mm_attrs_set_string/data_by_name' can set null string/data
 - artwork & thumbnail should null check due to memcpy

Change-Id: I219c365925eb03ddaffdbefa96677c7eb956aac8

4 years agoAdd new function to add bracket at genre tag 25/212825/9
jiyong.min [Tue, 27 Aug 2019 05:43:11 +0000 (14:43 +0900)]
Add new function to add bracket at genre tag

Change-Id: I2f9c9da246d573c53e2f364fb750afbf52f4e020

4 years agoReplace duplicate '__getMimeType' and 'getMimeType' to 'mmfile_util_get_mimetype' 10/212810/3
jiyong.min [Tue, 27 Aug 2019 04:07:05 +0000 (13:07 +0900)]
Replace duplicate '__getMimeType' and 'getMimeType' to 'mmfile_util_get_mimetype'

Change-Id: Ie01859409d1b6044c093c2de47f1e4449cf7b2aa

4 years agoImprove 'mmfile_format_read_tag_ffmpg' function 09/212809/4
jiyong.min [Tue, 27 Aug 2019 02:08:10 +0000 (11:08 +0900)]
Improve 'mmfile_format_read_tag_ffmpg' function

Change-Id: I2edf99b08d29631d0363e1ce3493004ad99bfa21

4 years agoUpdate debug msg 00/208300/1 accepted/tizen/unified/20190624.075133 submit/tizen/20190624.012801
hj kim [Fri, 21 Jun 2019 08:17:00 +0000 (17:17 +0900)]
Update debug msg

Change-Id: I4ca482bb7afb313de76f79a4624c563c197c679d

5 years agoUpdate pkg version 79/205979/1 submit/tizen/20190513.045956
hj kim [Mon, 13 May 2019 02:46:26 +0000 (11:46 +0900)]
Update pkg version

Change-Id: I0f336e2e2cb9c5eeab27469aa465974496e58b5f

5 years agoChange strcasecmp() to g_ascii_strcasecmp() because strcasecmp is locale sensitive. 77/205977/2
hj kim [Mon, 13 May 2019 02:43:42 +0000 (11:43 +0900)]
Change strcasecmp() to g_ascii_strcasecmp() because strcasecmp is locale sensitive.

Change-Id: Iff51728241d047f0af6f4dc2addbeecd5f573899

5 years agoMerge "Support TPOS (Part of a Set)" into tizen accepted/tizen/unified/20190307.231009 submit/tizen/20190304.011603
Jiyong Min [Mon, 4 Mar 2019 00:05:31 +0000 (00:05 +0000)]
Merge "Support TPOS (Part of a Set)" into tizen

5 years agoMerge "Just add description for the smta" into tizen
Jiyong Min [Mon, 4 Mar 2019 00:05:23 +0000 (00:05 +0000)]
Merge "Just add description for the smta" into tizen

5 years agoIncrease _RETRY_SEARCH_LIMIT to 250. some contents need search count this much 66/200666/1
hj kim [Thu, 28 Feb 2019 02:12:11 +0000 (11:12 +0900)]
Increase _RETRY_SEARCH_LIMIT to 250. some contents need search count this much

Change-Id: I6825cea3e9a0a2a895b2e13af78940889c602744

5 years agoSupport TPOS (Part of a Set) 64/200664/6
hj kim [Thu, 28 Feb 2019 01:32:12 +0000 (10:32 +0900)]
Support TPOS (Part of a Set)

The ‘Part of a set’ frame is a numeric string that describes which part of a set the audio came from.
This frame is used if the source described in the “TALB” frame is divided into several mediums,
e.g. a double CD. The value MAY be extended with a “/” character and a numeric string containing the total number of parts in the set. E.g. “1/2”.

Change-Id: Ic0613adda4b54834892e7592df34598b9d14be9b

5 years agoJust add description for the smta 65/200665/2
hj kim [Thu, 28 Feb 2019 01:38:43 +0000 (10:38 +0900)]
Just add description for the smta

Change-Id: I661cd6fe8667e3716e1269574836af63a61ac263

5 years agoSupport smta value 0x02 27/200527/2
hj kim [Tue, 26 Feb 2019 07:36:40 +0000 (16:36 +0900)]
Support smta value 0x02

Change-Id: I7dc1f10917a706e03447a97b5ef69d945064d664

5 years agoChange the size and nmemb of fread() to check the return value 13/199013/1
jiyong.min [Fri, 1 Feb 2019 00:39:25 +0000 (09:39 +0900)]
Change the size and nmemb of fread() to check the return value

Change-Id: Icff42f9f037df9b44cd5ab07420dab1037747463

5 years agoAdd to check the return of fseek() 87/198687/1 accepted/tizen/unified/20190207.120249 submit/tizen/20190131.041045
jiyong.min [Tue, 29 Jan 2019 00:37:27 +0000 (09:37 +0900)]
Add to check the return of fseek()

 - If fseek() is failed, -1 is returned and errno is set to indicate the errors.

Change-Id: I7174ca625da1026ebe07cb72fd97459d89c05d75

5 years agoAdd to check the file permission before mm_file access a file. 25/197225/4 accepted/tizen/unified/20190114.060054 submit/tizen/20190111.015801
jiyong.min [Thu, 10 Jan 2019 08:25:19 +0000 (17:25 +0900)]
Add to check the file permission before mm_file access a file.

- error case
Metadata-extractor did not return Permission denied.

Change-Id: I5ef74a95dcca60e451d9c1e55aab67694f7f208e

5 years agoCoverity issue fix 34/196034/1 accepted/tizen/unified/20181227.062028 submit/tizen/20181226.064859
hj kim [Fri, 21 Dec 2018 02:44:31 +0000 (11:44 +0900)]
Coverity issue fix

Change-Id: Id90eb786575e82376fd0535ea11fd0fadfcd5470

5 years agoFix format error in logs 81/194681/1 accepted/tizen/unified/20181210.060034 submit/tizen/20181207.051909
jiyong.min [Fri, 7 Dec 2018 03:45:39 +0000 (12:45 +0900)]
Fix format error in logs

Change-Id: I024c8d532c47c3a58aa13f4b6e5fa5c6a647d7a2

5 years agoFix build error without gtests 47/193747/1 accepted/tizen/unified/20181127.073258 submit/tizen/20181126.011146
jiyong.min [Mon, 26 Nov 2018 02:10:06 +0000 (11:10 +0900)]
Fix build error without gtests

Change-Id: I7eb22626683c57234d272302228beb831093d434

5 years agoMerge "Adding initial structure for unittest" into tizen
hj kim [Mon, 26 Nov 2018 01:13:54 +0000 (01:13 +0000)]
Merge "Adding initial structure for unittest" into tizen

5 years agoAdding initial structure for unittest 93/193493/5
jiyong.min [Wed, 21 Nov 2018 08:00:08 +0000 (17:00 +0900)]
Adding initial structure for unittest

- It has only one testcases for libmedia_utils of unittest
- It would be enabled by gtest build with '--define "gtests 1"'
- Two test contents would be copyied to '/usr/bin' directory

Change-Id: I6988de63bfd3c2cea7aa8518bf83d700d09d38cd

5 years agoApply new attribute API of libmm-common 40/192940/1
Sangchul Lee [Mon, 5 Nov 2018 07:20:30 +0000 (16:20 +0900)]
Apply new attribute API of libmm-common

- Remove dependency of mm_attrs_private.h.
- Use new API set in mm_attrs.h instead of those.

Change-Id: Icd720cc02b677b881e4266c8a4a0cd79f72ab5ce
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
5 years agoRemove dlog from Requires 72/192172/1 accepted/tizen/unified/20181107.081919 submit/tizen/20181105.235320
hj kim [Wed, 31 Oct 2018 06:45:07 +0000 (15:45 +0900)]
Remove dlog from Requires

Change-Id: Ie270508a787cc45064acfc7a3c5f1b17d658c8d2

5 years agoRemove duplicate verification code 87/184987/3 accepted/tizen/5.0/unified/20181102.014853 accepted/tizen/unified/20180730.142100 submit/tizen/20180727.055504 submit/tizen_5.0/20181101.000003
Minje Ahn [Wed, 25 Jul 2018 03:55:18 +0000 (12:55 +0900)]
Remove duplicate verification code

Use mmfile_free instead of FREE_EX
Remove duplicate null check

Change-Id: I73101a08098966b1e026d2d0c384632abc1c74d9
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
5 years ago[PLM P180706-00145]Fix character set issue for some languages used in Europe. And... 69/183869/1 submit/tizen/20180712.041051
hj kim [Thu, 12 Jul 2018 03:57:19 +0000 (12:57 +0900)]
[PLM P180706-00145]Fix character set issue for some languages used in Europe. And svace issues

Change-Id: I90bdeb4d5ba89b0f130995bfe575766a24ce37bb

6 years agoAdd fortify, stack canary option 28/175628/1 accepted/tizen/unified/20180516.065459 submit/tizen/20180511.003859 submit/tizen/20180515.044502
Minje Ahn [Wed, 11 Apr 2018 07:29:46 +0000 (16:29 +0900)]
Add fortify, stack canary option

Change-Id: I52c4da8092619c3d0d165082bb8a9be64766fab0
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
6 years agoImplement Spherical video metadata V2 extraction in MKV/WebM 01/155001/9
Mykola Alieksieiev [Fri, 29 Sep 2017 15:18:02 +0000 (18:18 +0300)]
Implement Spherical video metadata V2 extraction in MKV/WebM

- No stereo-mode support added as far as it is stored using the
  existing StereoMode element specified in the Matroska spec. and
  can be supported in the Matroska format parser

- WebM files prepared with MKVMerge tool with "-w" option turned on
  (force WebM sub-format) are not recognized by libmm-fileinfo

- Ambisonic audio is not specified in Google's RFC v2

Change-Id: I4935602afb658bfa6971be247a4ffd1e3332fe55
Signed-off-by: Mykola Alieksieiev <m.alieksieie@samsung.com>
6 years agosupport webm format 13/169613/2 accepted/tizen/unified/20180213.132804 submit/tizen/20180208.063721
yujie.cheng [Thu, 8 Feb 2018 02:47:26 +0000 (10:47 +0800)]
support webm format

Change-Id: I4154332ff696b0efc060ad58876ad4d892e1715c

6 years agoadd support ape format 58/166858/1 accepted/tizen/unified/20180131.060513 submit/tizen/20180114.234158 submit/tizen/20180130.062218
chen89.chen [Fri, 12 Jan 2018 07:40:59 +0000 (15:40 +0800)]
add support ape format

Change-Id: I529ee542ea735c8d33ee1b4eefa15135e3c8df3c

6 years agoAdd debug msg for error case 32/166132/1 accepted/tizen/unified/20180109.172748 submit/tizen/20180108.070811
hj kim [Mon, 8 Jan 2018 05:42:24 +0000 (14:42 +0900)]
Add debug msg for error case

Change-Id: If7c7e0ee7994ca99b864a35fb0b67024a3b220a5

6 years agoFix deadlock during extracting tags 18/163318/3
Vitaliy Cherepanov [Fri, 8 Dec 2017 12:03:19 +0000 (15:03 +0300)]
Fix deadlock during extracting tags

Change-Id: I16fe8b3844ace9be1edce741de533b40362ab4d6
Signed-off-by: Vitaliy Cherepanov <v.cherepanov@samsung.com>
6 years agoMPEGTS content parsing timeout set. 50/164850/1 accepted/tizen/unified/20171222.062621 submit/tizen/20171222.014458
ji.yong.seo [Thu, 23 Feb 2017 05:53:18 +0000 (14:53 +0900)]
MPEGTS content parsing timeout set.

Signed-off-by: ji.yong.seo <ji.yong.seo@samsung.com>
Change-Id: If2a7d646255ca0d35761c3d5aabd4667877d6d76
(cherry picked from commit fea2250192199c4669c0c5974fc1e73f27ffee8e)

6 years agoSupport AIFF 14/163914/1 accepted/tizen/unified/20171219.072641 submit/tizen/20171214.062642
hj kim [Thu, 14 Dec 2017 04:30:47 +0000 (13:30 +0900)]
Support AIFF

Change-Id: Idc4fd8a1caf4dc337fae1be7adf04debb24df3ee

6 years agoFix Memory leak 36/157336/2 accepted/tizen/unified/20171025.075231 submit/tizen/20171024.235653
hj kim [Tue, 24 Oct 2017 07:53:00 +0000 (16:53 +0900)]
Fix Memory leak

Change-Id: I53f4585b12708aeeb7b41452f4b79ddfdbebed81

6 years agoBug fix of tag checking 16/153416/1 accepted/tizen/unified/20170929.081702 submit/tizen/20170928.095536
Haejeong Kim [Thu, 28 Sep 2017 09:53:24 +0000 (18:53 +0900)]
Bug fix of tag checking

Change-Id: I7be4676b170f561f0e73f9548d28b7c2d1292093

6 years agoCoverity Issue Fix 20/153320/2
Haejeong Kim [Thu, 28 Sep 2017 08:47:44 +0000 (17:47 +0900)]
Coverity Issue Fix

Change-Id: I54eec93fc513692bde3df0030f2841d23fff0afe

6 years agoRemove useless configure file 34/150034/1 accepted/tizen/unified/20170918.093841 submit/tizen/20170915.084033
Haejeong Kim [Thu, 14 Sep 2017 05:17:20 +0000 (14:17 +0900)]
Remove useless configure file

Change-Id: I67d823a239c6cb89769ae52c49e404e365c2c36f

6 years agoModify the search function 57/149157/5 accepted/tizen/unified/20170913.071136 submit/tizen/20170912.034220
Minje Ahn [Tue, 12 Sep 2017 00:32:36 +0000 (09:32 +0900)]
Modify the search function

Use glib API instead of dirent API

Change-Id: I2dc135b0f53f915ad478609b6457aa3999140780
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
6 years agompg audio clip can't play , fix check mpeg audio layer 1 header 78/148278/2 accepted/tizen/unified/20170908.220538 submit/tizen/20170908.022404
chen89.chen [Thu, 7 Sep 2017 09:25:41 +0000 (17:25 +0800)]
mpg audio clip can't play , fix check mpeg audio layer 1 header

Change-Id: I34fb96eddddab03039be81d627d45b8fea7bf414

6 years agoApply tizen coding rule 41/147341/1 accepted/tizen/unified/20170906.060715 submit/tizen/20170904.081106 submit/tizen/20170905.045152
Haejeong Kim [Mon, 4 Sep 2017 05:10:24 +0000 (14:10 +0900)]
Apply tizen coding rule

Change-Id: I8fa2ede20e3dbb42a76d1e0a374f010750cd0e94

6 years agoupdate msg format for debugging and apply tizen coding rule 41/147141/4
Haejeong Kim [Fri, 1 Sep 2017 06:44:32 +0000 (15:44 +0900)]
update msg format for debugging and apply tizen coding rule

Change-Id: I08190f96959658e63844ab77ff5a4ea065c43a33

6 years agoAdd Spherical Video Metadata V2 support 42/144642/4
Mykola Alieksieiev [Thu, 17 Aug 2017 09:32:07 +0000 (12:32 +0300)]
Add Spherical Video Metadata V2 support

Change-Id: I215cce72ac37719c8fbb62da5953e498452ded1f
Signed-off-by: Mykola Alieksieiev <m.alieksieie@samsung.com>
6 years agoAdd to check NULL of pbSetup 86/145786/3 accepted/tizen/unified/20170825.043938 submit/tizen/20170824.093149
Jiyong Min [Thu, 24 Aug 2017 00:33:26 +0000 (09:33 +0900)]
Add to check NULL of pbSetup

Change-Id: I5ab01613fdc188446677cd55632dbf036715e745
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
6 years agoApply libav 12.1 53/142653/2 accepted/tizen/4.0/unified/20170829.015816 accepted/tizen/unified/20170822.113057 submit/tizen/20170822.010353 submit/tizen_4.0/20170828.100004 submit/tizen_4.0/20170828.110004
Haejeong Kim [Mon, 7 Aug 2017 02:54:02 +0000 (11:54 +0900)]
Apply libav 12.1

Change-Id: Ic93a7190a1be1d8deefd7e70cd0ba4984af34b82

6 years agoRemove deprecated ffurl related code. Use own io_context instead of it 92/141092/11 accepted/tizen/unified/20170804.133119 submit/tizen/20170804.024406
Haejeong Kim [Fri, 28 Jul 2017 06:42:40 +0000 (15:42 +0900)]
Remove deprecated ffurl related code. Use own io_context instead of it

Change-Id: I26a8c473fb9d4e9aa29aec928cf248299c4c5bfd

6 years agoSvace issue fix 36/140936/2 accepted/tizen/4.0/unified/20170816.012147 accepted/tizen/unified/20170728.003927 submit/tizen/20170727.081109 submit/tizen_4.0/20170811.094300
Haejeong Kim [Thu, 27 Jul 2017 07:24:11 +0000 (16:24 +0900)]
Svace issue fix

Change-Id: I479294aeda58771c9646c03a3d216c621b58af11

6 years agoAdd test code for getting video frame 04/140904/3
Haejeong Kim [Thu, 27 Jul 2017 06:08:52 +0000 (15:08 +0900)]
Add test code for getting video frame

Change-Id: I25ae5287f48837aca7ed27f369cc9aecc353a826

6 years agoRemove useless include 85/140885/1
Haejeong Kim [Thu, 27 Jul 2017 05:16:16 +0000 (14:16 +0900)]
Remove useless include

Change-Id: I80534df4da30b1453e49524a679f0c0eae5adcc6

6 years ago[SATIZENVUL-914] Add verify for value range 81/139181/6 accepted/tizen/unified/20170726.012943 submit/tizen/20170724.084341 submit/tizen/20170725.010916 submit/tizen/20170726.234453
Minje Ahn [Tue, 18 Jul 2017 00:59:53 +0000 (09:59 +0900)]
[SATIZENVUL-914] Add verify for value range

Change-Id: I6ffdc7c29568471347d4f58841925096a31a66e2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
6 years agoRemove __MMFILE_FFMPEG_V085__ 76/139876/1 submit/tizen/20170721.021113
Haejeong Kim [Fri, 21 Jul 2017 02:08:53 +0000 (11:08 +0900)]
Remove __MMFILE_FFMPEG_V085__

Change-Id: Iaddf2c369576a63cbd4457008049725ba7541b45

6 years agoChange parameter type of time_stamp. double -> int64_t 67/139867/1 accepted/tizen/unified/20170721.201949 submit/tizen/20170721.015330
Haejeong Kim [Fri, 21 Jul 2017 01:48:17 +0000 (10:48 +0900)]
Change parameter type of time_stamp. double -> int64_t

Change-Id: I81de7b6465611f4ba482b75412a2b992b8c3a02b

6 years agoRemove too old __MMFILE_FFMPEG_V085__ and related code. because __MMFILE_FFMPEG_V085_... 55/139755/1
Haejeong Kim [Thu, 20 Jul 2017 09:05:56 +0000 (18:05 +0900)]
Remove too old __MMFILE_FFMPEG_V085__ and related code. because __MMFILE_FFMPEG_V085__ was created when FFMpeg upgraded to v1.0 to backup code

Change-Id: Ibc3e6e96f89b5c4e1d69ade2f7ef8a32f2b40aae

6 years agoRemove too old __MMFILE_FFMPEG_V100__ and related code. because __MMFILE_FFMPEG_V100_... 37/139737/1
Haejeong Kim [Thu, 20 Jul 2017 08:29:11 +0000 (17:29 +0900)]
Remove too old __MMFILE_FFMPEG_V100__ and related code. because __MMFILE_FFMPEG_V100__ was created when FFMpeg upgrade to v1.0

Change-Id: I34f40f317d3b246ba83573b2200435cfcf595c63

6 years agoFix Old Pixel format to New one 32/139732/1
Haejeong Kim [Thu, 20 Jul 2017 08:10:49 +0000 (17:10 +0900)]
Fix Old Pixel format to New one

Change-Id: Ic238f65e2b1775dce3e575065f404dd876bf2867

6 years ago[SATIZENVUL-949] check memory allocation 77/138877/4
Minje Ahn [Fri, 14 Jul 2017 05:52:48 +0000 (14:52 +0900)]
[SATIZENVUL-949] check memory allocation

1. Add allocation check
2. Remove code bundled with _SM_ONLY

Change-Id: Ic833adfdb30711797c3e005f9e5b842a2bda3752
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
6 years agoAdd support for Spherical Video and Ambisonics Audio Metadata 50/123150/10
Mykola Alieksieiev [Tue, 4 Apr 2017 17:14:29 +0000 (20:14 +0300)]
Add support for Spherical Video and Ambisonics Audio Metadata

* Spherical Video Metadata V1 in mp4 files
* Spatial audio metadata extraction from SA3D atom nested in mp4a atom
* Supported different ambisonics types, orders and formats

Change-Id: I0768ef0e8f6875c47d1b58b35e4cbea68dacaf52
Signed-off-by: Mykola Alieksieiev <m.alieksieie@samsung.com>
6 years agofix invalid format argument types for dlog 71/135171/1 accepted/tizen/unified/20170630.083256 submit/tizen/20170621.064821 submit/tizen/20170622.044226
Haejeong Kim [Wed, 21 Jun 2017 06:09:37 +0000 (15:09 +0900)]
fix invalid format argument types for dlog

Change-Id: Ia611bd5fccd8027d6fc3610c41562f59266543ec

6 years ago[RQ170606-00002] fix invalid format argument types for dlog 08/133408/1 accepted/tizen/unified/20170613.194012 submit/tizen/20170613.005517
Haejeong Kim [Mon, 12 Jun 2017 05:51:17 +0000 (14:51 +0900)]
[RQ170606-00002] fix invalid format argument types for dlog

Change-Id: Ib3cb1ae54e9a94de9044515cb37b751a695b9648

7 years agoModify to use vulnerable function 'sscanf' 90/126490/1 accepted/tizen/unified/20170428.033133 submit/tizen/20170427.223501 tizen_4.0.m1_release
Jiyong Min [Thu, 20 Apr 2017 01:22:24 +0000 (10:22 +0900)]
Modify to use vulnerable function 'sscanf'

Change-Id: I82d34b900905e3dc487a7b22b995c5c05b609ec1
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
(cherry picked from commit 81d593deaba59483538a1f357b676aa805807304)

7 years agoremove MMFileUtilGetMetaDataFromMP4() when extract content attributes. because MMFile... 86/122986/2 accepted/tizen/unified/20170406.054606 submit/tizen/20170405.054127
Haejeong Kim [Tue, 4 Apr 2017 06:38:30 +0000 (15:38 +0900)]
remove MMFileUtilGetMetaDataFromMP4() when extract content attributes. because MMFileUtilGetMetaDataFromMP4() is only extracting metadata(tag)

Change-Id: Iac932732e656ae2320b123a1628816b89f33c581

7 years agoJust update comment for smta and cdis which in samsung specific moov container 91/120291/1
Haejeong Kim [Wed, 22 Mar 2017 08:17:14 +0000 (17:17 +0900)]
Just update comment for smta and cdis which in samsung specific moov container

Change-Id: I3435b1613c2fdf449969241ddb637965adb18503

7 years agoAdd to check junk data 96/119996/1 accepted/tizen_common accepted/tizen_ivi accepted/tizen_mobile accepted/tizen_tv accepted/tizen_wearable accepted/tizen/common/20170322.153633 accepted/tizen/ivi/20170322.235545 accepted/tizen/mobile/20170322.235514 accepted/tizen/tv/20170322.235528 accepted/tizen/unified/20170322.235559 accepted/tizen/wearable/20170322.235539 submit/tizen/20170322.011031
Jiyong Min [Mon, 20 Mar 2017 07:43:04 +0000 (16:43 +0900)]
Add to check junk data

 [Problem] It is too long to read mpeg header when it was broken.
- When read tag from the file with the junk data, read whole file to find tag
because of wrong offset of box.
If the offset of box was wrong, add to check the moov data has already found at first.
After reading moov data is done, it check junk data for 1000 times.

Change-Id: I7ff67e7076870c6af43a1f3a98565c2b5cea856c
Signed-off-by: jiyong.min <jiyong.min@samsung.com>
Conflicts:
packaging/libmm-fileinfo.spec

Change-Id: I4ad0f2ff2000a8b8a784665a852a1e6f767c74d3
Signed-off-by: jiyong.min <jiyong.min@samsung.com>
7 years agoAdd tool package of executable file(mm_file_test) to improve security 75/119675/7
Jiyong Min [Tue, 17 Jan 2017 09:13:29 +0000 (18:13 +0900)]
Add tool package of executable file(mm_file_test) to improve security

Change-Id: I1a72170872b8f7a04109a452cf60e897d962a593
Signed-off-by: jiyong.min <jiyong.min@samsung.com>
Conflicts:
packaging/libmm-fileinfo.spec

Change-Id: Idcbce52b7e02cca763c2358de373e8307440c8ee

7 years agoReplace readdir_r to readdir to fix build error 42/118542/1 accepted/tizen/common/20170313.162525 accepted/tizen/ivi/20170313.120228 accepted/tizen/mobile/20170313.120141 accepted/tizen/tv/20170313.120157 accepted/tizen/unified/20170313.120247 accepted/tizen/wearable/20170313.120212 submit/tizen/20170313.062244
Jiyong Min [Mon, 13 Mar 2017 06:15:41 +0000 (15:15 +0900)]
Replace readdir_r to readdir to fix build error

 [Problem] After update tool chain to GCC6, 'readdir_r is deprecated' build error happen

'readdir_r' is deprecated because of below reasons.
 *  On systems where NAME_MAX is undefined, calling readdir_r() may be
    unsafe because the interface does not allow the caller to specify
    the length of the buffer used for the returned directory entry.

 *  On some systems, readdir_r() can't read directory entries with
    very long names.  When the glibc implementation encounters such a
    name, readdir_r() fails with the error ENAMETOOLONG after the
    final directory entry has been read.  On some other systems,
    readdir_r() may return a success status, but the returned d_name
    field may not be null terminated or may be truncated.

Change-Id: Iaeabf4b09ab77dfedbc161c725c27a39ec4325c2
Signed-off-by: jiyong.min <jiyong.min@samsung.com>
7 years agoRemove unused static variable to fix build error 56/117756/1 accepted/tizen/common/20170307.134027 accepted/tizen/ivi/20170307.222010 accepted/tizen/mobile/20170307.221927 accepted/tizen/tv/20170307.221939 accepted/tizen/unified/20170309.033210 accepted/tizen/wearable/20170307.221956 submit/tizen/20170307.093310 submit/tizen_unified/20170308.100408
Jiyong Min [Tue, 7 Mar 2017 09:22:35 +0000 (18:22 +0900)]
Remove unused static variable to fix build error

 [Problem] After update tool chain to GCC6, 'definded but not used' build error happen

Before GCC6 -Wunused-variable (enabled by -Wall) didn’t warn for unused static const variables in C.
This was because some old code had constructs like: static const char rcs_id[] = "$Id:...";.
But this old special use case is not very common anymore. And not warning about such unused variables was hiding real bugs.
So GCC6 introduces -Wunused-const-variable (enabled by -Wunused-variable for C, but not for C++).

Change-Id: I075937a718b0dbbd3cab28df75084581bed363ab
Signed-off-by: jiyong.min <jiyong.min@samsung.com>
7 years agocode refactoring 62/110362/1
ji.yong.seo [Wed, 11 Jan 2017 04:11:51 +0000 (13:11 +0900)]
code refactoring

Change-Id: I935050c1fffe4643d3ebfeb493d012d1c5e01f7f
Signed-off-by: ji.yong.seo <ji.yong.seo@samsung.com>
7 years agopackaging: fix build error by Werror 91/109091/1 accepted/tizen/common/20170109.202413 accepted/tizen/ivi/20170109.084405 accepted/tizen/mobile/20170109.084306 accepted/tizen/tv/20170109.084324 accepted/tizen/wearable/20170109.084345 submit/tizen/20170109.021416
Jiyong Min [Mon, 9 Jan 2017 00:49:45 +0000 (09:49 +0900)]
packaging: fix build error by Werror

Different semantics for inline functions

While -std=gnu89 employs the GNU89 inline semantics, -std=gnu11 uses the
C99 inline semantics. The C99 inline semantics requires that if a
function with external linkage is declared with inline function
specifier, it also has to be defined in the same translation unit (TU).
Consequently, GCC now warns if it sees a TU such as the following:

  inline int foo (void);
  This example now gives the following diagnostic:

  f.c:1:12: warning: inline function 'foo' declared but never defined
    inline int foo (void);

Change-Id: I01405d2b7820e32400d5ec193c073c7ce6e1a50a
Signed-off-by: jiyong.min <jiyong.min@samsung.com>
7 years agoReduce error log 90/109090/1
Minje Ahn [Fri, 23 Dec 2016 00:54:35 +0000 (09:54 +0900)]
Reduce error log

Change error message to info message

Change-Id: If97d61f6a5625e272f9271502e27bc1ae1c1da2e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
modify debug msg.

Change-Id: I4883b3b044efda104c9d1bf682aa538f42e5f405
Signed-off-by: ji.yong.seo <ji.yong.seo@samsung.com>
fix build error.

Change-Id: Ic9e28d7234110c2208a953e39330aac3ce6ccabf
Signed-off-by: ji.yong.seo <ji.yong.seo@samsung.com>
7 years agofix uuid parsing fail. 85/109085/1
ji.yong.seo [Fri, 16 Dec 2016 05:32:18 +0000 (14:32 +0900)]
fix uuid parsing fail.

Change-Id: Iac5c56750f3bbb51b6665a3a8465f00e9441f018
Signed-off-by: ji.yong.seo <ji.yong.seo@samsung.com>
(cherry picked from commit c490426bc6f333747d8fc8dd3185fd1baad7a518)

7 years agomodify 360 video parser. 01/101401/2
ji.yong.seo [Thu, 1 Dec 2016 04:12:45 +0000 (13:12 +0900)]
modify 360 video parser.

Change-Id: I5411e7583b0fa8d964dd0e268d206cc0b38b61e7
Signed-off-by: ji.yong.seo <ji.yong.seo@samsung.com>
(cherry picked from commit 3636ddb575175638220b414a7f3b9a818dd01d24)

7 years agoAdd testcode 83/101483/1
Minje Ahn [Thu, 1 Dec 2016 08:57:18 +0000 (17:57 +0900)]
Add testcode

Change-Id: Ifd76105cd77bea23eeaef8d68617fd88d842c215
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
7 years agoMerge "Remove unused condition and fix buffer overflow" into tizen accepted/tizen/common/20161129.173544 accepted/tizen/ivi/20161130.015415 accepted/tizen/mobile/20161130.015158 accepted/tizen/tv/20161130.015243 accepted/tizen/wearable/20161130.015332 submit/tizen/20161129.052917
Jiyong Min [Tue, 29 Nov 2016 05:01:26 +0000 (21:01 -0800)]
Merge "Remove unused condition and fix buffer overflow" into tizen

7 years agoRemove unused condition and fix buffer overflow 17/100717/1
Jiyong Min [Tue, 29 Nov 2016 04:52:21 +0000 (13:52 +0900)]
Remove unused condition and fix buffer overflow

Change-Id: Id1d0a7de85d5251c90f0b3df80ce6c5b662d1622
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
7 years agoFix svace 2.2 issue 12/100712/1
Minje Ahn [Tue, 29 Nov 2016 04:49:30 +0000 (13:49 +0900)]
Fix svace 2.2 issue

Change-Id: I20351b4b4241ca4994cedfe27cad56e4cb272a1d
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
7 years agoFix 64bit crash & tc fail when get content info from buffer 87/93387/1 accepted/tizen/common/20161025.155104 accepted/tizen/common/20161031.121750 accepted/tizen/ivi/20161101.004509 accepted/tizen/mobile/20161101.004417 accepted/tizen/tv/20161101.004436 accepted/tizen/wearable/20161101.004449 submit/tizen/20161025.104308 submit/tizen/20161031.023900 submit/tizen_3.0_common/20161104.104000
Jiyong Min [Mon, 24 Oct 2016 05:20:51 +0000 (14:20 +0900)]
Fix 64bit crash & tc fail when get content info from buffer

 [Problem] 64bit address is 8 byte(64bit), so the URI of memory buffer should be assigned to 8 byte string.
          The typecast of memory buffer is changed from unsigned int(4 byte) to unsigned long(8 byte).
          In 32bit, unsigned int and unsigned long are 4 byte. It has no problem for 32bit.

Change-Id: I09fa95e4c1cf937651c1c4e77d30053f577d7c2d
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
7 years agoFix svace issue 18/92818/1 accepted/tizen/3.0/ivi/20161028.133913 accepted/tizen/3.0/mobile/20161028.133012 accepted/tizen/3.0/tv/20161028.133334 accepted/tizen/3.0/wearable/20161028.133632 accepted/tizen/common/20161019.145742 accepted/tizen/ivi/20161019.141540 accepted/tizen/mobile/20161019.141347 accepted/tizen/tv/20161019.141448 accepted/tizen/wearable/20161019.141517 submit/tizen/20161019.084351 submit/tizen_3.0/20161028.062323 submit/tizen_3.0/20161028.082423
Minje Ahn [Wed, 19 Oct 2016 01:15:29 +0000 (10:15 +0900)]
Fix svace issue

Change-Id: I28d7e0adedb7f606888954a670777281238c10b2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
7 years agoFix shared object path 36/90436/1 accepted/tizen/3.0/ivi/20161011.044300 accepted/tizen/3.0/mobile/20161015.033504 accepted/tizen/3.0/tv/20161016.004935 accepted/tizen/3.0/wearable/20161015.083225 accepted/tizen/common/20160930.174838 accepted/tizen/ivi/20160930.084005 accepted/tizen/mobile/20160930.084124 accepted/tizen/tv/20160930.084204 accepted/tizen/wearable/20160930.084110 submit/tizen/20160930.050935 submit/tizen_3.0_ivi/20161010.000003 submit/tizen_3.0_mobile/20161015.000003 submit/tizen_3.0_tv/20161015.000003 submit/tizen_3.0_wearable/20161015.000003
Minje Ahn [Fri, 30 Sep 2016 05:01:28 +0000 (14:01 +0900)]
Fix shared object path

Change-Id: I215cefac9360c1fea7497fc9031d09f100fa40c3
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
7 years agoModify library path(using full-path <TSAM-7896>) 47/89747/1 accepted/tizen/common/20160928.163924 accepted/tizen/ivi/20160930.040740 accepted/tizen/mobile/20160930.040410 accepted/tizen/tv/20160930.040550 accepted/tizen/wearable/20160930.040648 submit/tizen/20160928.043825
Minje Ahn [Mon, 26 Sep 2016 23:33:31 +0000 (08:33 +0900)]
Modify library path(using full-path <TSAM-7896>)

Change-Id: I0989f8bf46b67b43e0eccbf02089aa416f719a88
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
7 years agoFix null pointer dereferenced issue (WGID-28322) 00/87600/2 accepted/tizen/common/20160921.162157 accepted/tizen/ivi/20160922.042617 accepted/tizen/mobile/20160922.042327 accepted/tizen/tv/20160922.042452 accepted/tizen/wearable/20160922.042538 submit/tizen/20160921.041639
Jiyong Min [Thu, 8 Sep 2016 23:02:22 +0000 (08:02 +0900)]
Fix null pointer dereferenced issue (WGID-28322)

Change-Id: Id853dffbeb3aba5aa247725e2b326d8d532cdb37
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
7 years agoSupports files larger than 4GB. 45/80045/1 accepted/tizen/common/20160811.145639 accepted/tizen/ivi/20160812.010624 accepted/tizen/mobile/20160812.010646 accepted/tizen/tv/20160812.010601 accepted/tizen/wearable/20160812.010528 submit/tizen/20160810.075454 submit/tizen/20160811.023523
Minje Ahn [Thu, 14 Jul 2016 07:46:09 +0000 (16:46 +0900)]
Supports files larger than 4GB.

Change-Id: Ifc5f29e36a0977584029270fab21516ff522a905
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
7 years agoFix svace issue 86/76486/1 accepted/tizen/common/20160627.191919 accepted/tizen/ivi/20160629.015419 accepted/tizen/mobile/20160629.015317 accepted/tizen/tv/20160629.015358 accepted/tizen/wearable/20160629.015341 submit/tizen/20160627.022624
Minje Ahn [Fri, 24 Jun 2016 05:34:51 +0000 (14:34 +0900)]
Fix svace issue

Change-Id: Id8119ed32a1141b1713c3df4f88eef2b930ce9b5
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
7 years agoFix svace defect 49/75849/2 accepted/tizen/common/20160622.145826 accepted/tizen/ivi/20160622.094120 accepted/tizen/mobile/20160622.094031 accepted/tizen/tv/20160622.094048 accepted/tizen/wearable/20160622.094109 submit/tizen/20160622.011011
Minje Ahn [Wed, 22 Jun 2016 01:03:04 +0000 (10:03 +0900)]
Fix svace defect

Change-Id: I6bb25184199358f2d32f8feae7504f01f61194a9
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
7 years agoFix svace issue 66/74866/1 accepted/tizen/common/20160620.162457 accepted/tizen/ivi/20160617.082441 accepted/tizen/mobile/20160617.081920 accepted/tizen/tv/20160617.082027 accepted/tizen/wearable/20160617.082127 submit/tizen/20160616.065630
Minje Ahn [Thu, 16 Jun 2016 02:24:30 +0000 (11:24 +0900)]
Fix svace issue

Change-Id: Ia9eab08b963a23a71f66f391ef67c6be555c7e47
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
7 years ago[TNEF-7080] Change PNG checker for album art of ID3 tag 11/71711/3 accepted/tizen/common/20160609.145215 accepted/tizen/ivi/20160609.091736 accepted/tizen/mobile/20160609.091955 accepted/tizen/tv/20160609.091605 accepted/tizen/wearable/20160609.091710 submit/tizen/20160609.040222
Jiyong Min [Thu, 26 May 2016 23:34:30 +0000 (08:34 +0900)]
[TNEF-7080] Change PNG checker for album art of ID3 tag

Change-Id: I5c012185bd614081dd36a33aec5cdf1f23cb9705
Signed-off-by: Jiyong Min <jiyong.min@samsung.com>
7 years agoAdd 360 content feature 37/71537/2 accepted/tizen/common/20160531.141838 accepted/tizen/ivi/20160602.022044 accepted/tizen/mobile/20160602.022121 accepted/tizen/tv/20160602.021903 accepted/tizen/wearable/20160602.022015 submit/tizen/20160530.013417
Minje Ahn [Thu, 26 May 2016 00:43:19 +0000 (09:43 +0900)]
Add 360 content feature

Change-Id: I73ea6c702822d22af36caf4d241117eec3c18aa2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
8 years agoAdd checker for id3tag v1 size and memory overlap issue fix 46/59246/2 accepted/tizen/ivi/20160218.023752 accepted/tizen/mobile/20160212.045849 accepted/tizen/tv/20160212.050000 accepted/tizen/wearable/20160212.050005 submit/tizen/20160211.235929 submit/tizen_common/20160218.142243 submit/tizen_ivi/20160217.000000 submit/tizen_ivi/20160217.000003
Minje Ahn [Thu, 11 Feb 2016 23:56:02 +0000 (08:56 +0900)]
Add checker for id3tag v1 size and memory overlap issue fix

Change-Id: I4005065f31ab41a208ea12bf9949a661b57dccac
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
8 years agobug fix patch from tizen 2.4. 08/57608/3 accepted/tizen/mobile/20160128.083246 accepted/tizen/tv/20160128.083308 accepted/tizen/wearable/20160128.083324 submit/tizen/20160128.055041
ji.yong.seo [Thu, 21 Jan 2016 07:26:49 +0000 (16:26 +0900)]
bug fix patch from  tizen 2.4.

Change-Id: I2418e1a46e27151ce2103a89115b0bda74c257e2
Signed-off-by: ji.yong.seo <ji.yong.seo@samsung.com>
8 years agomodify id3 tag parser (extended header exception handing) 57/56057/1 accepted/tizen/mobile/20160104.084626 accepted/tizen/tv/20160104.084709 accepted/tizen/wearable/20160104.084742 submit/tizen/20160104.050314
Minje Ahn [Mon, 4 Jan 2016 04:13:13 +0000 (13:13 +0900)]
modify id3 tag parser (extended header exception handing)

Change-Id: I04e2cf9f77d4a56bdc511649077ba6e89a490176
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
8 years agoSvace issue fix 49/55749/1 accepted/tizen/mobile/20151230.223027 accepted/tizen/tv/20151230.223040 accepted/tizen/wearable/20151230.223059 submit/tizen/20151230.051638
Haejeong Kim [Tue, 29 Dec 2015 06:27:23 +0000 (15:27 +0900)]
Svace issue fix

Change-Id: Id074567a077a36092c7b6afd18a90377df3029cf

8 years agoSvace issue fix 01/55001/1 accepted/tizen/mobile/20151221.223502 accepted/tizen/tv/20151221.223518 accepted/tizen/wearable/20151221.223536 submit/tizen/20151221.103501 submit/tizen_common/20151229.142028 submit/tizen_common/20151229.144031 submit/tizen_common/20151229.154718
Haejeong Kim [Mon, 21 Dec 2015 08:11:37 +0000 (17:11 +0900)]
Svace issue fix

Change-Id: Ia8a53323c9680cbddac59ffc2d73268c785066e8

8 years agoTypo fix 65/54665/1 accepted/tizen/mobile/20151218.044339 accepted/tizen/tv/20151218.044311 accepted/tizen/wearable/20151218.044318 submit/tizen/20151218.020211
Haejeong Kim [Thu, 17 Dec 2015 05:29:12 +0000 (14:29 +0900)]
Typo fix

Change-Id: Ieda9a7b9e13e52470b15009af983784e4e28aaa5

8 years agoApply tizen coding rule 96/53896/1 accepted/tizen/mobile/20151210.082057 accepted/tizen/tv/20151210.082144 accepted/tizen/wearable/20151210.082303 submit/tizen/20151210.060052
Haejeong Kim [Thu, 10 Dec 2015 05:43:47 +0000 (14:43 +0900)]
Apply tizen coding rule

Change-Id: I2419dafc2271df5ed2140ed405de6a22dc86532d

8 years agoApply tizen coding rule 57/53857/1
Haejeong Kim [Thu, 10 Dec 2015 01:01:47 +0000 (10:01 +0900)]
Apply tizen coding rule

Change-Id: Ic89a94ce8e5f20aaccb5bc6af11bcc8efc669135

8 years agoRemove dependency with libmm-common. 68/48968/5 accepted/tizen/mobile/20151103.105437 accepted/tizen/tv/20151103.105450 accepted/tizen/wearable/20151103.105501 submit/tizen/20151103.053124 submit/tizen/20151103.065424
ji.yong.seo [Fri, 2 Oct 2015 09:19:35 +0000 (18:19 +0900)]
Remove dependency with libmm-common.

Change-Id: Ia79020ede78ee6f16729d3983b6d1b44f1da1cd9
Signed-off-by: ji.yong.seo <ji.yong.seo@samsung.com>
8 years agoMerge "sync tizen_2.4." into tizen tizen_3.0.m1_mobile tizen_3.0.m1_tv accepted/tizen/mobile/20150910.070707 accepted/tizen/tv/20150910.070728 accepted/tizen/wearable/20150910.070735 submit/tizen/20150910.050653 submit/tizen_common/20151015.190624 submit/tizen_common/20151019.135620 submit/tizen_common/20151023.083358 submit/tizen_common/20151026.085049 tizen_3.0.m1_mobile_release tizen_3.0.m1_tv_release tizen_3.0.m2.a1_mobile_release tizen_3.0.m2.a1_tv_release
hj kim [Thu, 10 Sep 2015 05:02:46 +0000 (22:02 -0700)]
Merge "sync tizen_2.4." into tizen