Fix crash on avrcp controller API (SIGSEGV) 44/173644/2
authorSangki Park <sangki79.park@samsung.com>
Thu, 22 Mar 2018 08:28:00 +0000 (17:28 +0900)
committerSangki Park <sangki79.park@samsung.com>
Fri, 23 Mar 2018 01:38:36 +0000 (10:38 +0900)
0  0xf722c048 in g_value_unset () from /lib/libgobject-2.0.so.0
1  0xaaeca726 in _bt_avrcp_control_set_property ()
2  0xaaece41c in __bt_bluez_request ()
3  0xaaed4d9c in ?? ()
4  0xf7432a60 in ?? () from /lib/libgio-2.0.so.0
5  0xf71338e8 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
6  0xf7133c78 in ?? () from /lib/libglib-2.0.so.0
7  0xf7133fd8 in g_main_loop_run () from /lib/libglib-2.0.so.0
8  0xaae5726a in main ()

Change-Id: I8b5d77241c1b8788ba91531a4c80cd6f2f280970

bt-service/bt-service-avrcp-controller.c

index be6ce19..2da972d 100644 (file)
@@ -486,13 +486,10 @@ int _bt_avrcp_control_get_property(int type, unsigned int *value)
 
 int _bt_avrcp_control_set_property(int type, unsigned int value)
 {
-       GValue *attr_value = NULL;
        GDBusProxy *proxy = NULL;
        GError *error = NULL;
        GVariant *reply, *param;
 
-       g_value_init(attr_value, G_TYPE_STRING);
-
        switch (type) {
        case EQUALIZER:
                param = g_variant_new("s", equalizer_status[value].property);
@@ -512,7 +509,6 @@ int _bt_avrcp_control_set_property(int type, unsigned int value)
                break;
        default:
                BT_ERR("Invalid property type: %d", type);
-               g_value_unset(attr_value);
                return BLUETOOTH_ERROR_INTERNAL;
        }
 
@@ -536,7 +532,6 @@ int _bt_avrcp_control_set_property(int type, unsigned int value)
        }
 
        g_variant_unref(reply);
-       g_value_unset(attr_value);
 
        return BLUETOOTH_ERROR_NONE;
 }