From: Sangki Park Date: Thu, 22 Mar 2018 08:28:00 +0000 (+0900) Subject: Fix crash on avrcp controller API (SIGSEGV) X-Git-Tag: accepted/tizen/4.0/unified/20190212.083135~7 X-Git-Url: http://review.tizen.org/git/?p=platform%2Fcore%2Fconnectivity%2Fbluetooth-frwk.git;a=commitdiff_plain;h=1b78b7cb437f57d599d5f9b709c0e7276105828e Fix crash on avrcp controller API (SIGSEGV) 0 0xf722c048 in g_value_unset () from /lib/libgobject-2.0.so.0 1 0xaaeca726 in _bt_avrcp_control_set_property () 2 0xaaece41c in __bt_bluez_request () 3 0xaaed4d9c in ?? () 4 0xf7432a60 in ?? () from /lib/libgio-2.0.so.0 5 0xf71338e8 in g_main_context_dispatch () from /lib/libglib-2.0.so.0 6 0xf7133c78 in ?? () from /lib/libglib-2.0.so.0 7 0xf7133fd8 in g_main_loop_run () from /lib/libglib-2.0.so.0 8 0xaae5726a in main () Change-Id: I8b5d77241c1b8788ba91531a4c80cd6f2f280970 --- diff --git a/bt-service/bt-service-avrcp-controller.c b/bt-service/bt-service-avrcp-controller.c index be6ce19..2da972d 100644 --- a/bt-service/bt-service-avrcp-controller.c +++ b/bt-service/bt-service-avrcp-controller.c @@ -486,13 +486,10 @@ int _bt_avrcp_control_get_property(int type, unsigned int *value) int _bt_avrcp_control_set_property(int type, unsigned int value) { - GValue *attr_value = NULL; GDBusProxy *proxy = NULL; GError *error = NULL; GVariant *reply, *param; - g_value_init(attr_value, G_TYPE_STRING); - switch (type) { case EQUALIZER: param = g_variant_new("s", equalizer_status[value].property); @@ -512,7 +509,6 @@ int _bt_avrcp_control_set_property(int type, unsigned int value) break; default: BT_ERR("Invalid property type: %d", type); - g_value_unset(attr_value); return BLUETOOTH_ERROR_INTERNAL; } @@ -536,7 +532,6 @@ int _bt_avrcp_control_set_property(int type, unsigned int value) } g_variant_unref(reply); - g_value_unset(attr_value); return BLUETOOTH_ERROR_NONE; }