[Common] Fixing Coverity issues: AUTO_CAUSES_COPY

[Issues]
1584748
1584753
1584888
1584930
1584981
1585116
1585144
1585152
1585167
1585180
1585249
1585254
1585268
1585269
1585302
1585304
1585322
1585336
1585343
1585355
1585361
1585450
1585522
1585537
1585564
1585601
1585624

[Verification] Code compiles without issues.

Change-Id: I4ace12779be4252a32c376b3ed766032964b35c2

diff --git a/src/badge/badge_manager.cc b/src/badge/badge_manager.cc
index b41f9cc..19aabdc 100644 (file)
--- a/src/badge/badge_manager.cc
+++ b/src/badge/badge_manager.cc
@@ -160,7 +160,7 @@ PlatformResult BadgeManager::GetBadgeCount(const std::string &app_id, unsigned i
 PlatformResult BadgeManager::AddChangeListener(const JsonObject &obj) {
   ScopeLogger();
   auto &items = FromJson<picojson::array>(obj, "appIdList");
-  for (auto item : items) {
+  for (auto &item : items) {
     watched_applications_.insert(common::JsonCast<std::string>(item));
   }
   int ret = BADGE_ERROR_SERVICE_NOT_READY;
@@ -179,7 +179,7 @@ PlatformResult BadgeManager::AddChangeListener(const JsonObject &obj) {
 PlatformResult BadgeManager::RemoveChangeListener(const JsonObject &obj) {
   ScopeLogger();
   auto &items = FromJson<picojson::array>(obj, "appIdList");
-  for (auto item : items) {
+  for (auto &item : items) {
     watched_applications_.erase(common::JsonCast<std::string>(item));
   }
   if (watched_applications_.empty() && is_cb_registered_) {

diff --git a/src/bluetooth/bluetooth_adapter.cc b/src/bluetooth/bluetooth_adapter.cc
index 82c1118..2f9e855 100644 (file)
--- a/src/bluetooth/bluetooth_adapter.cc
+++ b/src/bluetooth/bluetooth_adapter.cc
@@ -290,7 +290,7 @@ void BluetoothAdapter::DiscoveryStateChangedCB(int result,
         if (adapter->user_request_list_[DISCOVER_DEVICES]) {
           data_obj->insert(std::make_pair(kAction, picojson::value(kOnDiscoverFinished)));
 
-          for (auto it : adapter->disappeared_addresses_) {
+          for (auto& it : adapter->disappeared_addresses_) {
             picojson::value disapeared_val = picojson::value(picojson::object());
             picojson::object* disapeared_obj = &disapeared_val.get<picojson::object>();
 
@@ -395,7 +395,7 @@ BluetoothAdapter::~BluetoothAdapter() {
     bt_socket_disconnect_rfcomm(it);
   }
 
-  for (auto it : registered_uuids_) {
+  for (auto& it : registered_uuids_) {
     bt_socket_destroy_rfcomm(it.second.first);
   }
 

diff --git a/src/bluetooth/bluetooth_le_adapter.cc b/src/bluetooth/bluetooth_le_adapter.cc
index 6da5135..bbd7f3c 100644 (file)
--- a/src/bluetooth/bluetooth_le_adapter.cc
+++ b/src/bluetooth/bluetooth_le_adapter.cc
@@ -336,7 +336,7 @@ class BluetoothLEAdvertiseData : public ParsedDataHolder {
     // check servicesData first and append services to a vector (higher priority)
     if (!services_data_obj.is<picojson::null>() && services_data_obj.is<picojson::array>()) {
       LoggerD("Parsing service data array");
-      for (auto single_service : services_data_obj.get<picojson::array>()) {
+      for (auto& single_service : services_data_obj.get<picojson::array>()) {
         auto service_data = BluetoothLEServiceData::Construct(single_service);
         if (!service_data) {
           return false;

diff --git a/src/common/filesystem/filesystem_provider_deviced.cc b/src/common/filesystem/filesystem_provider_deviced.cc
index f179be0..646da3e 100644 (file)
--- a/src/common/filesystem/filesystem_provider_deviced.cc
+++ b/src/common/filesystem/filesystem_provider_deviced.cc
@@ -321,11 +321,11 @@ VirtualStorages FilesystemProviderDeviced::GetAllStorages() {
 
   std::lock_guard<std::mutex> lock(mutex_);
   VirtualStorages vs;
-  for (auto storage : GetStorages()) {
+  for (auto& storage : GetStorages()) {
     vs.push_back(storage);
   }
 
-  for (auto virtual_root : virtual_roots_provider_.GetVirtualPaths()) {
+  for (auto& virtual_root : virtual_roots_provider_.GetVirtualPaths()) {
     vs.push_back(std::make_shared<VirtualRoot>(virtual_root));
   }
 

diff --git a/src/common/filesystem/filesystem_provider_storage.cc b/src/common/filesystem/filesystem_provider_storage.cc
index c48edec..40cf410 100644 (file)
--- a/src/common/filesystem/filesystem_provider_storage.cc
+++ b/src/common/filesystem/filesystem_provider_storage.cc
@@ -199,11 +199,11 @@ std::string FilesystemProviderStorage::GetVirtualPath(const std::string& real_pa
 VirtualStorages FilesystemProviderStorage::GetAllStorages() {
   ScopeLogger();
   VirtualStorages vs;
-  for (auto storage : storages_) {
+  for (auto& storage : storages_) {
     vs.push_back(storage);
   }
 
-  for (auto virtualRoot : virtual_paths_) {
+  for (auto& virtualRoot : virtual_paths_) {
     vs.push_back(std::make_shared<VirtualRoot>(virtualRoot));
   }
 

diff --git a/src/common/json-filter.cc b/src/common/json-filter.cc
index c796a7b..c87248e 100644 (file)
--- a/src/common/json-filter.cc
+++ b/src/common/json-filter.cc
@@ -40,7 +40,7 @@ std::vector<std::string> SplitString(std::string text, char delimiter) {
 
 picojson::value GetAttribute(std::string attribute, picojson::value json) {
   ScopeLogger();
-  for (auto node : SplitString(attribute, kAttributeSeparator)) {
+  for (auto& node : SplitString(attribute, kAttributeSeparator)) {
     if (!json.is<picojson::object>()) {
       throw "filtered attribute not found";
     }

diff --git a/src/common/platform_enum.h b/src/common/platform_enum.h
index 3023850..e1895cf 100644 (file)
--- a/src/common/platform_enum.h
+++ b/src/common/platform_enum.h
@@ -36,7 +36,7 @@ class PlatformEnum {
  public:
   PlatformEnum(std::initializer_list<std::pair<const std::string, NativeEnumType>> m)
       : mapping_(m) {
-    for (auto it : mapping_) {
+    for (auto& it : mapping_) {
       rev_mapping_[it.second] = it.first;
     }
   }

diff --git a/src/common/tools.cc b/src/common/tools.cc
index 74a6b2f..bc29a1b 100644 (file)
--- a/src/common/tools.cc
+++ b/src/common/tools.cc
@@ -355,7 +355,7 @@ PlatformResult CheckAccess(const std::vector<std::string>& privileges) {
   }
   LoggerD("Application api version: %s", api_version.c_str());
 
-  for (auto input_priv : privileges) {
+  for (auto& input_priv : privileges) {
     LoggerD("Input privilege: %s", input_priv.c_str());
     GList* input_glist = nullptr;
     GList* mapped_glist = nullptr;

diff --git a/src/common/worker.cc b/src/common/worker.cc
index 4442c99..10057f9 100644 (file)
--- a/src/common/worker.cc
+++ b/src/common/worker.cc
@@ -87,7 +87,7 @@ void Worker::stop() {
   }
 
   // finalize jobs left in queue
-  for (auto job : jobs) {
+  for (auto& job : jobs) {
     try {
       job.finally();
     } catch (...) {

diff --git a/src/filesystem/filesystem_instance.cc b/src/filesystem/filesystem_instance.cc
index efe92bd..487266d 100644 (file)
--- a/src/filesystem/filesystem_instance.cc
+++ b/src/filesystem/filesystem_instance.cc
@@ -1018,7 +1018,7 @@ void FilesystemInstance::FileReadDir(const picojson::value& args, picojson::obje
     picojson::value response = picojson::value(picojson::object());
     picojson::object& obj = response.get<picojson::object>();
     obj["callbackId"] = picojson::value(callback_id);
-    for (auto path : paths) {
+    for (auto& path : paths) {
       FilesystemStat stat = FilesystemStat::getStat(path);
 
       if (FilesystemError::None == stat.error) {

diff --git a/src/mediacontroller/mediacontroller_client.cc b/src/mediacontroller/mediacontroller_client.cc
index 82d927d..70371c5 100644 (file)
--- a/src/mediacontroller/mediacontroller_client.cc
+++ b/src/mediacontroller/mediacontroller_client.cc
@@ -747,7 +747,7 @@ PlatformResult MediaControllerClient::SetAbilityChangeListener(const JsonCallbac
 
 void UnsubscribeAllTypes(mc_client_h handle_, const std::string& server_name) {
   int ret;
-  for (auto type : types::MediaControllerSubscriptionTypeEnum) {
+  for (auto& type : types::MediaControllerSubscriptionTypeEnum) {
     ret = mc_client_unsubscribe(handle_, type.second, server_name.c_str());
     if (MEDIA_CONTROLLER_ERROR_NONE != ret) {
       LoggerE("mc_client_unsubscribe() failed with type %s, error: %d, message: %s",
@@ -761,7 +761,7 @@ PlatformResult MediaControllerClient::UnsetAbilityChangeListener() {
 
   // we have to unsubscribe all servers before unsetting callback to avoid
   // calling callback twice if the callback will be set again
-  for (auto srv : subscribed_servers) {
+  for (auto& srv : subscribed_servers) {
     UnsubscribeAllTypes(handle_, srv);
   }
   subscribed_servers.clear();
@@ -812,7 +812,7 @@ PlatformResult MediaControllerClient::SubscribeServer(const std::string& server_
 
   SCOPE_EXIT {
     if (to_unsubscribe > 0) {
-      for (auto type : types::MediaControllerSubscriptionTypeEnum) {
+      for (auto& type : types::MediaControllerSubscriptionTypeEnum) {
         if (to_unsubscribe > 0) {
           ret = mc_client_unsubscribe(handle_, type.second, server_name.c_str());
           if (MEDIA_CONTROLLER_ERROR_NONE != ret) {
@@ -825,7 +825,7 @@ PlatformResult MediaControllerClient::SubscribeServer(const std::string& server_
     }
   };
 
-  for (auto type : types::MediaControllerSubscriptionTypeEnum) {
+  for (auto& type : types::MediaControllerSubscriptionTypeEnum) {
     ret = mc_client_subscribe(handle_, type.second, server_name.c_str());
     if (MEDIA_CONTROLLER_ERROR_NONE != ret) {
       return LogAndCreateResult(

diff --git a/src/mediacontroller/mediacontroller_instance.cc b/src/mediacontroller/mediacontroller_instance.cc
index b9d6b07..b982e13 100644 (file)
--- a/src/mediacontroller/mediacontroller_instance.cc
+++ b/src/mediacontroller/mediacontroller_instance.cc
@@ -821,7 +821,7 @@ void MediaControllerInstance::MediaControllerServerSavePlaybackAbilities(
     return;
   }
 
-  for (auto e : types::MediaControllerPlaybackActionEnum) {
+  for (auto& e : types::MediaControllerPlaybackActionEnum) {
     CHECK_ARGS(args, e.first, std::string, out);
   }
 

diff --git a/src/mediacontroller/mediacontroller_server.cc b/src/mediacontroller/mediacontroller_server.cc
index cd6b1ea..85b48e9 100644 (file)
--- a/src/mediacontroller/mediacontroller_server.cc
+++ b/src/mediacontroller/mediacontroller_server.cc
@@ -641,7 +641,7 @@ PlatformResult MediaControllerServer::MediaControllerPlaylistAddItem(
     return result;
   }
 
-  for (auto v : types::MediaControllerMetadataAttributeEnum) {
+  for (auto& v : types::MediaControllerMetadataAttributeEnum) {
     std::string value = encoded[v.first].get<std::string>();
     LoggerD("Key: %s - Value: %s", v.first.c_str(), value.c_str());
 
@@ -709,7 +709,7 @@ PlatformResult MediaControllerServer::SavePlaybackAbilities(const picojson::valu
   bool is_changed = false;
   PlatformResult result = PlatformResult(ErrorCode::NO_ERROR);
 
-  for (auto action : types::MediaControllerPlaybackActionEnum) {
+  for (auto& action : types::MediaControllerPlaybackActionEnum) {
     const std::string& action_str = action.first.c_str();
     const std::string& support_str = abilities.get(action_str).get<std::string>();
     result = SetPlaybackAbility(action_str, support_str, &is_changed);

diff --git a/src/mediacontroller/mediacontroller_utils.cc b/src/mediacontroller/mediacontroller_utils.cc
index 034920d..4b0a10c 100644 (file)
--- a/src/mediacontroller/mediacontroller_utils.cc
+++ b/src/mediacontroller/mediacontroller_utils.cc
@@ -292,7 +292,7 @@ PlatformResult ConvertMetadata(mc_metadata_h metadata_h, picojson::object* metad
   picojson::value to_decode = picojson::value(picojson::object());
   picojson::object& obj = to_decode.get<picojson::object>();
 
-  for (auto entry : MediaControllerMetadataAttributeEnum) {
+  for (auto& entry : MediaControllerMetadataAttributeEnum) {
     int ret = mc_metadata_get(metadata_h, entry.second, &value);
     if (ret != MEDIA_CONTROLLER_ERROR_NONE) {
       return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "Error getting metadata",
@@ -621,7 +621,7 @@ PlatformResult utils::EncodeMetadata(const picojson::object& to_encode, picojson
   }
 
   // other metadata attributes
-  for (auto entry : types::MediaControllerMetadataAttributeEnum) {
+  for (auto& entry : types::MediaControllerMetadataAttributeEnum) {
     std::string name = entry.first;
     if (!isMetadataAttributeEncodable(name)) {
       try {
@@ -700,7 +700,7 @@ PlatformResult utils::DecodeMetadata(const picojson::value& to_decode, picojson:
   }
 
   // now rewrite not encoded attributes
-  for (auto entry : types::MediaControllerMetadataAttributeEnum) {
+  for (auto& entry : types::MediaControllerMetadataAttributeEnum) {
     std::string name = entry.first;
     if (!isMetadataAttributeEncodable(name)) {
       (*decoded)[name] =

diff --git a/src/notification/common_notification.cc b/src/notification/common_notification.cc
index cd03304..826bb05 100644 (file)
--- a/src/notification/common_notification.cc
+++ b/src/notification/common_notification.cc
@@ -515,7 +515,7 @@ PlatformResult CommonNotification::SetApplicationControl(app_control_h app_handl
 
   int idx = 0;
 
-  for (auto item : items) {
+  for (auto& item : items) {
     const picojson::object& obj = JsonCast<picojson::object>(item);
     const std::string key = FromJson<std::string>(obj, "key");
     const picojson::array values = FromJson<picojson::array>(obj, "value");

diff --git a/src/notification/notification_manager.cc b/src/notification/notification_manager.cc
index e249b61..8f13c9c 100644 (file)
--- a/src/notification/notification_manager.cc
+++ b/src/notification/notification_manager.cc
@@ -250,7 +250,7 @@ PlatformResult NotificationManager::PlayLEDCustomEffect(const picojson::object&
 
   auto& flags = FromJson<picojson::array>(args, "flags");
   unsigned int platformFlags = 0;
-  for (auto flag : flags) {
+  for (auto& flag : flags) {
     std::string flagStr = JsonCast<std::string>(flag);
     if ("LED_CUSTOM_DEFAULT" == flagStr)
       platformFlags |= LED_CUSTOM_DEFAULT;

diff --git a/src/systeminfo/systeminfo_properties_manager.cc b/src/systeminfo/systeminfo_properties_manager.cc
index 5ee798d..01df340 100644 (file)
--- a/src/systeminfo/systeminfo_properties_manager.cc
+++ b/src/systeminfo/systeminfo_properties_manager.cc
@@ -1204,7 +1204,7 @@ PlatformResult SysteminfoPropertiesManager::ReportStorage(picojson::object* out)
   common::FilesystemProvider& provider(common::FilesystemProvider::Create());
   auto storages = provider.GetStorages();
   LoggerD("Storages found %zu", storages.size());
-  for (auto storage : storages) {
+  for (auto& storage : storages) {
     if (storage->state() == common::StorageState::kMounted) {
       unsigned long long available;
       unsigned long long total_capacity;