Build fixes for new toolchain

[Verification] Code compiles without errors.

Change-Id: I90dd40984fddf8cbf5d5e16883b63ad550cabb01

diff --git a/src/callhistory/callhistory.cc b/src/callhistory/callhistory.cc
index 9b61057..b863ee5 100644 (file)
--- a/src/callhistory/callhistory.cc
+++ b/src/callhistory/callhistory.cc
@@ -485,7 +485,7 @@ void CallHistory::removeAll(const picojson::object& args) {
 }
 
 CallHistory::LockedVector CallHistory::getPhoneNumbers() {
-  return std::move(CallHistory::LockedVector{m_phone_numbers, m_phone_numbers_mutex});
+  return CallHistory::LockedVector{m_phone_numbers, m_phone_numbers_mutex};
 }
 
 CallHistoryUtils& CallHistory::getUtils() {

diff --git a/src/common/converter.h b/src/common/converter.h
index db0955d..31dd4fa 100644 (file)
--- a/src/common/converter.h
+++ b/src/common/converter.h
@@ -17,6 +17,8 @@
 #ifndef COMMON_CONVERTER_H_
 #define COMMON_CONVERTER_H_
 
+#include <cstdint>
+
 #include "common/picojson.h"
 #include "common/platform_exception.h"
 

diff --git a/src/common/json-filter.cc b/src/common/json-filter.cc
index 58dd98b..c796a7b 100644 (file)
--- a/src/common/json-filter.cc
+++ b/src/common/json-filter.cc
@@ -170,7 +170,7 @@ bool JsonFilter::EvaluateOperator(std::string opType, picojson::value arguments,
 bool JsonFilter::EvaluateNode(picojson::object node, picojson::value record) const {
   ScopeLogger();
   bool result = true;
-  for (const auto attr : node) {
+  for (const auto& attr : node) {
     if (IsOperator(attr.first)) {
       bool value = EvaluateOperator(attr.first, attr.second, record);
       result = result && value;

diff --git a/src/filesystem/filesystem_instance.cc b/src/filesystem/filesystem_instance.cc
index 4ab1ce3..efe92bd 100644 (file)
--- a/src/filesystem/filesystem_instance.cc
+++ b/src/filesystem/filesystem_instance.cc
@@ -892,7 +892,7 @@ void FilesystemInstance::FileSystemManagerFetchStorages(const picojson::value& a
     ScopeLogger("Entered into asynchronous function, onSuccess");
     picojson::array storages;
     storages.reserve(result.size());
-    for (const auto storage : result) {
+    for (const auto& storage : result) {
       storages.push_back(storage->ToJson());
     }
     ReportSuccess(picojson::value(storages), out);

diff --git a/src/iotcon/iotcon_utils.cc b/src/iotcon/iotcon_utils.cc
index 88e25b0..ee674c8 100644 (file)
--- a/src/iotcon/iotcon_utils.cc
+++ b/src/iotcon/iotcon_utils.cc
@@ -1183,7 +1183,7 @@ common::TizenResult IotconUtils::QueryFromJson(const picojson::object& source,
       const auto& filter = IotconUtils::GetArg(source, kFilter);
       if (filter.is<picojson::object>()) {
         const auto& filter_obj = filter.get<picojson::object>();
-        for (const auto it : filter_obj) {
+        for (const auto& it : filter_obj) {
           if (it.second.is<std::string>()) {
             const std::string& key = it.first;
             const std::string& value = it.second.get<std::string>();

diff --git a/src/messaging/message_conversation.cc b/src/messaging/message_conversation.cc
index a2ef073..694ba68 100644 (file)
--- a/src/messaging/message_conversation.cc
+++ b/src/messaging/message_conversation.cc
@@ -42,7 +42,7 @@ bool ContainsAllRequiredRecipients(AnyPtr match_value, std::vector<std::string>
   }
 
   const auto array = match_value->getValue().get<picojson::array>();
-  for (const auto value : array) {
+  for (const auto& value : array) {
     if (!value.is<std::string>()) {
       LoggerE("AttributeFilter value for TO attribute must be an array of strings.");
       return false;

diff --git a/src/metadata/metadata_file_handle.h b/src/metadata/metadata_file_handle.h
index f0136b0..b8d4c48 100644 (file)
--- a/src/metadata/metadata_file_handle.h
+++ b/src/metadata/metadata_file_handle.h
@@ -18,6 +18,8 @@
 #define METADATA_METADATA_FILE_HANDLE_H_
 
 #include <metadata_extractor.h>
+
+#include <cstdint>
 #include <string>
 
 #include "common/picojson.h"