platform/core/uifw/dali-toolkit.git
9 months agoEnsure image visual shaderType is in range 67/307567/3
Eunki, Hong [Tue, 12 Mar 2024 04:05:25 +0000 (13:05 +0900)]
Ensure image visual shaderType is in range

Let we make assert if we try to use invalid native shader feature

Change-Id: I20780e264038c5d59018c8c7110a51a18f36dbe5
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoMerge "Change TransitionEffect" into devel/master
sunghyun kim [Thu, 14 Mar 2024 01:24:27 +0000 (01:24 +0000)]
Merge "Change TransitionEffect" into devel/master

9 months agoMerge "Ignore overwritable image changeness during utc test" into devel/master
David Steele [Wed, 13 Mar 2024 10:17:35 +0000 (10:17 +0000)]
Merge "Ignore overwritable image changeness during utc test" into devel/master

9 months agoMerge "The canvas view defaults to SYNCHRONOUS_LOADING." into devel/master
joogab yun [Wed, 13 Mar 2024 01:11:38 +0000 (01:11 +0000)]
Merge "The canvas view defaults to SYNCHRONOUS_LOADING." into devel/master

9 months agoChange TransitionEffect 19/307719/2
sunghyun kim [Tue, 12 Mar 2024 11:39:09 +0000 (20:39 +0900)]
Change TransitionEffect

The existing effect was rather slow and unnatural.
therefore, some of the settings have been modified to make the effect more natural.

Change-Id: I42ef237dd831dd210766bf670b2d3061def69c44

9 months agoMerge "Lock mutex when we queue offscreen texture at GlView" into devel/master
David Steele [Tue, 12 Mar 2024 11:58:51 +0000 (11:58 +0000)]
Merge "Lock mutex when we queue offscreen texture at GlView" into devel/master

9 months agoIgnore overwritable image changeness during utc test 97/307697/2
Eunki, Hong [Tue, 12 Mar 2024 08:38:09 +0000 (17:38 +0900)]
Ignore overwritable image changeness during utc test

Change-Id: I09ad220850be41ae1b659100e6e4a5ba555dba59
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoThe canvas view defaults to SYNCHRONOUS_LOADING. 71/307671/3
joogab.yun [Tue, 12 Mar 2024 04:48:35 +0000 (13:48 +0900)]
The canvas view defaults to SYNCHRONOUS_LOADING.

A crash occurs when multiple CanvasViews are operated async.
So, we change it to operate synchronously by default.

The problem of async operation when using a multi-canvas view should be resolved later.

Change-Id: I9bb4c8165b69ebdd93753211214fcadf06a3f456

9 months agoIntroduce REMOVE_FRONT_INSET, REMOVE_BACK_INSET Property 25/307025/17
ANZ1217 [Wed, 21 Feb 2024 05:39:52 +0000 (14:39 +0900)]
Introduce REMOVE_FRONT_INSET, REMOVE_BACK_INSET Property

Added new property to TextLabel

Example:
textLabel.SetProperty(DevelTextLabel::Property::REMOVE_FRONT_INSET, false);
textLabel.SetProperty(DevelTextLabel::Property::REMOVE_BACK_INSET, false);

When REMOVE_FRONT_INSET is set to false, the xBearing of first glyph won't be trimmed.
When REMOVE_BACK_INSET is set to false, the advance of last glyph won't be trimmed.

Change-Id: I169d87b9f83d3b204ea51601188982cda54cb9d0

9 months agoMerge "Fix svace issue : Need to check Property::Value.Get() return" into devel/master
Eunki Hong [Mon, 11 Mar 2024 02:45:43 +0000 (02:45 +0000)]
Merge "Fix svace issue : Need to check Property::Value.Get() return" into devel/master

9 months agoMerge "DALi Version 2.3.14" into devel/master
David Steele [Fri, 8 Mar 2024 10:55:24 +0000 (10:55 +0000)]
Merge "DALi Version 2.3.14" into devel/master

9 months agoDALi Version 2.3.14 54/307454/1 dali_2.3.14
Adam Bialogonski [Fri, 8 Mar 2024 10:49:53 +0000 (10:49 +0000)]
DALi Version 2.3.14

Change-Id: I523b759829956740ddc95706005ce408a0741041

9 months agoAdd CastShadow and ReceiveShadow for Model and ModelNode 61/307061/3
Seungho Baek [Mon, 4 Mar 2024 09:08:27 +0000 (18:08 +0900)]
Add CastShadow and ReceiveShadow for Model and ModelNode

 - CastShadow can be used to make an object cast shadow or not.
 - ReceiveShadow can be used to make an object be not drawn any shadow on its surface.
 - Model and ModelNode have the methods.
 - If Model's method is called, it is inherited to its current child ModelNode.
 - If ModelNode's method is called, it is only affects the ModelNode itself.
 - The ModelNode's property changes do not affect its parent Model's property.

Change-Id: I8ebeeed9ed814718a38ad7f69c43a4814a5a70ae
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
9 months agoFix svace issue : Need to check Property::Value.Get() return 98/307098/2
Eunki, Hong [Tue, 5 Mar 2024 00:43:05 +0000 (09:43 +0900)]
Fix svace issue : Need to check Property::Value.Get() return

It is possible that user set invalid value type. If then, we need to skip
given value setter.

Change-Id: I8bc339f30b969c049a0b07bda152c4d24593bb48
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoLet we use legacy rounded blur algorithm for gles2.0 + remove GL keyword 17/307317/5
Eunki, Hong [Thu, 7 Mar 2024 06:21:03 +0000 (15:21 +0900)]
Let we use legacy rounded blur algorithm for gles2.0 + remove GL keyword

Since low spec device also want to use rounded blur color visual,
let we make them use some old legacy code, which required low calculation.

Change-Id: I50ad32c09da384e9ddc8a18423e67681f8824a5c
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoLock mutex when we queue offscreen texture at GlView 38/307038/2
Eunki, Hong [Mon, 4 Mar 2024 06:39:55 +0000 (15:39 +0900)]
Lock mutex when we queue offscreen texture at GlView

Change-Id: I3919c9be6dbb7cb16ef269d95a0ebab5a70711e9
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoFix code comments 11/307111/1
Eunki, Hong [Tue, 5 Mar 2024 03:57:08 +0000 (12:57 +0900)]
Fix code comments

Change-Id: Id61ceee6144d6b81e8e302785093c4b545140d91
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoFix many svace issues at dali-toolkit (integer overflow + etc) 68/307068/1
Eunki, Hong [Mon, 4 Mar 2024 07:50:23 +0000 (16:50 +0900)]
Fix many svace issues at dali-toolkit (integer overflow + etc)

This is a combination of 3 commits.

Let we remove many cases of dali-toolkit when we can be call 0u - 1u, which is undefined behavior.

Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
(Scene3D) Fix svace issue : convert uint32_t to std::streamoff + minor

Fix svace issue when we try to convert from 32bit unsigned integer
to (might) 64bit signed integer.

+

Fix the name of function collision issue

Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Fix svace issue : Avoid to divide by zero cases

Change-Id: If11884693253cd86f89cb98704e93473166faca1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoDo not call malloc during terminate 73/306873/2
Eunki, Hong [Wed, 28 Feb 2024 12:51:32 +0000 (21:51 +0900)]
Do not call malloc during terminate

There was some strange crash issue during application terminate.

That crash comes at malloc.c during destruct JsonParser.

So, let we just remove some potential of mallocate memory during terminate,
what might not neccessary.

Change-Id: I93dc70b0c069f90a94e526f7916f9c54e1565a7f
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoAssume memory allocation failed cases 12/307012/1
Eunki, Hong [Mon, 4 Mar 2024 01:54:19 +0000 (10:54 +0900)]
Assume memory allocation failed cases

Let we consider malloc return null.

Change-Id: I5bafbf1cd47880ca5bc488cea264b88d742a7861
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoImageVisualShader debug script make to add custom attribute / varying / uniform 43/306943/2
Eunki, Hong [Thu, 29 Feb 2024 05:25:04 +0000 (14:25 +0900)]
ImageVisualShader debug script make to add custom attribute / varying / uniform

Let we allow to set some extra uniform and attribute , varying if user need to debug.

Change-Id: I0c98358fe22e6678fcfa352d33c61308597bcfe0
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoDALi Version 2.3.13 83/306983/1 dali_2.3.13
Richard Huang [Fri, 1 Mar 2024 11:42:39 +0000 (11:42 +0000)]
DALi Version 2.3.13

Change-Id: I694a7fa17d2953cb73dea911f332f3276de1352d

9 months ago(Automated Tests) Use github link instead of w3 for SVG image 78/306878/1
Adeel Kazmi [Wed, 28 Feb 2024 17:43:24 +0000 (17:43 +0000)]
(Automated Tests) Use github link instead of w3 for SVG image

Change-Id: I801f86b265f0101c5c906ccfcb221c477aee9484

9 months ago(Vector) Change ConditionalWait as Mutex at lottie task 66/306766/1
Eunki, Hong [Tue, 27 Feb 2024 09:27:30 +0000 (18:27 +0900)]
(Vector) Change ConditionalWait as Mutex at lottie task

Change-Id: I1f652c440945a9b40a88a992018e14ae0746bc9d
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoChange precision of corner radius relative shader codes as highp 96/306696/2
Eunki, Hong [Mon, 26 Feb 2024 09:31:22 +0000 (18:31 +0900)]
Change  precision of corner radius relative shader codes as highp

There was some visual defect when view size is near 20,000 in target.

Change-Id: Ia9440c98e20a873664d09493cc9d645f1f7a91b1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
9 months agoMerge "Change precision of shader variable" into devel/master
Seungho BAEK [Mon, 26 Feb 2024 01:46:23 +0000 (01:46 +0000)]
Merge "Change precision of shader variable" into devel/master

10 months agoMerge "DALi Version 2.3.12" into devel/master
David Steele [Fri, 23 Feb 2024 13:32:13 +0000 (13:32 +0000)]
Merge "DALi Version 2.3.12" into devel/master

10 months agoDALi Version 2.3.12 36/306636/1 dali_2.3.12
David Steele [Fri, 23 Feb 2024 13:05:44 +0000 (13:05 +0000)]
DALi Version 2.3.12

Change-Id: I853019d9e13691b62c471ac789e010c101fca2d1

10 months agoFix Shadow crash issue during SceneOff 10/306510/2
Eunki, Hong [Thu, 22 Feb 2024 08:31:25 +0000 (17:31 +0900)]
Fix Shadow crash issue during SceneOff

Change-Id: If2e7cd12212d6207f7b9e582c8105574df0dd3c7
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoChange precision of shader variable 37/306537/2
seungho baek [Thu, 22 Feb 2024 13:08:44 +0000 (22:08 +0900)]
Change precision of shader variable

Change-Id: I4138a170c0ba9bea240a0fd0fcfab36afc2d182b
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
10 months agoMerge "Support Scene3D on gles 2.0" into devel/master
Eunki Hong [Thu, 22 Feb 2024 11:22:04 +0000 (11:22 +0000)]
Merge "Support Scene3D on gles 2.0" into devel/master

10 months agoMerge "Fix bug when we try to load two image s.t. premultyOnLoad difference" into...
Eunki Hong [Thu, 22 Feb 2024 05:59:37 +0000 (05:59 +0000)]
Merge "Fix bug when we try to load two image s.t. premultyOnLoad difference" into devel/master

10 months agoMerge "Emit ResourceReady if we call Reload even if it was ready visual." into devel...
Eunki Hong [Thu, 22 Feb 2024 05:59:29 +0000 (05:59 +0000)]
Merge "Emit ResourceReady if we call Reload even if it was ready visual." into devel/master

10 months agoMerge changes Ic9dba03a,Id5ec87c1 into devel/master
Eunki Hong [Thu, 22 Feb 2024 04:18:56 +0000 (04:18 +0000)]
Merge changes Ic9dba03a,Id5ec87c1 into devel/master

* changes:
  Print image process duration when we trace it
  Reduce the length of log during image trace

10 months agoSupport Scene3D on gles 2.0 21/305621/10
Eunki, Hong [Mon, 5 Feb 2024 10:49:19 +0000 (19:49 +0900)]
Support Scene3D on gles 2.0

Let we support Scene3D::Model under gles 2.0 devices.

Note : Since glsl doesnt support textureLod, we cannot support roughness.

Change-Id: If518bf48361331eb47b0f8a5a2ef265ba3fee488
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoAdded UNSAFE_RENDERING_DIRECT backend mode for GLView. 91/306191/6
Adam Bialogonski [Fri, 16 Feb 2024 16:11:14 +0000 (16:11 +0000)]
Added UNSAFE_RENDERING_DIRECT backend mode for GLView.

UNSAFE_RENDERING_DIRECT mode allows injecting the GL calls
directly into window context. This method is considered unsafe
and should be used cautiously as it may alter GL state of the
main DALi pipeline (ie. affect UI rendering).

Change-Id: Idd36a26541f9af56657c1eef72ee7e83e2a45581
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
10 months agoPrint image process duration when we trace it 89/306289/2
Eunki, Hong [Mon, 19 Feb 2024 13:31:11 +0000 (22:31 +0900)]
Print image process duration when we trace it

Change-Id: Ic9dba03a2f18743ea253ccf9e1234bd1bda78239
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoReduce the length of log during image trace 88/306288/2
Eunki, Hong [Mon, 19 Feb 2024 13:08:19 +0000 (22:08 +0900)]
Reduce the length of log during image trace

Change-Id: Id5ec87c10021a3d391295d88fbef2a88e1750150
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoFix bug when we try to load two image s.t. premultyOnLoad difference 84/306184/1
Eunki, Hong [Fri, 16 Feb 2024 12:54:48 +0000 (21:54 +0900)]
Fix bug when we try to load two image s.t. premultyOnLoad difference

Let we seperate cache between
"Could-be-premultiplied, but not loaded yet" VS "Do not premultiplied"

Currently, we check both of them as same item.

Change-Id: Idfb68580e5a321745ee3accf9bb61d3845a39067
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoEmit ResourceReady if we call Reload even if it was ready visual. 83/306183/1
Eunki, Hong [Fri, 16 Feb 2024 11:25:09 +0000 (20:25 +0900)]
Emit ResourceReady if we call Reload even if it was ready visual.

If the visual was already ready state, and if we call Reload, the visual state
still ResourceReady. So ResourceReady signal was not be emitted.

Since someone might need to know the timing of resource loaded after Reload(),
Make we reset status as PREPARE, and wait callback again.

Change-Id: Id0ddb6523c4d9fcd58aab63a2fb07d27fdd9c5b5
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoMerge "DALi Version 2.3.11" into devel/master
David Steele [Fri, 16 Feb 2024 11:13:11 +0000 (11:13 +0000)]
Merge "DALi Version 2.3.11" into devel/master

10 months agoDALi Version 2.3.11 63/306163/1 dali_2.3.11
Richard Huang [Fri, 16 Feb 2024 11:02:25 +0000 (11:02 +0000)]
DALi Version 2.3.11

Change-Id: Ifb9447b21d0f483c31d2658660f19c15694704a5

10 months agoMerge "Ignore corner blur radius if glsl version is low" into devel/master
Eunki Hong [Fri, 16 Feb 2024 07:17:36 +0000 (07:17 +0000)]
Merge "Ignore corner blur radius if glsl version is low" into devel/master

10 months agoTest harness sync 86/305886/3
David Steele [Mon, 12 Feb 2024 19:12:44 +0000 (19:12 +0000)]
Test harness sync

Change-Id: I480e0fb3b1f3a475ea02ec7be1599f9af36a8f18

10 months agoMerge "Let we make WebView invisible if window is hide" into devel/master
Eunki Hong [Wed, 14 Feb 2024 06:58:54 +0000 (06:58 +0000)]
Merge "Let we make WebView invisible if window is hide" into devel/master

10 months agoMerge "Make uShadowBias highp" into devel/master
Eunki Hong [Wed, 14 Feb 2024 06:58:18 +0000 (06:58 +0000)]
Merge "Make uShadowBias highp" into devel/master

10 months agoMerge changes Iafce95d1,I701627ff,Ic2b33c53 into devel/master
Eunki Hong [Wed, 14 Feb 2024 06:37:15 +0000 (06:37 +0000)]
Merge changes Iafce95d1,I701627ff,Ic2b33c53 into devel/master

* changes:
  Apply some missing shader names
  Add precompiled shader names
  Add name of shader what we generate as default

10 months agoDALi Version 2.3.10 44/305844/1 dali_2.3.10
Adeel Kazmi [Fri, 9 Feb 2024 10:11:52 +0000 (10:11 +0000)]
DALi Version 2.3.10

Change-Id: I86045f8c3be35213371476eac93fcc52d3b3b615

10 months agoMake uShadowBias highp 86/305486/2
Eunki, Hong [Fri, 2 Feb 2024 07:26:35 +0000 (16:26 +0900)]
Make uShadowBias highp

Change-Id: I29a72fb8e7a3756d7e672ec4b06a5ae86c93a5b7
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoApply some missing shader names 65/305765/1
Eunki, Hong [Wed, 7 Feb 2024 11:15:16 +0000 (20:15 +0900)]
Apply some missing shader names

Change-Id: Iafce95d1725bd05e9c64a249d3de9e565b5d761b
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoAdd precompiled shader names 06/305606/2
Eunki, Hong [Mon, 5 Feb 2024 08:54:05 +0000 (17:54 +0900)]
Add precompiled shader names

Let we allow to use precompiled shader also use shader name

Change-Id: I701627ffc53b8450e286c31b8ac8e348e2a81cb0
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoAdd name of shader what we generate as default 11/305511/5
Eunki, Hong [Fri, 2 Feb 2024 10:25:18 +0000 (19:25 +0900)]
Add name of shader what we generate as default

Let we use the feature of shader name for our dali side default shaders.

Change-Id: Ic2b33c53192075e78cb68aef0eb1401069b65e13
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoLet we make WebView invisible if window is hide 76/305376/7
Eunki, Hong [Thu, 1 Feb 2024 03:44:42 +0000 (12:44 +0900)]
Let we make WebView invisible if window is hide

Since we didn't check window visibility changed during webview is on scene
+
We don't check whether webview is on scene or not,

it could be make WebEngine keep rendering infinitly.

Let we make web engine visible only if we can assume that it is visible now.

TODO : We cannot check parent visibility changed for current system correctly,
without any overhead. Todo in future

Change-Id: I86ca4cf816eb718a45cc0b5146217eb82f373fa0
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoMerge "Make model load task priority as low" into devel/master
Eunki Hong [Tue, 6 Feb 2024 05:18:05 +0000 (05:18 +0000)]
Merge "Make model load task priority as low" into devel/master

10 months agoMerge "Create Shadow RenderTask only shadow is required." into devel/master
Seungho BAEK [Tue, 6 Feb 2024 05:17:12 +0000 (05:17 +0000)]
Merge "Create Shadow RenderTask only shadow is required." into devel/master

10 months agoIgnore corner blur radius if glsl version is low 17/305617/4
Eunki, Hong [Mon, 5 Feb 2024 10:06:34 +0000 (19:06 +0900)]
Ignore corner blur radius if glsl version is low

Let we make to not blur rounded corner if gles version is too low

Change-Id: I1ed43633d97e63a0b4d843ce692e7db28db22e0d
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoMake model load task priority as low 96/305596/1
Eunki, Hong [Mon, 5 Feb 2024 08:25:47 +0000 (17:25 +0900)]
Make model load task priority as low

Since gltf model load spend a lots of time, let we make it priority low

Change-Id: I4af0711d74b5836f4c7b039217463e13ce5c5220
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoCreate Shadow RenderTask only shadow is required. 04/305304/5
seungho baek [Wed, 31 Jan 2024 06:20:57 +0000 (15:20 +0900)]
Create Shadow RenderTask only shadow is required.

 - By using OrderIndex, Shadow RenderTask can be created only it is required.

Change-Id: I65a14ff4db167b1aa546be81f80238008322e7b5
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
10 months agoFix wrong order of linear enumeration 63/305563/3
Eunki, Hong [Mon, 5 Feb 2024 04:48:16 +0000 (13:48 +0900)]
Fix wrong order of linear enumeration

Since Fitting mode have FIT_HEIGHT = 4 and FIT_WIDTH = 5, we need to follow up the order of enum

Change-Id: I63be4fdb114be28c20716fd3eaad01f061049f92
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoMerge "Test harness sync" into devel/master
David Steele [Fri, 2 Feb 2024 16:43:30 +0000 (16:43 +0000)]
Merge "Test harness sync" into devel/master

10 months agoDALi Version 2.3.9 99/305499/1 dali_2.3.9
Adam Bialogonski [Fri, 2 Feb 2024 09:58:20 +0000 (09:58 +0000)]
DALi Version 2.3.9

Change-Id: I1800c69f074d795cb1252698c9aebb1fcd98f71e

10 months agoTest harness sync 39/305439/2
David Steele [Thu, 1 Feb 2024 14:15:23 +0000 (14:15 +0000)]
Test harness sync

Change-Id: Ic3887917d576dc81ab4d252128dc832f2ecdfbc9

10 months agoMerge "Fix decorator cursor size didn't changed issue" into devel/master
Eunki Hong [Wed, 31 Jan 2024 08:25:10 +0000 (08:25 +0000)]
Merge "Fix decorator cursor size didn't changed issue" into devel/master

10 months agoFix decorator cursor size didn't changed issue 73/305273/3
Eunki, Hong [Tue, 30 Jan 2024 12:16:41 +0000 (21:16 +0900)]
Fix decorator cursor size didn't changed issue

Since dali don't change the size during Relayout callback working,
the cursor size was not applied at 'current' relayout result.

So there was some issue that the cursor size applied well after 1 event loop working.

To avoid this issue, let we 'add' some relayout required actor to container.
It will call Relayout internally, at this loop.

TODO : Is there any other actor to be changed during relayout?

Change-Id: I88f48c7b64e76644ea8738abce4245a584c83cc9
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoFix editable text font size update issue 95/305295/2
Bowon Ryu [Wed, 31 Jan 2024 04:44:10 +0000 (13:44 +0900)]
Fix editable text font size update issue

There is an issue that the font runs of the editable text area are separated
when the font size is updated.

If the editable text is an active state and the font size is updated,
the input font size should also be updated.

And due to the feature that changes the selected area's font size when the input font size is updated,
unintended font run separation and font size change occur if there is selected text when updating the font size.

This patch fixed so that the selection-related logic is not executed
when SetInputFontPointSize is called due to an update of the default font size.

Change-Id: I1a5f5190d00a25291a8cafc215f5bf0df2cd71f7
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
10 months agoAdd editable text's idler function at PostProcessor time, instead of whenever we... 84/305184/1
Eunki, Hong [Mon, 29 Jan 2024 12:01:28 +0000 (21:01 +0900)]
Add editable text's idler function at PostProcessor time, instead of whenever we want

Since we need to remove whole queued style change signals even if idler add failed,
let we collect duplicated codes into single class, and make TextEditor / TextField just use it.

Change-Id: Ic181814eb8a4bcb12fb17c45dd39e3210bfb136a
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoDALi Version 2.3.8 94/305094/1 dali_2.3.8
David Steele [Fri, 26 Jan 2024 10:21:04 +0000 (10:21 +0000)]
DALi Version 2.3.8

Change-Id: I0c69335ab01b58af356a99eb053d524d6cb75cef

10 months agoMake we use valid geometry if broken image was n-patch and reloaded 42/304842/7
Eunki, Hong [Wed, 24 Jan 2024 07:30:56 +0000 (16:30 +0900)]
Make we use valid geometry if broken image was n-patch and reloaded

It is possible that we use broken image not matched with given visual,
and then Reload API call it, and successed.

For this case, we need to change to use valid geometry again.

Change-Id: I2df7fb8b6123361b515b8f9ac9c1fafc77f665b6
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
10 months agoMerge "Call idle functions what we might be failed to add" into devel/master
Eunki Hong [Thu, 25 Jan 2024 06:04:33 +0000 (06:04 +0000)]
Merge "Call idle functions what we might be failed to add" into devel/master

10 months agoMerge "Make ModelNode and Light as Control" into devel/master
Eunki Hong [Thu, 25 Jan 2024 04:21:52 +0000 (04:21 +0000)]
Merge "Make ModelNode and Light as Control" into devel/master

10 months agoCall idle functions what we might be failed to add 71/304671/5
Eunki, Hong [Tue, 23 Jan 2024 03:44:52 +0000 (12:44 +0900)]
Call idle functions what we might be failed to add

Since AddIdle could be failed at ecore side, we need to call given callback
synchronously, or need to print some error logs for some cases.

Change-Id: Ie0afd1fd7ddb92d43e2fdc03592144c8dae711e2
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
11 months agoMerge "Make method to get VisualUrl shorter." into devel/master
Eunki Hong [Wed, 24 Jan 2024 05:13:45 +0000 (05:13 +0000)]
Merge "Make method to get VisualUrl shorter." into devel/master

11 months agoMerge "(Scene3D) Guard cache impl will not be re-created at terminate case" into...
Eunki Hong [Wed, 24 Jan 2024 05:13:29 +0000 (05:13 +0000)]
Merge "(Scene3D) Guard cache impl will not be re-created at terminate case" into devel/master

11 months agoMerge "(Scene3D) Optimize AnimatedProperty's KeyFrame values after load complete...
David Steele [Tue, 23 Jan 2024 17:45:25 +0000 (17:45 +0000)]
Merge "(Scene3D) Optimize AnimatedProperty's KeyFrame values after load complete" into devel/master

11 months agoMerge "(Vector) Use mutex instead of ConditionalWait for EventhThreadCallback" into...
David Steele [Tue, 23 Jan 2024 15:57:55 +0000 (15:57 +0000)]
Merge "(Vector) Use mutex instead of ConditionalWait for EventhThreadCallback" into devel/master

11 months ago(Scene3D) Guard cache impl will not be re-created at terminate case 73/304673/1
Eunki, Hong [Tue, 23 Jan 2024 04:12:59 +0000 (13:12 +0900)]
(Scene3D) Guard cache impl will not be re-created at terminate case

Since LifecycleController could be called first before Model / ModelCache destroy,
re-create the image resource cache at terminate time was possible.

Since we don't check the validation of this item, it will make crash.

So let we ensure that we call those API under same thread with adaptor.

Change-Id: I995c509f070b56f99214689e5a9f3e66514d5f91
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
11 months agoMerge "Fix decorator color update issue" into devel/master
Bowon Ryu [Mon, 22 Jan 2024 09:54:06 +0000 (09:54 +0000)]
Merge "Fix decorator color update issue" into devel/master

11 months agoMake method to get VisualUrl shorter. 13/304613/1
Eunki, Hong [Mon, 22 Jan 2024 08:03:06 +0000 (17:03 +0900)]
Make method to get VisualUrl shorter.

Let we allow to get only the last 20 character of URL name
when we don't need to print full URL.

Change-Id: Id7203bff84fdf61a7950cec1c79ebce48b1a9a43
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
11 months agoFix decorator color update issue 15/304515/6
Bowon Ryu [Thu, 18 Jan 2024 09:19:17 +0000 (18:19 +0900)]
Fix decorator color update issue

After a text decorator is created,
changing the related color causes only the property to be changed.
This patch fixes an issue where the actual actor's color was not changed.

Change-Id: I4778d9a51fa0cd128e24a4362354cebb81b2b2e9
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
11 months agoMake ModelNode and Light as Control 29/303829/3
Eunki, Hong [Fri, 5 Jan 2024 10:14:23 +0000 (19:14 +0900)]
Make ModelNode and Light as Control

Since we need to use some control features (like KeyboardFocus) let we make
ModelNode and Light as Control, instead of CustomActor.

TODO : We'd better make some universion Control for Scene3D.
For example, we should not allow to add Visual into ModelNode or Light.

Change-Id: I8acbb57d967c438101fe8a1877950d044ca943f2
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
11 months ago(Vector) Use mutex instead of ConditionalWait for EventhThreadCallback 21/304221/3
Eunki Hong [Fri, 12 Jan 2024 06:25:03 +0000 (15:25 +0900)]
(Vector) Use mutex instead of ConditionalWait for EventhThreadCallback

Since worker thread can call AddEventTriggerCallback freely,

we should make some lock between workerthread and
main thread(RemoveEventTriggerCallbacks, GetNextEventCallback, ~VectorAnimationThread).

ConditionalWait used only for AsyncTask rasterization, and sleep thread.
We'd better seperate those job locker.

Change-Id: I543ba7f0bdf54036a8127d1815dda18cafca54e7
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
11 months ago(Scene3D) Optimize AnimatedProperty's KeyFrame values after load complete 01/304401/2
Eunki, Hong [Wed, 17 Jan 2024 02:54:38 +0000 (11:54 +0900)]
(Scene3D) Optimize AnimatedProperty's KeyFrame values after load complete

Let we reduce the total key frame of MotionValue what we parse.

Since both json and bvh store the data by framerate.
So, there might be useless values are included.

If the number of keyframe is large, it might give some overhead to core.
So let we reduce useless keyframe for MotionValue and Model's internal animation.

Change-Id: I04b86b0341125cef1f60d3da68150c9367655169
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
11 months agoMerge "DALi Version 2.3.7" into devel/master
Adeel Kazmi [Fri, 19 Jan 2024 10:18:24 +0000 (10:18 +0000)]
Merge "DALi Version 2.3.7" into devel/master

11 months agoDALi Version 2.3.7 55/304555/1 dali_2.3.7
Adam Bialogonski [Fri, 19 Jan 2024 09:52:26 +0000 (09:52 +0000)]
DALi Version 2.3.7

Change-Id: I7a03929416d3d91b37b6c350885fd96bfb1c85b2

11 months agoTest harness update. 80/304180/3
Adam Bialogonski [Thu, 11 Jan 2024 11:04:54 +0000 (11:04 +0000)]
Test harness update.

"uColor" uniform added as first.
Custom uniforms are added before default uniforms in the reflection.

Change-Id: Ifb837b5e18c80afb94f24cf9372c5c60d840b477
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
11 months agoMerge "Remove cubemap cache temperary + Fix bug when Uploaded PixelData resue after...
Adeel Kazmi [Wed, 17 Jan 2024 12:27:28 +0000 (12:27 +0000)]
Merge "Remove cubemap cache temperary + Fix bug when Uploaded PixelData resue after Texture GC" into devel/master

11 months agoMerge "Change Property name USE_FIXED_CACHE to ENABLE_FRAME_CACHE" into devel/master
sunghyun kim [Mon, 15 Jan 2024 06:20:30 +0000 (06:20 +0000)]
Merge "Change Property name USE_FIXED_CACHE to ENABLE_FRAME_CACHE" into devel/master

11 months agoRemove cubemap cache temperary + Fix bug when Uploaded PixelData resue after Texture GC 51/304251/4
Eunki Hong [Sat, 13 Jan 2024 00:28:27 +0000 (09:28 +0900)]
Remove cubemap cache temperary + Fix bug when Uploaded PixelData resue after Texture GC

If we create NewPixelDataWithReleaseAfterUpload and Upload to texture,
and if that texture reference count become 1 and GC,
the key of PixelData is not valid anymore.

To avoid this cases, Let we collect all PixelData container if some texture removed.
And also, since PixelData could be key of Texture cache, we should check the
reference count is less than 2.

+

Since current cubemap cache not works well reasonable, just remove it.
We will reopen it after we implement PixelDataList cache system again.

+

Print more log information if we need.

Change-Id: I6693ceab9b03cc20e1c6a42282ef39af38344e27
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
11 months agoMerge "DALi Version 2.3.6" into devel/master
Adeel Kazmi [Fri, 12 Jan 2024 11:40:06 +0000 (11:40 +0000)]
Merge "DALi Version 2.3.6" into devel/master

11 months agoDALi Version 2.3.6 35/304235/1 dali_2.3.6
Richard Huang [Fri, 12 Jan 2024 11:16:42 +0000 (11:16 +0000)]
DALi Version 2.3.6

Change-Id: Ifc29588cd2df64ed6acb4412eeb9449a2e41d4ab

11 months agoMerge "Fix bug that IBLFactor / Roughness not works well when we change material...
David Steele [Fri, 12 Jan 2024 10:34:36 +0000 (10:34 +0000)]
Merge "Fix bug that IBLFactor / Roughness not works well when we change material" into devel/master

11 months agoChange Property name USE_FIXED_CACHE to ENABLE_FRAME_CACHE 09/304209/2
sunghyun kim [Fri, 12 Jan 2024 05:21:31 +0000 (14:21 +0900)]
Change Property name USE_FIXED_CACHE to ENABLE_FRAME_CACHE

existing name is ambiguous in meaning, so we change it to a more clear name.

Change-Id: I8a797dee0378ffbc6ab2547f63d9360f8a2da2b5

11 months agoMerge "Fix Text Anchor don't work properly" into devel/master
Chihun Jeong [Fri, 12 Jan 2024 03:23:21 +0000 (03:23 +0000)]
Merge "Fix Text Anchor don't work properly" into devel/master

11 months agoFix Text Anchor don't work properly 82/304182/2
ANZ1217 [Thu, 11 Jan 2024 11:36:48 +0000 (20:36 +0900)]
Fix Text Anchor don't work properly

When the text component is vertical aligned as center or bottom,
The y offset was not calculated at anchor event.
Now, it works properly.

Change-Id: I31f2530122d28e07a32c8a75875a77bcc69353ee

11 months agoFix bug that IBLFactor / Roughness not works well when we change material 44/303844/5
Eunki Hong [Fri, 5 Jan 2024 16:01:50 +0000 (01:01 +0900)]
Fix bug that IBLFactor / Roughness not works well when we change material

There was some bug when we change Material info, uMaxLOD and uIblIntensity does not applied what primitive has.

This is because Material's SetUniform API overwrite the value of those uniform.

This patch make we ensure the order of uniform register, so let we use correct LOD and IBL intensity.

Change-Id: Ic14b7f9b6c0e443ac17188a8968ac71a7c6328d6
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
11 months agoRemove build warning at gcc-13 53/304053/3
Eunki Hong [Tue, 9 Jan 2024 13:13:26 +0000 (22:13 +0900)]
Remove build warning at gcc-13

Remove build warning when we build dali-csharp-binder by gcc-13

Change-Id: Ib331ca7ce62ff54d0db5311bcf9420e1b6e1cd0e
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
11 months agoMerge "Fix the 3D model rendering issue after the KHR_texture_transform extension...
Adeel Kazmi [Wed, 10 Jan 2024 11:13:20 +0000 (11:13 +0000)]
Merge "Fix the 3D model rendering issue after the KHR_texture_transform extension support" into devel/master

11 months agoMerge "Improve Textfit performance" into devel/master
Chihun Jeong [Wed, 10 Jan 2024 07:54:33 +0000 (07:54 +0000)]
Merge "Improve Textfit performance" into devel/master

11 months agoImprove Textfit performance 02/303502/16
ANZ1217 [Fri, 29 Dec 2023 01:01:13 +0000 (10:01 +0900)]
Improve Textfit performance

We can assume point size of text and size of text's layout
are directly proportional.
So the size of the largest text point size
can be calculated by O(1) operations.
Previously, this was O(logn) operations.

Change-Id: Ie5aae28e949738ce0f67e389f3e920663f4e19bc

11 months agoFix svace issue 90/304090/1
jmm [Wed, 10 Jan 2024 03:44:49 +0000 (12:44 +0900)]
Fix svace issue

Change-Id: I2646aae8db36a5471915e6ee4101beef4a51c9ba