platform/core/connectivity/net-config.git
5 years ago[net-config] Manage the MAX saved wireless profiles. 74/215774/2
prashanth kumar [Tue, 15 Oct 2019 09:12:18 +0000 (14:42 +0530)]
[net-config] Manage the MAX saved wireless profiles.

If the number of saved profiles exceed 200, remove the
oldest profile in the list.

Change-Id: Ic0a2fc850f13f44f3191efe9bb8e2aa7f13cd911
Signed-off-by: prashanth kumar <prasadam.p@samsung.com>
5 years agoMerge "Add battery monitor framework" into tizen accepted/tizen/unified/20191017.072557 submit/tizen/20191014.104721 submit/tizen/20191016.060650
Jaehyun Kim [Mon, 14 Oct 2019 09:50:03 +0000 (09:50 +0000)]
Merge "Add battery monitor framework" into tizen

5 years agoAdd battery monitor framework 08/215408/2
hyunuk.tak [Wed, 14 Aug 2019 08:36:46 +0000 (17:36 +0900)]
Add battery monitor framework

Change-Id: Iaccffa57e6ce5d0fb8ce8112452c6893fcd232f8
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
5 years agoMerge "Refactoring sd->timer_id for ip-conflict-detect code" into tizen
Jaehyun Kim [Mon, 14 Oct 2019 07:24:21 +0000 (07:24 +0000)]
Merge "Refactoring sd->timer_id for ip-conflict-detect code" into tizen

5 years agoMerge "Using updated clatd's Dbus interface and Path values" into tizen
Jaehyun Kim [Mon, 14 Oct 2019 07:22:37 +0000 (07:22 +0000)]
Merge "Using updated clatd's Dbus interface and Path values" into tizen

5 years agoFix Coverity issues 64/215664/3 accepted/tizen/unified/20191015.011952 submit/tizen/20191014.071714
Jihoon Jung [Mon, 14 Oct 2019 14:49:14 +0000 (23:49 +0900)]
Fix Coverity issues

- Resource leak : 1087883, 1087991, 1087992

Change-Id: Ic3191b2c5aac190d48537cc6b03ccbb5a33f2158
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
5 years agoRefactoring sd->timer_id for ip-conflict-detect code 34/215334/1
INSUN PYO [Mon, 7 Oct 2019 06:11:16 +0000 (15:11 +0900)]
Refactoring sd->timer_id for ip-conflict-detect code

0  0xb6ab5634 in raise () from /lib/libpthread.so.0
1  0xb6c23774 in g_logv (log_domain=0xb6c23774 <g_logv+772> "\300\377\377\352", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x5 <error: Cannot access memory at address 0x5>, args=..., args@entry=...) at gmessages.c:1357
2  0xb6c23824 in g_log (log_domain=<optimized out>, log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=0xb6c73a7c "%s: assertion '%s' failed") at gmessages.c:1398
3  0xb6c23dc0 in g_return_if_fail_warning (log_domain=<optimized out>, pretty_function=<optimized out>, expression=<optimized out>) at gmessages.c:2688
4  0xb6c1b374 in g_source_remove (tag=0) at gmain.c:2351
5  0xb6f46058 in send_arp (data=0xb79817d0) at /usr/src/debug/net-config-1.1.146/src/ip-conflict-detect.c:363
6  0xb6f46468 in start_ip_conflict_mon () at /usr/src/debug/net-config-1.1.146/src/ip-conflict-detect.c:408
7  0xb6f3c34c in _service_signal_cb (conn=<optimized out>, name=<optimized out>, path=<optimized out>, interface=<optimized out>, sig=0xb5231540 "", param=0xb5236298, user_data=0x0) at /usr/src/debug/net-config-1.1.146/src/signal-handler.c:447
8  0xb6dec980 in emit_signal_instance_in_idle_cb (data=0xb52074c8) at gdbusconnection.c:4660
9  0xb6c1c654 in g_main_dispatch (context=0xb7960d70) at gmain.c:3234
10 g_main_context_dispatch (context=context@entry=0xb7960d70) at gmain.c:3887
11 0xb6c1c9e4 in g_main_context_iterate (context=0xb7960d70, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3960
12 0xb6c1cd44 in g_main_loop_run (loop=0xb795e3c0) at gmain.c:4156
13 0xb6f21a20 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/net-config-1.1.146/src/main.c:152

Change-Id: I59d0eb7dc0b1e4ce5eed8795c2d25a8ca8c31ad0

5 years agoAdd logic for Device Provisioning Protocol(DPP) 44/212344/14 accepted/tizen/unified/20191007.234802 submit/tizen/20190927.130602 submit/tizen/20191001.114836
Yu [Tue, 24 Sep 2019 06:46:17 +0000 (15:46 +0900)]
Add logic for Device Provisioning Protocol(DPP)

Description : Currently, there's problem that
DPP operation is working with only P2P Wi-Fi interface.
Change-Id: I7e7285a453ecbf1f5b352c97962f752e2482ef2f
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
5 years agoUsing updated clatd's Dbus interface and Path values 97/214597/1
Nishant Chaprana [Tue, 24 Sep 2019 09:04:15 +0000 (14:34 +0530)]
Using updated clatd's Dbus interface and Path values

Change-Id: I6c5228f6e09d261c9cf624f97a4d484267a29edd
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoAdded NameOwnerChanged signal handling for clatd service. 39/212439/3
Niraj Kumar Goit [Wed, 21 Aug 2019 11:04:24 +0000 (16:34 +0530)]
Added NameOwnerChanged signal handling for clatd service.

If cellular profile is connected and clatd is terminated unexpectedly,
restart clat service.

Change-Id: Ic9a90db97fe6a8d6cefc52145496e55eb3394c17
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoGet cellular IPv6 profile and then enable clatd. 55/212255/2
Niraj Kumar Goit [Mon, 19 Aug 2019 09:34:19 +0000 (15:04 +0530)]
Get cellular IPv6 profile and then enable clatd.

Change-Id: I9daac7bd93b6c796657faebd5a87abba99b8a29f
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoAdded support to enable clatd service 94/212194/2
Jaehyun Kim [Fri, 16 Aug 2019 13:13:16 +0000 (22:13 +0900)]
Added support to enable clatd service

Change-Id: I943f9e5be057a1dc9959f7a36e00397777b6bd45
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoMerge "Added parsing of netlink scan results for WEP encryption." into tizen accepted/tizen/unified/20190819.005832 submit/tizen/20190816.125549
Jaehyun Kim [Fri, 16 Aug 2019 12:51:49 +0000 (12:51 +0000)]
Merge "Added parsing of netlink scan results for WEP encryption." into tizen

5 years agoMerge "Delete meaningless configuration" into tizen submit/tizen/20190805.112919
Jaehyun Kim [Mon, 5 Aug 2019 11:28:22 +0000 (11:28 +0000)]
Merge "Delete meaningless configuration" into tizen

5 years agoMerge "Remove unused features" into tizen accepted/tizen/unified/20190711.132631 submit/tizen/20190711.085116
Jaehyun Kim [Thu, 11 Jul 2019 08:50:22 +0000 (08:50 +0000)]
Merge "Remove unused features" into tizen

5 years agoDelete meaningless configuration 00/209500/1
INSUN PYO [Mon, 8 Jul 2019 10:25:56 +0000 (19:25 +0900)]
Delete meaningless configuration

Change-Id: I0a8a0107f697e88d3ccd35f620dbd58fd4bacc60

5 years agoRemove dependency on gmock in main rpm 76/209276/2 accepted/tizen/unified/20190705.041543 submit/tizen/20190704.111037
Cheoleun Moon [Thu, 4 Jul 2019 07:53:09 +0000 (16:53 +0900)]
Remove dependency on gmock in main rpm

Change-Id: I7a7aaa7470819e743781492d5b98c7369e4a7a01
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
5 years agoRemove unused features 03/209103/1
INSUN PYO [Tue, 2 Jul 2019 07:44:35 +0000 (16:44 +0900)]
Remove unused features

Change-Id: If803e311550571f26a8e55c521b720b887557947

5 years agoAdd to get passphrase string from config 65/208365/2 accepted/tizen/unified/20190703.110716 submit/tizen/20190702.113133
hyunuktak [Mon, 24 Jun 2019 01:36:50 +0000 (10:36 +0900)]
Add to get passphrase string from config

Change-Id: Idb2a16d46551edf765d8fc8a100def5ef5eb0268
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
5 years agoInitialized variable "iv_buf" and "aad_buf" to handle key-manager failure case 16/208116/1 accepted/tizen/unified/20190624.075218 submit/tizen/20190621.094817
Jaehyun Kim [Tue, 18 Jun 2019 11:13:27 +0000 (20:13 +0900)]
Initialized variable "iv_buf" and "aad_buf" to handle key-manager failure case

Change-Id: Ia7d1e123accaeb367fff7cb2aba577ecc46a8ebd
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoCombine dbus policy rules regarding the same priv (http://tizen.org/privilege/vpnservice) 53/207753/1 accepted/tizen/unified/20190617.061748 submit/tizen/20190614.050629
Hyotaek Shim [Wed, 12 Jun 2019 04:45:45 +0000 (13:45 +0900)]
Combine dbus policy rules regarding the same priv (tizen.org/privilege/vpnservice)

Change-Id: If1259fe9c248d937d0158f2cb4982d644fde7f38
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
5 years agoRemove invalid command from net-config_tv.service file 29/206729/1 accepted/tizen/unified/20190605.215653 submit/tizen/20190604.083831
Jaehyun Kim [Fri, 24 May 2019 04:47:13 +0000 (13:47 +0900)]
Remove invalid command from net-config_tv.service file

Change-Id: I691d263f7fff7678adf8ff98816d911b61ab26b7
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoMerge "Use libnl-3.0 in place of libnl-2.0" into tizen submit/tizen/20190520.082305
Jaehyun Kim [Mon, 20 May 2019 08:09:11 +0000 (08:09 +0000)]
Merge "Use libnl-3.0 in place of libnl-2.0" into tizen

5 years agoUse libnl-3.0 in place of libnl-2.0 47/205247/1
Nishant Chaprana [Wed, 1 May 2019 05:17:51 +0000 (10:47 +0530)]
Use libnl-3.0 in place of libnl-2.0

Change-Id: Ied635188934919066c973328248ad494a997a1b3
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoAdd more padding for arp packets 98/204698/3 accepted/tizen/unified/20190429.103809 submit/tizen/20190426.010452 submit/tizen/20190429.011734 submit/tizen/20190429.011734submit/tizen/20190429.011734
Cheoleun Moon [Fri, 26 Apr 2019 00:22:26 +0000 (09:22 +0900)]
Add more padding for arp packets

The minimum size of ethernet frame is 512 bits (64 octets).
It is required for correct CSMA/CD protocol operation.
(ref: 4.2.3.3 and 4.4.2, IEEE Std 802.3-2018)

dev_validate_header() in linux/net/packet/af_packet.c checks the frame size
and sendto() returns EINVAL if it returns false.

Change-Id: If42738cb796e4827ae396bc1b4f596c2c498bf65
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
5 years agoDo not close socket twice 47/204447/2
Cheoleun Moon [Wed, 24 Apr 2019 04:50:56 +0000 (13:50 +0900)]
Do not close socket twice

g_io_channel_shutdown closes the fd of the channel.

Change-Id: Iebb2f2eb3421094fc573ba859a65c2b18e86fbcc
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
5 years agoFix code style 72/203672/4 accepted/tizen/unified/20190425.111815 submit/tizen/20190422.081829
Cheoleun Moon [Wed, 17 Apr 2019 01:02:39 +0000 (10:02 +0900)]
Fix code style

Change-Id: I541c2e466d81748420262960e71a1a33436f2821
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
5 years agoUnref gio channel before closing socket 91/203591/5 accepted/tizen/unified/20190417.050125 submit/tizen/20190416.101341
Seonah Moon [Tue, 16 Apr 2019 06:12:53 +0000 (15:12 +0900)]
Unref gio channel before closing socket

Change-Id: Ia8166741abbe3c8a674e6e8a7bd2027a5db37057

5 years agoRemove mptcp files from security-network-config.conf 23/201223/1 accepted/tizen/unified/20190312.113110 submit/tizen/20190312.001056
Seonah Moon [Mon, 11 Mar 2019 10:46:43 +0000 (19:46 +0900)]
Remove mptcp files from security-network-config.conf

net-config has capabilities to access mptcp system files.

Change-Id: Ia418df7025d29c5d6c0fd5cf4e9ec11afc9add00

5 years agoMerge "Handle ethernet profile to set a default connection when init time" into tizen accepted/tizen/unified/20190129.064341 submit/tizen/20190128.124207
Jaehyun Kim [Mon, 28 Jan 2019 12:39:33 +0000 (12:39 +0000)]
Merge "Handle ethernet profile to set a default connection when init time" into tizen

5 years agoFix some svace issues for memory leak and checking return value 74/197874/1 submit/tizen/20190122.114357 submit/tizen/20190123.120140
hyunuktak [Thu, 17 Jan 2019 01:38:23 +0000 (10:38 +0900)]
Fix some svace issues for memory leak and checking return value

Change-Id: I515dbd75441176e234a97188762ccaf8af4d3016
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
5 years agoDisable TIZEN_DEBUG_ENABLE 63/197063/1 submit/tizen/20190109.071519
Seonah Moon [Wed, 9 Jan 2019 07:05:50 +0000 (16:05 +0900)]
Disable TIZEN_DEBUG_ENABLE

Change-Id: Iaf86277edaaaecd86d4b4bf34cbdb5202951b47d

5 years agoHandle ethernet profile to set a default connection when init time 09/196909/1
Jaehyun Kim [Mon, 7 Jan 2019 13:40:00 +0000 (22:40 +0900)]
Handle ethernet profile to set a default connection when init time

Change-Id: I4d96d37fba47c038d592c66272451b6e1a77ec4d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoAdded parsing of netlink scan results for WEP encryption. 73/196773/1
Niraj Kumar Goit [Fri, 4 Jan 2019 06:53:57 +0000 (12:23 +0530)]
Added parsing of netlink scan results for WEP encryption.

Change-Id: I23adcb76555af77891728d70e7a513763928a75c
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoFixed format error 48/195648/2 accepted/tizen/unified/20181219.063354 submit/tizen/20181218.125545
hyunuktak [Mon, 17 Dec 2018 04:57:52 +0000 (13:57 +0900)]
Fixed format error

Change-Id: I92d6c7bac6d2c49fc138f0d19174b2ec7603ffe7
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>
5 years agoMerge "Fixed memory related issues reported by valgrind." into tizen submit/tizen/20181211.041735 submit/tizen/20181214.044953
cheoleun moon [Tue, 11 Dec 2018 04:17:10 +0000 (04:17 +0000)]
Merge "Fixed memory related issues reported by valgrind." into tizen

5 years agoMerge "g_free 'field' and 'value' if you break out of a while loop." into tizen
cheoleun moon [Tue, 11 Dec 2018 04:17:07 +0000 (04:17 +0000)]
Merge "g_free 'field' and 'value' if you break out of a while loop." into tizen

5 years agoFix dlog format error 74/195074/2 submit/tizen/20181210.103434
Seonah Moon [Mon, 10 Dec 2018 10:18:40 +0000 (19:18 +0900)]
Fix dlog format error

Change-Id: Ifa907a3cc5940157c05934bd0b92dfa58b51ee45

5 years agoFixed memory related issues reported by valgrind. 41/194841/1
Niraj Kumar Goit [Fri, 7 Dec 2018 10:02:56 +0000 (15:32 +0530)]
Fixed memory related issues reported by valgrind.

==1191== Invalid read of size 4
==1191==    at 0x4AF034C: g_variant_unref (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x49677AF: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x4A232F3: g_object_unref (in /usr/lib/libgobject-2.0.so.0.5200.2)
==1191==    by 0x4973A33: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x497555B: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x4928777: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x49287AB: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x4AB08E7: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AB0C77: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AB0FD7: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x497389F: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==1191==    by 0x4AD9B3B: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==  Address 0x86ac014 is 20 bytes inside a block of size 24 free'd
==1191==    at 0x4846EC8: free (vg_replace_malloc.c:530)
==1191==    by 0x113FFD: __netconfig_wifi_bssid_create_interface (wifi-bssid-scan.c:454)
==1191==    by 0x113FFD: __netconfig_wifi_bssid_scan (wifi-bssid-scan.c:486)
==1191==    by 0x113FFD: handle_request_bssid_scan (wifi-bssid-scan.c:529)
==1191==    by 0x4E45AF7: ffi_call_SYSV (in /usr/lib/libffi.so.6.0.2)
==1191==  Block was alloc'd at
==1191==    at 0x48458A4: malloc (vg_replace_malloc.c:299)
==1191==    by 0x4AB61B3: g_malloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4ACF4A3: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AF01EF: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AEC8E7: g_variant_builder_end (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AEE6C7: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AEE9FF: g_variant_new_va (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x4AEEAC3: g_variant_new (in /usr/lib/libglib-2.0.so.0.5200.2)
==1191==    by 0x113FB7: __netconfig_wifi_bssid_create_interface (wifi-bssid-scan.c:438)
==1191==    by 0x113FB7: __netconfig_wifi_bssid_scan (wifi-bssid-scan.c:486)
==1191==    by 0x113FB7: handle_request_bssid_scan (wifi-bssid-scan.c:529)
==1191==    by 0x4E45AF7: ffi_call_SYSV (in /usr/lib/libffi.so.6.0.2)

Change-Id: If9fa9f2a0e6e2b6f201a486d333ed153c0581b98
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoRemove GSource before calling g_timeout_add() 62/194462/1 accepted/tizen/unified/20181205.154818 submit/tizen/20181205.011946
Cheoleun Moon [Tue, 4 Dec 2018 23:19:04 +0000 (08:19 +0900)]
Remove GSource before calling g_timeout_add()

Change-Id: I4f7af8297b298496e31577c381fd02b1024a0f23
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
5 years agog_free 'field' and 'value' if you break out of a while loop. 66/194266/1
Niraj Kumar Goit [Thu, 29 Nov 2018 13:50:30 +0000 (19:20 +0530)]
g_free 'field' and 'value' if you break out of a while loop.

g_free 'field' and 'value' if you break out of a while loop
using g_variant_iter_loop()

Change-Id: I4d76f723d9cedb3772a0f86db97152077cbfe7be
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoFix svace issue [WGID: 378746]. 12/193312/2 accepted/tizen/unified/20181122.160707 submit/tizen/20181122.014958
Niraj Kumar Goit [Mon, 19 Nov 2018 07:13:20 +0000 (12:43 +0530)]
Fix svace issue [WGID: 378746].

Use strerror_r function instead of strerror for thread safety.

Change-Id: Ib75cded4baaab3ae1862e594f409df9ec6511e71
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoMerge "[net-config] Suspend/Resume WLAN driver" into tizen accepted/tizen/unified/20181107.081842 submit/tizen/20181105.105104
cheoleun moon [Mon, 5 Nov 2018 10:50:39 +0000 (10:50 +0000)]
Merge "[net-config] Suspend/Resume WLAN driver" into tizen

6 years agoStart IP conflict monitoring only after default profile has been updated 35/191735/1 submit/tizen/20181023.084114
Abhishek Sansanwal [Tue, 23 Oct 2018 05:52:06 +0000 (11:22 +0530)]
Start IP conflict monitoring only after default profile has been updated

Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
Change-Id: I113a4f033a5bb398a494195fb4de11957cd7e7ff

6 years agoCreate temporary file to check wifi firmware state #3 92/191692/1 submit/tizen/20181022.095216
Seonah Moon [Mon, 22 Oct 2018 09:31:20 +0000 (18:31 +0900)]
Create temporary file to check wifi firmware state #3

Change-Id: I174f255dc49f2883b5ddc945e4375720327dc820

6 years agoCreate temporary file to check wifi firmware state #2 89/191689/1 submit/tizen/20181022.091718
Seonah Moon [Mon, 22 Oct 2018 09:03:40 +0000 (18:03 +0900)]
Create temporary file to check wifi firmware state #2

Change-Id: I8c2c4d287021f6b0b76fa23d947e98e32995f1c8

6 years agoCreate temporary file to check wifi firmware state 63/191363/2 submit/tizen/20181022.053844
Seonah Moon [Tue, 16 Oct 2018 08:32:29 +0000 (17:32 +0900)]
Create temporary file to check wifi firmware state

If net-config is finished unexpectly, it restarts.
And then wifi firmware is downloaded although it is already loaded.

This patch creates the file to check whether wifi firmware is loaded or not.

Change-Id: I4d8dbc4538d28d2c0eef7f945947bf007e47c73d

6 years agoChange signal level policy 75/190675/1 accepted/tizen/5.0/unified/20181102.015009 accepted/tizen/unified/20181010.061706 submit/tizen/20181004.140159 submit/tizen/20181005.071221 submit/tizen_5.0/20181101.000003
Jaehyun Kim [Thu, 4 Oct 2018 13:09:39 +0000 (22:09 +0900)]
Change signal level policy

Change-Id: I41b9e45518c1198b16b7208f2918999418c41ca2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoFixed incorrect comparision and memory leaks 46/189546/2 accepted/tizen/unified/20180919.061656 submit/tizen/20180919.023413
Saurav Babu [Tue, 18 Sep 2018 11:14:04 +0000 (16:44 +0530)]
Fixed incorrect comparision and memory leaks

This patch fixes incorrect comparion for GVariantType and also fixes
memory leak reported by valgrind
==9934== 20 bytes in 2 blocks are definitely lost in loss record 1,388 of 2,620
==9934==    at 0x48458A4: malloc (vg_replace_malloc.c:299)
==9934==    by 0x4AB21B3: g_malloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==9934==    by 0x4ACCF03: g_strdup (in /usr/lib/libglib-2.0.so.0.5200.2)
==9934==    by 0x123CEB: __netconfig_get_default_connection_info (network-state.c:409)
==9934==    by 0x124933: netconfig_update_default_profile (network-state.c:1210)
==9934==    by 0x1290AD: _service_signal_cb (signal-handler.c:358)
==9934==    by 0x4957997: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==9934==    by 0x4AAC8E7: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5200.2)
==9934==    by 0x4AACC77: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==9934==    by 0x4AACFD7: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5200.2)
==9934==    by 0x10F649: main (main.c:152)

Change-Id: I4e9791440ce4bc28968add19816d9e664cea9e62
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
6 years agoMerge "Added support to set and get prefix length." into tizen submit/tizen/20180918.091131
Jaehyun Kim [Tue, 18 Sep 2018 07:49:49 +0000 (07:49 +0000)]
Merge "Added support to set and get prefix length." into tizen

6 years agoFix coverity(1025915) issue. 11/189411/1
Niraj Kumar Goit [Mon, 17 Sep 2018 11:07:39 +0000 (16:37 +0530)]
Fix coverity(1025915) issue.

Added check on prefix length to fix bad bit shift issue.

Change-Id: I9402ef63b03f7e63a1a54d954c6f74e42d460330
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoAdded support to set and get prefix length. 64/189264/1
Niraj Kumar Goit [Fri, 14 Sep 2018 15:21:48 +0000 (20:51 +0530)]
Added support to set and get prefix length.

Added support to set and get prefix length from configuration file.

Change-Id: I17144c9a6a515ad8efcbc5ae2ca5199ef56cbcdb
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoRevert "Added support to add ipv6 route using netlink." 75/189075/1
Seonah Moon [Thu, 13 Sep 2018 07:15:27 +0000 (16:15 +0900)]
Revert "Added support to add ipv6 route using netlink."

This reverts commit cb573910888d91558cf3d2beb28187850eccc9ad.

Change-Id: I4e11785eb874be44dfe2988d7902aae9d1ccd514

6 years agoRevert "Added support to delete ipv6 route using netlink." 74/189074/1
Seonah Moon [Thu, 13 Sep 2018 07:14:36 +0000 (16:14 +0900)]
Revert "Added support to delete ipv6 route using netlink."

This reverts commit a259e3e99a5382699c19fc50288bf46eb03f18a4.

Change-Id: I488cb1554159ac05edfdcd6e2c8640bdf9ff78de

6 years agoMerge "Modify HAL TC to support wearable environment" into tizen accepted/tizen/unified/20180912.061658 submit/tizen/20180911.120738
Jaehyun Kim [Tue, 11 Sep 2018 12:05:59 +0000 (12:05 +0000)]
Merge "Modify HAL TC to support wearable environment" into tizen

6 years agoAdd feature check code for softap 97/188897/2
Seonah Moon [Tue, 11 Sep 2018 11:45:00 +0000 (20:45 +0900)]
Add feature check code for softap

Change-Id: If02dfe0bb3983bf0f969ddc4611fcb76583f86b7

6 years agoModify HAL TC to support wearable environment 96/188896/1
Jaehyun Kim [Tue, 11 Sep 2018 11:30:46 +0000 (20:30 +0900)]
Modify HAL TC to support wearable environment

Change-Id: I7e9d3332387ffbb51ea15e42bbad9346aa1c4c31
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoFix coverity issue (1025915). 88/188888/1
Niraj Kumar Goit [Tue, 11 Sep 2018 09:54:07 +0000 (15:24 +0530)]
Fix coverity issue (1025915).

Change-Id: I51b5cab5bc94232c7a389a5632863cb75cc23c79
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoSupport Softap feature in HAL TC 36/188836/1
Jaehyun Kim [Tue, 11 Sep 2018 04:17:50 +0000 (13:17 +0900)]
Support Softap feature in HAL TC

Change-Id: I9592e806316f725f3a5f62cf9cbd808049fbb82e
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoAdded exception handling for unsupported features in HAL TC 32/188832/1
Jaehyun Kim [Tue, 11 Sep 2018 04:09:12 +0000 (13:09 +0900)]
Added exception handling for unsupported features in HAL TC

Change-Id: I3144d40e4c2801d798c9563c468157001c74d222
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoFixed memory leaks 04/188804/1 accepted/tizen/unified/20180911.055420 submit/tizen/20180910.131901
Saurav Babu [Mon, 10 Sep 2018 10:46:34 +0000 (16:16 +0530)]
Fixed memory leaks

g_variant_builder_new() allocates memory and should be freed using
g_variant_builder_unref().
Below is the valgrind report:
==6712== 72 bytes in 1 blocks are definitely lost in loss record 2,933 of 3,062
==6712==    at 0x48458A4: malloc (vg_replace_malloc.c:299)
==6712==    by 0x4AB21B3: g_malloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4ACB4A3: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AE82BF: g_variant_builder_new (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x1236F1: __netconfig_update_default_connection_info (network-state.c:797)
==6712==    by 0x125727: netconfig_update_default_profile (network-state.c:1206)
==6712==    by 0x12AA1D: _service_signal_cb (signal-handler.c:355)
==6712==    by 0x4957997: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==6712==    by 0x4AAC8E7: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AACC77: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AACFD7: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x10F9F9: main (main.c:152)
==6712==
==6712== 72 bytes in 1 blocks are definitely lost in loss record 2,934 of 3,062
==6712==    at 0x48458A4: malloc (vg_replace_malloc.c:299)
==6712==    by 0x4AB21B3: g_malloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4ACB4A3: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AE82BF: g_variant_builder_new (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x123A8D: __netconfig_update_default_connection_info (network-state.c:764)
==6712==    by 0x125923: netconfig_update_default_profile (network-state.c:1193)
==6712==    by 0x12B71F: _service_signal_cb (signal-handler.c:399)
==6712==    by 0x4957997: ??? (in /usr/lib/libgio-2.0.so.0.5200.2)
==6712==    by 0x4AAC8E7: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AACC77: ??? (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x4AACFD7: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5200.2)
==6712==    by 0x10F9F9: main (main.c:152)

Change-Id: I2306aaa418fb04d29f7f717a25c0abe4bf47dc30
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
6 years ago[net-config] Suspend/Resume WLAN driver 07/188607/1
Mayank Haarit [Thu, 6 Sep 2018 11:49:53 +0000 (17:19 +0530)]
[net-config] Suspend/Resume WLAN driver

This patch suspend and resume wlan driver as
per below action :
1) On LCD ON/OFF state change callback
2) On the basis of current service state

Change-Id: I90d2b67c5d6fa6be80421c5bf817aefccdc3fe88
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
6 years agoMerge "Fixed crash in accessing non allocated memory" into tizen accepted/tizen/unified/20180907.043103 submit/tizen/20180906.090023
Jaehyun Kim [Thu, 6 Sep 2018 08:58:31 +0000 (08:58 +0000)]
Merge "Fixed crash in accessing non allocated memory" into tizen

6 years agoFixed crash in accessing non allocated memory 64/188564/2
Saurav Babu [Thu, 6 Sep 2018 06:23:21 +0000 (11:53 +0530)]
Fixed crash in accessing non allocated memory

In _load_configuration() config->ip_info was accessed without checking
if it was allocated. This patch ensures that config->ip_info is always
allocated when passing in _load_configuration() function.

Change-Id: I61c5bc168915b9d4f4f6ba976132cfcf3836753f
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
6 years agoMerge "Fixed memory leak" into tizen submit/tizen/20180904.110831
Jaehyun Kim [Tue, 4 Sep 2018 11:07:09 +0000 (11:07 +0000)]
Merge "Fixed memory leak" into tizen

6 years agoMerge "Added support to set and get IP configuration details." into tizen
Jaehyun Kim [Tue, 4 Sep 2018 11:06:03 +0000 (11:06 +0000)]
Merge "Added support to set and get IP configuration details." into tizen

6 years agoFixed memory leak 53/188253/1
Saurav Babu [Mon, 3 Sep 2018 10:02:21 +0000 (15:32 +0530)]
Fixed memory leak

g_ascii_strdown() returns a newly allocated string and should be freed
with g_free().
Below is the valgrind report complaining about the leak
==7455== 216 bytes in 12 blocks are definitely lost in loss record 3,009 of 3,068
==7455==    at 0x48458A4: malloc (vg_replace_malloc.c:299)
==7455==    by 0x4AB11B3: g_malloc (gmem.c:94)
==7455==    by 0x4ACBF73: g_strndup (gstrfuncs.c:425)
==7455==    by 0x4ACC9A7: g_ascii_strdown (gstrfuncs.c:1517)
==7455==    by 0x12F0E7: __get_mac_address (wifi-config.c:180)
==7455==    by 0x12F0E7: __get_group_name.constprop.4 (wifi-config.c:199)
==7455==    by 0x12F75B: _load_configuration (wifi-config.c:312)
==7455==    by 0x13133D: handle_load_configuration (wifi-config.c:1052)
==7455==    by 0x4E40AF7: ffi_call_SYSV (in /usr/lib/libffi.so.6.0.2)

Change-Id: I979c0daef4572a3a77a2f75e81ccfea0c8781fe0
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
6 years agoAdded support to set and get IP configuration details. 98/186498/4
Niraj Kumar Goit [Fri, 10 Aug 2018 03:34:23 +0000 (09:04 +0530)]
Added support to set and get IP configuration details.

Change-Id: I08320822454355853883991cad0d8b0ae58f5e36
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoMerge "Fix dbus methods for mptcp" into tizen submit/tizen/20180903.045143
Jaehyun Kim [Mon, 3 Sep 2018 04:13:22 +0000 (04:13 +0000)]
Merge "Fix dbus methods for mptcp" into tizen

6 years agoChange the directory and header file name for HAL TC 43/188043/1 submit/tizen/20180831.123807
Jaehyun Kim [Thu, 30 Aug 2018 13:16:26 +0000 (22:16 +0900)]
Change the directory and header file name for HAL TC

Change-Id: Ib1b701d14d35c9c34a819c12e2c1014660f92101
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoFix dbus methods for mptcp 35/187835/3
Seonah Moon [Wed, 29 Aug 2018 01:31:14 +0000 (10:31 +0900)]
Fix dbus methods for mptcp

Change-Id: Ice73114dcbb230b02f493dba648f15b591195d24

6 years agoChange owner and group of /usr/lib/udev/rules.d/99-wifiusb-dev.rules 25/187725/1 accepted/tizen/unified/20180831.061745 submit/tizen/20180828.112014 submit/tizen/20180830.132815
INSUN PYO [Tue, 28 Aug 2018 05:23:14 +0000 (14:23 +0900)]
Change owner and group of /usr/lib/udev/rules.d/99-wifiusb-dev.rules

Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ib1a7e47164d8e8d1b40399bf4159058f3c26c1e9

6 years agoMerge "Added support to set private-key password." into tizen accepted/tizen/unified/20180830.060928 submit/tizen/20180829.082616
Jaehyun Kim [Fri, 24 Aug 2018 05:15:03 +0000 (05:15 +0000)]
Merge "Added support to set private-key password." into tizen

6 years agoChange the HAL TC name to same as package name 67/186967/2 accepted/tizen/unified/20180817.140757 submit/tizen/20180817.033930
Jaehyun Kim [Fri, 17 Aug 2018 02:13:11 +0000 (11:13 +0900)]
Change the HAL TC name to same as package name

Change-Id: I40fae0eeaa60dfea4147d5f2c29463a0d2ecd0f1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoCombine the HAL TCs into one file 64/186764/1 accepted/tizen/unified/20180814.175012 submit/tizen/20180814.072804
Jaehyun Kim [Tue, 14 Aug 2018 06:59:49 +0000 (15:59 +0900)]
Combine the HAL TCs into one file

Change-Id: I3e7f8be918d088ee6b4dfe1d53223cc96a9df772
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoRename HAL TC files 47/186747/1 submit/tizen/20180814.054518
Jaehyun Kim [Tue, 14 Aug 2018 05:31:32 +0000 (14:31 +0900)]
Rename HAL TC files

Change-Id: Ie4c22435b635b2dc3e82828c3ec7957afbe51013
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoMerge "Avoid Null Check before g_free()." into tizen
taesub kim [Mon, 13 Aug 2018 08:18:47 +0000 (08:18 +0000)]
Merge "Avoid Null Check before g_free()." into tizen

6 years agoDisable TIZEN_DEBUG_ENABLE feature for wearable profile 72/186172/3 accepted/tizen/unified/20180808.063415 submit/tizen/20180808.022337
taesub.kim [Wed, 8 Aug 2018 02:04:26 +0000 (11:04 +0900)]
Disable TIZEN_DEBUG_ENABLE feature for wearable profile

Change-Id: I03950f53fcfeb3e1ef5c1c71f5423c29199edc95
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
6 years agoAdded support to set private-key password. 61/186061/1
Niraj Kumar Goit [Tue, 7 Aug 2018 05:03:59 +0000 (10:33 +0530)]
Added support to set private-key password.

Added support to set private-key password and it is valid
for EAP-TLS.
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Change-Id: I7499655f5237fea0f3fb38f39c36f67a5ee4eb96

6 years agoMerge "Don't free dbus method invocation twice" into tizen accepted/tizen/unified/20180726.140742 submit/tizen/20180726.054446
taesub kim [Thu, 26 Jul 2018 05:42:43 +0000 (05:42 +0000)]
Merge "Don't free dbus method invocation twice" into tizen

6 years agoDon't free dbus method invocation twice 32/185032/2
Saurav Babu [Wed, 25 Jul 2018 09:24:48 +0000 (14:54 +0530)]
Don't free dbus method invocation twice

Change-Id: I6b006b5c547d809acd6c4126da35cc3d80869585
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
6 years ago[Fix][stack-buffer-overflow] Use gboolean when using g_variant_get for boolean. 36/185036/1
Nishant Chaprana [Wed, 25 Jul 2018 09:52:06 +0000 (15:22 +0530)]
[Fix][stack-buffer-overflow] Use gboolean when using g_variant_get for boolean.

Description: g_variant_get API expects reference of gboolean variable
in third parameter, and we arepassing reference of bool variable.

As per Glib's documentation, gboolean is typecast of int.
=================================================================
(Reference: https://people.gnome.org/~desrt/glib-docs/glib-Basic-Types.html#gboolean)

gboolean

typedef gint   gboolean;

A standard boolean type. Variables of this type should only contain the value TRUE or FALSE.
=================================================================

Change-Id: I84f0120229a2a9eeec976b1785d5cc4d112db534
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
6 years agoAvoid Null Check before g_free(). 82/184882/1
Rahul Jain [Tue, 24 Jul 2018 05:45:10 +0000 (11:15 +0530)]
Avoid Null Check before g_free().

Change-Id: Ibebc50255f075ad0a931fc7bfc180caef1fc14a1
Signed-off-by: Bhaskar Dutta <bhaskar.d@samsung.com>
Signed-off-by: Rahul Jain <rahul.jain@samsung.com>
6 years agoMerge "Fix for CID:860302" into tizen accepted/tizen/unified/20180711.132737 submit/tizen/20180709.041434
taesub kim [Mon, 9 Jul 2018 04:13:19 +0000 (04:13 +0000)]
Merge "Fix for CID:860302" into tizen

6 years agoMerge "Fix for CID:860243" into tizen
taesub kim [Mon, 9 Jul 2018 04:13:06 +0000 (04:13 +0000)]
Merge "Fix for CID:860243" into tizen

6 years agoFix for CID:860302 17/183517/1
Abhishek Sansanwal [Fri, 6 Jul 2018 06:27:08 +0000 (11:57 +0530)]
Fix for CID:860302

Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
Change-Id: I1083261df5bf83d5dec91544c2eab9257c405232

6 years agoFix for CID:860282 05/183505/2
Abhishek Sansanwal [Fri, 6 Jul 2018 05:46:35 +0000 (11:16 +0530)]
Fix for CID:860282

Description: Call g_free on resource before return.

Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
Change-Id: I66412afbec1ad04e5e16a2edfe96f913ee1ceb1d

6 years agoMerge "Set passphrase for connman service when connecting using WPS without SSID... accepted/tizen/unified/20180709.064832 submit/tizen/20180706.050915
taesub kim [Fri, 6 Jul 2018 04:01:58 +0000 (04:01 +0000)]
Merge "Set passphrase for connman service when connecting using WPS without SSID" into tizen

6 years agoMerge "net-config:Generalize the setting of rps_cpus" into tizen
taesub kim [Fri, 6 Jul 2018 04:01:37 +0000 (04:01 +0000)]
Merge "net-config:Generalize the setting of rps_cpus" into tizen

6 years agoSet passphrase for connman service when connecting using WPS without SSID 35/183435/2
Saurav Babu [Thu, 5 Jul 2018 09:39:42 +0000 (15:09 +0530)]
Set passphrase for connman service when connecting using WPS without SSID

Change-Id: Ifb6ce45997e0f1275ae09d99418d6fac510293d4
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
6 years agoAdd exception handle for google test framework 65/183365/2
Taesoo Jun [Thu, 5 Jul 2018 02:01:16 +0000 (11:01 +0900)]
Add exception handle for google test framework

Change-Id: Ie8a465b9cbcbb0f4a055c790ee9687de63f378b5
Signed-off-by: Taesoo Jun <steve.jun@samsung.com>
6 years agoFix memory corruption in unittest 63/183363/2
Taesoo Jun [Thu, 5 Jul 2018 01:47:01 +0000 (10:47 +0900)]
Fix memory corruption in unittest

Change-Id: I075961d576735dd852939a70b276c1adbcd9a65a
Signed-off-by: Taesoo Jun <steve.jun@samsung.com>
6 years agonet-config:Generalize the setting of rps_cpus 31/183231/2
Mayank Haarit [Tue, 3 Jul 2018 11:44:36 +0000 (17:14 +0530)]
net-config:Generalize the setting of rps_cpus

This patch generalize the logic to set rps_cpus in
all receive queues of the wlan interface.

Change-Id: I2b4c2883338bcbaa989d52f9a1beac1409e2a5c7
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
6 years agoAdded dump log for connect fail #2 56/182956/1 accepted/tizen/unified/20180702.151346 submit/tizen/20180702.034741
taesub kim [Fri, 29 Jun 2018 06:50:58 +0000 (15:50 +0900)]
Added dump log for connect fail #2

Change-Id: Ied11589a7fcb26e9d285fd2304c3ae46be257567
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
6 years agoAdd a dbus rule for MPTCP 29/182629/1 accepted/tizen/unified/20180628.061157 submit/tizen/20180626.233453
chleun.moon [Tue, 26 Jun 2018 23:30:08 +0000 (08:30 +0900)]
Add a dbus rule for MPTCP

Change-Id: I211eac23a47bfdf2d827fa3359e96c9541b0b8ad
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>
6 years agoFix dbus method return value #2 20/182220/1 accepted/tizen/unified/20180622.122710 submit/tizen/20180622.032935
taesub kim [Thu, 21 Jun 2018 08:46:01 +0000 (17:46 +0900)]
Fix dbus method return value #2

Change-Id: Id2fde617f3160ef03c75ce5ebbf54043f0f94697
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
6 years agoAdded requires(tcpdump) in spec file 97/181497/1 accepted/tizen/unified/20180615.160540 submit/tizen/20180614.233117
taesub kim [Thu, 14 Jun 2018 08:45:41 +0000 (17:45 +0900)]
Added requires(tcpdump) in spec file

Change-Id: Ica164e3c5c8c19cd12a717382004ae2f035c74f7
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
6 years agoMerge "Added dump log for connect fail" into tizen accepted/tizen/unified/20180612.044202 submit/tizen/20180612.012523
taesub kim [Tue, 12 Jun 2018 00:26:53 +0000 (00:26 +0000)]
Merge "Added dump log for connect fail" into tizen

6 years agoMerge "Fix bug in Ip conflict set/get enabled API's" into tizen
taesub kim [Tue, 12 Jun 2018 00:25:28 +0000 (00:25 +0000)]
Merge "Fix bug in Ip conflict set/get enabled API's" into tizen

6 years agoMerge "Added initial code for Gtest" into tizen
taesub kim [Tue, 12 Jun 2018 00:25:13 +0000 (00:25 +0000)]
Merge "Added initial code for Gtest" into tizen