Seungbae Shin [Thu, 20 Oct 2022 05:07:00 +0000 (14:07 +0900)]
focus-server: change focus-server socket location
/run is widely used for daemon socket location, also without dot prefix
as-is : /tmp/.focus_server.socket
to-be : /run/focus_server.socket
[Version] 0.13.21
[Issue Type] Update
Change-Id: Ibbcbbfc8cc90002a2eb66a24a3fb50f05836c068
Seungbae Shin [Thu, 6 Oct 2022 11:41:20 +0000 (20:41 +0900)]
add additional device query functions
[Version] 0.13.20
[Issue Type] Feature
Change-Id: I4f5982ebaa0840ebd426b4eb0b506f85e59422b5
heechul.jeon [Tue, 28 Jun 2022 01:12:54 +0000 (10:12 +0900)]
testsuite: Extracted more function to reduce redundancy from testsuite
[Version] 0.13.19
[Issue Type] Cleanup
Change-Id: Iabc1704a9001488ee467079ee60e8d926a0705ce
Signed-off-by: heechul.jeon <heechul.jeon@samsung.com>
heechul.jeon [Mon, 27 Jun 2022 09:47:29 +0000 (18:47 +0900)]
testsuite: Extracted print_device_info() and remove redundant code
Change-Id: I93e5c30e359efc02a6cf1f3149f76a8611d683dd
Signed-off-by: heechul.jeon <heechul.jeon@samsung.com>
Jaechul Lee [Mon, 23 May 2022 06:18:25 +0000 (15:18 +0900)]
Revert "Add Acoustic Echo Cancellation services"
This reverts commit
4a826060ea22239e364ebc677a878dd6ef916c23.
Remove unused echo-cancellation code because a new feature that is
called 'stream based EC' was added.
[Version] 0.13.18
[Issue Type] Cleanup
Change-Id: I2bf95910db49e18c267ae4695f615da68e6a1744
Seungbae Shin [Wed, 24 Nov 2021 04:59:31 +0000 (13:59 +0900)]
fixup! Change focus pipe location (/tmp/ to /tmp/focus)
[Version] 0.13.17
[Issue Type] Build
Change-Id: I116a315df7c218a368eb16d058fffa3b5c7c4f37
Seungbae Shin [Wed, 17 Nov 2021 15:12:47 +0000 (00:12 +0900)]
Fix aarch64 casting build warnings
- warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
- warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
[Version] 0.13.16
[Issue Type] Build
Change-Id: Iabc8f08b2126ef0ce15493aece64d7527885cd65
Seungbae Shin [Mon, 15 Nov 2021 06:21:11 +0000 (15:21 +0900)]
Change focus pipe location (/tmp/ to /tmp/focus)
1. avoid pollution of /tmp directory by storing focus runtime files to dedicated sub-directory
2. makes easy migration(e.g. mounting host directory) for container support
[Version] 0.13.15
[Issue] Cleanup
Change-Id: Idf5dacb8bd75c14d9f5a8d47f3c0559eeb5a24c4
Sangchul Lee [Tue, 2 Nov 2021 05:34:29 +0000 (14:34 +0900)]
Change focus_lock init/lock/unlock/clear location
These moves make a improvement for race condition between focus
state callback and destroying handle. It fixes an abort issue from
unlocking mutex that is already unlocked.
'is_destroying' variable is added and is set to return earlier in the
focus state callback.
[Version] 0.13.14
[Issue Type] Improvement
Change-Id: Ic71341fef3e7e0f1d40f55a6bd470ed6bb423651
Jaechul Lee [Mon, 30 Aug 2021 02:08:00 +0000 (11:08 +0900)]
Fixes 'Unchecked return value'
[Version] 0.13.13
[Issue Type] Coverity
Change-Id: Ibe7d20fc4dbc01986cd44e72827e2061924c4014
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 5 Jul 2021 02:07:06 +0000 (11:07 +0900)]
Enable agc, denoise, dereverb
agc, denoise and dereverb are enabled to improve voice recognition ratio.
[Version] 0.13.12
[Issue Type] Add
Change-Id: Ib88c1afee0cd3f46b9c9e4833c8cc2db67f6fc14
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Thu, 10 Jun 2021 11:39:03 +0000 (20:39 +0900)]
Fix Coverity Defects (REVERSE_INULL)
+ remove unused variable
[Version] 0.13.11
[Issue Type] Coverity
Change-Id: I37723cb57bc7b29d504def5a8500c81a27e7303c
Jaechul Lee [Mon, 10 May 2021 03:55:10 +0000 (12:55 +0900)]
Fix USE_AFTER_FREE, DOUBLE_FREE
[Version] 0.13.10
[Issue Type] Coverity, SVACE
Change-Id: I06b08f23f46bd7fde1ac03716d603fa06a97df9a
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 26 Apr 2021 07:37:30 +0000 (16:37 +0900)]
Remove sound_server legacies
Change-Id: Ie6c3c07d86362233fc489d6b3286dda199bda106
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 26 Apr 2021 07:34:13 +0000 (16:34 +0900)]
Exclude AudioAec.service file from tv profile
Change-Id: If91aa93a6ef514f35ef49c28768549e71e33f746
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Fri, 12 Mar 2021 05:31:25 +0000 (14:31 +0900)]
Add Acoustic Echo Cancellation services
Added AEC services
[Version] 0.13.7
[Issue Type] New feature
Change-Id: I4ac638a0d61dae635efecd5e198bf2d2fec28557
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Fri, 12 Mar 2021 02:22:13 +0000 (11:22 +0900)]
fixup! mm_sound_proxy: add bt-a2dp device to query list properly only if mask satisfied
[Version] 0.13.6
[Issue Type] Bug (Product)
Change-Id: Ie6214bbf6fdd94125601e6fbf553715f650a6a9e
Seungbae Shin [Thu, 11 Mar 2021 10:57:39 +0000 (19:57 +0900)]
mm_sound_proxy: add bt-a2dp device to query list properly only if mask satisfied
[Version] 0.13.5
[Issue Type] Bug (Product)
Change-Id: I5035ba829f060bfc8638006b47787b3a0d9af4fb
Seungbae Shin [Wed, 4 Nov 2020 12:43:38 +0000 (21:43 +0900)]
mm_sound_proxy: null check before variant unref
[Version] 0.13.4
[Issue Type] Revise
Change-Id: Ife96c7915a3c190e77cc9e9d45168828b537deff
Seungbae Shin [Wed, 4 Nov 2020 11:26:57 +0000 (20:26 +0900)]
Remove build warnings and fix typos
[Version] 0.13.3
[Issue Type] Revise
Change-Id: Iba31fb4278631242e5a6ae65b7ca6feba2a53715
Sangchul Lee [Thu, 15 Oct 2020 06:29:01 +0000 (15:29 +0900)]
Improve condition checking codes to skip the callback in focus handlers
There was seg.fault issue when the race condition happened as below.
- invoked callback from server VS. unset watch callback by user
Level of some logs are changed to 'info' to debug issues more easily.
[Version] 0.13.2
[Issue Type] Improvement
Change-Id: Ie0dab8bedf538dda61d2313359627387e525a9c7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Mon, 12 Oct 2020 11:00:09 +0000 (20:00 +0900)]
Remove unused semaphore feature
+ remove minor build warnings
[Version] 0.13.1
[Issue Type] Cleanup
Change-Id: Ie9a5d71a2ffe3010f4c0f315dd505f871da09877
Jaechul Lee [Fri, 22 May 2020 06:08:04 +0000 (15:08 +0900)]
Remove sound_server in build packages
tone-player and wav-player in sound-server were moved to pulseaudio.
sound_server is not necessary to play sound/tone. Tizen_HW_Touch.ogg is
moved to pulseaudio-modules-tizen package.
[Version] 0.13.0
[Issue Type] Improvement
Change-Id: I06f5088db6381d5ca79d73d45bcfa143bc4a3923
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Mon, 4 May 2020 10:13:38 +0000 (19:13 +0900)]
Support gcov build for coverage check
gcov build enabled by gbs define option '--define "gcov 1"'
[Version] 0.12.73
[Issue Type] Add
Change-Id: I3e0dc35573f4aa6119004ad60462f8d8493ab126
Seungbae Shin [Mon, 4 May 2020 10:04:22 +0000 (19:04 +0900)]
Fix build warnings
Change-Id: Idcf9b5a32c18912aef01ab9580c2812243e86297
Jaechul Lee [Mon, 13 Apr 2020 06:34:20 +0000 (15:34 +0900)]
Adds mm_sound_tone_stop for tone-player
Tone-player and wav-player use mm_sound_stop API for stopping sound. So,
sound-play module in pulseadio received tone-player stop message through
dbus. Another problem was a stream handle that must have under
CLIENT_HANDLE_MAX(256) value. The handle from pulseaudio are increased
every creation.
[Version] 0.12.72
[Issue Type] Bug
Change-Id: I355aaf592413ec94730c0b206ea8d50a190a7281
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 13 Apr 2020 00:54:31 +0000 (09:54 +0900)]
Adds checking file existence
[Version] 0.12.71
[Issue Type] Bug
Change-Id: I3f8450ec6431851cb84e205d9d5b90e30a645859
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Wed, 8 Apr 2020 05:02:14 +0000 (14:02 +0900)]
Adds checking dbus error messages
It can't check error messages properly because dbus error message has a
space before org.tizen.bla. Besides, the messages are little difference
between sound-server and pulseaudio.
e.g)
a error message from sound-server(g_dbus api)
GDBus.Error:org.tizen.multimedia.audio.Internal: failed
a error message from pulseaudio(dbus api)
GDBus.Error:org.freedesktop.DBus.Error.Failed: org.tizen.multimedia.audio.Internal
[Version] 0.12.70
[Issue Type] Bug
Change-Id: I1f0ba391dd3645cac3a6bd7006ed8ca51b9c4a28
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 6 Apr 2020 01:53:32 +0000 (10:53 +0900)]
Adds checking a invalid handle
It needs to check the handle that is returned from pulseaudio.
[Version] 0.12.69
[Issue Type] Bug
Change-Id: I245579aa282452dba352ad6356b882d072a894d3
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Thu, 26 Mar 2020 08:10:39 +0000 (17:10 +0900)]
Changes playback interface to org.pulseaudio.SoundPlayer
[Version] 0.12.68
[Issue Type] Improvement
Change-Id: I7301167c3bf0bb6101a7e2064fdba863b5f383dc
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Fri, 27 Mar 2020 07:23:26 +0000 (16:23 +0900)]
fixup! Fix mismatching function prototype
Change-Id: Id158547ac10b3ceeabc8473ce10986d7c0d484fe
Seungbae Shin [Wed, 25 Mar 2020 08:13:34 +0000 (17:13 +0900)]
Fix mismatching function prototype
avoid unexpected complete callback for tone playback
fixup missing data type for volume_type in internal keysound function
[Version] 0.12.67
[Issue Type] Bug
Change-Id: I3bf44c8abcbd239ae867ba427d193268729762ee
INSUN PYO [Mon, 23 Mar 2020 23:21:55 +0000 (08:21 +0900)]
Fix memory leak
Change-Id: Idd7046f37979ac6041eac1b6b6df87c9a31d8f98
Seungbae Shin [Wed, 11 Mar 2020 07:32:48 +0000 (16:32 +0900)]
Add mm_sound_stop_keysound()
[Version] 0.12.66
[Issue Type] Add
Change-Id: I2e17159bcafabc4056fcae7cff62ec1a70403c95
Jaechul Lee [Thu, 19 Mar 2020 07:02:31 +0000 (16:02 +0900)]
Fix NULL pointer dereference
g_variant_unref is called with a NULL argument.
[Version] 0.12.65
[Issue Type] Bug
Change-Id: I2f65a076f2c54a35ffcbe756b846a2f8c14edb21
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Fri, 28 Feb 2020 05:00:19 +0000 (14:00 +0900)]
Fix double unlock of slot mutex in user stops scneario
In addition, stream started callback and written data log are added for convienent debugging
[Version] 0.12.64
[Issue Type] Bug
Change-Id: I1f444f9ff2920156407c4baa11aa655116d241f6
Seungbae Shin [Fri, 28 Feb 2020 04:54:45 +0000 (13:54 +0900)]
Revise code related to coding conventions and adjust some log levels
[Version] 0.12.63
[Issue Type] Revision
Change-Id: I5ac7e618fbab8f2d972a9fd94748ccd10c5776b4
Seungbae Shin [Thu, 27 Feb 2020 11:34:14 +0000 (20:34 +0900)]
Fix to start stream corked to avoid early drain complete
For short file playback, drain operation can be completed to early prior to actual stream start.
This is due to connecting playback stream with uncorked.
In this situation, stream handle will not be valid any more and finally crash occurred.
To fix this issue, stream should be started with corked state.
[Version] 0.12.62
[Issue Type] Bug
Change-Id: I32f0748dc64ce822a4fa277d957792dfecb5a323
Seungbae Shin [Mon, 17 Feb 2020 04:29:21 +0000 (13:29 +0900)]
Fix coverity (Negative array index write) defects
[Version] 0.12.61
[Issue Type] Vulnerability
Change-Id: I9ce6cd2c12fce3224a3bd4da99008a562cca076a
Seungbae Shin [Tue, 11 Feb 2020 04:59:01 +0000 (13:59 +0900)]
Fix coverity (Incorrect deallocator used) defects
[Version] 0.12.60
[Issue Type] Vulnerability
Change-Id: Ia5ef3506a39748ebb12dc89e60917ec48f8f89b0
Seungbae Shin [Mon, 13 Jan 2020 10:21:58 +0000 (19:21 +0900)]
fixup! Fix some vulnerability (Null Pointer Dereference) defects
Change-Id: Ic82ab59660ba7976789b06bc8da6c61ba5317d21
(cherry picked from commit
7852719f0a4cae043f7a6c13787d0aa0310c1721)
Seungbae Shin [Wed, 18 Dec 2019 02:31:24 +0000 (11:31 +0900)]
Fix some vulnerability (Null Pointer Dereference) defects
[Version] 0.12.59
[Issue Type] Vulnerability
Change-Id: I0d4ddd518dad40e4306cbc8f4200ccaa6f00ea78
(cherry picked from commit
38b3c36fd75409a72a7f2da8e3c27f15ef1ba7b9)
Sangchul Lee [Mon, 13 Jan 2020 03:40:26 +0000 (12:40 +0900)]
focus_server: Check symbolic link before opening a file
[Version] 0.12.58
[Issue Type] Security vulnerability
Change-Id: I84f699be4b1b6e82e33aeaf03f9181ddac9f0fbf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 13 Jan 2020 01:11:32 +0000 (10:11 +0900)]
mm_sound_plugin_codec_wave: Set client pid to PulseAudio property
[Version] 0.12.57
[Issue Type] Improvement
Change-Id: I756323dcfaa05eaf7584c4d6d16814242d137400
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 12 Nov 2019 05:16:06 +0000 (14:16 +0900)]
Add internal volume API set
Initially, this patch supports the bixby volume type.
[Version] 0.12.56
[Issue Type] New feature
Change-Id: Ib6739238356dd52aa2d519154ece65a892254dfa
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Wed, 20 Nov 2019 04:54:48 +0000 (13:54 +0900)]
Retry when writing to keysound pipe is failed with 'Resource temporarily unavailable'
[Version] 0.12.55
[Issue Type] Improvement
Change-Id: Ib9e43afca246832b81b8e7dc4e559d66ba13194c
Sangchul Lee [Tue, 12 Nov 2019 09:11:04 +0000 (18:11 +0900)]
Remove the validation check of volume level in the client side
It was the only hard-coded condition which limits the maxium
volume level per each volume type. The rest of volume policy
has been implemented with fixing the maximum level by the values
in the volume table loaded inside of the PulseAudio.
[Version] 0.12.54
[Issue Type] Improvement
Change-Id: Id34f818764062da0060a8288f16e4281fd7aae05
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 11 Nov 2019 02:01:49 +0000 (11:01 +0900)]
mm_sound: Remove deprecated symbol - mm_sound_volume_remove_callback()
[Version] 0.12.53
[Issue Type] Clean-up
Change-Id: I45db42cae27ff0537e747118b85cbff5c241684c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 24 Sep 2019 03:30:41 +0000 (12:30 +0900)]
mm_sound_server: fix not to nofity complete callback in case of stopping wav playback
[Version] 0.12.52
[Issue Type] Bug
Change-Id: I89d6c270511a1f51f8c048484dda24226c0cd43b
Sangchul Lee [Fri, 20 Sep 2019 07:24:46 +0000 (16:24 +0900)]
mm_sound_server: Terminate the server when MMSoundThreadPoolRun() is failed
[Version] 0.12.51
[Issue Type] Crash
Change-Id: Ia58555507d775426dd1b4633e296f57c4635af2f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 11 Sep 2019 08:09:27 +0000 (17:09 +0900)]
Add new function to update taken_info of nodes used right after invoking user callback
It'll reduce cyclomatic complexity of SAM.
[Version] 0.12.50
[Issue Type] Refactoring
Change-Id: Ife68840f015f82ab7cfd25dc3d54ecc792a197da
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 11 Sep 2019 02:32:26 +0000 (11:32 +0900)]
Add new function to check if it needs to trigger focus callback or not
It'll reduce cyclomatic complexity of SAM.
[Version] 0.12.49
[Issue Type] Refactoring
Change-Id: Ibc71f4192ffed181d1d9999dc5a3f48b512c5929
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 10 Sep 2019 08:02:03 +0000 (17:02 +0900)]
Add new function to get my focus node and apply it
It'll reduce cyclomatic complexity of SAM.
[Version] 0.12.48
[Issue Type] Refactoring
Change-Id: I3cc8ae7160161c3d2e52078fab268f8a710b99d7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 27 Aug 2019 11:39:28 +0000 (20:39 +0900)]
Use static keyword for global variables
[Version] 0.12.47
[Issue Type] Refactorying
Change-Id: I00460fb797eb41492c6b8223dce6fc39610a2fea
Seungbae Shin [Tue, 27 Aug 2019 10:40:55 +0000 (19:40 +0900)]
Remove unused handle mode enum for pa_client
[Version] 0.12.46
[Issue Type] Refactorying
Change-Id: I208d23d0bb9318d3a7b21de49ca1ee7f6968550c
Jeongmo Yang [Thu, 11 Jul 2019 05:59:40 +0000 (14:59 +0900)]
Add new functions to support ducking state changed callback
[Version] 0.12.45
[Profile] Common
[Issue Type] New feature
Change-Id: Ia4664b74e810320c39a268c7f5de1c829ef874e6
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Hyotaek Shim [Tue, 9 Jul 2019 02:23:24 +0000 (11:23 +0900)]
Remove unused dependency of tizen-system.target
Change-Id: Iac2ed749279512e559f01df44ae7436e699af053
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Mon, 24 Jun 2019 06:01:22 +0000 (15:01 +0900)]
Adjust the position of focus-server.path
Change-Id: I4afcb31ea237dfd2e0a379a1ff942a634624e6d3
INSUN PYO [Mon, 24 Jun 2019 02:23:46 +0000 (11:23 +0900)]
Change the config value of the systemd service ("false" -> "no")
"no" and "false" have the same meaning, but the document has "no".
Also, since the parsing order is "no" first, there is some performance gain.
Change-Id: Ia619d43197cdf42c6a430b9c32700e99483662af
Sangchul Lee [Tue, 18 Jun 2019 00:17:00 +0000 (09:17 +0900)]
Use MM_SOUND_DEVICE_TYPE_NETWORK renamed from _TYPE_RAOP
[Version] 0.12.44
[Issue Type] Improvement
Change-Id: I77ab3317bca9ae4d75d7c3e09ae735d1a9a188e1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 24 May 2019 04:47:11 +0000 (13:47 +0900)]
Get stream list again if it doesn't seem to have done it before
stream list is obtained from PulseAudio via DBus during the initialization
of the focus server. Normally, PulseAudio is launched before this focus
server. It has no problem with the normal situation. If the sequence is
reversed for some reason, these new codes can get a chance to make it right.
[Version] 0.12.43
[Issue Type] Fault tolerance
Change-Id: I95007aa7ea8aecbf9f7212c6b0d2daaf6bee7806
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 29 Apr 2019 01:03:52 +0000 (10:03 +0900)]
Improve logic regarding focus reacquisition change in the callback
If reacquisition value is changed in the focus callback, taken_by_id
/taken_backup structures for both playback/capture of the node should
be updated.
[Version] 0.12.42
[Issue Type] Bug fix
Change-Id: I0161d0af91878909ae5c60b3072382d576955a80
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 22 Mar 2019 01:25:30 +0000 (10:25 +0900)]
Manage focus cb thread and focus watch cb thread separately
API is revised as below.
- int mm_sound_focus_is_cb_thread(bool *result)
+ int mm_sound_focus_is_cb_thread(bool *result, bool *is_for_watching)
[Version] 0.12.41
[Issue Type] Enhancement
Change-Id: Ib2cfa6b7b2425d5a37db224bb242c7c2a1651d14
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 19 Mar 2019 06:25:32 +0000 (15:25 +0900)]
Add to check the condition before unlocking mutex in focus watch callback handler
[Version] 0.12.40
[Issue Type] Bug fix
Change-Id: I767b8d1593ee92f8196a9bbdba9ade0ccdbdafa9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 14 Feb 2019 08:25:14 +0000 (17:25 +0900)]
Add support for mute API set
[Version] 0.12.39
[Issue Type] New feature
Change-Id: I53276fe8e860eb97ba1b6aa4864ac10552ebf494
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 15 Feb 2019 01:23:24 +0000 (10:23 +0900)]
Remove unused symbols
[Version] 0.12.38
[Issue Type] Clean up
Change-Id: Iad1ca7700177a193390b1c2b6410c3080fce6577
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 13 Feb 2019 02:29:39 +0000 (11:29 +0900)]
Add mm_sound_is_stream_on_device_by_id()
[Version] 0.12.37
[Issue Type] API
Change-Id: I897d2198ec9fb592a0f75b5905cfad8568514ae1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Thu, 10 Jan 2019 03:52:48 +0000 (12:52 +0900)]
Apply -fPIC -pie on focus-server always due to non-prelink
[Version] 0.12.36
[Issue Type] Build
Change-Id: I1f04948b721abd973f8da7c92536a5480ed490aa
Seungbae Shin [Thu, 17 Jan 2019 10:52:33 +0000 (19:52 +0900)]
Fix SVACE defects : OP_PRECEDENCE_ASSIGN_CMP
[Version] 0.12.35
[Issue Type] Security vulnerability
Change-Id: I594c7f33c95500141c27d830b9b4cbb92b10f87f
Sangchul Lee [Mon, 14 Jan 2019 09:53:43 +0000 (18:53 +0900)]
Check for symbolic link vulnerability
Verfiy the absolute path by using realpath() and
unlink it if it seems to be unexpected symbolic link.
[Version] 0.12.34
[Issue Type] Security vulnerability
Change-Id: I82d85f1b2d3c218985f59463461dfc005ade5ccf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Thu, 20 Dec 2018 10:46:32 +0000 (19:46 +0900)]
Fix improper errno handling
[Version] 0.12.33
[Issue Type] Bug
Change-Id: If13ea55bbce212bf96581a66b9e464019e7b8819
Seungbae Shin [Fri, 14 Dec 2018 01:57:46 +0000 (10:57 +0900)]
fixup! Fix invalid format string
[Version] 0.12.32
[Issue Type] Build
Change-Id: Iff9e7ab2701743640c605867849b502a700c03e0
Seungbae Shin [Fri, 7 Dec 2018 06:52:04 +0000 (15:52 +0900)]
Fix invalid format string
[Version] 0.12.31
[Issue Type] Build
Change-Id: I17a4f2603d215e69864042c172c51d5c7db3c377
Seungbae Shin [Thu, 22 Nov 2018 05:45:15 +0000 (14:45 +0900)]
Add initial unittest
[Version] 0.12.30
[Issue Type] Test
Change-Id: I67946e26c90492d9d39cb6ee080be8e1d6a4e8bf
Sangchul Lee [Wed, 7 Nov 2018 07:42:04 +0000 (16:42 +0900)]
Enhance error handling in case of failure in focus_init_context()
operations of quitting mainloop and joining focus thread are added to error handling codes.
timeout for waiting run state of mainloop is also changed to 2.5 sec.
[Version] 0.12.29
[Issue Type] Enhancement
Change-Id: Ide47c174b531395d69a1aa9f45a4b381f4d505af
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 10 Jul 2018 07:44:17 +0000 (16:44 +0900)]
Add MM_SOUND_DEVICE_TYPE_RAOP
[Version] 0.12.28
[Issue Type] Feature
Change-Id: I1533f03e174490ecf9ae4d64ef8c0d72c13617f4
Sangchul Lee [Mon, 20 Aug 2018 01:49:17 +0000 (10:49 +0900)]
Fix ASAN build break
Declaration of g_focus_sound_handle array is moved to mm_sound_focus_private.c
[Version] 0.12.27
[Issue Type] Bug fix
Change-Id: Idc5a03f7df22763b4cf71762489d7f4c0d7df45b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 8 Aug 2018 06:41:04 +0000 (15:41 +0900)]
Fix coverity issues
[Version] 0.12.26
[Issue Type] Coverity
Change-Id: Ibea05053ed04c21c347471d9e885206ca944afc9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Fri, 3 Aug 2018 10:44:27 +0000 (19:44 +0900)]
Fix not to shutdown when playing streams.
[Version] 0.12.25
[Issue Type] Bug
Change-Id: I63ed17dce2a220c2374c0cdbff68bae0663ac1cd
Sangchul Lee [Thu, 2 Aug 2018 05:48:33 +0000 (14:48 +0900)]
Remove undefined symbol
The function has been already removed.
[Version] 0.12.24
[Issue Type] VD Build break
Change-Id: I7b5ad7eb825682c7be591c3a21053ead1a865edf
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 25 Jul 2018 06:55:37 +0000 (15:55 +0900)]
Revise error handling in mm_sound_proxy.c
[Version] 0.12.23
[Issue Type] Refactor and bug fix
Change-Id: If0b5bfa27d2d434b5a126df6a9d7ecd66e06e691
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Fri, 29 Jun 2018 05:50:26 +0000 (14:50 +0900)]
Fix stack-buffer-overflow bug issued by ASAN
[Version] 0.12.22
[Issue Type] Bug
Change-Id: If94c462f9e586a56a3e26bfdfe4256c1894df6f1
Seungbae Shin [Thu, 28 Jun 2018 12:11:08 +0000 (21:11 +0900)]
Fix use-after-free bug issued by ASAN
[Version] 0.12.21
[Issue Type] Bug
Change-Id: I324875fd1aedfec9f91560b701c1062c7fb52b20
Sangchul Lee [Fri, 15 Dec 2017 09:05:12 +0000 (18:05 +0900)]
Use socket for IPC of focus APIs instead of the DBus
The benefits of this change are here.
- Connection is established when registering a focus node. This leads to
remove the previous signal handler for cleaning focus resources.
- Response time is enhanced as per the change of IPC.(DBus to socket)
[Version] 0.12.20
[Issue Type] Enhancement
Change-Id: Ifbc3ecde29985e9150ed7429b8616ef6cbe99d92
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jungsup Lee [Wed, 30 May 2018 02:06:02 +0000 (11:06 +0900)]
Fix Wformat build error
[Version] 0.12.19
[Issue Type] Build break
Change-Id: I65a370861867d2630b84d8d6f7ce09554fe658e3
Signed-off-by: Jungsup Lee <jungsup4.lee@samsung.com>
Sangchul Lee [Thu, 10 May 2018 02:35:26 +0000 (11:35 +0900)]
Fix unchecked return value
[Version] 0.12.18
[Issue Type] Coverity (CID 118319)
Change-Id: I04aa31259c6a7f6d433ee91517d8aa9adf591148
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 10 May 2018 03:21:22 +0000 (12:21 +0900)]
Correct signature of internal function that does not require return value
svace info : Redundant comparison 'ret' == '0' (0 == 0) is always true at
mm_sound_plugin_codec_wave.c:604.
[Version] 0.12.17
[Issue Type] SVACE (WGID 34314)
Change-Id: I9e89b3fca2b98f45a5e97ae30fb6a122ed2689d5
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Fri, 4 May 2018 09:06:50 +0000 (18:06 +0900)]
Apply deny policy for default context in dbus conf
Applied to both sound-server / focus-server
[Version] 0.12.16
[Issue Type] Security
Change-Id: Idb3c93ae5397269089eed1f0f351d5ff467b0878
Seungbae Shin [Thu, 26 Apr 2018 12:47:55 +0000 (21:47 +0900)]
Fix float->int(short) clipping issue when playing ogg content
related reference:
http://www.mega-nerd.com/libsndfile/api.html#note2
https://github.com/erikd/libsndfile/issues/194
[Version] 0.12.15
[Issue Type] Bug Fix
Change-Id: I60894d8286c53999c5d907c486a10ca7a88dd95a
Seungbae Shin [Tue, 24 Apr 2018 11:36:26 +0000 (20:36 +0900)]
Fix coverity defects
fix minor build warning
[Version] 0.12.14
[Issue Type] Security
Change-Id: I5eee1290de2fb381f61078e099e566ae166e530e
Seungbae Shin [Mon, 23 Apr 2018 10:14:06 +0000 (19:14 +0900)]
Fix for TV product build macro
[Version] 0.12.13
[Issue Type] Build
Change-Id: Ib717c739ef11c46425ee9163394a3ebdbcc7c3b2
Sangchul Lee [Thu, 16 Nov 2017 08:20:56 +0000 (17:20 +0900)]
Remove deprecated APIs and codes for session backward compatibility
[Version] 0.12.12
[Issue Type] Clean-up
Change-Id: I7545981ceafe13d56e9c4fa9d99227d6e326f631
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 13 Mar 2018 07:38:16 +0000 (16:38 +0900)]
Fix SVACE defects
[Version] 0.12.12
[Issue Type] Security
Change-Id: Id681c147e6b346e7391e0f635d5ff92d49ca6b48
Jungsup Lee [Tue, 20 Feb 2018 04:43:12 +0000 (13:43 +0900)]
Check pulseaudio ready file in _mm_sound_play_keysound
Check "/tmp/.pulseaudio_ready" file before access "/tmp/keytone"
[Version] 0.12.11
[Issue Type] Bug Fix
Signed-off-by: Jungsup Lee <jungsup4.lee@samsung.com>
Change-Id: Ib5d91e2733bdf390f277faf1efcb2d4cdfbbec48
Sangchul Lee [Tue, 16 Jan 2018 00:25:49 +0000 (09:25 +0900)]
Extend timeout period of waiting for mainloop running
Sometimes it takes long time to change its state to "running" especially on TV target.
[Version] 0.12.10
[Issue Type] Enhancement
Change-Id: I2192047295794fbd21ca2a541826eaac1ed7c5f9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Wed, 10 Jan 2018 12:58:07 +0000 (21:58 +0900)]
Add TV BT device when current device list query
[Version] 0.12.9
[Profile] TV
[Issue Type] Bug
Change-Id: I74998313adbd54ac99094a1f68f34e983723d767
Sangchul Lee [Wed, 20 Dec 2017 02:45:53 +0000 (11:45 +0900)]
Revise service file to add capabilities option
[Version] 0.12.8
[Issue Type] Enhancement
Change-Id: Ieefd933534c94d4af36678cd78d05fe8659fb7bb
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 6 Feb 2018 09:22:13 +0000 (18:22 +0900)]
Remove unused / unnecessary usage of pa simple
[Version] 0.12.7
[Issue Type] Build
Change-Id: I8f593a868df18d458aec256c44b5e2ece187c5d9
Seungbae Shin [Fri, 15 Dec 2017 04:40:14 +0000 (13:40 +0900)]
Remove dlog prints on signal handler / dotnet cleanup
[Version] 0.12.6
[Issue Type] Enhancement
Change-Id: Ib73de0cbd07d3648d4aa500a9a2d8f5ea1670275
Seungbae Shin [Thu, 7 Dec 2017 11:28:15 +0000 (20:28 +0900)]
Fix memory leak after wav playback
threaded_mainloop was not removed after wav playback,
now it will be removed on seperate temporal thread
(we can't remove from inside of mainloop thread)
in addition, change shutdown timeout from 10 to 60 sec.
(I think 10 sec. might be too short)
[Version] 0.12.5
[Issue Type] Bug Fix
Change-Id: Ic3a0053812fc3f31c344b9170a0684c656a97648