Fix generating HTTP API v1 test fixtures 85/190485/3
authorMaciej Wereski <m.wereski@partner.samsung.com>
Tue, 2 Oct 2018 11:06:30 +0000 (13:06 +0200)
committerMaciej Wereski <m.wereski@partner.samsung.com>
Thu, 4 Oct 2018 14:40:06 +0000 (16:40 +0200)
Empty files shouldn't be generated when server responds with '204 No
Content'. All such files were removed.

Change-Id: I97823f9a476d7699bc5cf88b7da9f342c4b1ac71
Signed-off-by: Maciej Wereski <m.wereski@partner.samsung.com>
http/server/api/v1/api_test.go
http/server/api/v1/testdata/close-req-valid-POST.json [deleted file]
http/server/api/v1/testdata/prolong-access-valid-POST.json [deleted file]
http/server/api/v1/testdata/update-req-prio-POST.json [deleted file]
http/server/api/v1/testdata/update-req-valid-POST.json [deleted file]
http/server/api/v1/testdata/worker-deregister-valid-POST.json [deleted file]
http/server/api/v1/testdata/worker-set-groups-valid-POST.json [deleted file]

index e8cf5b2..ee4495b 100644 (file)
@@ -192,7 +192,8 @@ func runTests(assert *assert.Assertions, r *httptreemux.TreeMux, tests []request
                        tdata := filepath.Join("testdata", test.name+"-"+method+".json")
                        body, err := ioutil.ReadAll(resp.Body)
                        assert.Nil(err)
-                       if update && method != http.MethodHead {
+                       if update && resp.StatusCode != http.StatusNoContent &&
+                               method != http.MethodHead {
                                err = ioutil.WriteFile(tdata, body, 0644)
                                assert.Nil(err)
                        }
diff --git a/http/server/api/v1/testdata/close-req-valid-POST.json b/http/server/api/v1/testdata/close-req-valid-POST.json
deleted file mode 100644 (file)
index e69de29..0000000
diff --git a/http/server/api/v1/testdata/prolong-access-valid-POST.json b/http/server/api/v1/testdata/prolong-access-valid-POST.json
deleted file mode 100644 (file)
index e69de29..0000000
diff --git a/http/server/api/v1/testdata/update-req-prio-POST.json b/http/server/api/v1/testdata/update-req-prio-POST.json
deleted file mode 100644 (file)
index e69de29..0000000
diff --git a/http/server/api/v1/testdata/update-req-valid-POST.json b/http/server/api/v1/testdata/update-req-valid-POST.json
deleted file mode 100644 (file)
index e69de29..0000000
diff --git a/http/server/api/v1/testdata/worker-deregister-valid-POST.json b/http/server/api/v1/testdata/worker-deregister-valid-POST.json
deleted file mode 100644 (file)
index e69de29..0000000
diff --git a/http/server/api/v1/testdata/worker-set-groups-valid-POST.json b/http/server/api/v1/testdata/worker-set-groups-valid-POST.json
deleted file mode 100644 (file)
index e69de29..0000000