Reduce usage of Q_ASSERT in autotests.
authorJason McDonald <jason.mcdonald@nokia.com>
Wed, 18 May 2011 00:45:40 +0000 (10:45 +1000)
committerRohan McGovern <rohan.mcgovern@nokia.com>
Wed, 18 May 2011 01:04:38 +0000 (11:04 +1000)
Using Q_ASSERT does nothing in release-mode builds, and in debug builds
it causes tests to terminate prematurely.  It is much better to use
QVERIFY or QCOMPARE.

Task-number: QTBUG-17582
Reviewed-by: Rohan McGovern
(cherry picked from commit 3475168550c1a804f04f2a4edfeb30c04cd36551)

tests/auto/xmlpatternsxqts/tst_suitetest.cpp

index 62cc4bb..ff6121f 100644 (file)
@@ -108,7 +108,7 @@ void tst_SuiteTest::runTestSuite() const
 
     /* Run the tests, and serialize the result(as according to XQTSResult.xsd) to standard out. */
     TestSuiteResult *const result = ts->runSuite();
-    Q_ASSERT(result);
+    QVERIFY(result);
 
     QFile out(m_candidateBaseline);
     QVERIFY(out.open(QIODevice::WriteOnly));