Notify about buildinfo parsing fail, fix leak

Without setting 'rc' code packing is failed with OK message:

[ 2687s] error: Can't parse BUILDINFO tag: unknown error
[ 2687s] Wrote: /home/abuild/rpmbuild/RPMS/armv7l/tizen-locale-0.1-2.49.armv7l.rpm

As the result rpm was not wrote and process exits successfully without errors.

Change-Id: I56a2a99b4347e056f79beda21180d1013148f4b6

diff --git a/build/pack.c b/build/pack.c
index b6c808e..eb87eca 100644 (file)
--- a/build/pack.c
+++ b/build/pack.c
@@ -341,6 +341,8 @@ static rpmRC writeRPM(Header *hdrp, unsigned char ** pkgidp, const char *fileNam
       char **strings = NULL;
 
       if ((err = poptParseArgvString(buildinfo, &count, &strings))) {
+       rc = RPMRC_FAIL;
+       free(buildinfo);
        rpmlog(RPMLOG_ERR, _("Can't parse BUILDINFO tag: %s\n"), poptStrerror(xx));
        goto exit;
       }