Merge pull request #1106 from nico/winfix
authorNico Weber <nicolasweber@gmx.de>
Fri, 5 Feb 2016 21:26:52 +0000 (16:26 -0500)
committerNico Weber <nicolasweber@gmx.de>
Fri, 5 Feb 2016 21:26:52 +0000 (16:26 -0500)
win: Only drop /showIncludes in bootstrap builds.

configure.py

index 92d0573..f0e452f 100755 (executable)
@@ -133,7 +133,9 @@ class Bootstrap:
         return self.writer.newline()
 
     def variable(self, key, val):
-        self.vars[key] = self._expand(val)
+        # In bootstrap mode, we have no ninja process to catch /showIncludes
+        # output.
+        self.vars[key] = self._expand(val).replace('/showIncludes', '')
         return self.writer.variable(key, val)
 
     def rule(self, name, **kwargs):
@@ -315,10 +317,6 @@ if platform.is_msvc():
               '/DNOMINMAX', '/D_CRT_SECURE_NO_WARNINGS',
               '/D_HAS_EXCEPTIONS=0',
               '/DNINJA_PYTHON="%s"' % options.with_python]
-    if options.bootstrap:
-        # In bootstrap mode, we have no ninja process to catch /showIncludes
-        # output.
-        cflags.remove('/showIncludes')
     if platform.msvc_needs_fs():
         cflags.append('/FS')
     ldflags = ['/DEBUG', '/libpath:$builddir']