fflush: adjust to glibc 2.28 libio.h removal

Problem reported by Daniel P. Berrangé in:
https://lists.gnu.org/r/bug-gnulib/2018-03/msg00000.html
* lib/fbufmode.c (fbufmode):
* lib/fflush.c (clear_ungetc_buffer_preserving_position)
(disable_seek_optimization, rpl_fflush):
* lib/fpending.c (__fpending):
* lib/fpurge.c (fpurge):
* lib/freadable.c (freadable):
* lib/freadahead.c (freadahead):
* lib/freading.c (freading):
* lib/freadptr.c (freadptr):
* lib/freadseek.c (freadptrinc):
* lib/fseeko.c (fseeko):
* lib/fseterr.c (fseterr):
* lib/fwritable.c (fwritable):
* lib/fwriting.c (fwriting):
Check _IO_EOF_SEEN instead of _IO_ftrylockfile.
* lib/stdio-impl.h (_IO_IN_BACKUP) [_IO_EOF_SEEN]:
Define if not already defined.

(cherry picked from gnulib commit 4af4a4a71827c0bc5e0ec67af23edef4f15cee8e)

diff --git a/ChangeLog b/ChangeLog
index cf04ae4..36ece54 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,26 @@
+2018-03-05  Paul Eggert  <eggert@cs.ucla.edu>
+
+       fflush: adjust to glibc 2.28 libio.h removal
+       Problem reported by Daniel P. Berrangé in:
+       https://lists.gnu.org/r/bug-gnulib/2018-03/msg00000.html
+       * lib/fbufmode.c (fbufmode):
+       * lib/fflush.c (clear_ungetc_buffer_preserving_position)
+       (disable_seek_optimization, rpl_fflush):
+       * lib/fpending.c (__fpending):
+       * lib/fpurge.c (fpurge):
+       * lib/freadable.c (freadable):
+       * lib/freadahead.c (freadahead):
+       * lib/freading.c (freading):
+       * lib/freadptr.c (freadptr):
+       * lib/freadseek.c (freadptrinc):
+       * lib/fseeko.c (fseeko):
+       * lib/fseterr.c (fseterr):
+       * lib/fwritable.c (fwritable):
+       * lib/fwriting.c (fwriting):
+       Check _IO_EOF_SEEN instead of _IO_ftrylockfile.
+       * lib/stdio-impl.h (_IO_IN_BACKUP) [_IO_EOF_SEEN]:
+       Define if not already defined.
+
 2014-09-01  Daiki Ueno  <ueno@gnu.org>
 
        * Version 0.9.4 released.

diff --git a/lib/fseterr.c b/lib/fseterr.c
index 030f6e5..c93ae06 100644 (file)
--- a/lib/fseterr.c
+++ b/lib/fseterr.c
@@ -29,7 +29,7 @@ fseterr (FILE *fp)
   /* Most systems provide FILE as a struct and the necessary bitmask in
      <stdio.h>, because they need it for implementing getc() and putc() as
      fast macros.  */
-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
+#if defined _IO_EOF_SEEN || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */
   fp->_flags |= _IO_ERR_SEEN;
 #elif defined __sferror || defined __DragonFly__ /* FreeBSD, NetBSD, OpenBSD, DragonFly, Mac OS X, Cygwin */
   fp_->_flags |= __SERR;

diff --git a/lib/stdio-impl.h b/lib/stdio-impl.h
index b50c937..3608578 100644 (file)
--- a/lib/stdio-impl.h
+++ b/lib/stdio-impl.h
@@ -18,6 +18,12 @@
    the same implementation of stdio extension API, except that some fields
    have different naming conventions, or their access requires some casts.  */
 
+/* Glibc 2.28 made _IO_IN_BACKUP private.  For now, work around this
+   problem by defining it ourselves.  FIXME: Do not rely on glibc
+   internals.  */
+#if !defined _IO_IN_BACKUP && defined _IO_EOF_SEEN
+# define _IO_IN_BACKUP 0x100
+#endif
 
 /* BSD stdio derived implementations.  */