src/rules.c

   1 /*
   2  * Copyright (c) 2007-2017, SUSE Inc.
   3  *
   4  * This program is licensed under the BSD license, read LICENSE.BSD
   5  * for further information
   6  */
   7
   8 /*
   9  * rules.c
  10  *
  11  * SAT based dependency solver
  12  */
  13
  14 #include <stdio.h>
  15 #include <stdlib.h>
  16 #include <unistd.h>
  17 #include <string.h>
  18 #include <assert.h>
  19
  20 #include "solver.h"
  21 #include "solver_private.h"
  22 #include "bitmap.h"
  23 #include "pool.h"
  24 #include "poolarch.h"
  25 #include "util.h"
  26 #include "evr.h"
  27 #include "policy.h"
  28 #include "solverdebug.h"
  29 #include "linkedpkg.h"
  30 #include "cplxdeps.h"
  31
  32 #define RULES_BLOCK 63
  33
  34 static void addpkgruleinfo(Solver *solv, Id p, Id p2, Id d, int type, Id dep);
  35
  36 static inline int
  37 is_otherproviders_dep(Pool *pool, Id dep)
  38 {
  39   if (ISRELDEP(dep))
  40     {
  41       Reldep *rd = GETRELDEP(pool, dep);
  42       if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_OTHERPROVIDERS)
  43         return 1;
  44     }
  45   return 0;
  46 }
  47
  48 /********************************************************************
  49  *
  50  * Rule handling
  51  *
  52  * - unify rules, remove duplicates
  53  */
  54
  55 /*-------------------------------------------------------------------
  56  *
  57  * compare rules for unification sort
  58  *
  59  */
  60
  61 static int
  62 unifyrules_sortcmp(const void *ap, const void *bp, void *dp)
  63 {
  64   Pool *pool = dp;
  65   Rule *a = (Rule *)ap;
  66   Rule *b = (Rule *)bp;
  67   Id *ad, *bd;
  68   int x;
  69
  70   x = a->p - b->p;
  71   if (x)
  72     return x;                           /* p differs */
  73
  74   /* identical p */
  75   if (a->d == 0 && b->d == 0)           /* both assertions or binary */
  76     return a->w2 - b->w2;
  77
  78   if (a->d == 0)                        /* a is assertion or binary, b not */
  79     {
  80       x = a->w2 - pool->whatprovidesdata[b->d];
  81       return x ? x : -1;
  82     }
  83
  84   if (b->d == 0)                        /* b is assertion or binary, a not */
  85     {
  86       x = pool->whatprovidesdata[a->d] - b->w2;
  87       return x ? x : 1;
  88     }
  89
  90   if (a->d == b->d)
  91     return 0;
  92
  93   /* compare whatprovidesdata */
  94   ad = pool->whatprovidesdata + a->d;
  95   bd = pool->whatprovidesdata + b->d;
  96   while (*bd)
  97     if ((x = *ad++ - *bd++) != 0)
  98       return x;
  99   return *ad;
 100 }
 101
 102 int
 103 solver_rulecmp(Solver *solv, Rule *r1, Rule *r2)
 104 {
 105   return unifyrules_sortcmp(r1, r2, solv->pool);
 106 }
 107
 108
 109 /*-------------------------------------------------------------------
 110  *
 111  * unify rules
 112  * go over all rules and remove duplicates
 113  */
 114
 115 void
 116 solver_unifyrules(Solver *solv)
 117 {
 118   Pool *pool = solv->pool;
 119   int i, j;
 120   Rule *ir, *jr;
 121
 122   if (solv->nrules <= 2)                /* nothing to unify */
 123     return;
 124
 125   if (solv->recommendsruleq)
 126     {
 127       /* mis-use n2 as recommends rule marker */
 128       for (i = 1, ir = solv->rules + i; i < solv->nrules; i++, ir++)
 129         ir->n2 = 0;
 130       for (i = 0; i < solv->recommendsruleq->count; i++)
 131         solv->rules[solv->recommendsruleq->elements[i]].n2 = 1;
 132     }
 133
 134   /* sort rules first */
 135   solv_sort(solv->rules + 1, solv->nrules - 1, sizeof(Rule), unifyrules_sortcmp, solv->pool);
 136
 137   /* prune rules */
 138   jr = 0;
 139   for (i = j = 1, ir = solv->rules + i; i < solv->nrules; i++, ir++)
 140     {
 141       if (jr && !unifyrules_sortcmp(ir, jr, pool))
 142         {
 143           jr->n2 &= ir->n2;             /* bitwise-and recommends marker */
 144           continue;                     /* prune! */
 145         }
 146       jr = solv->rules + j++;           /* keep! */
 147       if (ir != jr)
 148         *jr = *ir;
 149     }
 150
 151   /* reduced count from nrules to j rules */
 152   POOL_DEBUG(SOLV_DEBUG_STATS, "pruned rules from %d to %d\n", solv->nrules, j);
 153
 154   /* adapt rule buffer */
 155   solver_shrinkrules(solv, j);
 156
 157   if (solv->recommendsruleq)
 158     {
 159       /* rebuild recommendsruleq */
 160       queue_empty(solv->recommendsruleq);
 161       for (i = 1, ir = solv->rules + i; i < solv->nrules; i++, ir++)
 162         if (ir->n2)
 163           {
 164             ir->n2 = 0;
 165             queue_push(solv->recommendsruleq, i);
 166           }
 167     }
 168
 169   /*
 170    * debug: log rule statistics
 171    */
 172   IF_POOLDEBUG (SOLV_DEBUG_STATS)
 173     {
 174       int binr = 0;
 175       int lits = 0;
 176       Id *dp;
 177       Rule *r;
 178
 179       for (i = 1; i < solv->nrules; i++)
 180         {
 181           r = solv->rules + i;
 182           if (r->d == 0)
 183             binr++;
 184           else
 185             {
 186               dp = solv->pool->whatprovidesdata + r->d;
 187               while (*dp++)
 188                 lits++;
 189             }
 190         }
 191       POOL_DEBUG(SOLV_DEBUG_STATS, "  binary: %d\n", binr);
 192       POOL_DEBUG(SOLV_DEBUG_STATS, "  normal: %d, %d literals\n", solv->nrules - 1 - binr, lits);
 193     }
 194 }
 195
 196 #if 0
 197
 198 /*
 199  * hash rule
 200  */
 201
 202 static Hashval
 203 hashrule(Solver *solv, Id p, Id d, int n)
 204 {
 205   unsigned int x = (unsigned int)p;
 206   int *dp;
 207
 208   if (n <= 1)
 209     return (x * 37) ^ (unsigned int)d;
 210   dp = solv->pool->whatprovidesdata + d;
 211   while (*dp)
 212     x = (x * 37) ^ (unsigned int)*dp++;
 213   return x;
 214 }
 215 #endif
 216
 217
 218 /*-------------------------------------------------------------------
 219  *
 220  */
 221
 222 /*
 223  * add rule
 224  *
 225  * A requires b, b provided by B1,B2,B3 => (-A|B1|B2|B3)
 226  *
 227  * p < 0  : pkg id of A
 228  * d > 0  : Offset in whatprovidesdata (list of providers of b)
 229  *
 230  * A conflicts b, b provided by B1,B2,B3 => (-A|-B1), (-A|-B2), (-A|-B3)
 231  * p < 0  : pkg id of A
 232  * p2 < 0 : Id of solvable (e.g. B1)
 233  *
 234  * d == 0, p2 == 0: unary rule, assertion => (A) or (-A)
 235  *
 236  *   Install:    p > 0, d = 0   (A)             user requested install
 237  *   Remove:     p < 0, d = 0   (-A)            user requested remove (also: uninstallable)
 238  *   Requires:   p < 0, d > 0   (-A|B1|B2|...)  d: <list of providers for requirement of p>
 239  *   Updates:    p > 0, d > 0   (A|B1|B2|...)   d: <list of updates for solvable p>
 240  *   Conflicts:  p < 0, p2 < 0  (-A|-B)         either p (conflict issuer) or d (conflict provider) (binary rule)
 241  *                                              also used for obsoletes
 242  *   No-op ?:    p = 0, d = 0   (null)          (used as placeholder in update/feature rules)
 243  *
 244  *   resulting watches:
 245  *   ------------------
 246  *   Direct assertion (no watch needed) --> d = 0, w1 = p, w2 = 0
 247  *   Binary rule: p = first literal, d = 0, w2 = second literal, w1 = p
 248  *   every other : w1 = p, w2 = whatprovidesdata[d];
 249  *
 250  *   always returns a rule for non-pkg rules
 251  */
 252
 253 Rule *
 254 solver_addrule(Solver *solv, Id p, Id p2, Id d)
 255 {
 256   Pool *pool = solv->pool;
 257   Rule *r;
 258
 259   if (d)
 260     {
 261       assert(!p2 && d > 0);
 262       if (!pool->whatprovidesdata[d])
 263         d = 0;
 264       else if (!pool->whatprovidesdata[d + 1])
 265         {
 266           p2 = pool->whatprovidesdata[d];
 267           d = 0;
 268         }
 269     }
 270
 271   /* now we have two cases:
 272    * 1 or 2 literals:    d = 0, p, p2 contain the literals
 273    * 3 or more literals: d > 0, p2 == 0, d is offset into whatprovidesdata
 274    */
 275
 276   /* it often happenes that requires lead to adding the same pkg rule
 277    * multiple times, so we prune those duplicates right away to make
 278    * the work for unifyrules a bit easier */
 279   if (!solv->pkgrules_end)              /* we add pkg rules */
 280     {
 281       r = solv->rules + solv->lastpkgrule;
 282       if (d)
 283         {
 284           Id *dp;
 285           /* check if rule is identical */
 286           if (r->p == p)
 287             {
 288               Id *dp2;
 289               if (r->d == d)
 290                 return r;
 291               dp2 = pool->whatprovidesdata + r->d;
 292               for (dp = pool->whatprovidesdata + d; *dp; dp++, dp2++)
 293                 if (*dp != *dp2)
 294                   break;
 295               if (*dp == *dp2)
 296                 return r;
 297             }
 298           /* check if rule is self-fulfilling */
 299           for (dp = pool->whatprovidesdata + d; *dp; dp++)
 300             if (*dp == -p)
 301               return 0;                 /* rule is self-fulfilling */
 302         }
 303       else
 304         {
 305           if (p2 && p > p2)
 306             {
 307               Id o = p;                 /* switch p1 and p2 */
 308               p = p2;
 309               p2 = o;
 310             }
 311           if (r->p == p && !r->d && r->w2 == p2)
 312             return r;
 313           if (p == -p2)
 314             return 0;                   /* rule is self-fulfilling */
 315         }
 316       solv->lastpkgrule = solv->nrules;
 317     }
 318
 319   solv->rules = solv_extend(solv->rules, solv->nrules, 1, sizeof(Rule), RULES_BLOCK);
 320   r = solv->rules + solv->nrules++;    /* point to rule space */
 321   r->p = p;
 322   r->d = d;
 323   r->w1 = p;
 324   r->w2 = d ? pool->whatprovidesdata[d] : p2;
 325   r->n1 = 0;
 326   r->n2 = 0;
 327   IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
 328     {
 329       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "  Add rule: ");
 330       solver_printrule(solv, SOLV_DEBUG_RULE_CREATION, r);
 331     }
 332   return r;
 333 }
 334
 335
 336 void
 337 solver_shrinkrules(Solver *solv, int nrules)
 338 {
 339   solv->nrules = nrules;
 340   solv->rules = solv_extend_resize(solv->rules, solv->nrules, sizeof(Rule), RULES_BLOCK);
 341   solv->lastpkgrule = 0;
 342 }
 343
 344 /******************************************************************************
 345  ***
 346  *** pkg rule part: create rules representing the package dependencies
 347  ***
 348  ***/
 349
 350 /*
 351  *  special multiversion patch conflict handling:
 352  *  a patch conflict is also satisfied if some other
 353  *  version with the same name/arch that doesn't conflict
 354  *  gets installed. The generated rule is thus:
 355  *  -patch|-cpack|opack1|opack2|...
 356  */
 357 static Id
 358 makemultiversionconflict(Solver *solv, Id n, Id con)
 359 {
 360   Pool *pool = solv->pool;
 361   Solvable *s, *sn;
 362   Queue q;
 363   Id p, pp, qbuf[64];
 364
 365   sn = pool->solvables + n;
 366   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
 367   queue_push(&q, -n);
 368   FOR_PROVIDES(p, pp, sn->name)
 369     {
 370       s = pool->solvables + p;
 371       if (s->name != sn->name || s->arch != sn->arch)
 372         continue;
 373       if (!MAPTST(&solv->multiversion, p))
 374         continue;
 375       if (pool_match_nevr(pool, pool->solvables + p, con))
 376         continue;
 377       /* here we have a multiversion solvable that doesn't conflict */
 378       /* thus we're not in conflict if it is installed */
 379       queue_push(&q, p);
 380     }
 381   if (q.count == 1)
 382     n = 0;      /* no other package found, normal conflict handling */
 383   else
 384     n = pool_queuetowhatprovides(pool, &q);
 385   queue_free(&q);
 386   return n;
 387 }
 388
 389 static inline void
 390 addpkgrule(Solver *solv, Id p, Id p2, Id d, int type, Id dep)
 391 {
 392   if (!solv->ruleinfoq)
 393     solver_addrule(solv, p, p2, d);
 394   else
 395     addpkgruleinfo(solv, p, p2, d, type, dep);
 396 }
 397
 398 #ifdef ENABLE_LINKED_PKGS
 399
 400 static int
 401 addlinks_cmp(const void *ap, const void *bp, void *dp)
 402 {
 403   Pool *pool = dp;
 404   Id a = *(Id *)ap;
 405   Id b = *(Id *)bp;
 406   Solvable *sa = pool->solvables + a;
 407   Solvable *sb = pool->solvables + b;
 408   if (sa->name != sb->name)
 409     return sa->name - sb->name;
 410   return sa - sb;
 411 }
 412
 413 static void
 414 addlinks(Solver *solv, Solvable *s, Id req, Queue *qr, Id prv, Queue *qp, Map *m, Queue *workq)
 415 {
 416   Pool *pool = solv->pool;
 417   int i;
 418   if (!qr->count)
 419     return;
 420   if (qp->count > 1)
 421     solv_sort(qp->elements, qp->count, sizeof(Id), addlinks_cmp, pool);
 422 #if 0
 423   printf("ADDLINKS %s\n -> %s\n", pool_solvable2str(pool, s), pool_dep2str(pool, req));
 424   for (i = 0; i < qr->count; i++)
 425     printf("    - %s\n", pool_solvid2str(pool, qr->elements[i]));
 426   printf(" <- %s\n", pool_dep2str(pool, prv));
 427   for (i = 0; i < qp->count; i++)
 428     printf("    - %s\n", pool_solvid2str(pool, qp->elements[i]));
 429 #endif
 430
 431   if (qr->count == 1)
 432     addpkgrule(solv, -(s - pool->solvables), qr->elements[0], 0, SOLVER_RULE_PKG_REQUIRES, req);
 433   else
 434     addpkgrule(solv, -(s - pool->solvables), 0, pool_queuetowhatprovides(pool, qr), SOLVER_RULE_PKG_REQUIRES, req);
 435   if (qp->count > 1)
 436     {
 437       int j;
 438       for (i = j = 0; i < qp->count; i = j)
 439         {
 440           Id d = pool->solvables[qp->elements[i]].name;
 441           for (j = i + 1; j < qp->count; j++)
 442             if (d != pool->solvables[qp->elements[j]].name)
 443               break;
 444           d = pool_ids2whatprovides(pool, qp->elements + i, j - i);
 445           for (i = 0; i < qr->count; i++)
 446             addpkgrule(solv, -qr->elements[i], 0, d, SOLVER_RULE_PKG_REQUIRES, prv);
 447         }
 448     }
 449   else if (qp->count)
 450     {
 451       for (i = 0; i < qr->count; i++)
 452         addpkgrule(solv, -qr->elements[i], qp->elements[0], 0, SOLVER_RULE_PKG_REQUIRES, prv);
 453     }
 454   if (!m)
 455     return;     /* nothing more to do if called from getpkgruleinfos() */
 456   for (i = 0; i < qr->count; i++)
 457     if (!MAPTST(m, qr->elements[i]))
 458       queue_push(workq, qr->elements[i]);
 459   for (i = 0; i < qp->count; i++)
 460     if (!MAPTST(m, qp->elements[i]))
 461       queue_push(workq, qp->elements[i]);
 462   if (solv->installed && s->repo == solv->installed)
 463     {
 464       Repo *installed = solv->installed;
 465       /* record installed buddies */
 466       if (!solv->instbuddy)
 467         solv->instbuddy = solv_calloc(installed->end - installed->start, sizeof(Id));
 468       if (qr->count == 1)
 469         solv->instbuddy[s - pool->solvables - installed->start] = qr->elements[0];
 470       for (i = 0; i < qr->count; i++)
 471         {
 472           Id p = qr->elements[i];
 473           if (pool->solvables[p].repo != installed)
 474             continue;   /* huh? */
 475           if (qp->count > 1 || (solv->instbuddy[p - installed->start] != 0 && solv->instbuddy[p - installed->start] != s - pool->solvables))
 476             solv->instbuddy[p - installed->start] = 1;  /* 1: ambiguous buddy */
 477           else
 478             solv->instbuddy[p - installed->start] = s - pool->solvables;
 479         }
 480     }
 481 }
 482
 483 static void
 484 add_package_link(Solver *solv, Solvable *s, Map *m, Queue *workq)
 485 {
 486   Queue qr, qp;
 487   Id req = 0, prv = 0;
 488   queue_init(&qr);
 489   queue_init(&qp);
 490   find_package_link(solv->pool, s, &req, &qr, &prv, &qp);
 491   if (qr.count)
 492     addlinks(solv, s, req, &qr, prv, &qp, m, workq);
 493   queue_free(&qr);
 494   queue_free(&qp);
 495 }
 496
 497 #endif
 498
 499 #ifdef ENABLE_COMPLEX_DEPS
 500
 501 static void
 502 add_complex_deprules(Solver *solv, Id p, Id dep, int type, int dontfix, Queue *workq, Map *m)
 503 {
 504   Pool *pool = solv->pool;
 505   Repo *installed = solv->installed;
 506   int i, j, flags;
 507   Queue bq;
 508
 509   queue_init(&bq);
 510   flags = dontfix ? CPLXDEPS_DONTFIX : 0;
 511   /* CNF expansion for requires, DNF + INVERT expansion for conflicts */
 512   if (type == SOLVER_RULE_PKG_CONFLICTS)
 513     flags |= CPLXDEPS_TODNF | CPLXDEPS_EXPAND | CPLXDEPS_INVERT;
 514
 515   i = pool_normalize_complex_dep(pool, dep, &bq, flags);
 516   /* handle special cases */
 517   if (i == 0)
 518     {
 519       if (dontfix)
 520         {
 521           POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "ignoring broken dependency %s of installed package %s\n", pool_dep2str(pool, dep), pool_solvid2str(pool, p));
 522         }
 523       else
 524         {
 525           POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable (%s)\n", pool_solvid2str(pool, p), p, pool_dep2str(pool, dep));
 526           addpkgrule(solv, -p, 0, 0, type == SOLVER_RULE_PKG_REQUIRES ? SOLVER_RULE_PKG_NOTHING_PROVIDES_DEP : type, dep);
 527         }
 528       queue_free(&bq);
 529       return;
 530     }
 531   if (i == 1)
 532     {
 533       queue_free(&bq);
 534       return;
 535     }
 536
 537   /* go through all blocks and add a rule for each block */
 538   for (i = 0; i < bq.count; i++)
 539     {
 540       if (!bq.elements[i])
 541         continue;       /* huh? */
 542       if (bq.elements[i] == pool->nsolvables)
 543         {
 544           /* conventional requires (cannot be a conflicts as they have been expanded) */
 545           Id *dp = pool->whatprovidesdata + bq.elements[i + 1];
 546           i += 2;
 547           if (dontfix)
 548             {
 549               for (j = 0; dp[j] != 0; j++)
 550                 if (pool->solvables[dp[j]].repo == installed)
 551                   break;                /* provider was installed */
 552               if (!dp[j])
 553                 continue;
 554             }
 555           if (type == SOLVER_RULE_PKG_RECOMMENDS && !*dp)
 556             continue;
 557           /* check if the rule contains both p and -p */
 558           for (j = 0; dp[j] != 0; j++)
 559             if (dp[j] == p)
 560               break;
 561           if (dp[j])
 562             continue;
 563           addpkgrule(solv, -p, 0, dp - pool->whatprovidesdata, type, dep);
 564           /* push all non-visited providers on the work queue */
 565           if (m)
 566             for (; *dp; dp++)
 567               if (!MAPTST(m, *dp))
 568                 queue_push(workq, *dp);
 569           continue;
 570         }
 571       if (!bq.elements[i + 1])
 572         {
 573           Id p2 = bq.elements[i++];
 574           /* simple rule with just two literals, we'll add a (-p, p2) rule */
 575           if (dontfix)
 576             {
 577               if (p2 < 0 && pool->solvables[-p2].repo == installed)
 578                 continue;
 579               if (p2 > 0 && pool->solvables[p2].repo != installed)
 580                 continue;
 581             }
 582           if (-p == p2)
 583             {
 584               if (type == SOLVER_RULE_PKG_CONFLICTS)
 585                 {
 586                   if (pool->forbidselfconflicts && !is_otherproviders_dep(pool, dep))
 587                     addpkgrule(solv, -p, 0, 0, SOLVER_RULE_PKG_SELF_CONFLICT, dep);
 588                   continue;
 589                 }
 590               addpkgrule(solv, -p, 0, 0, type, dep);
 591               continue;
 592             }
 593           /* check if the rule contains both p and -p */
 594           if (p == p2)
 595             continue;
 596           addpkgrule(solv, -p, p2, 0, type, dep);
 597           if (m && p2 > 0 && !MAPTST(m, p2))
 598             queue_push(workq, p2);
 599         }
 600       else
 601         {
 602           Id *qele;
 603           int qcnt;
 604
 605           qele = bq.elements + i;
 606           qcnt = i;
 607           while (bq.elements[i])
 608              i++;
 609           qcnt = i - qcnt;
 610           if (dontfix)
 611             {
 612               for (j = 0; j < qcnt; j++)
 613                 {
 614                   if (qele[j] > 0 && pool->solvables[qele[j]].repo == installed)
 615                     break;
 616                   if (qele[j] < 0 && pool->solvables[-qele[j]].repo != installed)
 617                     break;
 618                 }
 619               if (j == qcnt)
 620                 continue;
 621             }
 622           /* add -p to (ordered) rule (overwriting the trailing zero) */
 623           for (j = 0; ; j++)
 624             {
 625               if (j == qcnt || qele[j] > -p)
 626                 {
 627                   if (j < qcnt)
 628                     memmove(qele + j + 1, qele + j, (qcnt - j) * sizeof(Id));
 629                   qele[j] = -p;
 630                   qcnt++;
 631                   break;
 632                 }
 633               if (qele[j] == -p)
 634                 break;
 635             }
 636           /* check if the rule contains both p and -p */
 637           for (j = 0; j < qcnt; j++)
 638             if (qele[j] == p)
 639               break;
 640           if (j < qcnt)
 641             continue;
 642           addpkgrule(solv, qele[0], 0, pool_ids2whatprovides(pool, qele + 1, qcnt - 1), type, dep);
 643           if (m)
 644             for (j = 0; j < qcnt; j++)
 645               if (qele[j] > 0 && !MAPTST(m, qele[j]))
 646                 queue_push(workq, qele[j]);
 647         }
 648     }
 649   queue_free(&bq);
 650 }
 651
 652 #endif
 653
 654 /*-------------------------------------------------------------------
 655  *
 656  * add dependency rules for solvable
 657  *
 658  * s: Solvable for which to add rules
 659  * m: m[s] = 1 for solvables which have rules, prevent rule duplication
 660  *
 661  * Algorithm: 'visit all nodes of a graph'. The graph nodes are
 662  *  solvables, the edges their dependencies.
 663  *  Starting from an installed solvable, this will create all rules
 664  *  representing the graph created by the solvables dependencies.
 665  *
 666  * for unfulfilled requirements, conflicts, obsoletes,....
 667  * add a negative assertion for solvables that are not installable
 668  *
 669  * It will also create rules for all solvables referenced by 's'
 670  *  i.e. descend to all providers of requirements of 's'
 671  *
 672  */
 673
 674 void
 675 solver_addpkgrulesforsolvable(Solver *solv, Solvable *s, Map *m)
 676 {
 677   Pool *pool = solv->pool;
 678   Repo *installed = solv->installed;
 679
 680   Queue workq;  /* list of solvables we still have to work on */
 681   Id workqbuf[64];
 682   Queue prereqq;        /* list of pre-req ids to ignore */
 683   Id prereqbuf[16];
 684
 685   int i;
 686   int dontfix;          /* ignore dependency errors for installed solvables */
 687   Id req, *reqp;
 688   Id con, *conp;
 689   Id obs, *obsp;
 690   Id rec, *recp;
 691   Id sug, *sugp;
 692   Id p, pp;             /* whatprovides loops */
 693   Id *dp;               /* ptr to 'whatprovides' */
 694   Id n;                 /* Id for current solvable 's' */
 695
 696   queue_init_buffer(&workq, workqbuf, sizeof(workqbuf)/sizeof(*workqbuf));
 697   queue_push(&workq, s - pool->solvables);      /* push solvable Id to work queue */
 698
 699   queue_init_buffer(&prereqq, prereqbuf, sizeof(prereqbuf)/sizeof(*prereqbuf));
 700
 701   /* loop until there's no more work left */
 702   while (workq.count)
 703     {
 704       /*
 705        * n: Id of solvable
 706        * s: Pointer to solvable
 707        */
 708
 709       n = queue_shift(&workq);          /* 'pop' next solvable to work on from queue */
 710       if (m)
 711         {
 712           if (MAPTST(m, n))             /* continue if already visited */
 713             continue;
 714           MAPSET(m, n);                 /* mark as visited */
 715         }
 716
 717       s = pool->solvables + n;
 718
 719       dontfix = 0;
 720       if (installed                     /* Installed system available */
 721           && s->repo == installed       /* solvable is installed */
 722           && !solv->fixmap_all          /* NOT repair errors in dependency graph */
 723           && !(solv->fixmap.size && MAPTST(&solv->fixmap, n - installed->start)))
 724         {
 725           dontfix = 1;                  /* dont care about broken deps */
 726         }
 727
 728       if (!dontfix)
 729         {
 730           if (s->arch == ARCH_SRC || s->arch == ARCH_NOSRC
 731                 ? pool_disabled_solvable(pool, s)
 732                 : !pool_installable(pool, s))
 733             {
 734               POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable\n", pool_solvid2str(pool, n), n);
 735               addpkgrule(solv, -n, 0, 0, SOLVER_RULE_PKG_NOT_INSTALLABLE, 0);
 736             }
 737         }
 738
 739 #ifdef ENABLE_LINKED_PKGS
 740       /* add pseudo-package <-> real-package links */
 741       if (has_package_link(pool, s))
 742         add_package_link(solv, s, m, &workq);
 743 #endif
 744
 745       /*-----------------------------------------
 746        * check requires of s
 747        */
 748
 749       if (s->requires)
 750         {
 751           int filterpre = 0;
 752           reqp = s->repo->idarraydata + s->requires;
 753           while ((req = *reqp++) != 0)            /* go through all requires */
 754             {
 755               if (req == SOLVABLE_PREREQMARKER)   /* skip the marker */
 756                 {
 757                   if (installed && s->repo == installed)
 758                     {
 759                       if (prereqq.count)
 760                         queue_empty(&prereqq);
 761                       solvable_lookup_idarray(s, SOLVABLE_PREREQ_IGNOREINST, &prereqq);
 762                       filterpre = prereqq.count;
 763                     }
 764                   continue;
 765                 }
 766               if (filterpre)
 767                 {
 768                   /* check if this id is filtered. assumes that prereqq.count is small */
 769                   for (i = 0; i < prereqq.count; i++)
 770                     if (req == prereqq.elements[i])
 771                       break;
 772                   if (i < prereqq.count)
 773                     {
 774                       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s: ignoring filtered pre-req dependency %s\n", pool_solvable2str(pool, s), pool_dep2str(pool, req));
 775                       continue;
 776                     }
 777                 }
 778
 779 #ifdef ENABLE_COMPLEX_DEPS
 780               if (pool_is_complex_dep(pool, req))
 781                 {
 782                   /* we have AND/COND deps, normalize */
 783                   add_complex_deprules(solv, n, req, SOLVER_RULE_PKG_REQUIRES, dontfix, &workq, m);
 784                   continue;
 785                 }
 786 #endif
 787
 788               /* find list of solvables providing 'req' */
 789               dp = pool_whatprovides_ptr(pool, req);
 790
 791               if (*dp == SYSTEMSOLVABLE)          /* always installed */
 792                 continue;
 793
 794               if (dontfix)
 795                 {
 796                   /* the strategy here is to not insist on dependencies
 797                    * that are already broken. so if we find one provider
 798                    * that was already installed, we know that the
 799                    * dependency was not broken before so we enforce it */
 800                   for (i = 0; (p = dp[i]) != 0; i++)
 801                     if (pool->solvables[p].repo == installed)
 802                       break;            /* found installed provider */
 803                   if (!p)
 804                     {
 805                       /* didn't find an installed provider: previously broken dependency */
 806                       POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "ignoring broken requires %s of installed package %s\n", pool_dep2str(pool, req), pool_solvable2str(pool, s));
 807                       continue;
 808                     }
 809                 }
 810
 811               if (!*dp)
 812                 {
 813                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable (%s)\n", pool_solvid2str(pool, n), n, pool_dep2str(pool, req));
 814                   addpkgrule(solv, -n, 0, 0, SOLVER_RULE_PKG_NOTHING_PROVIDES_DEP, req);
 815                   continue;
 816                 }
 817
 818               for (i = 0; dp[i] != 0; i++)
 819                 if (n == dp[i])
 820                   break;
 821               if (dp[i])
 822                 continue;               /* provided by itself, no need to add rule */
 823
 824               IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
 825                 {
 826                   POOL_DEBUG(SOLV_DEBUG_RULE_CREATION,"  %s requires %s\n", pool_solvable2str(pool, s), pool_dep2str(pool, req));
 827                   for (i = 0; dp[i]; i++)
 828                     POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "   provided by %s\n", pool_solvid2str(pool, dp[i]));
 829                 }
 830
 831               /* add 'requires' dependency */
 832               /* rule: (-requestor|provider1|provider2|...|providerN) */
 833               addpkgrule(solv, -n, 0, dp - pool->whatprovidesdata, SOLVER_RULE_PKG_REQUIRES, req);
 834
 835               /* push all non-visited providers on the work queue */
 836               if (m)
 837                 for (; *dp; dp++)
 838                   if (!MAPTST(m, *dp))
 839                     queue_push(&workq, *dp);
 840             }
 841         }
 842
 843       if (s->recommends && solv->strongrecommends)
 844         {
 845           int start = solv->nrules;
 846           solv->lastpkgrule = 0;
 847           reqp = s->repo->idarraydata + s->recommends;
 848           while ((req = *reqp++) != 0)            /* go through all recommends */
 849             {
 850 #ifdef ENABLE_COMPLEX_DEPS
 851               if (pool_is_complex_dep(pool, req))
 852                 {
 853                   /* we have AND/COND deps, normalize */
 854                   add_complex_deprules(solv, n, req, SOLVER_RULE_PKG_RECOMMENDS, dontfix, &workq, m);
 855                   continue;
 856                 }
 857 #endif
 858               dp = pool_whatprovides_ptr(pool, req);
 859               if (*dp == SYSTEMSOLVABLE || !*dp)          /* always installed or not installable */
 860                 continue;
 861               for (i = 0; dp[i] != 0; i++)
 862                 if (n == dp[i])
 863                   break;
 864               if (dp[i])
 865                 continue;               /* provided by itself, no need to add rule */
 866               addpkgrule(solv, -n, 0, dp - pool->whatprovidesdata, SOLVER_RULE_PKG_RECOMMENDS, req);
 867               if (m)
 868                 for (; *dp; dp++)
 869                   if (!MAPTST(m, *dp))
 870                     queue_push(&workq, *dp);
 871             }
 872           if (!solv->ruleinfoq && start < solv->nrules)
 873             {
 874               if (!solv->recommendsruleq)
 875                 {
 876                   solv->recommendsruleq = solv_calloc(1, sizeof(Queue));
 877                   queue_init(solv->recommendsruleq);
 878                 }
 879               for (i = start; i < solv->nrules; i++)
 880                 queue_push(solv->recommendsruleq, i);
 881               solv->lastpkgrule = 0;
 882             }
 883         }
 884
 885       /* that's all we check for src packages */
 886       if (s->arch == ARCH_SRC || s->arch == ARCH_NOSRC)
 887         continue;
 888
 889       /*-----------------------------------------
 890        * check conflicts of s
 891        */
 892
 893       if (s->conflicts)
 894         {
 895           int ispatch = 0;
 896
 897           /* we treat conflicts in patches a bit differen:
 898            * - nevr matching
 899            * - multiversion handling
 900            * XXX: we should really handle this different, looking
 901            * at the name is a bad hack
 902            */
 903           if (!strncmp("patch:", pool_id2str(pool, s->name), 6))
 904             ispatch = 1;
 905           conp = s->repo->idarraydata + s->conflicts;
 906           /* foreach conflicts of 's' */
 907           while ((con = *conp++) != 0)
 908             {
 909 #ifdef ENABLE_COMPLEX_DEPS
 910               if (!ispatch && pool_is_complex_dep(pool, con))
 911                 {
 912                   /* we have AND/COND deps, normalize */
 913                   add_complex_deprules(solv, n, con, SOLVER_RULE_PKG_CONFLICTS, dontfix, &workq, m);
 914                   continue;
 915                 }
 916 #endif
 917               /* foreach providers of a conflict of 's' */
 918               FOR_PROVIDES(p, pp, con)
 919                 {
 920                   if (ispatch && !pool_match_nevr(pool, pool->solvables + p, con))
 921                     continue;
 922                   /* dontfix: dont care about conflicts with already installed packs */
 923                   if (dontfix && pool->solvables[p].repo == installed)
 924                     continue;
 925                   if (p == n)           /* p == n: self conflict */
 926                     {
 927                       if (!pool->forbidselfconflicts || is_otherproviders_dep(pool, con))
 928                         continue;
 929                       addpkgrule(solv, -n, 0, 0, SOLVER_RULE_PKG_SELF_CONFLICT, con);
 930                       continue;
 931                     }
 932                   if (ispatch && solv->multiversion.size && MAPTST(&solv->multiversion, p) && ISRELDEP(con))
 933                     {
 934                       /* our patch conflicts with a multiversion package */
 935                       Id d = makemultiversionconflict(solv, p, con);
 936                       if (d)
 937                         {
 938                           addpkgrule(solv, -n, 0, d, SOLVER_RULE_PKG_CONFLICTS, con);
 939                           continue;
 940                         }
 941                     }
 942                   if (p == SYSTEMSOLVABLE)
 943                     p = 0;
 944                   /* rule: -n|-p: either solvable _or_ provider of conflict */
 945                   addpkgrule(solv, -n, -p, 0, SOLVER_RULE_PKG_CONFLICTS, con);
 946                 }
 947             }
 948         }
 949
 950       /*-----------------------------------------
 951        * check obsoletes and implicit obsoletes of a package
 952        * if ignoreinstalledsobsoletes is not set, we're also checking
 953        * obsoletes of installed packages (like newer rpm versions)
 954        */
 955       if ((!installed || s->repo != installed) || !pool->noinstalledobsoletes)
 956         {
 957           int multi = solv->multiversion.size && MAPTST(&solv->multiversion, n);
 958           int isinstalled = (installed && s->repo == installed);
 959           if (s->obsoletes && (!multi || solv->keepexplicitobsoletes))
 960             {
 961               obsp = s->repo->idarraydata + s->obsoletes;
 962               /* foreach obsoletes */
 963               while ((obs = *obsp++) != 0)
 964                 {
 965                   /* foreach provider of an obsoletes of 's' */
 966                   FOR_PROVIDES(p, pp, obs)
 967                     {
 968                       Solvable *ps = pool->solvables + p;
 969                       if (p == n)
 970                         continue;
 971                       if (isinstalled && dontfix && ps->repo == installed)
 972                         continue;       /* don't repair installed/installed problems */
 973                       if (!pool->obsoleteusesprovides /* obsoletes are matched names, not provides */
 974                           && !pool_match_nevr(pool, ps, obs))
 975                         continue;
 976                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
 977                         continue;
 978                       if (p == SYSTEMSOLVABLE)
 979                         p = 0;
 980                       if (!isinstalled)
 981                         addpkgrule(solv, -n, -p, 0, SOLVER_RULE_PKG_OBSOLETES, obs);
 982                       else
 983                         addpkgrule(solv, -n, -p, 0, SOLVER_RULE_PKG_INSTALLED_OBSOLETES, obs);
 984                     }
 985                 }
 986             }
 987           /* check implicit obsoletes
 988            * for installed packages we only need to check installed/installed problems (and
 989            * only when dontfix is not set), as the others are picked up when looking at the
 990            * uninstalled package.
 991            */
 992           if (!isinstalled || !dontfix)
 993             {
 994               FOR_PROVIDES(p, pp, s->name)
 995                 {
 996                   Solvable *ps = pool->solvables + p;
 997                   if (p == n)
 998                     continue;
 999                   if (isinstalled && ps->repo != installed)
1000                     continue;
1001                   /* we still obsolete packages with same nevra, like rpm does */
1002                   /* (actually, rpm mixes those packages. yuck...) */
1003                   if (multi && (s->name != ps->name || s->evr != ps->evr || s->arch != ps->arch))
1004                     {
1005                       if (isinstalled || ps->repo != installed)
1006                         continue;
1007                       /* also check the installed package for multi-ness */
1008                       if (MAPTST(&solv->multiversion, p))
1009                         continue;
1010                     }
1011                   if (!pool->implicitobsoleteusesprovides && s->name != ps->name)
1012                     continue;
1013                   if (pool->implicitobsoleteusescolors && !pool_colormatch(pool, s, ps))
1014                     continue;
1015                   if (p == SYSTEMSOLVABLE)
1016                     p = 0;
1017                   if (s->name == ps->name)
1018                     {
1019                       /* optimization: do not add the same-name conflict rule if it was
1020                        * already added when we looked at the other package.
1021                        * (this assumes pool_colormatch is symmetric) */
1022                       if (p && m && ps->repo != installed && MAPTST(m, p) &&
1023                           (ps->arch != ARCH_SRC && ps->arch != ARCH_NOSRC) &&
1024                           !(solv->multiversion.size && MAPTST(&solv->multiversion, p)))
1025                         continue;
1026                       addpkgrule(solv, -n, -p, 0, SOLVER_RULE_PKG_SAME_NAME, 0);
1027                     }
1028                   else
1029                     addpkgrule(solv, -n, -p, 0, SOLVER_RULE_PKG_IMPLICIT_OBSOLETES, s->name);
1030                 }
1031             }
1032         }
1033
1034       if (m && pool->implicitobsoleteusescolors && pool_arch2score(pool, s->arch) > 1)
1035         {
1036           unsigned int pa, a = pool_arch2score(pool, s->arch);
1037           /* check lock-step candidates */
1038           FOR_PROVIDES(p, pp, s->name)
1039             {
1040               Solvable *ps = pool->solvables + p;
1041               if (s->name != ps->name || s->evr != ps->evr || MAPTST(m, p))
1042                 continue;
1043               pa = pool_arch2score(pool, ps->arch);
1044               if (!pa || pa == 1 || pa >= a)
1045                 continue;
1046               queue_push(&workq, p);
1047             }
1048         }
1049
1050       /*-----------------------------------------
1051        * add recommends/suggests to the work queue
1052        */
1053       if (s->recommends && m)
1054         {
1055           recp = s->repo->idarraydata + s->recommends;
1056           while ((rec = *recp++) != 0)
1057             {
1058 #ifdef ENABLE_COMPLEX_DEPS
1059               if (pool_is_complex_dep(pool, rec))
1060                 {
1061                   pool_add_pos_literals_complex_dep(pool, rec, &workq, m, 0);
1062                   continue;
1063                 }
1064 #endif
1065               FOR_PROVIDES(p, pp, rec)
1066                 if (!MAPTST(m, p))
1067                   queue_push(&workq, p);
1068             }
1069         }
1070       if (s->suggests && m)
1071         {
1072           sugp = s->repo->idarraydata + s->suggests;
1073           while ((sug = *sugp++) != 0)
1074             {
1075 #ifdef ENABLE_COMPLEX_DEPS
1076               if (pool_is_complex_dep(pool, sug))
1077                 {
1078                   pool_add_pos_literals_complex_dep(pool, sug, &workq, m, 0);
1079                   continue;
1080                 }
1081 #endif
1082               FOR_PROVIDES(p, pp, sug)
1083                 if (!MAPTST(m, p))
1084                   queue_push(&workq, p);
1085             }
1086         }
1087     }
1088   queue_free(&prereqq);
1089   queue_free(&workq);
1090 }
1091
1092 #ifdef ENABLE_LINKED_PKGS
1093 void
1094 solver_addpkgrulesforlinked(Solver *solv, Map *m)
1095 {
1096   Pool *pool = solv->pool;
1097   Solvable *s;
1098   int i, j;
1099   Queue qr;
1100
1101   queue_init(&qr);
1102   for (i = 1; i < pool->nsolvables; i++)
1103     {
1104       if (MAPTST(m, i))
1105         continue;
1106       s = pool->solvables + i;
1107       if (!s->repo || s->repo == solv->installed)
1108         continue;
1109       if (!strchr(pool_id2str(pool, s->name), ':'))
1110         continue;
1111       if (!pool_installable(pool, s))
1112         continue;
1113       find_package_link(pool, s, 0, &qr, 0, 0);
1114       if (qr.count)
1115         {
1116           for (j = 0; j < qr.count; j++)
1117             if (MAPTST(m, qr.elements[j]))
1118               {
1119                 solver_addpkgrulesforsolvable(solv, s, m);
1120                 break;
1121               }
1122           queue_empty(&qr);
1123         }
1124     }
1125   queue_free(&qr);
1126 }
1127 #endif
1128
1129 /*-------------------------------------------------------------------
1130  *
1131  * Add rules for packages possibly selected in by weak dependencies
1132  *
1133  * m: already added solvables
1134  */
1135
1136 void
1137 solver_addpkgrulesforweak(Solver *solv, Map *m)
1138 {
1139   Pool *pool = solv->pool;
1140   Solvable *s;
1141   Id sup, *supp;
1142   int i, n;
1143
1144   /* foreach solvable in pool */
1145   for (i = n = 1; n < pool->nsolvables; i++, n++)
1146     {
1147       if (i == pool->nsolvables)                /* wrap i */
1148         i = 1;
1149       if (MAPTST(m, i))                         /* already added that one */
1150         continue;
1151
1152       s = pool->solvables + i;
1153       if (!s->repo)
1154         continue;
1155       if (s->repo != pool->installed && !pool_installable(pool, s))
1156         continue;       /* only look at installable ones */
1157
1158       sup = 0;
1159       if (s->supplements)
1160         {
1161           /* find possible supplements */
1162           supp = s->repo->idarraydata + s->supplements;
1163           while ((sup = *supp++) != 0)
1164             if (solver_dep_possible(solv, sup, m))
1165               break;
1166         }
1167
1168       /* if nothing found, check for enhances */
1169       if (!sup && s->enhances)
1170         {
1171           supp = s->repo->idarraydata + s->enhances;
1172           while ((sup = *supp++) != 0)
1173             if (solver_dep_possible(solv, sup, m))
1174               break;
1175         }
1176       /* if nothing found, goto next solvables */
1177       if (!sup)
1178         continue;
1179       solver_addpkgrulesforsolvable(solv, s, m);
1180       n = 0;                    /* check all solvables again because we added solvables to m */
1181     }
1182 }
1183
1184
1185 /*-------------------------------------------------------------------
1186  *
1187  * add package rules for possible updates
1188  *
1189  * s: solvable
1190  * m: map of already visited solvables
1191  * allow_all: 0 = dont allow downgrades, 1 = allow all candidates
1192  */
1193
1194 void
1195 solver_addpkgrulesforupdaters(Solver *solv, Solvable *s, Map *m, int allow_all)
1196 {
1197   Pool *pool = solv->pool;
1198   int i;
1199     /* queue and buffer for it */
1200   Queue qs;
1201   Id qsbuf[64];
1202
1203   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
1204     /* find update candidates for 's' */
1205   policy_findupdatepackages(solv, s, &qs, allow_all);
1206     /* add rule for 's' if not already done */
1207   if (!MAPTST(m, s - pool->solvables))
1208     solver_addpkgrulesforsolvable(solv, s, m);
1209     /* foreach update candidate, add rule if not already done */
1210   for (i = 0; i < qs.count; i++)
1211     if (!MAPTST(m, qs.elements[i]))
1212       solver_addpkgrulesforsolvable(solv, pool->solvables + qs.elements[i], m);
1213   queue_free(&qs);
1214 }
1215
1216
1217 /***********************************************************************
1218  ***
1219  ***  Update/Feature rule part
1220  ***
1221  ***  Those rules make sure an installed package isn't silently deleted
1222  ***
1223  ***/
1224
1225 static int
1226 dup_maykeepinstalled(Solver *solv, Solvable *s)
1227 {
1228   Pool *pool = solv->pool;
1229   Id ip, pp;
1230
1231   if (solv->dupmap.size && MAPTST(&solv->dupmap,  s - pool->solvables))
1232     return 1;
1233   /* is installed identical to a good one? */
1234   FOR_PROVIDES(ip, pp, s->name)
1235     {
1236       Solvable *is = pool->solvables + ip;
1237       if (is->evr != s->evr)
1238         continue;
1239       if (solv->dupmap.size)
1240         {
1241           if (!MAPTST(&solv->dupmap, ip))
1242             continue;
1243         }
1244       else if (is->repo == pool->installed)
1245         continue;
1246       if (solvable_identical(s, is))
1247         return 1;
1248     }
1249   return 0;
1250 }
1251
1252
1253 /* stash away the original updaters for multiversion packages. We do this so that
1254  * we can update the package later */
1255 static inline void
1256 set_specialupdaters(Solver *solv, Solvable *s, Id d)
1257 {
1258   Repo *installed = solv->installed;
1259   if (!solv->specialupdaters)
1260     solv->specialupdaters = solv_calloc(installed->end - installed->start, sizeof(Id));
1261   solv->specialupdaters[s - solv->pool->solvables - installed->start] = d;
1262 }
1263
1264 #ifdef ENABLE_LINKED_PKGS
1265 /* Check if this is a linked pseudo package. As it is linked, we do not need an update/feature rule */
1266 static inline int
1267 is_linked_pseudo_package(Solver *solv, Solvable *s)
1268 {
1269   Pool *pool = solv->pool;
1270   if (solv->instbuddy && solv->instbuddy[s - pool->solvables - solv->installed->start])
1271     {
1272       const char *name = pool_id2str(pool, s->name);
1273       if (strncmp(name, "pattern:", 8) == 0 || strncmp(name, "application:", 12) == 0)
1274         return 1;
1275     }
1276   return 0;
1277 }
1278 #endif
1279
1280 void
1281 solver_addfeaturerule(Solver *solv, Solvable *s)
1282 {
1283   Pool *pool = solv->pool;
1284   int i;
1285   Id p;
1286   Queue qs;
1287   Id qsbuf[64];
1288
1289 #ifdef ENABLE_LINKED_PKGS
1290   if (is_linked_pseudo_package(solv, s))
1291     {
1292       solver_addrule(solv, 0, 0, 0);    /* no feature rules for those */
1293       return;
1294     }
1295 #endif
1296   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
1297   p = s - pool->solvables;
1298   policy_findupdatepackages(solv, s, &qs, 1);
1299   if (solv->dupinvolvedmap_all || (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p)))
1300     {
1301       if (!dup_maykeepinstalled(solv, s))
1302         {
1303           for (i = 0; i < qs.count; i++)
1304             {
1305               Solvable *ns = pool->solvables + qs.elements[i];
1306               if (ns->repo != pool->installed || dup_maykeepinstalled(solv, ns))
1307                 break;
1308             }
1309           if (i == qs.count)
1310             {
1311               solver_addrule(solv, 0, 0, 0);    /* this is an orphan */
1312               queue_free(&qs);
1313               return;
1314             }
1315         }
1316     }
1317   if (qs.count > 1)
1318     {
1319       Id d = pool_queuetowhatprovides(pool, &qs);
1320       queue_free(&qs);
1321       solver_addrule(solv, p, 0, d);    /* allow update of s */
1322     }
1323   else
1324     {
1325       Id d = qs.count ? qs.elements[0] : 0;
1326       queue_free(&qs);
1327       solver_addrule(solv, p, d, 0);    /* allow update of s */
1328     }
1329 }
1330
1331 /*-------------------------------------------------------------------
1332  *
1333  * add rule for update
1334  *   (A|A1|A2|A3...)  An = update candidates for A
1335  *
1336  * s = (installed) solvable
1337  */
1338
1339 void
1340 solver_addupdaterule(Solver *solv, Solvable *s)
1341 {
1342   /* installed packages get a special upgrade allowed rule */
1343   Pool *pool = solv->pool;
1344   Id p, d;
1345   Queue qs;
1346   Id qsbuf[64];
1347   Rule *r;
1348   int dupinvolved = 0;
1349
1350   p = s - pool->solvables;
1351   /* Orphan detection. We cheat by looking at the feature rule, which
1352    * we already calculated */
1353   r = solv->rules + solv->featurerules + (p - solv->installed->start);
1354   if (!r->p)
1355     {
1356 #ifdef ENABLE_LINKED_PKGS
1357       if (is_linked_pseudo_package(solv, s))
1358         {
1359           solver_addrule(solv, 0, 0, 0);
1360           return;
1361         }
1362 #endif
1363       p = 0;
1364       queue_push(&solv->orphaned, s - pool->solvables);         /* an orphaned package */
1365       if (solv->keep_orphans && !(solv->droporphanedmap_all || (solv->droporphanedmap.size && MAPTST(&solv->droporphanedmap, s - pool->solvables - solv->installed->start))))
1366         p = s - pool->solvables;        /* keep this orphaned package installed */
1367       solver_addrule(solv, p, 0, 0);
1368       return;
1369     }
1370
1371   /* find update candidates for 's' */
1372   queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
1373   dupinvolved = solv->dupinvolvedmap_all || (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p));
1374   policy_findupdatepackages(solv, s, &qs, dupinvolved ? 2 : 0);
1375
1376   if (qs.count && solv->multiversion.size)
1377     {
1378       int i, j;
1379
1380       for (i = 0; i < qs.count; i++)
1381         if (MAPTST(&solv->multiversion, qs.elements[i]))
1382           break;
1383       if (i < qs.count)
1384         {
1385           /* filter out all multiversion packages as they don't update */
1386           d = pool_queuetowhatprovides(pool, &qs);      /* save qs away */
1387           for (j = i; i < qs.count; i++)
1388              {
1389               if (MAPTST(&solv->multiversion, qs.elements[i]))
1390                 {
1391                   Solvable *ps = pool->solvables + qs.elements[i];
1392                   /* if keepexplicitobsoletes is set and the name is different,
1393                    * we assume that there is an obsoletes. XXX: not 100% correct */
1394                   if (solv->keepexplicitobsoletes && ps->name != s->name)
1395                     {
1396                       qs.elements[j++] = qs.elements[i];
1397                       continue;
1398                     }
1399                   /* it's ok if they have same nevra */
1400                   if (ps->name != s->name || ps->evr != s->evr || ps->arch != s->arch)
1401                     continue;
1402                 }
1403               qs.elements[j++] = qs.elements[i];
1404             }
1405
1406           if (j == 0 && dupinvolved && !dup_maykeepinstalled(solv, s))
1407             {
1408               /* this is a multiversion orphan */
1409               queue_push(&solv->orphaned, p);
1410               set_specialupdaters(solv, s, d);
1411               if (solv->keep_orphans && !(solv->droporphanedmap_all || (solv->droporphanedmap.size && MAPTST(&solv->droporphanedmap, p - solv->installed->start))))
1412                 {
1413                   /* we need to keep the orphan */
1414                   queue_free(&qs);
1415                   solver_addrule(solv, p, 0, 0);
1416                   return;
1417                 }
1418               /* we can drop it as long as we update */
1419               j = qs.count;
1420             }
1421
1422           if (j < qs.count)             /* filtered at least one package? */
1423             {
1424               if (d && (solv->updatemap_all || (solv->updatemap.size && MAPTST(&solv->updatemap, p - solv->installed->start))))
1425                 {
1426                   /* non-orphan multiversion package, set special updaters if we want an update */
1427                   set_specialupdaters(solv, s, d);
1428                 }
1429               qs.count = j;
1430             }
1431           else
1432             {
1433               /* could fallthrough, but then we would do pool_queuetowhatprovides twice */
1434               queue_free(&qs);
1435               solver_addrule(solv, p, 0, d);    /* allow update of s */
1436               return;
1437             }
1438         }
1439     }
1440   if (qs.count > 1)
1441     {
1442       d = pool_queuetowhatprovides(pool, &qs);
1443       queue_free(&qs);
1444       solver_addrule(solv, p, 0, d);    /* allow update of s */
1445     }
1446   else
1447     {
1448       d = qs.count ? qs.elements[0] : 0;
1449       queue_free(&qs);
1450       solver_addrule(solv, p, d, 0);    /* allow update of s */
1451     }
1452 }
1453
1454 static inline void
1455 disableupdaterule(Solver *solv, Id p)
1456 {
1457   Rule *r;
1458
1459   MAPSET(&solv->noupdate, p - solv->installed->start);
1460   r = solv->rules + solv->updaterules + (p - solv->installed->start);
1461   if (r->p && r->d >= 0)
1462     solver_disablerule(solv, r);
1463   r = solv->rules + solv->featurerules + (p - solv->installed->start);
1464   if (r->p && r->d >= 0)
1465     solver_disablerule(solv, r);
1466   if (solv->bestrules_info)
1467     {
1468       int i, ni;
1469       ni = solv->bestrules_end - solv->bestrules;
1470       for (i = solv->bestrules_up - solv->bestrules; i < ni; i++)
1471         if (solv->bestrules_info[i] == p)
1472           solver_disablerule(solv, solv->rules + solv->bestrules + i);
1473     }
1474 }
1475
1476 static inline void
1477 reenableupdaterule(Solver *solv, Id p)
1478 {
1479   Pool *pool = solv->pool;
1480   Rule *r;
1481
1482   MAPCLR(&solv->noupdate, p - solv->installed->start);
1483   r = solv->rules + solv->updaterules + (p - solv->installed->start);
1484   if (r->p)
1485     {
1486       if (r->d < 0)
1487         {
1488           solver_enablerule(solv, r);
1489           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1490             {
1491               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1492               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1493             }
1494         }
1495     }
1496   else
1497     {
1498       r = solv->rules + solv->featurerules + (p - solv->installed->start);
1499       if (r->p && r->d < 0)
1500         {
1501           solver_enablerule(solv, r);
1502           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1503             {
1504               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1505               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1506             }
1507         }
1508     }
1509   if (solv->bestrules_info)
1510     {
1511       int i, ni;
1512       ni = solv->bestrules_end - solv->bestrules;
1513       for (i = solv->bestrules_up - solv->bestrules; i < ni; i++)
1514         if (solv->bestrules_info[i] == p)
1515           solver_enablerule(solv, solv->rules + solv->bestrules + i);
1516     }
1517 }
1518
1519
1520 /***********************************************************************
1521  ***
1522  ***  Infarch rule part
1523  ***
1524  ***  Infarch rules make sure the solver uses the best architecture of
1525  ***  a package if multiple archetectures are available
1526  ***
1527  ***/
1528
1529 void
1530 solver_addinfarchrules(Solver *solv, Map *addedmap)
1531 {
1532   Pool *pool = solv->pool;
1533   Repo *installed = pool->installed;
1534   int first, i, j;
1535   Id p, pp, aa;
1536   unsigned int a, bestscore;
1537   Solvable *s, *ps, *bests;
1538   Queue badq, allowedarchs;
1539   Queue lsq;
1540
1541   queue_init(&badq);
1542   queue_init(&allowedarchs);
1543   queue_init(&lsq);
1544   solv->infarchrules = solv->nrules;
1545   for (i = 1; i < pool->nsolvables; i++)
1546     {
1547       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1548         continue;
1549       s = pool->solvables + i;
1550       first = i;
1551       bestscore = 0;
1552       bests = 0;
1553       queue_empty(&allowedarchs);
1554       FOR_PROVIDES(p, pp, s->name)
1555         {
1556           ps = pool->solvables + p;
1557           if (ps->name != s->name || !MAPTST(addedmap, p))
1558             continue;
1559           if (p == i)
1560             first = 0;
1561           if (first)
1562             break;
1563           a = pool_arch2score(pool, ps->arch);
1564           if (a != 1 && installed && ps->repo == installed)
1565             {
1566               if (solv->dupinvolvedmap_all || (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p)))
1567                 continue;
1568               queue_pushunique(&allowedarchs, ps->arch);        /* also ok to keep this architecture */
1569               continue;         /* but ignore installed solvables when calculating the best arch */
1570             }
1571           if (a && a != 1 && (!bestscore || a < bestscore))
1572             {
1573               bestscore = a;
1574               bests = ps;
1575             }
1576         }
1577       if (first)
1578         continue;
1579
1580       /* speed up common case where installed package already has best arch */
1581       if (allowedarchs.count == 1 && bests && allowedarchs.elements[0] == bests->arch)
1582         allowedarchs.count--;   /* installed arch is best */
1583
1584       if (allowedarchs.count && pool->implicitobsoleteusescolors && installed && bestscore)
1585         {
1586           /* need an extra pass for lockstep checking: we only allow to keep an inferior arch
1587            * if the corresponding installed package is not lock-stepped */
1588           queue_empty(&allowedarchs);
1589           FOR_PROVIDES(p, pp, s->name)
1590             {
1591               Id p2, pp2;
1592               ps = pool->solvables + p;
1593               if (ps->name != s->name || ps->repo != installed || !MAPTST(addedmap, p))
1594                 continue;
1595               if (solv->dupinvolvedmap_all || (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p)))
1596                 continue;
1597               a = pool_arch2score(pool, ps->arch);
1598               if (!a)
1599                 {
1600                   queue_pushunique(&allowedarchs, ps->arch);    /* strange arch, allow */
1601                   continue;
1602                 }
1603               if (a == 1 || ((a ^ bestscore) & 0xffff0000) == 0)
1604                 continue;
1605               /* have installed package with inferior arch, check if lock-stepped */
1606               FOR_PROVIDES(p2, pp2, s->name)
1607                 {
1608                   Solvable *s2 = pool->solvables + p2;
1609                   unsigned int a2;
1610                   if (p2 == p || s2->name != s->name || s2->evr != pool->solvables[p].evr || s2->arch == pool->solvables[p].arch)
1611                     continue;
1612                   a2 = pool_arch2score(pool, s2->arch);
1613                   if (a2 && (a2 == 1 || ((a2 ^ bestscore) & 0xffff0000) == 0))
1614                     break;
1615                 }
1616               if (!p2)
1617                 queue_pushunique(&allowedarchs, ps->arch);
1618             }
1619         }
1620
1621       /* find all bad packages */
1622       queue_empty(&badq);
1623       FOR_PROVIDES(p, pp, s->name)
1624         {
1625           ps = pool->solvables + p;
1626           if (ps->name != s->name || !MAPTST(addedmap, p))
1627             continue;
1628           a = pool_arch2score(pool, ps->arch);
1629           if (a != 1 && bestscore && ((a ^ bestscore) & 0xffff0000) != 0)
1630             {
1631               if (installed && ps->repo == installed)
1632                 {
1633                   if (pool->implicitobsoleteusescolors)
1634                     queue_push(&badq, p);               /* special lock-step handling, see below */
1635                   continue;     /* always ok to keep an installed package */
1636                 }
1637               for (j = 0; j < allowedarchs.count; j++)
1638                 {
1639                   unsigned int aas;
1640                   aa = allowedarchs.elements[j];
1641                   if (ps->arch == aa)
1642                     break;
1643                   aas = pool_arch2score(pool, aa);
1644                   if (aas && ((a ^ aas) & 0xffff0000) == 0)
1645                     break;      /* compatible */
1646                 }
1647               if (j == allowedarchs.count)
1648                 queue_push(&badq, p);
1649             }
1650         }
1651
1652       /* block all solvables in the badq! */
1653       for (j = 0; j < badq.count; j++)
1654         {
1655           p = badq.elements[j];
1656           /* special lock-step handling */
1657           if (pool->implicitobsoleteusescolors)
1658             {
1659               Id p2;
1660               int haveinstalled = 0;
1661               queue_empty(&lsq);
1662               FOR_PROVIDES(p2, pp, s->name)
1663                 {
1664                   Solvable *s2 = pool->solvables + p2;
1665                   if (p2 == p || s2->name != s->name || s2->evr != pool->solvables[p].evr || s2->arch == pool->solvables[p].arch)
1666                     continue;
1667                   a = pool_arch2score(pool, s2->arch);
1668                   if (a && (a == 1 || ((a ^ bestscore) & 0xffff000) == 0))
1669                     {
1670                       queue_push(&lsq, p2);
1671                       if (installed && s2->repo == installed)
1672                         haveinstalled = 1;
1673                     }
1674                 }
1675               if (installed && pool->solvables[p].repo == installed && !haveinstalled)
1676                 continue;       /* installed package not in lock-step */
1677               if (lsq.count < 2)
1678                 solver_addrule(solv, -p, lsq.count ? lsq.elements[0] : 0, 0);
1679               else
1680                 solver_addrule(solv, -p, 0, pool_queuetowhatprovides(pool, &lsq));
1681             }
1682           else
1683             {
1684               solver_addrule(solv, -p, 0, 0);
1685             }
1686         }
1687     }
1688   queue_free(&lsq);
1689   queue_free(&badq);
1690   queue_free(&allowedarchs);
1691   solv->infarchrules_end = solv->nrules;
1692 }
1693
1694 static inline void
1695 disableinfarchrule(Solver *solv, Id name)
1696 {
1697   Pool *pool = solv->pool;
1698   Rule *r;
1699   int i;
1700   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1701     {
1702       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
1703         solver_disablerule(solv, r);
1704     }
1705 }
1706
1707 static inline void
1708 reenableinfarchrule(Solver *solv, Id name)
1709 {
1710   Pool *pool = solv->pool;
1711   Rule *r;
1712   int i;
1713   for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
1714     {
1715       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
1716         {
1717           solver_enablerule(solv, r);
1718           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
1719             {
1720               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
1721               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
1722             }
1723         }
1724     }
1725 }
1726
1727
1728 /***********************************************************************
1729  ***
1730  ***  Dup rule part
1731  ***
1732  ***  Dup rules make sure a package is selected from the specified dup
1733  ***  repositories if an update candidate is included in one of them.
1734  ***
1735  ***/
1736
1737 static inline void
1738 add_cleandeps_updatepkg(Solver *solv, Id p)
1739 {
1740   if (!solv->cleandeps_updatepkgs)
1741     {
1742       solv->cleandeps_updatepkgs = solv_calloc(1, sizeof(Queue));
1743       queue_init(solv->cleandeps_updatepkgs);
1744     }
1745   queue_pushunique(solv->cleandeps_updatepkgs, p);
1746 }
1747
1748 static void
1749 solver_addtodupmaps(Solver *solv, Id p, Id how, int targeted)
1750 {
1751   Pool *pool = solv->pool;
1752   Solvable *ps, *s = pool->solvables + p;
1753   Repo *installed = solv->installed;
1754   Id pi, pip, obs, *obsp;
1755
1756   if (!solv->dupinvolvedmap.size)
1757     map_grow(&solv->dupinvolvedmap, pool->nsolvables);
1758
1759   MAPSET(&solv->dupinvolvedmap, p);
1760   if (targeted)
1761     MAPSET(&solv->dupmap, p);
1762   FOR_PROVIDES(pi, pip, s->name)
1763     {
1764       ps = pool->solvables + pi;
1765       if (ps->name != s->name)
1766         continue;
1767       MAPSET(&solv->dupinvolvedmap, pi);
1768       if (targeted && ps->repo == installed && solv->obsoletes && solv->obsoletes[pi - installed->start])
1769         {
1770           Id *opp, pi2;
1771           for (opp = solv->obsoletes_data + solv->obsoletes[pi - installed->start]; (pi2 = *opp++) != 0;)
1772             if (pool->solvables[pi2].repo != installed)
1773               MAPSET(&solv->dupinvolvedmap, pi2);
1774         }
1775       if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0 && !solv->bestupdatemap_all)
1776         {
1777           if (!solv->bestupdatemap.size)
1778             map_grow(&solv->bestupdatemap, installed->end - installed->start);
1779           MAPSET(&solv->bestupdatemap, pi - installed->start);
1780         }
1781       if (ps->repo == installed && (how & SOLVER_CLEANDEPS) != 0)
1782         add_cleandeps_updatepkg(solv, pi);
1783       if (!targeted && ps->repo != installed)
1784         MAPSET(&solv->dupmap, pi);
1785     }
1786   if (s->repo == installed && solv->obsoletes && solv->obsoletes[p - installed->start])
1787     {
1788       Id *opp;
1789       for (opp = solv->obsoletes_data + solv->obsoletes[p - installed->start]; (pi = *opp++) != 0;)
1790         {
1791           ps = pool->solvables + pi;
1792           if (ps->repo == installed)
1793             continue;
1794           MAPSET(&solv->dupinvolvedmap, pi);
1795           if (!targeted)
1796             MAPSET(&solv->dupmap, pi);
1797         }
1798     }
1799   if (targeted && s->repo != installed && s->obsoletes)
1800     {
1801       /* XXX: check obsoletes/provides combination */
1802       obsp = s->repo->idarraydata + s->obsoletes;
1803       while ((obs = *obsp++) != 0)
1804         {
1805           FOR_PROVIDES(pi, pip, obs)
1806             {
1807               Solvable *ps = pool->solvables + pi;
1808               if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
1809                 continue;
1810               if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
1811                 continue;
1812               MAPSET(&solv->dupinvolvedmap, pi);
1813               if (targeted && ps->repo == installed && solv->obsoletes && solv->obsoletes[pi - installed->start])
1814                 {
1815                   Id *opp, pi2;
1816                   for (opp = solv->obsoletes_data + solv->obsoletes[pi - installed->start]; (pi2 = *opp++) != 0;)
1817                     if (pool->solvables[pi2].repo != installed)
1818                       MAPSET(&solv->dupinvolvedmap, pi2);
1819                 }
1820               if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0 && !solv->bestupdatemap_all)
1821                 {
1822                   if (!solv->bestupdatemap.size)
1823                     map_grow(&solv->bestupdatemap, installed->end - installed->start);
1824                   MAPSET(&solv->bestupdatemap, pi - installed->start);
1825                 }
1826               if (ps->repo == installed && (how & SOLVER_CLEANDEPS) != 0)
1827                 add_cleandeps_updatepkg(solv, pi);
1828             }
1829         }
1830     }
1831 }
1832
1833 /* create the two dupmaps:
1834  * - dupmap: packages in that map are good to install/keep
1835  * - dupinvolvedmap: packages are subject to dup mode
1836  */
1837 void
1838 solver_createdupmaps(Solver *solv)
1839 {
1840   Queue *job = &solv->job;
1841   Pool *pool = solv->pool;
1842   Repo *installed = solv->installed;
1843   Id select, how, what, p, pp;
1844   Solvable *s;
1845   int i, targeted;
1846
1847   map_init(&solv->dupmap, pool->nsolvables);
1848   solv->dupinvolvedmap_all = 0;
1849   map_init(&solv->dupinvolvedmap, 0);
1850   for (i = 0; i < job->count; i += 2)
1851     {
1852       how = job->elements[i];
1853       select = job->elements[i] & SOLVER_SELECTMASK;
1854       what = job->elements[i + 1];
1855       switch (how & SOLVER_JOBMASK)
1856         {
1857         case SOLVER_DISTUPGRADE:
1858           if (select == SOLVER_SOLVABLE_REPO)
1859             {
1860               Repo *repo;
1861               if (what <= 0 || what > pool->nrepos)
1862                 break;
1863               repo = pool_id2repo(pool, what);
1864               if (!repo)
1865                 break;
1866               if (repo != installed && !(how & SOLVER_TARGETED) && solv->noautotarget)
1867                 break;
1868               targeted = repo != installed || (how & SOLVER_TARGETED) != 0;
1869               FOR_REPO_SOLVABLES(repo, p, s)
1870                 {
1871                   if (repo != installed && !pool_installable(pool, s))
1872                     continue;
1873                   solver_addtodupmaps(solv, p, how, targeted);
1874                 }
1875             }
1876           else if (select == SOLVER_SOLVABLE_ALL)
1877             {
1878               solv->dupinvolvedmap_all = 1;
1879               FOR_POOL_SOLVABLES(p)
1880                 {
1881                   Solvable *s = pool->solvables + p;
1882                   if (!s->repo || s->repo == installed)
1883                     continue;
1884                   if (!pool_installable(pool, s))
1885                     continue;
1886                   MAPSET(&solv->dupmap, p);
1887                 }
1888               if ((how & SOLVER_FORCEBEST) != 0)
1889                 solv->bestupdatemap_all = 1;
1890               if ((how & SOLVER_CLEANDEPS) != 0 && installed)
1891                 {
1892                   FOR_REPO_SOLVABLES(installed, p, s)
1893                     add_cleandeps_updatepkg(solv, p);
1894                 }
1895             }
1896           else
1897             {
1898               targeted = how & SOLVER_TARGETED ? 1 : 0;
1899               if (installed && !targeted && !solv->noautotarget)
1900                 {
1901                   FOR_JOB_SELECT(p, pp, select, what)
1902                     if (pool->solvables[p].repo == installed)
1903                       break;
1904                   targeted = p == 0;
1905                 }
1906               else if (!installed && !solv->noautotarget)
1907                 targeted = 1;
1908               FOR_JOB_SELECT(p, pp, select, what)
1909                 {
1910                   Solvable *s = pool->solvables + p;
1911                   if (!s->repo)
1912                     continue;
1913                   if (s->repo != installed && !targeted)
1914                     continue;
1915                   if (s->repo != installed && !pool_installable(pool, s))
1916                     continue;
1917                   solver_addtodupmaps(solv, p, how, targeted);
1918                 }
1919             }
1920           break;
1921         default:
1922           break;
1923         }
1924     }
1925   if (solv->dupinvolvedmap.size)
1926     MAPCLR(&solv->dupinvolvedmap, SYSTEMSOLVABLE);
1927   /* set update for all involved installed packages. We need to do
1928    * this before creating the update rules */
1929   if (solv->dupinvolvedmap_all)
1930     solv->updatemap_all = 1;
1931   else if (installed && !solv->updatemap_all && solv->dupinvolvedmap.size)
1932     {
1933       FOR_REPO_SOLVABLES(installed, p, s)
1934         {
1935           if (!MAPTST(&solv->dupinvolvedmap, p))
1936             continue;
1937           if (!solv->updatemap.size)
1938             map_grow(&solv->updatemap, installed->end - installed->start);
1939           MAPSET(&solv->updatemap, p - installed->start);
1940         }
1941     }
1942 }
1943
1944 void
1945 solver_freedupmaps(Solver *solv)
1946 {
1947   map_free(&solv->dupmap);
1948   /* we no longer free solv->dupinvolvedmap as we need it in
1949    * policy's priority pruning code. sigh. */
1950 }
1951
1952 void
1953 solver_addduprules(Solver *solv, Map *addedmap)
1954 {
1955   Pool *pool = solv->pool;
1956   Repo *installed = solv->installed;
1957   Id p, pp;
1958   Solvable *s, *ps;
1959   int first, i;
1960   Rule *r;
1961
1962   solv->duprules = solv->nrules;
1963   for (i = 1; i < pool->nsolvables; i++)
1964     {
1965       if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
1966         continue;
1967       s = pool->solvables + i;
1968       first = i;
1969       FOR_PROVIDES(p, pp, s->name)
1970         {
1971           ps = pool->solvables + p;
1972           if (ps->name != s->name || !MAPTST(addedmap, p))
1973             continue;
1974           if (p == i)
1975             first = 0;
1976           if (first)
1977             break;
1978           if (!solv->dupinvolvedmap_all && !MAPTST(&solv->dupinvolvedmap, p))
1979             continue;
1980           if (installed && ps->repo == installed)
1981             {
1982               if (!MAPTST(&solv->dupmap, p))
1983                 {
1984                   Id ip, ipp;
1985                   /* is installed identical to a good one? */
1986                   FOR_PROVIDES(ip, ipp, ps->name)
1987                     {
1988                       Solvable *is = pool->solvables + ip;
1989                       if (!MAPTST(&solv->dupmap, ip))
1990                         continue;
1991                       if (is->evr == ps->evr && solvable_identical(ps, is))
1992                         break;
1993                     }
1994                   if (ip)
1995                     {
1996                       /* ok, identical to a good one. we may keep this package. */
1997                       MAPSET(&solv->dupmap, p);         /* for best rules processing */
1998                       continue;
1999                     }
2000                   /* check if it's orphaned. If yes, we may keep it */
2001                   r = solv->rules + solv->updaterules + (p - installed->start);
2002                   if (!r->p)
2003                     r = solv->rules + solv->featurerules + (p - installed->start);
2004                   if (!r->p)
2005                     {
2006                       /* no update/feature rule, this is an orphan */
2007                       MAPSET(&solv->dupmap, p);         /* for best rules processing */
2008                       continue;
2009                     }
2010                   if (solv->specialupdaters && solv->specialupdaters[p - installed->start])
2011                     {
2012                       /* this is a multiversion orphan, we're good if an update is installed */
2013                       solver_addrule(solv, -p, 0, solv->specialupdaters[p - installed->start]);
2014                       continue;
2015                     }
2016                   if (r->p == p && !r->d && !r->w2)
2017                     {
2018                       r = solv->rules + solv->featurerules + (p - installed->start);
2019                       if (!r->p || (!r->d && !r->w2))
2020                         {
2021                           /* this is an orphan */
2022                           MAPSET(&solv->dupmap, p);             /* for best rules processing */
2023                           continue;
2024                         }
2025                     }
2026                   solver_addrule(solv, -p, 0, 0);       /* no match, sorry */
2027                 }
2028             }
2029           else if (!MAPTST(&solv->dupmap, p))
2030             solver_addrule(solv, -p, 0, 0);
2031         }
2032     }
2033   solv->duprules_end = solv->nrules;
2034 }
2035
2036
2037 static inline void
2038 disableduprule(Solver *solv, Id name)
2039 {
2040   Pool *pool = solv->pool;
2041   Rule *r;
2042   int i;
2043   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
2044     {
2045       if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
2046         solver_disablerule(solv, r);
2047     }
2048 }
2049
2050 static inline void
2051 reenableduprule(Solver *solv, Id name)
2052 {
2053   Pool *pool = solv->pool;
2054   Rule *r;
2055   int i;
2056   for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
2057     {
2058       if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
2059         {
2060           solver_enablerule(solv, r);
2061           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
2062             {
2063               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
2064               solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
2065             }
2066         }
2067     }
2068 }
2069
2070
2071 /***********************************************************************
2072  ***
2073  ***  Policy rule disabling/reenabling
2074  ***
2075  ***  Disable all policy rules that conflict with our jobs. If a job
2076  ***  gets disabled later on, reenable the involved policy rules again.
2077  ***
2078  ***/
2079
2080 #define DISABLE_UPDATE  1
2081 #define DISABLE_INFARCH 2
2082 #define DISABLE_DUP     3
2083
2084 static void
2085 jobtodisablelist(Solver *solv, Id how, Id what, Queue *q)
2086 {
2087   Pool *pool = solv->pool;
2088   Id select, p, pp;
2089   Repo *installed;
2090   Solvable *s;
2091   int i, j, set, qstart;
2092   Map omap;
2093
2094   installed = solv->installed;
2095   select = how & SOLVER_SELECTMASK;
2096   switch (how & SOLVER_JOBMASK)
2097     {
2098     case SOLVER_INSTALL:
2099       set = how & SOLVER_SETMASK;
2100       if (!(set & SOLVER_NOAUTOSET))
2101         {
2102           /* automatically add set bits by analysing the job */
2103           if (select == SOLVER_SOLVABLE_NAME)
2104             set |= SOLVER_SETNAME;
2105           if (select == SOLVER_SOLVABLE)
2106             set |= SOLVER_SETNAME | SOLVER_SETARCH | SOLVER_SETVENDOR | SOLVER_SETREPO | SOLVER_SETEVR;
2107           else if ((select == SOLVER_SOLVABLE_NAME || select == SOLVER_SOLVABLE_PROVIDES) && ISRELDEP(what))
2108             {
2109               Reldep *rd = GETRELDEP(pool, what);
2110               if (rd->flags == REL_EQ && select == SOLVER_SOLVABLE_NAME)
2111                 {
2112                   if (pool->disttype != DISTTYPE_DEB)
2113                     {
2114                       const char *rel = strrchr(pool_id2str(pool, rd->evr), '-');
2115                       set |= rel ? SOLVER_SETEVR : SOLVER_SETEV;
2116                     }
2117                   else
2118                     set |= SOLVER_SETEVR;
2119                 }
2120               if (rd->flags <= 7 && ISRELDEP(rd->name))
2121                 rd = GETRELDEP(pool, rd->name);
2122               if (rd->flags == REL_ARCH)
2123                 set |= SOLVER_SETARCH;
2124             }
2125         }
2126       else
2127         set &= ~SOLVER_NOAUTOSET;
2128       if (!set)
2129         return;
2130       if ((set & SOLVER_SETARCH) != 0 && solv->infarchrules != solv->infarchrules_end)
2131         {
2132           if (select == SOLVER_SOLVABLE)
2133             {
2134               for (i = solv->infarchrules; i < solv->infarchrules_end; i++)
2135                 if (solv->rules[i].p == -what)
2136                   break;
2137               if (i < solv->infarchrules_end)
2138                 queue_push2(q, DISABLE_INFARCH, pool->solvables[what].name);
2139             }
2140           else
2141             {
2142               int qcnt = q->count;
2143               /* does not work for SOLVER_SOLVABLE_ALL and SOLVER_SOLVABLE_REPO, but
2144                  they are not useful for SOLVER_INSTALL jobs anyway */
2145               FOR_JOB_SELECT(p, pp, select, what)
2146                 {
2147                   s = pool->solvables + p;
2148                   /* unify names */
2149                   for (i = qcnt; i < q->count; i += 2)
2150                     if (q->elements[i + 1] == s->name)
2151                       break;
2152                   if (i < q->count)
2153                     continue;           /* already have that DISABLE_INFARCH element */
2154                   for (i = solv->infarchrules; i < solv->infarchrules_end; i++)
2155                     if (solv->rules[i].p == -p)
2156                       break;
2157                   if (i < solv->infarchrules_end)
2158                     queue_push2(q, DISABLE_INFARCH, s->name);
2159                 }
2160             }
2161         }
2162       if ((set & SOLVER_SETREPO) != 0 && solv->duprules != solv->duprules_end)
2163         {
2164           if (select == SOLVER_SOLVABLE)
2165             queue_push2(q, DISABLE_DUP, pool->solvables[what].name);
2166           else
2167             {
2168               int qcnt = q->count;
2169               FOR_JOB_SELECT(p, pp, select, what)
2170                 {
2171                   s = pool->solvables + p;
2172                   /* unify names */
2173                   for (i = qcnt; i < q->count; i += 2)
2174                     if (q->elements[i + 1] == s->name)
2175                       break;
2176                   if (i < q->count)
2177                     continue;
2178                   queue_push2(q, DISABLE_DUP, s->name);
2179                 }
2180             }
2181         }
2182       if (!installed || installed->end == installed->start)
2183         return;
2184       /* now the hard part: disable some update rules */
2185
2186       /* first check if we have installed or multiversion packages in the job */
2187       FOR_JOB_SELECT(p, pp, select, what)
2188         {
2189           if (pool->solvables[p].repo == installed)
2190             return;
2191           if (solv->multiversion.size && MAPTST(&solv->multiversion, p) && !solv->keepexplicitobsoletes)
2192             return;
2193         }
2194       omap.size = 0;
2195       qstart = q->count;
2196       FOR_JOB_SELECT(p, pp, select, what)
2197         {
2198           solver_intersect_obsoleted(solv, p, q, qstart, &omap);
2199           if (q->count == qstart)
2200             break;
2201         }
2202       if (omap.size)
2203         map_free(&omap);
2204
2205       if (qstart == q->count)
2206         return;         /* nothing to prune */
2207
2208       /* convert result to (DISABLE_UPDATE, p) pairs */
2209       i = q->count;
2210       for (j = qstart; j < i; j++)
2211         queue_push(q, q->elements[j]);
2212       for (j = qstart; j < q->count; j += 2)
2213         {
2214           q->elements[j] = DISABLE_UPDATE;
2215           q->elements[j + 1] = q->elements[i++];
2216         }
2217
2218       /* now that we know which installed packages are obsoleted check each of them */
2219       if ((set & (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR)) == (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR))
2220         return;         /* all is set, nothing to do */
2221
2222       for (i = j = qstart; i < q->count; i += 2)
2223         {
2224           Solvable *is = pool->solvables + q->elements[i + 1];
2225           FOR_JOB_SELECT(p, pp, select, what)
2226             {
2227               int illegal = 0;
2228               s = pool->solvables + p;
2229               if ((set & SOLVER_SETEVR) != 0)
2230                 illegal |= POLICY_ILLEGAL_DOWNGRADE;    /* ignore */
2231               if ((set & SOLVER_SETNAME) != 0)
2232                 illegal |= POLICY_ILLEGAL_NAMECHANGE;   /* ignore */
2233               if ((set & SOLVER_SETARCH) != 0)
2234                 illegal |= POLICY_ILLEGAL_ARCHCHANGE;   /* ignore */
2235               if ((set & SOLVER_SETVENDOR) != 0)
2236                 illegal |= POLICY_ILLEGAL_VENDORCHANGE; /* ignore */
2237               illegal = policy_is_illegal(solv, is, s, illegal);
2238               if (illegal && illegal == POLICY_ILLEGAL_DOWNGRADE && (set & SOLVER_SETEV) != 0)
2239                 {
2240                   /* it's ok if the EV is different */
2241                   if (pool_evrcmp(pool, is->evr, s->evr, EVRCMP_COMPARE_EVONLY) != 0)
2242                     illegal = 0;
2243                 }
2244               if (illegal)
2245                 break;
2246             }
2247           if (!p)
2248             {
2249               /* no package conflicts with the update rule */
2250               /* thus keep the DISABLE_UPDATE */
2251               q->elements[j + 1] = q->elements[i + 1];
2252               j += 2;
2253             }
2254         }
2255       queue_truncate(q, j);
2256       return;
2257
2258     case SOLVER_ERASE:
2259       if (!installed)
2260         break;
2261       if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
2262         {
2263           FOR_REPO_SOLVABLES(installed, p, s)
2264             queue_push2(q, DISABLE_UPDATE, p);
2265         }
2266       FOR_JOB_SELECT(p, pp, select, what)
2267         if (pool->solvables[p].repo == installed)
2268           {
2269             queue_push2(q, DISABLE_UPDATE, p);
2270 #ifdef ENABLE_LINKED_PKGS
2271             if (solv->instbuddy && solv->instbuddy[p - installed->start] > 1)
2272               queue_push2(q, DISABLE_UPDATE, solv->instbuddy[p - installed->start]);
2273 #endif
2274           }
2275       return;
2276     default:
2277       return;
2278     }
2279 }
2280
2281 /* disable all policy rules that are in conflict with our job list */
2282 void
2283 solver_disablepolicyrules(Solver *solv)
2284 {
2285   Queue *job = &solv->job;
2286   int i, j;
2287   Queue allq;
2288   Rule *r;
2289   Id lastjob = -1;
2290   Id allqbuf[128];
2291
2292   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
2293
2294   for (i = solv->jobrules; i < solv->jobrules_end; i++)
2295     {
2296       r = solv->rules + i;
2297       if (r->d < 0)     /* disabled? */
2298         continue;
2299       j = solv->ruletojob.elements[i - solv->jobrules];
2300       if (j == lastjob)
2301         continue;
2302       lastjob = j;
2303       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
2304     }
2305   if (solv->cleandepsmap.size)
2306     {
2307       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
2308       for (i = solv->installed->start; i < solv->installed->end; i++)
2309         if (MAPTST(&solv->cleandepsmap, i - solv->installed->start))
2310           queue_push2(&allq, DISABLE_UPDATE, i);
2311     }
2312   MAPZERO(&solv->noupdate);
2313   for (i = 0; i < allq.count; i += 2)
2314     {
2315       Id type = allq.elements[i], arg = allq.elements[i + 1];
2316       switch(type)
2317         {
2318         case DISABLE_UPDATE:
2319           disableupdaterule(solv, arg);
2320           break;
2321         case DISABLE_INFARCH:
2322           disableinfarchrule(solv, arg);
2323           break;
2324         case DISABLE_DUP:
2325           disableduprule(solv, arg);
2326           break;
2327         default:
2328           break;
2329         }
2330     }
2331   queue_free(&allq);
2332 }
2333
2334 /* we just disabled job #jobidx, now reenable all policy rules that were
2335  * disabled because of this job */
2336 void
2337 solver_reenablepolicyrules(Solver *solv, int jobidx)
2338 {
2339   Queue *job = &solv->job;
2340   int i, j, k, ai;
2341   Queue q, allq;
2342   Rule *r;
2343   Id lastjob = -1;
2344   Id qbuf[32], allqbuf[32];
2345
2346   queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
2347   jobtodisablelist(solv, job->elements[jobidx - 1], job->elements[jobidx], &q);
2348   if (!q.count)
2349     {
2350       queue_free(&q);
2351       return;
2352     }
2353   /* now remove everything from q that is disabled by other jobs */
2354
2355   /* first remove cleandeps packages, they count as DISABLE_UPDATE */
2356   if (solv->cleandepsmap.size)
2357     {
2358       solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
2359       for (j = k = 0; j < q.count; j += 2)
2360         {
2361           if (q.elements[j] == DISABLE_UPDATE)
2362             {
2363               Id p = q.elements[j + 1];
2364               if (p >= solv->installed->start && p < solv->installed->end && MAPTST(&solv->cleandepsmap, p - solv->installed->start))
2365                 continue;       /* remove element from q */
2366             }
2367           q.elements[k++] = q.elements[j];
2368           q.elements[k++] = q.elements[j + 1];
2369         }
2370       q.count = k;
2371       if (!q.count)
2372         {
2373           queue_free(&q);
2374           return;
2375         }
2376     }
2377
2378   /* now go through the disable list of all other jobs */
2379   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
2380   for (i = solv->jobrules; i < solv->jobrules_end; i++)
2381     {
2382       r = solv->rules + i;
2383       if (r->d < 0)     /* disabled? */
2384         continue;
2385       j = solv->ruletojob.elements[i - solv->jobrules];
2386       if (j == lastjob)
2387         continue;
2388       lastjob = j;
2389       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
2390       if (!allq.count)
2391         continue;
2392       /* remove all elements in allq from q */
2393       for (j = k = 0; j < q.count; j += 2)
2394         {
2395           Id type = q.elements[j], arg = q.elements[j + 1];
2396           for (ai = 0; ai < allq.count; ai += 2)
2397             if (allq.elements[ai] == type && allq.elements[ai + 1] == arg)
2398               break;
2399           if (ai < allq.count)
2400             continue;   /* found it in allq, remove element from q */
2401           q.elements[k++] = q.elements[j];
2402           q.elements[k++] = q.elements[j + 1];
2403         }
2404       q.count = k;
2405       if (!q.count)
2406         {
2407           queue_free(&q);
2408           queue_free(&allq);
2409           return;
2410         }
2411       queue_empty(&allq);
2412     }
2413   queue_free(&allq);
2414
2415   /* now re-enable anything that's left in q */
2416   for (j = 0; j < q.count; j += 2)
2417     {
2418       Id type = q.elements[j], arg = q.elements[j + 1];
2419       switch(type)
2420         {
2421         case DISABLE_UPDATE:
2422           reenableupdaterule(solv, arg);
2423           break;
2424         case DISABLE_INFARCH:
2425           reenableinfarchrule(solv, arg);
2426           break;
2427         case DISABLE_DUP:
2428           reenableduprule(solv, arg);
2429           break;
2430         }
2431     }
2432   queue_free(&q);
2433 }
2434
2435 /* we just removed a package from the cleandeps map, now reenable all policy rules that were
2436  * disabled because of this */
2437 void
2438 solver_reenablepolicyrules_cleandeps(Solver *solv, Id pkg)
2439 {
2440   Queue *job = &solv->job;
2441   int i, j;
2442   Queue allq;
2443   Rule *r;
2444   Id lastjob = -1;
2445   Id allqbuf[128];
2446
2447   queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
2448   for (i = solv->jobrules; i < solv->jobrules_end; i++)
2449     {
2450       r = solv->rules + i;
2451       if (r->d < 0)     /* disabled? */
2452         continue;
2453       j = solv->ruletojob.elements[i - solv->jobrules];
2454       if (j == lastjob)
2455         continue;
2456       lastjob = j;
2457       jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
2458     }
2459   for (i = 0; i < allq.count; i += 2)
2460     if (allq.elements[i] == DISABLE_UPDATE && allq.elements[i + 1] == pkg)
2461       break;
2462   if (i == allq.count)
2463     reenableupdaterule(solv, pkg);
2464   queue_free(&allq);
2465 }
2466
2467
2468 /***********************************************************************
2469  ***
2470  ***  Rule info part, tell the user what the rule is about.
2471  ***
2472  ***/
2473
2474 static void
2475 addpkgruleinfo(Solver *solv, Id p, Id p2, Id d, int type, Id dep)
2476 {
2477   Pool *pool = solv->pool;
2478   Rule *r;
2479
2480   if (d)
2481     {
2482       assert(!p2 && d > 0);
2483       if (!pool->whatprovidesdata[d])
2484         d = 0;
2485       else if (!pool->whatprovidesdata[d + 1])
2486         {
2487           p2 = pool->whatprovidesdata[d];
2488           d = 0;
2489         }
2490     }
2491
2492   /* check if this creates the rule we're searching for */
2493   r = solv->rules + solv->ruleinfoq->elements[0];
2494   if (d)
2495     {
2496       /* three or more literals */
2497       Id od = r->d < 0 ? -r->d - 1 : r->d;
2498       if (p != r->p && !od)
2499         return;
2500       if (d != od)
2501         {
2502           Id *dp = pool->whatprovidesdata + d;
2503           Id *odp = pool->whatprovidesdata + od;
2504           while (*dp)
2505             if (*dp++ != *odp++)
2506               return;
2507           if (*odp)
2508             return;
2509         }
2510       if (p < 0 && pool->whatprovidesdata[d] < 0 && type == SOLVER_RULE_PKG_CONFLICTS)
2511         p2 = pool->whatprovidesdata[d];
2512     }
2513   else
2514     {
2515       /* one or two literals */
2516       Id op = p, op2 = p2;
2517       if (op2 && op > op2)      /* normalize */
2518         {
2519           Id o = op;
2520           op = op2;
2521           op2 = o;
2522         }
2523       if (r->p != op || r->w2 != op2 || (r->d && r->d != -1))
2524         return;
2525       if (type == SOLVER_RULE_PKG_CONFLICTS && !p2)
2526         p2 = -SYSTEMSOLVABLE;
2527       if (type == SOLVER_RULE_PKG_SAME_NAME)
2528         {
2529           p = op;       /* we normalize same name order */
2530           p2 = op2;
2531         }
2532     }
2533   /* yep, rule matches. record info */
2534   queue_push(solv->ruleinfoq, type);
2535   queue_push(solv->ruleinfoq, p < 0 ? -p : 0);
2536   queue_push(solv->ruleinfoq, p2 < 0 ? -p2 : 0);
2537   queue_push(solv->ruleinfoq, dep);
2538 }
2539
2540 static int
2541 solver_allruleinfos_cmp(const void *ap, const void *bp, void *dp)
2542 {
2543   const Id *a = ap, *b = bp;
2544   int r;
2545
2546   r = a[0] - b[0];
2547   if (r)
2548     return r;
2549   r = a[1] - b[1];
2550   if (r)
2551     return r;
2552   r = a[2] - b[2];
2553   if (r)
2554     return r;
2555   r = a[3] - b[3];
2556   if (r)
2557     return r;
2558   return 0;
2559 }
2560
2561 static void
2562 getpkgruleinfos(Solver *solv, Rule *r, Queue *rq)
2563 {
2564   Pool *pool = solv->pool;
2565   Id l, pp;
2566   if (r->p >= 0)
2567     return;
2568   queue_push(rq, r - solv->rules);      /* push the rule we're interested in */
2569   solv->ruleinfoq = rq;
2570   FOR_RULELITERALS(l, pp, r)
2571     {
2572       if (l >= 0)
2573         break;
2574       solver_addpkgrulesforsolvable(solv, pool->solvables - l, 0);
2575     }
2576 #ifdef ENABLE_LINKED_PKGS
2577   FOR_RULELITERALS(l, pp, r)
2578     {
2579       if (l < 0)
2580         {
2581           if (l == r->p)
2582             continue;
2583           break;
2584         }
2585       if (!strchr(pool_id2str(pool, pool->solvables[l].name), ':') || !has_package_link(pool, pool->solvables + l))
2586         break;
2587       add_package_link(solv, pool->solvables + l, 0, 0);
2588     }
2589 #endif
2590   solv->ruleinfoq = 0;
2591   queue_shift(rq);
2592 }
2593
2594 int
2595 solver_allruleinfos(Solver *solv, Id rid, Queue *rq)
2596 {
2597   Rule *r = solv->rules + rid;
2598   int i, j;
2599
2600   queue_empty(rq);
2601   if (rid <= 0 || rid >= solv->pkgrules_end)
2602     {
2603       Id type, from, to, dep;
2604       type = solver_ruleinfo(solv, rid, &from, &to, &dep);
2605       queue_push(rq, type);
2606       queue_push(rq, from);
2607       queue_push(rq, to);
2608       queue_push(rq, dep);
2609       return 1;
2610     }
2611   getpkgruleinfos(solv, r, rq);
2612   /* now sort & unify em */
2613   if (!rq->count)
2614     return 0;
2615   solv_sort(rq->elements, rq->count / 4, 4 * sizeof(Id), solver_allruleinfos_cmp, 0);
2616   /* throw out identical entries */
2617   for (i = j = 0; i < rq->count; i += 4)
2618     {
2619       if (j)
2620         {
2621           if (rq->elements[i] == rq->elements[j - 4] &&
2622               rq->elements[i + 1] == rq->elements[j - 3] &&
2623               rq->elements[i + 2] == rq->elements[j - 2] &&
2624               rq->elements[i + 3] == rq->elements[j - 1])
2625             continue;
2626         }
2627       rq->elements[j++] = rq->elements[i];
2628       rq->elements[j++] = rq->elements[i + 1];
2629       rq->elements[j++] = rq->elements[i + 2];
2630       rq->elements[j++] = rq->elements[i + 3];
2631     }
2632   rq->count = j;
2633   return j / 4;
2634 }
2635
2636 SolverRuleinfo
2637 solver_ruleinfo(Solver *solv, Id rid, Id *fromp, Id *top, Id *depp)
2638 {
2639   Pool *pool = solv->pool;
2640   Rule *r = solv->rules + rid;
2641   SolverRuleinfo type = SOLVER_RULE_UNKNOWN;
2642
2643   if (fromp)
2644     *fromp = 0;
2645   if (top)
2646     *top = 0;
2647   if (depp)
2648     *depp = 0;
2649   if (rid > 0 && rid < solv->pkgrules_end)
2650     {
2651       Queue rq;
2652       int i;
2653
2654       if (r->p >= 0)
2655         return SOLVER_RULE_PKG;
2656       if (fromp)
2657         *fromp = -r->p;
2658       queue_init(&rq);
2659       getpkgruleinfos(solv, r, &rq);
2660       type = SOLVER_RULE_PKG;
2661       for (i = 0; i < rq.count; i += 4)
2662         {
2663           Id qt, qo, qp, qd;
2664           qt = rq.elements[i];
2665           qp = rq.elements[i + 1];
2666           qo = rq.elements[i + 2];
2667           qd = rq.elements[i + 3];
2668           if (type == SOLVER_RULE_PKG || type > qt)
2669             {
2670               type = qt;
2671               if (fromp)
2672                 *fromp = qp;
2673               if (top)
2674                 *top = qo;
2675               if (depp)
2676                 *depp = qd;
2677             }
2678         }
2679       queue_free(&rq);
2680       return type;
2681     }
2682   if (rid >= solv->jobrules && rid < solv->jobrules_end)
2683     {
2684       Id jidx = solv->ruletojob.elements[rid - solv->jobrules];
2685       if (fromp)
2686         *fromp = jidx;
2687       if (top)
2688         *top = solv->job.elements[jidx];
2689       if (depp)
2690         *depp = solv->job.elements[jidx + 1];
2691       if ((r->d == 0 || r->d == -1) && r->w2 == 0 && r->p == -SYSTEMSOLVABLE)
2692         {
2693           Id how = solv->job.elements[jidx];
2694           if ((how & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_INSTALL|SOLVER_SOLVABLE_NAME))
2695             return SOLVER_RULE_JOB_UNKNOWN_PACKAGE;
2696           if ((how & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_INSTALL|SOLVER_SOLVABLE_PROVIDES))
2697             return SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP;
2698           if ((how & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_ERASE|SOLVER_SOLVABLE_NAME))
2699             return SOLVER_RULE_JOB_PROVIDED_BY_SYSTEM;
2700           if ((how & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_ERASE|SOLVER_SOLVABLE_PROVIDES))
2701             return SOLVER_RULE_JOB_PROVIDED_BY_SYSTEM;
2702           return SOLVER_RULE_JOB_UNSUPPORTED;
2703         }
2704       return SOLVER_RULE_JOB;
2705     }
2706   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2707     {
2708       if (fromp)
2709         *fromp = solv->installed->start + (rid - solv->updaterules);
2710       return SOLVER_RULE_UPDATE;
2711     }
2712   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2713     {
2714       if (fromp)
2715         *fromp = solv->installed->start + (rid - solv->featurerules);
2716       return SOLVER_RULE_FEATURE;
2717     }
2718   if (rid >= solv->duprules && rid < solv->duprules_end)
2719     {
2720       if (fromp)
2721         *fromp = -r->p;
2722       if (depp)
2723         *depp = pool->solvables[-r->p].name;
2724       return SOLVER_RULE_DISTUPGRADE;
2725     }
2726   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2727     {
2728       if (fromp)
2729         *fromp = -r->p;
2730       if (depp)
2731         *depp = pool->solvables[-r->p].name;
2732       return SOLVER_RULE_INFARCH;
2733     }
2734   if (rid >= solv->bestrules && rid < solv->bestrules_end)
2735     {
2736       if (fromp && solv->bestrules_info[rid - solv->bestrules] > 0)
2737         *fromp = solv->bestrules_info[rid - solv->bestrules];
2738       return SOLVER_RULE_BEST;
2739     }
2740   if (rid >= solv->yumobsrules && rid < solv->yumobsrules_end)
2741     {
2742       if (fromp)
2743         *fromp = -r->p;
2744       if (top)
2745         {
2746           /* first solvable is enough, we just need it for the name */
2747           if (!r->d || r->d == -1)
2748             *top = r->w2;
2749           else
2750             *top = pool->whatprovidesdata[r->d < 0 ? -r->d : r->d];
2751         }
2752       if (depp)
2753         *depp = solv->yumobsrules_info[rid - solv->yumobsrules];
2754       return SOLVER_RULE_YUMOBS;
2755     }
2756   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2757     return SOLVER_RULE_CHOICE;
2758   if (rid >= solv->recommendsrules && rid < solv->recommendsrules_end)
2759     return SOLVER_RULE_RECOMMENDS;
2760   if (rid >= solv->learntrules)
2761     return SOLVER_RULE_LEARNT;
2762   return SOLVER_RULE_UNKNOWN;
2763 }
2764
2765 SolverRuleinfo
2766 solver_ruleclass(Solver *solv, Id rid)
2767 {
2768   if (rid <= 0)
2769     return SOLVER_RULE_UNKNOWN;
2770   if (rid > 0 && rid < solv->pkgrules_end)
2771     return SOLVER_RULE_PKG;
2772   if (rid >= solv->jobrules && rid < solv->jobrules_end)
2773     return SOLVER_RULE_JOB;
2774   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2775     return SOLVER_RULE_UPDATE;
2776   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2777     return SOLVER_RULE_FEATURE;
2778   if (rid >= solv->duprules && rid < solv->duprules_end)
2779     return SOLVER_RULE_DISTUPGRADE;
2780   if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
2781     return SOLVER_RULE_INFARCH;
2782   if (rid >= solv->bestrules && rid < solv->bestrules_end)
2783     return SOLVER_RULE_BEST;
2784   if (rid >= solv->yumobsrules && rid < solv->yumobsrules_end)
2785     return SOLVER_RULE_YUMOBS;
2786   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2787     return SOLVER_RULE_CHOICE;
2788   if (rid >= solv->recommendsrules && rid < solv->recommendsrules_end)
2789     return SOLVER_RULE_RECOMMENDS;
2790   if (rid >= solv->learntrules && rid < solv->nrules)
2791     return SOLVER_RULE_LEARNT;
2792   return SOLVER_RULE_UNKNOWN;
2793 }
2794
2795 void
2796 solver_ruleliterals(Solver *solv, Id rid, Queue *q)
2797 {
2798   Pool *pool = solv->pool;
2799   Id p, pp;
2800   Rule *r;
2801
2802   queue_empty(q);
2803   r = solv->rules + rid;
2804   FOR_RULELITERALS(p, pp, r)
2805     if (p != -SYSTEMSOLVABLE)
2806       queue_push(q, p);
2807   if (!q->count)
2808     queue_push(q, -SYSTEMSOLVABLE);     /* hmm, better to return an empty result? */
2809 }
2810
2811 int
2812 solver_rule2jobidx(Solver *solv, Id rid)
2813 {
2814   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2815     return 0;
2816   return solv->ruletojob.elements[rid - solv->jobrules] + 1;
2817 }
2818
2819 /* job rule introspection */
2820 Id
2821 solver_rule2job(Solver *solv, Id rid, Id *whatp)
2822 {
2823   int idx;
2824   if (rid < solv->jobrules || rid >= solv->jobrules_end)
2825     {
2826       if (whatp)
2827         *whatp = 0;
2828       return 0;
2829     }
2830   idx = solv->ruletojob.elements[rid - solv->jobrules];
2831   if (whatp)
2832     *whatp = solv->job.elements[idx + 1];
2833   return solv->job.elements[idx];
2834 }
2835
2836 /* update/feature rule introspection */
2837 Id
2838 solver_rule2solvable(Solver *solv, Id rid)
2839 {
2840   if (rid >= solv->updaterules && rid < solv->updaterules_end)
2841     return rid - solv->updaterules;
2842   if (rid >= solv->featurerules && rid < solv->featurerules_end)
2843     return rid - solv->featurerules;
2844   return 0;
2845 }
2846
2847 Id
2848 solver_rule2pkgrule(Solver *solv, Id rid)
2849 {
2850   if (rid >= solv->choicerules && rid < solv->choicerules_end)
2851     return solv->choicerules_info[rid - solv->choicerules];
2852   if (rid >= solv->recommendsrules && rid < solv->recommendsrules_end)
2853     return solv->recommendsrules_info[rid - solv->recommendsrules];
2854   return 0;
2855 }
2856
2857 static void
2858 solver_rule2rules_rec(Solver *solv, Id rid, Queue *q, Map *seen)
2859 {
2860   int i;
2861   Id rid2;
2862
2863   if (seen)
2864     MAPSET(seen, rid);
2865   for (i = solv->learnt_why.elements[rid - solv->learntrules]; (rid2 = solv->learnt_pool.elements[i]) != 0; i++)
2866     {
2867       if (seen)
2868         {
2869           if (MAPTST(seen, rid2))
2870             continue;
2871           if (rid2 >= solv->learntrules)
2872             solver_rule2rules_rec(solv, rid2, q, seen);
2873           continue;
2874         }
2875       queue_push(q, rid2);
2876     }
2877 }
2878
2879 /* learnt rule introspection */
2880 void
2881 solver_rule2rules(Solver *solv, Id rid, Queue *q, int recursive)
2882 {
2883   queue_empty(q);
2884   if (rid < solv->learntrules || rid >= solv->nrules)
2885     return;
2886   if (recursive)
2887     {
2888       Map seen;
2889       map_init(&seen, solv->nrules);
2890       solver_rule2rules_rec(solv, rid, q, &seen);
2891       map_free(&seen);
2892     }
2893   else
2894     solver_rule2rules_rec(solv, rid, q, 0);
2895 }
2896
2897
2898 /* check if the newest versions of pi still provides the dependency we're looking for */
2899 static int
2900 solver_choicerulecheck(Solver *solv, Id pi, Rule *r, Map *m, Queue *q)
2901 {
2902   Pool *pool = solv->pool;
2903   Rule *ur;
2904   Id p, pp;
2905   int i;
2906
2907   if (!q->count || q->elements[0] != pi)
2908     {
2909       if (q->count)
2910         queue_empty(q);
2911       ur = solv->rules + solv->updaterules + (pi - pool->installed->start);
2912       if (!ur->p)
2913         ur = solv->rules + solv->featurerules + (pi - pool->installed->start);
2914       if (!ur->p)
2915         return 0;
2916       queue_push2(q, pi, 0);
2917       FOR_RULELITERALS(p, pp, ur)
2918         if (p > 0)
2919           queue_push(q, p);
2920     }
2921   if (q->count == 2)
2922     return 1;
2923   if (q->count == 3)
2924     {
2925       p = q->elements[2];
2926       return MAPTST(m, p) ? 0 : 1;
2927     }
2928   if (!q->elements[1])
2929     {
2930       for (i = 2; i < q->count; i++)
2931         if (!MAPTST(m, q->elements[i]))
2932           break;
2933       if (i == q->count)
2934         return 0;       /* all provide it, no need to filter */
2935       /* some don't provide it, have to filter */
2936       queue_deleten(q, 0, 2);
2937       policy_filter_unwanted(solv, q, POLICY_MODE_CHOOSE);
2938       queue_unshift(q, 1);      /* filter mark */
2939       queue_unshift(q, pi);
2940     }
2941   for (i = 2; i < q->count; i++)
2942     if (MAPTST(m, q->elements[i]))
2943       return 0;         /* at least one provides it */
2944   return 1;     /* none of the new packages provided it */
2945 }
2946
2947 static inline void
2948 queue_removeelement(Queue *q, Id el)
2949 {
2950   int i, j;
2951   for (i = 0; i < q->count; i++)
2952     if (q->elements[i] == el)
2953       break;
2954   if (i < q->count)
2955     {
2956       for (j = i++; i < q->count; i++)
2957         if (q->elements[i] != el)
2958           q->elements[j++] = q->elements[i];
2959       queue_truncate(q, j);
2960     }
2961 }
2962
2963 void
2964 solver_addchoicerules(Solver *solv)
2965 {
2966   Pool *pool = solv->pool;
2967   Map m, mneg;
2968   Rule *r;
2969   Queue q, qi, qcheck, infoq;
2970   int i, j, rid, havechoice;
2971   Id p, d, pp;
2972   Id p2, pp2;
2973   Solvable *s, *s2;
2974   Id lastaddedp, lastaddedd;
2975   int lastaddedcnt;
2976   unsigned int now;
2977
2978   solv->choicerules = solv->nrules;
2979   if (!pool->installed)
2980     {
2981       solv->choicerules_end = solv->nrules;
2982       return;
2983     }
2984   now = solv_timems(0);
2985   solv->choicerules_info = solv_calloc(solv->pkgrules_end, sizeof(Id));
2986   queue_init(&q);
2987   queue_init(&qi);
2988   queue_init(&qcheck);
2989   queue_init(&infoq);
2990   map_init(&m, pool->nsolvables);
2991   map_init(&mneg, pool->nsolvables);
2992   /* set up negative assertion map from infarch and dup rules */
2993   for (rid = solv->infarchrules, r = solv->rules + rid; rid < solv->infarchrules_end; rid++, r++)
2994     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2995       MAPSET(&mneg, -r->p);
2996   for (rid = solv->duprules, r = solv->rules + rid; rid < solv->duprules_end; rid++, r++)
2997     if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
2998       MAPSET(&mneg, -r->p);
2999   lastaddedp = 0;
3000   lastaddedd = 0;
3001   lastaddedcnt = 0;
3002   for (rid = 1; rid < solv->pkgrules_end ; rid++)
3003     {
3004       r = solv->rules + rid;
3005       if (r->p >= 0 || ((r->d == 0 || r->d == -1) && r->w2 <= 0))
3006         continue;       /* only look at requires rules */
3007       /* solver_printrule(solv, SOLV_DEBUG_RESULT, r); */
3008       queue_empty(&q);
3009       queue_empty(&qi);
3010       havechoice = 0;
3011       FOR_RULELITERALS(p, pp, r)
3012         {
3013           if (p < 0)
3014             continue;
3015           s = pool->solvables + p;
3016           if (!s->repo)
3017             continue;
3018           if (s->repo == pool->installed)
3019             {
3020               queue_push(&q, p);
3021               continue;
3022             }
3023           /* check if this package is "blocked" by a installed package */
3024           s2 = 0;
3025           FOR_PROVIDES(p2, pp2, s->name)
3026             {
3027               s2 = pool->solvables + p2;
3028               if (s2->repo != pool->installed)
3029                 continue;
3030               if (!pool->implicitobsoleteusesprovides && s->name != s2->name)
3031                 continue;
3032               if (pool->implicitobsoleteusescolors && !pool_colormatch(pool, s, s2))
3033                 continue;
3034               break;
3035             }
3036           if (p2)
3037             {
3038               /* found installed package p2 that we can update to p */
3039               if (MAPTST(&mneg, p))
3040                 continue;
3041               if (policy_is_illegal(solv, s2, s, 0))
3042                 continue;
3043 #if 0
3044               if (solver_choicerulecheck(solv, p2, r, &m))
3045                 continue;
3046               queue_push(&qi, p2);
3047 #else
3048               queue_push2(&qi, p2, p);
3049 #endif
3050               queue_push(&q, p);
3051               continue;
3052             }
3053           if (s->obsoletes)
3054             {
3055               Id obs, *obsp = s->repo->idarraydata + s->obsoletes;
3056               s2 = 0;
3057               while ((obs = *obsp++) != 0)
3058                 {
3059                   FOR_PROVIDES(p2, pp2, obs)
3060                     {
3061                       s2 = pool->solvables + p2;
3062                       if (s2->repo != pool->installed)
3063                         continue;
3064                       if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pool->solvables + p2, obs))
3065                         continue;
3066                       if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
3067                         continue;
3068                       break;
3069                     }
3070                   if (p2)
3071                     break;
3072                 }
3073               if (obs)
3074                 {
3075                   /* found installed package p2 that we can update to p */
3076                   if (MAPTST(&mneg, p))
3077                     continue;
3078                   if (policy_is_illegal(solv, s2, s, 0))
3079                     continue;
3080 #if 0
3081                   if (solver_choicerulecheck(solv, p2, r, &m))
3082                     continue;
3083                   queue_push(&qi, p2);
3084 #else
3085                   queue_push2(&qi, p2, p);
3086 #endif
3087                   queue_push(&q, p);
3088                   continue;
3089                 }
3090             }
3091           /* package p is independent of the installed ones */
3092           havechoice = 1;
3093         }
3094       if (!havechoice || !q.count || !qi.count)
3095         continue;       /* no choice */
3096
3097       FOR_RULELITERALS(p, pp, r)
3098         if (p > 0)
3099           MAPSET(&m, p);
3100
3101       /* do extra checking */
3102       for (i = j = 0; i < qi.count; i += 2)
3103         {
3104           p2 = qi.elements[i];
3105           if (!p2)
3106             continue;
3107           if (solver_choicerulecheck(solv, p2, r, &m, &qcheck))
3108             {
3109               /* oops, remove element p from q */
3110               queue_removeelement(&q, qi.elements[i + 1]);
3111               continue;
3112             }
3113           qi.elements[j++] = p2;
3114         }
3115       queue_truncate(&qi, j);
3116
3117       if (!q.count || !qi.count)
3118         {
3119           FOR_RULELITERALS(p, pp, r)
3120             if (p > 0)
3121               MAPCLR(&m, p);
3122           continue;
3123         }
3124
3125
3126       /* now check the update rules of the installed package.
3127        * if all packages of the update rules are contained in
3128        * the dependency rules, there's no need to set up the choice rule */
3129       for (i = 0; i < qi.count; i++)
3130         {
3131           Rule *ur;
3132           if (!qi.elements[i])
3133             continue;
3134           ur = solv->rules + solv->updaterules + (qi.elements[i] - pool->installed->start);
3135           if (!ur->p)
3136             ur = solv->rules + solv->featurerules + (qi.elements[i] - pool->installed->start);
3137           if (!ur->p)
3138             continue;
3139           FOR_RULELITERALS(p, pp, ur)
3140             if (!MAPTST(&m, p))
3141               break;
3142           if (p)
3143             break;
3144           for (j = i + 1; j < qi.count; j++)
3145             if (qi.elements[i] == qi.elements[j])
3146               qi.elements[j] = 0;
3147         }
3148       /* empty map again */
3149       FOR_RULELITERALS(p, pp, r)
3150         if (p > 0)
3151           MAPCLR(&m, p);
3152       if (i == qi.count)
3153         {
3154 #if 0
3155           printf("skipping choice ");
3156           solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
3157 #endif
3158           continue;
3159         }
3160
3161       /* don't add identical rules */
3162       if (lastaddedp == r->p && lastaddedcnt == q.count)
3163         {
3164           for (i = 0; i < q.count; i++)
3165             if (q.elements[i] != pool->whatprovidesdata[lastaddedd + i])
3166               break;
3167           if (i == q.count)
3168             continue;   /* already added that one */
3169         }
3170       d = q.count ? pool_queuetowhatprovides(pool, &q) : 0;
3171
3172       lastaddedp = r->p;
3173       lastaddedd = d;
3174       lastaddedcnt = q.count;
3175
3176       solver_addrule(solv, r->p, 0, d);
3177       queue_push(&solv->weakruleq, solv->nrules - 1);
3178       queue_push(&infoq, rid);
3179 #if 0
3180       printf("OLD ");
3181       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
3182       printf("WEAK CHOICE ");
3183       solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + solv->nrules - 1);
3184 #endif
3185     }
3186   if (infoq.count)
3187     solv->choicerules_info = solv_memdup2(infoq.elements, infoq.count, sizeof(Id));
3188   queue_free(&q);
3189   queue_free(&qi);
3190   queue_free(&qcheck);
3191   queue_free(&infoq);
3192   map_free(&m);
3193   map_free(&mneg);
3194   solv->choicerules_end = solv->nrules;
3195   POOL_DEBUG(SOLV_DEBUG_STATS, "choice rule creation took %d ms\n", solv_timems(now));
3196 }
3197
3198 /* called when a choice rule needs to be disabled by analyze_unsolvable.
3199  * We also have to disable all other choice rules so that the best packages
3200  * get picked */
3201 void
3202 solver_disablechoicerules(Solver *solv, Rule *r)
3203 {
3204   Id rid, p, pp;
3205   Pool *pool = solv->pool;
3206   Map m;
3207   Rule *or;
3208
3209   solver_disablerule(solv, r);
3210   or = solv->rules + solv->choicerules_info[(r - solv->rules) - solv->choicerules];
3211   map_init(&m, pool->nsolvables);
3212   FOR_RULELITERALS(p, pp, or)
3213     if (p > 0)
3214       MAPSET(&m, p);
3215   FOR_RULELITERALS(p, pp, r)
3216     if (p > 0)
3217       MAPCLR(&m, p);
3218   for (rid = solv->choicerules; rid < solv->choicerules_end; rid++)
3219     {
3220       r = solv->rules + rid;
3221       if (r->d < 0)
3222         continue;
3223       or = solv->rules + solv->choicerules_info[rid - solv->choicerules];
3224       FOR_RULELITERALS(p, pp, or)
3225         if (p > 0 && MAPTST(&m, p))
3226           break;
3227       if (p)
3228         solver_disablerule(solv, r);
3229     }
3230 }
3231
3232 static void
3233 prune_to_update_targets(Solver *solv, Id *cp, Queue *q)
3234 {
3235   int i, j;
3236   Id p, *cp2;
3237   for (i = j = 0; i < q->count; i++)
3238     {
3239       p = q->elements[i];
3240       for (cp2 = cp; *cp2; cp2++)
3241         if (*cp2 == p)
3242           {
3243             q->elements[j++] = p;
3244             break;
3245           }
3246     }
3247   queue_truncate(q, j);
3248 }
3249
3250 static void
3251 prune_to_dup_packages(Solver *solv, Id p, Queue *q)
3252 {
3253   int i, j;
3254   for (i = j = 0; i < q->count; i++)
3255     {
3256       Id p = q->elements[i];
3257       if (MAPTST(&solv->dupmap, p))
3258         q->elements[j++] = p;
3259     }
3260   queue_truncate(q, j);
3261 }
3262
3263 void
3264 solver_addbestrules(Solver *solv, int havebestinstalljobs)
3265 {
3266   Pool *pool = solv->pool;
3267   Id p;
3268   Solvable *s;
3269   Repo *installed = solv->installed;
3270   Queue q, q2;
3271   Rule *r;
3272   Queue infoq;
3273   int i, oldcnt;
3274
3275   solv->bestrules = solv->nrules;
3276   queue_init(&q);
3277   queue_init(&q2);
3278   queue_init(&infoq);
3279
3280   if (havebestinstalljobs)
3281     {
3282       for (i = 0; i < solv->job.count; i += 2)
3283         {
3284           Id how = solv->job.elements[i];
3285           if ((how & (SOLVER_JOBMASK | SOLVER_FORCEBEST)) == (SOLVER_INSTALL | SOLVER_FORCEBEST))
3286             {
3287               int j;
3288               Id p2, pp2;
3289               for (j = 0; j < solv->ruletojob.count; j++)
3290                 {
3291                   if (solv->ruletojob.elements[j] != i)
3292                     continue;
3293                   r = solv->rules + solv->jobrules + j;
3294                   queue_empty(&q);
3295                   queue_empty(&q2);
3296                   FOR_RULELITERALS(p2, pp2, r)
3297                     {
3298                       if (p2 > 0)
3299                         queue_push(&q, p2);
3300                       else if (p2 < 0)
3301                         queue_push(&q2, p2);
3302                     }
3303                   if (!q.count)
3304                     continue;   /* orphaned */
3305                   /* select best packages, just look at prio and version */
3306                   oldcnt = q.count;
3307                   policy_filter_unwanted(solv, &q, POLICY_MODE_RECOMMEND);
3308                   if (q.count == oldcnt)
3309                     continue;   /* nothing filtered */
3310                   if (q2.count)
3311                     queue_insertn(&q, 0, q2.count, q2.elements);
3312                   p2 = queue_shift(&q);
3313                   if (q.count < 2)
3314                     solver_addrule(solv, p2, q.count ? q.elements[0] : 0, 0);
3315                   else
3316                     solver_addrule(solv, p2, 0, pool_queuetowhatprovides(pool, &q));
3317                   if ((how & SOLVER_WEAK) != 0)
3318                     queue_push(&solv->weakruleq, solv->nrules - 1);
3319                   queue_push(&infoq, -(solv->jobrules + j));
3320                 }
3321             }
3322         }
3323     }
3324   solv->bestrules_up = solv->nrules;
3325
3326   if (installed && (solv->bestupdatemap_all || solv->bestupdatemap.size))
3327     {
3328       Map m;
3329
3330       if (solv->allowuninstall || solv->allowuninstall_all || solv->allowuninstallmap.size)
3331         map_init(&m, pool->nsolvables);
3332       else
3333         map_init(&m, 0);
3334       FOR_REPO_SOLVABLES(installed, p, s)
3335         {
3336           Id d, p2, pp2;
3337           if (!solv->updatemap_all && (!solv->updatemap.size || !MAPTST(&solv->updatemap, p - installed->start)))
3338             continue;
3339           if (!solv->bestupdatemap_all && (!solv->bestupdatemap.size || !MAPTST(&solv->bestupdatemap, p - installed->start)))
3340             continue;
3341           queue_empty(&q);
3342           if (solv->bestobeypolicy)
3343             r = solv->rules + solv->updaterules + (p - installed->start);
3344           else
3345             {
3346               r = solv->rules + solv->featurerules + (p - installed->start);
3347               if (!r->p)        /* identical to update rule? */
3348                 r = solv->rules + solv->updaterules + (p - installed->start);
3349             }
3350           if (solv->specialupdaters && (d = solv->specialupdaters[p - installed->start]) != 0 && r == solv->rules + solv->updaterules + (p - installed->start))
3351             {
3352               /* need to check specialupdaters */
3353               if (r->p == p)    /* be careful with the dup case */
3354                 queue_push(&q, p);
3355               while ((p2 = pool->whatprovidesdata[d++]) != 0)
3356                 queue_push(&q, p2);
3357             }
3358           else
3359             {
3360               FOR_RULELITERALS(p2, pp2, r)
3361                 if (p2 > 0)
3362                   queue_push(&q, p2);
3363             }
3364           if (solv->update_targets && solv->update_targets->elements[p - installed->start])
3365             prune_to_update_targets(solv, solv->update_targets->elements + solv->update_targets->elements[p - installed->start], &q);
3366           if (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
3367             prune_to_dup_packages(solv, p, &q);
3368           /* select best packages, just look at prio and version */
3369           policy_filter_unwanted(solv, &q, POLICY_MODE_RECOMMEND);
3370           if (!q.count)
3371             continue;   /* orphaned */
3372           if (solv->bestobeypolicy)
3373             {
3374               /* also filter the best of the feature rule packages and add them */
3375               r = solv->rules + solv->featurerules + (p - installed->start);
3376               if (r->p)
3377                 {
3378                   int j;
3379                   queue_empty(&q2);
3380                   FOR_RULELITERALS(p2, pp2, r)
3381                     if (p2 > 0)
3382                       queue_push(&q2, p2);
3383                   if (solv->update_targets && solv->update_targets->elements[p - installed->start])
3384                     prune_to_update_targets(solv, solv->update_targets->elements + solv->update_targets->elements[p - installed->start], &q2);
3385                   if (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
3386                     prune_to_dup_packages(solv, p, &q2);
3387                   policy_filter_unwanted(solv, &q2, POLICY_MODE_RECOMMEND);
3388                   for (j = 0; j < q2.count; j++)
3389                     queue_pushunique(&q, q2.elements[j]);
3390                 }
3391             }
3392           if (solv->allowuninstall || solv->allowuninstall_all || (solv->allowuninstallmap.size && MAPTST(&solv->allowuninstallmap, p - installed->start)))
3393             {
3394               /* package is flagged both for allowuninstall and best, add negative rules */
3395               d = q.count == 1 ? q.elements[0] : -pool_queuetowhatprovides(pool, &q);
3396               for (i = 0; i < q.count; i++)
3397                 MAPSET(&m, q.elements[i]);
3398               r = solv->rules + solv->featurerules + (p - installed->start);
3399               if (!r->p)        /* identical to update rule? */
3400                 r = solv->rules + solv->updaterules + (p - installed->start);
3401               FOR_RULELITERALS(p2, pp2, r)
3402                 {
3403                   if (MAPTST(&m, p2))
3404                     continue;
3405                   if (d >= 0)
3406                     solver_addrule(solv, -p2, d, 0);
3407                   else
3408                     solver_addrule(solv, -p2, 0, -d);
3409                   queue_push(&infoq, p);
3410                 }
3411               for (i = 0; i < q.count; i++)
3412                 MAPCLR(&m, q.elements[i]);
3413               continue;
3414             }
3415           p2 = queue_shift(&q);
3416           if (q.count < 2)
3417             solver_addrule(solv, p2, q.count ? q.elements[0] : 0, 0);
3418           else
3419             solver_addrule(solv, p2, 0, pool_queuetowhatprovides(pool, &q));
3420           queue_push(&infoq, p);
3421         }
3422       map_free(&m);
3423     }
3424   if (infoq.count)
3425     solv->bestrules_info = solv_memdup2(infoq.elements, infoq.count, sizeof(Id));
3426   solv->bestrules_end = solv->nrules;
3427   queue_free(&q);
3428   queue_free(&q2);
3429   queue_free(&infoq);
3430 }
3431
3432
3433
3434
3435 /* yumobs rule handling */
3436 /* note that we use pool->obsoleteusescolors || pool->implicitobsoleteusescolors
3437  * like in policy_findupdatepackages */
3438
3439 static void
3440 find_obsolete_group(Solver *solv, Id obs, Queue *q)
3441 {
3442   Pool *pool = solv->pool;
3443   Queue qn;
3444   Id p2, pp2, op, *opp, opp2;
3445   int i, j, qnc, ncnt;
3446
3447   queue_empty(q);
3448   FOR_PROVIDES(p2, pp2, obs)
3449     {
3450       Solvable *s2 = pool->solvables + p2;
3451       if (s2->repo != pool->installed)
3452         continue;
3453       if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pool->solvables + p2, obs))
3454         continue;
3455       /* we obsolete installed package s2 with obs. now find all other packages that have the same dep  */
3456       for (opp = solv->obsoletes_data + solv->obsoletes[p2 - solv->installed->start]; (op = *opp++) != 0;)
3457         {
3458           Solvable *os = pool->solvables + op;
3459           Id obs2, *obsp2;
3460           if (!os->obsoletes)
3461             continue;
3462           if ((pool->obsoleteusescolors || pool->implicitobsoleteusescolors) && !pool_colormatch(pool, s2, os))
3463             continue;
3464           obsp2 = os->repo->idarraydata + os->obsoletes;
3465           while ((obs2 = *obsp2++) != 0)
3466             if (obs2 == obs)
3467               break;
3468           if (obs2)
3469             queue_pushunique(q, op);
3470         }
3471       /* also search packages with the same name */
3472       FOR_PROVIDES(op, opp2, s2->name)
3473         {
3474           Solvable *os = pool->solvables + op;
3475           Id obs2, *obsp2;
3476           if (os->name != s2->name)
3477             continue;
3478           if (!os->obsoletes)
3479             continue;
3480           if ((pool->obsoleteusescolors || pool->implicitobsoleteusescolors) && !pool_colormatch(pool, s2, os))
3481             continue;
3482           obsp2 = os->repo->idarraydata + os->obsoletes;
3483           while ((obs2 = *obsp2++) != 0)
3484             if (obs2 == obs)
3485               break;
3486           if (obs2)
3487             queue_pushunique(q, op);
3488         }
3489     }
3490   /* find names so that we can build groups */
3491   queue_init_clone(&qn, q);
3492   prune_to_best_version(solv->pool, &qn);
3493 #if 0
3494 {
3495   for (i = 0; i < qn.count; i++)
3496     printf(" + %s\n", pool_solvid2str(pool, qn.elements[i]));
3497 }
3498 #endif
3499   /* filter into name groups */
3500   qnc = qn.count;
3501   if (qnc == 1)
3502     {
3503       queue_free(&qn);
3504       queue_empty(q);
3505       return;
3506     }
3507   ncnt = 0;
3508   for (i = 0; i < qnc; i++)
3509     {
3510       Id n = pool->solvables[qn.elements[i]].name;
3511       int got = 0;
3512       for (j = 0; j < q->count; j++)
3513         {
3514           Id p = q->elements[j];
3515           if (pool->solvables[p].name == n)
3516             {
3517               queue_push(&qn, p);
3518               got = 1;
3519             }
3520         }
3521       if (got)
3522         {
3523           queue_push(&qn, 0);
3524           ncnt++;
3525         }
3526     }
3527   if (ncnt <= 1)
3528     {
3529       queue_empty(q);
3530     }
3531   else
3532     {
3533       queue_empty(q);
3534       queue_insertn(q, 0, qn.count - qnc, qn.elements + qnc);
3535     }
3536   queue_free(&qn);
3537 }
3538
3539 void
3540 solver_addyumobsrules(Solver *solv)
3541 {
3542   Pool *pool = solv->pool;
3543   Repo *installed = solv->installed;
3544   Id p, op, *opp;
3545   Solvable *s;
3546   Queue qo, qq, infoq;
3547   int i, j, k;
3548   unsigned int now;
3549
3550   solv->yumobsrules = solv->nrules;
3551   if (!installed || !solv->obsoletes)
3552     {
3553       solv->yumobsrules_end = solv->nrules;
3554       return;
3555     }
3556   now = solv_timems(0);
3557   queue_init(&qo);
3558   FOR_REPO_SOLVABLES(installed, p, s)
3559     {
3560       if (!solv->obsoletes[p - installed->start])
3561         continue;
3562 #if 0
3563 printf("checking yumobs for %s\n", pool_solvable2str(pool, s));
3564 #endif
3565       for (opp = solv->obsoletes_data + solv->obsoletes[p - installed->start]; (op = *opp++) != 0;)
3566         {
3567           Solvable *os = pool->solvables + op;
3568           Id obs, *obsp = os->repo->idarraydata + os->obsoletes;
3569           Id p2, pp2;
3570           while ((obs = *obsp++) != 0)
3571             {
3572               FOR_PROVIDES(p2, pp2, obs)
3573                 {
3574                   Solvable *s2 = pool->solvables + p2;
3575                   if (s2->repo != installed)
3576                     continue;
3577                   if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pool->solvables + p2, obs))
3578                     continue;
3579                   if ((pool->obsoleteusescolors || pool->implicitobsoleteusescolors) && !pool_colormatch(pool, s, s2))
3580                     continue;
3581                   queue_pushunique(&qo, obs);
3582                   break;
3583                 }
3584             }
3585         }
3586     }
3587   if (!qo.count)
3588     {
3589       queue_free(&qo);
3590       return;
3591     }
3592   queue_init(&infoq);
3593   queue_init(&qq);
3594   for (i = 0; i < qo.count; i++)
3595     {
3596       int group, groupk, groupstart;
3597       queue_empty(&qq);
3598 #if 0
3599 printf("investigating %s\n", pool_dep2str(pool, qo.elements[i]));
3600 #endif
3601       find_obsolete_group(solv, qo.elements[i], &qq);
3602 #if 0
3603 printf("result:\n");
3604 for (j = 0; j < qq.count; j++)
3605   if (qq.elements[j] == 0)
3606     printf("---\n");
3607   else
3608     printf("%s\n", pool_solvid2str(pool, qq.elements[j]));
3609 #endif
3610
3611       if (!qq.count)
3612         continue;
3613       /* at least two goups, build rules */
3614       group = 0;
3615       for (j = 0; j < qq.count; j++)
3616         {
3617           p = qq.elements[j];
3618           if (!p)
3619             {
3620               group++;
3621               continue;
3622             }
3623           if (pool->solvables[p].repo == installed)
3624             continue;
3625           groupk = 0;
3626           groupstart = 0;
3627           for (k = 0; k < qq.count; k++)
3628             {
3629               Id pk = qq.elements[k];
3630               if (pk)
3631                 continue;
3632               if (group != groupk && k > groupstart)
3633                 {
3634                   /* add the rule */
3635                   if (k - groupstart == 1)
3636                     solver_addrule(solv, -p, qq.elements[groupstart], 0);
3637                   else
3638                     solver_addrule(solv, -p, 0, pool_ids2whatprovides(pool, qq.elements + groupstart, k - groupstart));
3639                   queue_push(&infoq, qo.elements[i]);
3640                 }
3641               groupstart = k + 1;
3642               groupk++;
3643             }
3644         }
3645     }
3646   if (infoq.count)
3647     solv->yumobsrules_info = solv_memdup2(infoq.elements, infoq.count, sizeof(Id));
3648   queue_free(&infoq);
3649   queue_free(&qq);
3650   queue_free(&qo);
3651   solv->yumobsrules_end = solv->nrules;
3652   POOL_DEBUG(SOLV_DEBUG_STATS, "yumobs rule creation took %d ms\n", solv_timems(now));
3653 }
3654
3655 /* recommendsrules are a copy of some recommends package rule but
3656  * with some disfavored literals removed */
3657 void
3658 solver_addrecommendsrules(Solver *solv)
3659 {
3660   Pool *pool = solv->pool;
3661   int i, havedis, havepos;
3662   Id p, pp;
3663   Queue q, infoq;
3664
3665   solv->recommendsrules = solv->nrules;
3666   queue_init(&q);
3667   queue_init(&infoq);
3668   for (i = 0; i < solv->recommendsruleq->count; i++)
3669     {
3670       int rid = solv->recommendsruleq->elements[i];
3671       Rule *r = solv->rules + rid;
3672       queue_empty(&q);
3673       havedis = havepos = 0;
3674       FOR_RULELITERALS(p, pp, r)
3675         {
3676           if (p > 0 && solv->favormap[p] < 0)
3677             havedis = 1;
3678           else
3679             {
3680               if (p > 0)
3681                 havepos = 1;
3682               queue_push(&q, p);
3683             }
3684         }
3685       if (!havedis)
3686         continue;
3687       solver_disablerule(solv, r);
3688       if (!havepos || q.count < 2)
3689         continue;
3690       if (q.count == 2)
3691         solver_addrule(solv, q.elements[0], q.elements[1], 0);
3692       else
3693         solver_addrule(solv, q.elements[0], 0, pool_ids2whatprovides(pool, q.elements + 1, q.count - 1));
3694       queue_push(&infoq, rid);
3695     }
3696   if (infoq.count)
3697     solv->recommendsrules_info = solv_memdup2(infoq.elements, infoq.count, sizeof(Id));
3698   queue_free(&infoq);
3699   queue_free(&q);
3700   solv->recommendsrules_end = solv->nrules;
3701 }
3702
3703 void
3704 solver_breakorphans(Solver *solv)
3705 {
3706   Pool *pool = solv->pool;
3707   Repo *installed = solv->installed;
3708   int i, rid;
3709   Map m;
3710
3711   if (!installed || solv->droporphanedmap_all)
3712     return;
3713   solv->brokenorphanrules = solv_calloc(1, sizeof(Queue));
3714   queue_init(solv->brokenorphanrules);
3715   map_init(&m, installed->end - installed->start);
3716   for (i = 0; i < solv->orphaned.count; i++)
3717     {
3718       Id p = solv->orphaned.elements[i];
3719       if (pool->solvables[p].repo != installed)
3720         continue;
3721       if (solv->droporphanedmap.size && MAPTST(&solv->droporphanedmap, p - installed->start))
3722         continue;
3723       MAPSET(&m, p - installed->start);
3724     }
3725   for (rid = 1; rid < solv->pkgrules_end ; rid++)
3726     {
3727       Id p, *dp;
3728       Rule *r = solv->rules + rid;
3729       /* ignore non-deps and simple conflicts */
3730       if (r->p >= 0 || ((r->d == 0 || r->d == -1) && r->w2 < 0))
3731         continue;
3732       p = -r->p;
3733       if (p < installed->start || p >= installed->end || !MAPTST(&m, p - installed->start))
3734         {
3735           /* need to check other literals */
3736           if (r->d == 0 || r->d == -1)
3737             continue;
3738           for (dp = pool->whatprovidesdata + (r->d < 0 ? -r->d - 1 : r->d); *dp < 0; dp++)
3739             {
3740               p = -*dp;
3741               if (p >= installed->start && p < installed->end && MAPTST(&m, p - installed->start))
3742                 break;
3743             }
3744           if (*dp >= 0)
3745             continue;
3746         }
3747       /* ok, disable this rule */
3748       queue_push(solv->brokenorphanrules, rid);
3749       if (r->d >= 0)
3750         solver_disablerule(solv, r);
3751     }
3752   map_free(&m);
3753   if (!solv->brokenorphanrules->count)
3754     {
3755       queue_free(solv->brokenorphanrules);
3756       solv->brokenorphanrules = solv_free(solv->brokenorphanrules);
3757     }
3758 }
3759
3760 void
3761 solver_check_brokenorphanrules(Solver *solv, Queue *dq)
3762 {
3763   Pool *pool = solv->pool;
3764   int i;
3765   Id l, pp;
3766
3767   queue_empty(dq);
3768   if (!solv->brokenorphanrules)
3769     return;
3770   for (i = 0; i < solv->brokenorphanrules->count; i++)
3771     {
3772       int rid = solv->brokenorphanrules->elements[i];
3773       Rule *r = solv->rules + rid;
3774       FOR_RULELITERALS(l, pp, r)
3775         {
3776           if (l < 0)
3777             {
3778               if (solv->decisionmap[-l] <= 0)
3779                 break;
3780             }
3781           else
3782             {
3783               if (solv->decisionmap[l] > 0 && pool->solvables[l].repo != solv->installed)
3784                 break;
3785             }
3786         }
3787       if (l)
3788         continue;
3789       FOR_RULELITERALS(l, pp, r)
3790         if (l > 0 && solv->decisionmap[l] == 0 && pool->solvables[l].repo != solv->installed)
3791           queue_pushunique(dq, l);
3792     }
3793 }
3794