src/problems.c

   1 /*
   2  * Copyright (c) 2007-2009, Novell Inc.
   3  *
   4  * This program is licensed under the BSD license, read LICENSE.BSD
   5  * for further information
   6  */
   7
   8 /*
   9  * problems.c
  10  *
  11  */
  12
  13 #include <stdio.h>
  14 #include <stdlib.h>
  15 #include <unistd.h>
  16 #include <string.h>
  17 #include <assert.h>
  18
  19 #include "solver.h"
  20 #include "solver_private.h"
  21 #include "bitmap.h"
  22 #include "pool.h"
  23 #include "util.h"
  24 #include "evr.h"
  25 #include "solverdebug.h"
  26
  27
  28 /**********************************************************************************/
  29
  30 /* a problem is an item on the solver's problem list. It can either be >0, in that
  31  * case it is a update/infarch/dup rule, or it can be <0, which makes it refer to a job
  32  * consisting of multiple job rules.
  33  */
  34
  35 void
  36 solver_disableproblem(Solver *solv, Id v)
  37 {
  38   Rule *r;
  39   int i;
  40   Id *jp;
  41
  42   if (v > 0)
  43     {
  44       if (v >= solv->infarchrules && v < solv->infarchrules_end)
  45         {
  46           Pool *pool = solv->pool;
  47           Id name = pool->solvables[-solv->rules[v].p].name;
  48           while (v > solv->infarchrules && pool->solvables[-solv->rules[v - 1].p].name == name)
  49             v--;
  50           for (; v < solv->infarchrules_end && pool->solvables[-solv->rules[v].p].name == name; v++)
  51             solver_disablerule(solv, solv->rules + v);
  52           return;
  53         }
  54       if (v >= solv->duprules && v < solv->duprules_end)
  55         {
  56           Pool *pool = solv->pool;
  57           Id name = pool->solvables[-solv->rules[v].p].name;
  58           while (v > solv->duprules && pool->solvables[-solv->rules[v - 1].p].name == name)
  59             v--;
  60           for (; v < solv->duprules_end && pool->solvables[-solv->rules[v].p].name == name; v++)
  61             solver_disablerule(solv, solv->rules + v);
  62           return;
  63         }
  64       solver_disablerule(solv, solv->rules + v);
  65 #if 0
  66       /* XXX: doesn't work */
  67       if (v >= solv->updaterules && v < solv->updaterules_end)
  68         {
  69           /* enable feature rule if we disabled the update rule */
  70           r = solv->rules + (v - solv->updaterules + solv->featurerules);
  71           if (r->p)
  72             solver_enablerule(solv, r);
  73         }
  74 #endif
  75       return;
  76     }
  77   v = -(v + 1);
  78   jp = solv->ruletojob.elements;
  79   for (i = solv->jobrules, r = solv->rules + i; i < solv->jobrules_end; i++, r++, jp++)
  80     if (*jp == v)
  81       solver_disablerule(solv, r);
  82 }
  83
  84 /*-------------------------------------------------------------------
  85  * enableproblem
  86  */
  87
  88 void
  89 solver_enableproblem(Solver *solv, Id v)
  90 {
  91   Rule *r;
  92   int i;
  93   Id *jp;
  94
  95   if (v > 0)
  96     {
  97       if (v >= solv->infarchrules && v < solv->infarchrules_end)
  98         {
  99           Pool *pool = solv->pool;
 100           Id name = pool->solvables[-solv->rules[v].p].name;
 101           while (v > solv->infarchrules && pool->solvables[-solv->rules[v - 1].p].name == name)
 102             v--;
 103           for (; v < solv->infarchrules_end && pool->solvables[-solv->rules[v].p].name == name; v++)
 104             solver_enablerule(solv, solv->rules + v);
 105           return;
 106         }
 107       if (v >= solv->duprules && v < solv->duprules_end)
 108         {
 109           Pool *pool = solv->pool;
 110           Id name = pool->solvables[-solv->rules[v].p].name;
 111           while (v > solv->duprules && pool->solvables[-solv->rules[v - 1].p].name == name)
 112             v--;
 113           for (; v < solv->duprules_end && pool->solvables[-solv->rules[v].p].name == name; v++)
 114             solver_enablerule(solv, solv->rules + v);
 115           return;
 116         }
 117       if (v >= solv->featurerules && v < solv->featurerules_end)
 118         {
 119           /* do not enable feature rule if update rule is enabled */
 120           r = solv->rules + (v - solv->featurerules + solv->updaterules);
 121           if (r->d >= 0)
 122             return;
 123         }
 124       solver_enablerule(solv, solv->rules + v);
 125       if (v >= solv->updaterules && v < solv->updaterules_end)
 126         {
 127           /* disable feature rule when enabling update rule */
 128           r = solv->rules + (v - solv->updaterules + solv->featurerules);
 129           if (r->p)
 130             solver_disablerule(solv, r);
 131         }
 132       return;
 133     }
 134   v = -(v + 1);
 135   jp = solv->ruletojob.elements;
 136   for (i = solv->jobrules, r = solv->rules + i; i < solv->jobrules_end; i++, r++, jp++)
 137     if (*jp == v)
 138       solver_enablerule(solv, r);
 139 }
 140
 141
 142 /*-------------------------------------------------------------------
 143  * enable weak rules
 144  *
 145  * Reenable all disabled weak rules (marked in weakrulemap)
 146  *
 147  */
 148
 149 static void
 150 enableweakrules(Solver *solv)
 151 {
 152   int i;
 153   Rule *r;
 154
 155   if (!solv->weakrulemap.size)
 156     return;
 157   for (i = 1, r = solv->rules + i; i < solv->learntrules; i++, r++)
 158     {
 159       if (r->d >= 0) /* already enabled? */
 160         continue;
 161       if (!MAPTST(&solv->weakrulemap, i))
 162         continue;
 163       solver_enablerule(solv, r);
 164     }
 165   /* make sure broken orphan rules stay disabled */
 166   if (solv->brokenorphanrules)
 167     for (i = 0; i < solv->brokenorphanrules->count; i++)
 168       solver_disablerule(solv, solv->rules + solv->brokenorphanrules->elements[i]);
 169 }
 170
 171
 172 /*-------------------------------------------------------------------
 173  *
 174  * refine_suggestion
 175  *
 176  * at this point, all rules that led to conflicts are disabled.
 177  * we re-enable all rules of a problem set but rule "sug", then
 178  * continue to disable more rules until there as again a solution.
 179  */
 180
 181 /* FIXME: think about conflicting assertions */
 182
 183 static void
 184 refine_suggestion(Solver *solv, Id *problem, Id sug, Queue *refined, int essentialok)
 185 {
 186   Pool *pool = solv->pool;
 187   int i, j;
 188   Id v;
 189   Queue disabled;
 190   int disabledcnt;
 191
 192   IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
 193     {
 194       POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "refine_suggestion start\n");
 195       for (i = 0; problem[i]; i++)
 196         {
 197           if (problem[i] == sug)
 198             POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "=> ");
 199           solver_printproblem(solv, problem[i]);
 200         }
 201     }
 202   queue_empty(refined);
 203   if (!essentialok && sug < 0 && (solv->job.elements[-sug - 1] & SOLVER_ESSENTIAL) != 0)
 204     return;
 205   queue_init(&disabled);
 206   queue_push(refined, sug);
 207
 208   /* re-enable all problem rules with the exception of "sug"(gestion) */
 209   solver_reset(solv);
 210
 211   for (i = 0; problem[i]; i++)
 212     if (problem[i] != sug)
 213       solver_enableproblem(solv, problem[i]);
 214
 215   if (sug < 0)
 216     solver_reenablepolicyrules(solv, -sug);
 217   else if (sug >= solv->updaterules && sug < solv->updaterules_end)
 218     {
 219       /* enable feature rule */
 220       Rule *r = solv->rules + solv->featurerules + (sug - solv->updaterules);
 221       if (r->p)
 222         solver_enablerule(solv, r);
 223     }
 224
 225   enableweakrules(solv);
 226
 227   for (;;)
 228     {
 229       int njob, nfeature, nupdate, pass;
 230       queue_empty(&solv->problems);
 231       solver_reset(solv);
 232       solver_run_sat(solv, 0, 0);
 233
 234       if (!solv->problems.count)
 235         {
 236           POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "no more problems!\n");
 237           break;                /* great, no more problems */
 238         }
 239       disabledcnt = disabled.count;
 240       /* start with 1 to skip over proof index */
 241       njob = nfeature = nupdate = 0;
 242       for (pass = 0; pass < 2; pass++)
 243         {
 244           for (i = 1; i < solv->problems.count - 1; i++)
 245             {
 246               /* ignore solutions in refined */
 247               v = solv->problems.elements[i];
 248               if (v == 0)
 249                 break;  /* end of problem reached */
 250               if (sug != v)
 251                 {
 252                   /* check if v is in the given problems list
 253                    * we allow disabling all problem rules *after* sug in
 254                    * pass 2, to prevent getting the same solution twice */
 255                   for (j = 0; problem[j]; j++)
 256                     if (problem[j] == v || (pass && problem[j] == sug))
 257                       break;
 258                   if (problem[j] == v)
 259                     continue;
 260                 }
 261               if (v >= solv->featurerules && v < solv->featurerules_end)
 262                 nfeature++;
 263               else if (v > 0)
 264                 nupdate++;
 265               else
 266                 {
 267                   if (!essentialok && (solv->job.elements[-v - 1] & SOLVER_ESSENTIAL) != 0)
 268                     continue;   /* not that one! */
 269                   njob++;
 270                 }
 271               queue_push(&disabled, v);
 272             }
 273           if (disabled.count != disabledcnt)
 274             break;
 275         }
 276       if (disabled.count == disabledcnt)
 277         {
 278           /* no solution found, this was an invalid suggestion! */
 279           POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "no solution found!\n");
 280           refined->count = 0;
 281           break;
 282         }
 283       if (!njob && nupdate && nfeature)
 284         {
 285           /* got only update rules, filter out feature rules */
 286           POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "throwing away feature rules\n");
 287           for (i = j = disabledcnt; i < disabled.count; i++)
 288             {
 289               v = disabled.elements[i];
 290               if (v < solv->featurerules || v >= solv->featurerules_end)
 291                 disabled.elements[j++] = v;
 292             }
 293           disabled.count = j;
 294           nfeature = 0;
 295         }
 296       if (disabled.count == disabledcnt + 1)
 297         {
 298           /* just one suggestion, add it to refined list */
 299           v = disabled.elements[disabledcnt];
 300           if (!nfeature && v != sug)
 301             queue_push(refined, v);     /* do not record feature rules */
 302           solver_disableproblem(solv, v);
 303           if (v >= solv->updaterules && v < solv->updaterules_end)
 304             {
 305               Rule *r = solv->rules + (v - solv->updaterules + solv->featurerules);
 306               if (r->p)
 307                 solver_enablerule(solv, r);     /* enable corresponding feature rule */
 308             }
 309           if (v < 0)
 310             solver_reenablepolicyrules(solv, -v);
 311         }
 312       else
 313         {
 314           /* more than one solution, disable all */
 315           /* do not push anything on refine list, as we do not know which solution to choose */
 316           /* thus, the user will get another problem if he selects this solution, where he
 317            * can choose the right one */
 318           IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
 319             {
 320               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "more than one solution found:\n");
 321               for (i = disabledcnt; i < disabled.count; i++)
 322                 solver_printproblem(solv, disabled.elements[i]);
 323             }
 324           for (i = disabledcnt; i < disabled.count; i++)
 325             {
 326               v = disabled.elements[i];
 327               solver_disableproblem(solv, v);
 328               if (v >= solv->updaterules && v < solv->updaterules_end)
 329                 {
 330                   Rule *r = solv->rules + (v - solv->updaterules + solv->featurerules);
 331                   if (r->p)
 332                     solver_enablerule(solv, r);
 333                 }
 334             }
 335         }
 336     }
 337   /* all done, get us back into the same state as before */
 338   /* enable refined rules again */
 339   for (i = 0; i < disabled.count; i++)
 340     solver_enableproblem(solv, disabled.elements[i]);
 341   queue_free(&disabled);
 342   /* reset policy rules */
 343   for (i = 0; problem[i]; i++)
 344     solver_enableproblem(solv, problem[i]);
 345   solver_disablepolicyrules(solv);
 346   /* disable problem rules again */
 347   for (i = 0; problem[i]; i++)
 348     solver_disableproblem(solv, problem[i]);
 349   POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "refine_suggestion end\n");
 350 }
 351
 352
 353 /*-------------------------------------------------------------------
 354  * sorting helper for problems
 355  *
 356  * bring update rules before job rules
 357  * make essential job rules last
 358  */
 359
 360 static int
 361 problems_sortcmp(const void *ap, const void *bp, void *dp)
 362 {
 363   Queue *job = dp;
 364   Id a = *(Id *)ap, b = *(Id *)bp;
 365   if (a < 0 && b > 0)
 366     return 1;
 367   if (a > 0 && b < 0)
 368     return -1;
 369   if (a < 0 && b < 0)
 370     {
 371       int af = job->elements[-a - 1] & SOLVER_ESSENTIAL;
 372       int bf = job->elements[-b - 1] & SOLVER_ESSENTIAL;
 373       int x = af - bf;
 374       if (x)
 375         return x;
 376     }
 377   return a - b;
 378 }
 379
 380 /*
 381  * convert a solution rule into a job modifier
 382  */
 383 static void
 384 convertsolution(Solver *solv, Id why, Queue *solutionq)
 385 {
 386   Pool *pool = solv->pool;
 387   if (why < 0)
 388     {
 389       why = -why;
 390       if (why < solv->pooljobcnt)
 391         {
 392           queue_push(solutionq, SOLVER_SOLUTION_POOLJOB);
 393           queue_push(solutionq, why);
 394         }
 395       else
 396         {
 397           queue_push(solutionq, SOLVER_SOLUTION_JOB);
 398           queue_push(solutionq, why - solv->pooljobcnt);
 399         }
 400       return;
 401     }
 402   if (why >= solv->infarchrules && why < solv->infarchrules_end)
 403     {
 404       Id p, name;
 405       /* infarch rule, find replacement */
 406       assert(solv->rules[why].p < 0);
 407       name = pool->solvables[-solv->rules[why].p].name;
 408       while (why > solv->infarchrules && pool->solvables[-solv->rules[why - 1].p].name == name)
 409         why--;
 410       p = 0;
 411       for (; why < solv->infarchrules_end && pool->solvables[-solv->rules[why].p].name == name; why++)
 412         if (solv->decisionmap[-solv->rules[why].p] > 0)
 413           {
 414             p = -solv->rules[why].p;
 415             break;
 416           }
 417       if (!p)
 418         return;         /* false alarm */
 419       queue_push(solutionq, SOLVER_SOLUTION_INFARCH);
 420       queue_push(solutionq, p);
 421       return;
 422     }
 423   if (why >= solv->duprules && why < solv->duprules_end)
 424     {
 425       Id p, name;
 426       /* dist upgrade rule, find replacement */
 427       assert(solv->rules[why].p < 0);
 428       name = pool->solvables[-solv->rules[why].p].name;
 429       while (why > solv->duprules && pool->solvables[-solv->rules[why - 1].p].name == name)
 430         why--;
 431       p = 0;
 432       for (; why < solv->duprules_end && pool->solvables[-solv->rules[why].p].name == name; why++)
 433         if (solv->decisionmap[-solv->rules[why].p] > 0)
 434           {
 435             p = -solv->rules[why].p;
 436             break;
 437           }
 438       if (!p)
 439         return;         /* false alarm */
 440       queue_push(solutionq, SOLVER_SOLUTION_DISTUPGRADE);
 441       queue_push(solutionq, p);
 442       return;
 443     }
 444   if (why >= solv->updaterules && why < solv->updaterules_end)
 445     {
 446       /* update rule, find replacement package */
 447       Id p, pp, rp = 0;
 448       Rule *rr;
 449
 450       /* check if this is a false positive, i.e. the update rule is fulfilled */
 451       rr = solv->rules + why;
 452       FOR_RULELITERALS(p, pp, rr)
 453         if (p > 0 && solv->decisionmap[p] > 0)
 454           return;       /* false alarm */
 455
 456       p = solv->installed->start + (why - solv->updaterules);
 457       if (solv->decisionmap[p] > 0)
 458         return;         /* false alarm, turned out we can keep the package */
 459       rr = solv->rules + solv->featurerules + (why - solv->updaterules);
 460       if (!rr->p)
 461         rr = solv->rules + why;
 462       if (rr->w2)
 463         {
 464           int mvrp = 0;         /* multi-version replacement */
 465           FOR_RULELITERALS(rp, pp, rr)
 466             {
 467               if (rp > 0 && solv->decisionmap[rp] > 0 && pool->solvables[rp].repo != solv->installed)
 468                 {
 469                   mvrp = rp;
 470                   if (!(solv->multiversion.size && MAPTST(&solv->multiversion, rp)))
 471                     break;
 472                 }
 473             }
 474           if (!rp && mvrp)
 475             {
 476               /* found only multi-version replacements */
 477               /* have to split solution into two parts */
 478               queue_push(solutionq, p);
 479               queue_push(solutionq, mvrp);
 480             }
 481         }
 482       queue_push(solutionq, p);
 483       queue_push(solutionq, rp);
 484       return;
 485     }
 486   if (why >= solv->bestrules && why < solv->bestrules_end)
 487     {
 488       int mvrp;
 489       Id p, pp, rp = 0;
 490       Rule *rr;
 491       /* check false positive */
 492       rr = solv->rules + why;
 493       FOR_RULELITERALS(p, pp, rr)
 494         if (p > 0 && solv->decisionmap[p] > 0)
 495           return;       /* false alarm */
 496       /* check update/feature rule */
 497       p = solv->bestrules_pkg[why - solv->bestrules];
 498       if (p < 0)
 499         {
 500           /* install job */
 501           queue_push(solutionq, 0);
 502           queue_push(solutionq, solv->ruletojob.elements[-p - solv->jobrules] + 1);
 503           return;
 504         }
 505       if (solv->decisionmap[p] > 0)
 506         {
 507           /* disable best rule by keeping the old package */
 508           queue_push(solutionq, SOLVER_SOLUTION_BEST);
 509           queue_push(solutionq, p);
 510           return;
 511         }
 512       rr = solv->rules + solv->featurerules + (p - solv->installed->start);
 513       if (!rr->p)
 514         rr = solv->rules + solv->updaterules + (p - solv->installed->start);
 515       mvrp = 0;         /* multi-version replacement */
 516       FOR_RULELITERALS(rp, pp, rr)
 517         if (rp > 0 && solv->decisionmap[rp] > 0 && pool->solvables[rp].repo != solv->installed)
 518           {
 519             mvrp = rp;
 520             if (!(solv->multiversion.size && MAPTST(&solv->multiversion, rp)))
 521               break;
 522           }
 523       if (!rp && mvrp)
 524         {
 525           queue_push(solutionq, SOLVER_SOLUTION_BEST);  /* split, see above */
 526           queue_push(solutionq, mvrp);
 527           queue_push(solutionq, p);
 528           queue_push(solutionq, 0);
 529           return;
 530         }
 531       if (rp)
 532         {
 533           queue_push(solutionq, SOLVER_SOLUTION_BEST);
 534           queue_push(solutionq, rp);
 535         }
 536       return;
 537     }
 538 }
 539
 540 /*
 541  * convert problem data into a form usable for refining.
 542  * Returns the number of problems.
 543  */
 544 int
 545 solver_prepare_solutions(Solver *solv)
 546 {
 547   int i, j = 1, idx;
 548
 549   if (!solv->problems.count)
 550     return 0;
 551   queue_empty(&solv->solutions);
 552   queue_push(&solv->solutions, 0);      /* dummy so idx is always nonzero */
 553   idx = solv->solutions.count;
 554   queue_push(&solv->solutions, -1);     /* unrefined */
 555   /* proofidx stays in position, thus we start with 1 */
 556   for (i = 1; i < solv->problems.count; i++)
 557     {
 558       Id p = solv->problems.elements[i];
 559       queue_push(&solv->solutions, p);
 560       if (p)
 561         continue;
 562       /* end of problem reached */
 563       solv->problems.elements[j++] = idx;
 564       if (i + 1 >= solv->problems.count)
 565         break;
 566       /* start another problem */
 567       solv->problems.elements[j++] = solv->problems.elements[++i];  /* copy proofidx */
 568       idx = solv->solutions.count;
 569       queue_push(&solv->solutions, -1); /* unrefined */
 570     }
 571   solv->problems.count = j;
 572   return j / 2;
 573 }
 574
 575 /*
 576  * refine the simple solution rule list provided by
 577  * the solver into multiple lists of job modifiers.
 578  */
 579 static void
 580 create_solutions(Solver *solv, int probnr, int solidx)
 581 {
 582   Pool *pool = solv->pool;
 583   Queue redoq;
 584   Queue problem, solution, problems_save, branches_save, decisionq_reason_save;
 585   int i, j, nsol;
 586   int essentialok;
 587   unsigned int now;
 588   int oldmistakes = solv->cleandeps_mistakes ? solv->cleandeps_mistakes->count : 0;
 589   Id extraflags = -1;
 590
 591   now = solv_timems(0);
 592   queue_init(&redoq);
 593   /* save decisionq, decisionq_why, decisionmap, and decisioncnt */
 594   for (i = 0; i < solv->decisionq.count; i++)
 595     {
 596       Id p = solv->decisionq.elements[i];
 597       queue_push(&redoq, p);
 598       queue_push(&redoq, solv->decisionq_why.elements[i]);
 599       queue_push(&redoq, solv->decisionmap[p > 0 ? p : -p]);
 600     }
 601
 602   /* save problems queue */
 603   problems_save = solv->problems;
 604   memset(&solv->problems, 0, sizeof(solv->problems));
 605
 606   /* save branches queue */
 607   branches_save = solv->problems;
 608   memset(&solv->branches, 0, sizeof(solv->branches));
 609
 610   /* save decisionq_reason */
 611   decisionq_reason_save = solv->decisionq_reason;
 612   memset(&solv->decisionq_reason, 0, sizeof(solv->decisionq_reason));
 613
 614   /* extract problem from queue */
 615   queue_init(&problem);
 616   for (i = solidx + 1; i < solv->solutions.count; i++)
 617     {
 618       Id v = solv->solutions.elements[i];
 619       if (!v)
 620         break;
 621       queue_push(&problem, v);
 622       if (v < 0)
 623         extraflags &= solv->job.elements[-v - 1];
 624     }
 625   if (extraflags == -1)
 626     extraflags = 0;
 627   if (problem.count > 1)
 628     solv_sort(problem.elements, problem.count, sizeof(Id), problems_sortcmp, &solv->job);
 629   queue_push(&problem, 0);      /* mark end for refine_suggestion */
 630   problem.count--;
 631 #if 0
 632   for (i = 0; i < problem.count; i++)
 633     printf("PP %d %d\n", i, problem.elements[i]);
 634 #endif
 635
 636   /* refine each solution element */
 637   nsol = 0;
 638   essentialok = 0;
 639   queue_init(&solution);
 640   for (i = 0; i < problem.count; i++)
 641     {
 642       int solstart = solv->solutions.count;
 643       refine_suggestion(solv, problem.elements, problem.elements[i], &solution, essentialok);
 644       queue_push(&solv->solutions, 0);  /* reserve room for number of elements */
 645       for (j = 0; j < solution.count; j++)
 646         convertsolution(solv, solution.elements[j], &solv->solutions);
 647       if (solv->solutions.count == solstart + 1)
 648         {
 649           solv->solutions.count--;      /* this one did not work out */
 650           if (nsol || i + 1 < problem.count)
 651             continue;                   /* got one or still hope */
 652           if (!essentialok)
 653             {
 654               /* nothing found, start over */
 655               POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "nothing found, re-run with essentialok = 1\n");
 656               essentialok = 1;
 657               i = -1;
 658               continue;
 659             }
 660           /* this is bad, we found no solution */
 661           /* for now just offer a rule */
 662           POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "nothing found, already did essentialok, fake it\n");
 663           queue_push(&solv->solutions, 0);
 664           for (j = 0; j < problem.count; j++)
 665             {
 666               convertsolution(solv, problem.elements[j], &solv->solutions);
 667               if (solv->solutions.count > solstart + 1)
 668                 break;
 669             }
 670           if (solv->solutions.count == solstart + 1)
 671             {
 672               solv->solutions.count--;
 673               continue;         /* sorry */
 674             }
 675         }
 676       /* patch in number of solution elements */
 677       solv->solutions.elements[solstart] = (solv->solutions.count - (solstart + 1)) / 2;
 678       queue_push(&solv->solutions, 0);  /* add end marker */
 679       queue_push(&solv->solutions, 0);  /* add end marker */
 680       queue_push(&solv->solutions, problem.elements[i]);        /* just for bookkeeping */
 681       queue_push(&solv->solutions, extraflags & SOLVER_CLEANDEPS);      /* our extraflags */
 682       solv->solutions.elements[solidx + 1 + nsol++] = solstart;
 683     }
 684   solv->solutions.elements[solidx + 1 + nsol] = 0;      /* end marker */
 685   solv->solutions.elements[solidx] = nsol;
 686   queue_free(&problem);
 687   queue_free(&solution);
 688
 689   /* restore decisions */
 690   memset(solv->decisionmap, 0, pool->nsolvables * sizeof(Id));
 691   queue_empty(&solv->decisionq);
 692   queue_empty(&solv->decisionq_why);
 693   for (i = 0; i < redoq.count; i += 3)
 694     {
 695       Id p = redoq.elements[i];
 696       queue_push(&solv->decisionq, p);
 697       queue_push(&solv->decisionq_why, redoq.elements[i + 1]);
 698       solv->decisionmap[p > 0 ? p : -p] = redoq.elements[i + 2];
 699     }
 700   queue_free(&redoq);
 701
 702   /* restore decision reasons */
 703   queue_free(&solv->decisionq_reason);
 704   solv->decisionq_reason = decisionq_reason_save;
 705
 706   /* restore problems */
 707   queue_free(&solv->problems);
 708   solv->problems = problems_save;
 709
 710   /* restore branches */
 711   queue_free(&solv->branches);
 712   solv->branches = branches_save;
 713
 714   if (solv->cleandeps_mistakes)
 715     {
 716       if (oldmistakes)
 717         queue_truncate(solv->cleandeps_mistakes, oldmistakes);
 718       else
 719         {
 720           queue_free(solv->cleandeps_mistakes);
 721           solv->cleandeps_mistakes = solv_free(solv->cleandeps_mistakes);
 722         }
 723     }
 724
 725   POOL_DEBUG(SOLV_DEBUG_STATS, "create_solutions for problem #%d took %d ms\n", probnr, solv_timems(now));
 726 }
 727
 728
 729 /**************************************************************************/
 730
 731 unsigned int
 732 solver_problem_count(Solver *solv)
 733 {
 734   return solv->problems.count / 2;
 735 }
 736
 737 Id
 738 solver_next_problem(Solver *solv, Id problem)
 739 {
 740   if (!problem)
 741     return solv->problems.count ? 1 : 0;
 742   return (problem + 1) * 2 - 1 < solv->problems.count ? problem + 1 : 0;
 743 }
 744
 745 unsigned int
 746 solver_solution_count(Solver *solv, Id problem)
 747 {
 748   Id solidx = solv->problems.elements[problem * 2 - 1];
 749   if (solv->solutions.elements[solidx] < 0)
 750     create_solutions(solv, problem, solidx);
 751   return solv->solutions.elements[solidx];
 752 }
 753
 754 Id
 755 solver_next_solution(Solver *solv, Id problem, Id solution)
 756 {
 757   Id solidx = solv->problems.elements[problem * 2 - 1];
 758   if (solv->solutions.elements[solidx] < 0)
 759     create_solutions(solv, problem, solidx);
 760   return solv->solutions.elements[solidx + solution + 1] ? solution + 1 : 0;
 761 }
 762
 763 unsigned int
 764 solver_solutionelement_count(Solver *solv, Id problem, Id solution)
 765 {
 766   Id solidx = solv->problems.elements[problem * 2 - 1];
 767   solidx = solv->solutions.elements[solidx + solution];
 768   return solv->solutions.elements[solidx];
 769 }
 770
 771 Id
 772 solver_solutionelement_internalid(Solver *solv, Id problem, Id solution)
 773 {
 774   Id solidx = solv->problems.elements[problem * 2 - 1];
 775   solidx = solv->solutions.elements[solidx + solution];
 776   return solv->solutions.elements[solidx + 2 * solv->solutions.elements[solidx] + 3];
 777 }
 778
 779 Id
 780 solver_solutionelement_extrajobflags(Solver *solv, Id problem, Id solution)
 781 {
 782   Id solidx = solv->problems.elements[problem * 2 - 1];
 783   solidx = solv->solutions.elements[solidx + solution];
 784   return solv->solutions.elements[solidx + 2 * solv->solutions.elements[solidx] + 4];
 785 }
 786
 787
 788 /*
 789  *  return the next item of the proposed solution
 790  *  here are the possibilities for p / rp and what
 791  *  the solver expects the application to do:
 792  *    p                             rp
 793  *  -------------------------------------------------------
 794  *    SOLVER_SOLUTION_INFARCH       pkgid
 795  *    -> add (SOLVER_INSTALL|SOLVER_SOLVABLE, rp) to the job
 796  *    SOLVER_SOLUTION_DISTUPGRADE   pkgid
 797  *    -> add (SOLVER_INSTALL|SOLVER_SOLVABLE, rp) to the job
 798  *    SOLVER_SOLUTION_BEST          pkgid
 799  *    -> add (SOLVER_INSTALL|SOLVER_SOLVABLE, rp) to the job
 800  *    SOLVER_SOLUTION_JOB           jobidx
 801  *    -> remove job (jobidx - 1, jobidx) from job queue
 802  *    SOLVER_SOLUTION_POOLJOB       jobidx
 803  *    -> remove job (jobidx - 1, jobidx) from pool job queue
 804  *    pkgid (> 0)                   0
 805  *    -> add (SOLVER_ERASE|SOLVER_SOLVABLE, p) to the job
 806  *    pkgid (> 0)                   pkgid (> 0)
 807  *    -> add (SOLVER_INSTALL|SOLVER_SOLVABLE, rp) to the job
 808  *       (this will replace package p)
 809  *
 810  * Thus, the solver will either ask the application to remove
 811  * a specific job from the job queue, or ask to add an install/erase
 812  * job to it.
 813  *
 814  */
 815
 816 Id
 817 solver_next_solutionelement(Solver *solv, Id problem, Id solution, Id element, Id *p, Id *rp)
 818 {
 819   Id solidx = solv->problems.elements[problem * 2 - 1];
 820   solidx = solv->solutions.elements[solidx + solution];
 821   if (!solidx)
 822     return 0;
 823   solidx += 1 + element * 2;
 824   if (!solv->solutions.elements[solidx] && !solv->solutions.elements[solidx + 1])
 825     return 0;
 826   *p = solv->solutions.elements[solidx];
 827   *rp = solv->solutions.elements[solidx + 1];
 828   return element + 1;
 829 }
 830
 831 void
 832 solver_take_solutionelement(Solver *solv, Id p, Id rp, Id extrajobflags, Queue *job)
 833 {
 834   int i;
 835
 836   if (p == SOLVER_SOLUTION_POOLJOB)
 837     {
 838       solv->pool->pooljobs.elements[rp - 1] = SOLVER_NOOP;
 839       solv->pool->pooljobs.elements[rp] = 0;
 840       return;
 841     }
 842   if (p == SOLVER_SOLUTION_JOB)
 843     {
 844       job->elements[rp - 1] = SOLVER_NOOP;
 845       job->elements[rp] = 0;
 846       return;
 847     }
 848   if (rp <= 0 && p <= 0)
 849     return;     /* just in case */
 850   if (rp > 0)
 851     p = SOLVER_INSTALL|SOLVER_SOLVABLE|SOLVER_NOTBYUSER|extrajobflags;
 852   else
 853     {
 854       rp = p;
 855       p = SOLVER_ERASE|SOLVER_SOLVABLE|extrajobflags;
 856     }
 857   for (i = 0; i < job->count; i += 2)
 858     if (job->elements[i] == p && job->elements[i + 1] == rp)
 859       return;
 860   queue_push2(job, p, rp);
 861 }
 862
 863 void
 864 solver_take_solution(Solver *solv, Id problem, Id solution, Queue *job)
 865 {
 866   Id p, rp, element = 0;
 867   Id extrajobflags = solver_solutionelement_extrajobflags(solv, problem, solution);
 868   while ((element = solver_next_solutionelement(solv, problem, solution, element, &p, &rp)) != 0)
 869     solver_take_solutionelement(solv, p, rp, extrajobflags, job);
 870 }
 871
 872
 873 /*-------------------------------------------------------------------
 874  *
 875  * find problem rule
 876  */
 877
 878 static void
 879 findproblemrule_internal(Solver *solv, Id idx, Id *reqrp, Id *conrp, Id *sysrp, Id *jobrp, Map *rseen)
 880 {
 881   Id rid, d;
 882   Id lreqr, lconr, lsysr, ljobr;
 883   Rule *r;
 884   Id jobassert = 0;
 885   int i, reqset = 0;    /* 0: unset, 1: installed, 2: jobassert, 3: assert */
 886   int conset = 0;       /* 0: unset, 1: installed */
 887
 888   /* find us a jobassert rule */
 889   for (i = idx; (rid = solv->learnt_pool.elements[i]) != 0; i++)
 890     {
 891       if (rid < solv->jobrules || rid >= solv->jobrules_end)
 892         continue;
 893       r = solv->rules + rid;
 894       d = r->d < 0 ? -r->d - 1 : r->d;
 895       if (!d && r->w2 == 0 && r->p > 0)
 896         {
 897           jobassert = r->p;
 898           break;
 899         }
 900     }
 901
 902   /* the problem rules are somewhat ordered from "near to the problem" to
 903    * "near to the job" */
 904   lreqr = lconr = lsysr = ljobr = 0;
 905   while ((rid = solv->learnt_pool.elements[idx++]) != 0)
 906     {
 907       assert(rid > 0);
 908       if (rid >= solv->learntrules)
 909         {
 910           if (MAPTST(rseen, rid - solv->learntrules))
 911             continue;
 912           MAPSET(rseen, rid - solv->learntrules);
 913           findproblemrule_internal(solv, solv->learnt_why.elements[rid - solv->learntrules], &lreqr, &lconr, &lsysr, &ljobr, rseen);
 914         }
 915       else if ((rid >= solv->jobrules && rid < solv->jobrules_end) || (rid >= solv->infarchrules && rid < solv->infarchrules_end) || (rid >= solv->duprules && rid < solv->duprules_end) || (rid >= solv->bestrules && rid < solv->bestrules_end) || (rid >= solv->yumobsrules && rid <= solv->yumobsrules_end))
 916         {
 917           if (!*jobrp)
 918             *jobrp = rid;
 919         }
 920       else if (rid >= solv->updaterules && rid < solv->updaterules_end)
 921         {
 922           if (!*sysrp)
 923             *sysrp = rid;
 924         }
 925       else
 926         {
 927           assert(rid < solv->pkgrules_end);
 928           r = solv->rules + rid;
 929           d = r->d < 0 ? -r->d - 1 : r->d;
 930           if (!d && r->w2 < 0)
 931             {
 932               /* prefer conflicts of installed packages */
 933               if (solv->installed && !conset)
 934                 {
 935                   if (r->p < 0 && (solv->pool->solvables[-r->p].repo == solv->installed ||
 936                                   solv->pool->solvables[-r->w2].repo == solv->installed))
 937                     {
 938                       *conrp = rid;
 939                       conset = 1;
 940                     }
 941                 }
 942               if (!*conrp)
 943                 *conrp = rid;
 944             }
 945           else
 946             {
 947               if (!d && r->w2 == 0 && reqset < 3)
 948                 {
 949                   if (*reqrp > 0 && r->p < -1)
 950                     {
 951                       Pool *pool = solv->pool;
 952                       Id op = -solv->rules[*reqrp].p;
 953                       if (op > 1 && pool->solvables[op].arch != pool->solvables[-r->p].arch &&
 954                           pool->solvables[op].arch != pool->noarchid &&
 955                           pool->solvables[-r->p].arch != pool->noarchid)
 956                         continue;       /* different arch, skip */
 957                     }
 958                   /* prefer assertions */
 959                   *reqrp = rid;
 960                   reqset = 3;
 961                 }
 962               else if (jobassert && r->p == -jobassert)
 963                 {
 964                   /* prefer rules of job assertions */
 965                   *reqrp = rid;
 966                   reqset = 2;
 967                 }
 968               else if (solv->installed && r->p < 0 && solv->pool->solvables[-r->p].repo == solv->installed && reqset <= 1)
 969                 {
 970                   /* prefer rules of job installed package so that the user doesn't get confused by strange packages */
 971                   *reqrp = rid;
 972                   reqset = 1;
 973                 }
 974               else if (!*reqrp)
 975                 *reqrp = rid;
 976             }
 977         }
 978     }
 979   if (!*reqrp && lreqr)
 980     *reqrp = lreqr;
 981   if (!*conrp && lconr)
 982     *conrp = lconr;
 983   if (!*jobrp && ljobr)
 984     *jobrp = ljobr;
 985   if (!*sysrp && lsysr)
 986     *sysrp = lsysr;
 987 }
 988
 989 /*
 990  * find problem rule
 991  *
 992  * search for a rule that describes the problem to the
 993  * user. Actually a pretty hopeless task that may leave the user
 994  * puzzled. To get all of the needed information use
 995  * solver_findallproblemrules() instead.
 996  */
 997
 998 Id
 999 solver_findproblemrule(Solver *solv, Id problem)
1000 {
1001   Id reqr, conr, sysr, jobr;
1002   Id idx = solv->problems.elements[2 * problem - 2];
1003   Map rseen;
1004   reqr = conr = sysr = jobr = 0;
1005   map_init(&rseen, solv->learntrules ? solv->nrules - solv->learntrules : 0);
1006   findproblemrule_internal(solv, idx, &reqr, &conr, &sysr, &jobr, &rseen);
1007   map_free(&rseen);
1008   /* check if the request is about a not-installed package requiring a installed
1009    * package conflicting with the non-installed package. In that case return the conflict */
1010   if (reqr && conr && solv->installed && solv->rules[reqr].p < 0 && solv->rules[conr].p < 0 && solv->rules[conr].w2 < 0)
1011     {
1012       Pool *pool = solv->pool;
1013       Solvable *s  = pool->solvables - solv->rules[reqr].p;
1014       Solvable *s1 = pool->solvables - solv->rules[conr].p;
1015       Solvable *s2 = pool->solvables - solv->rules[conr].w2;
1016       Id cp = 0;
1017       if (s == s1 && s2->repo == solv->installed)
1018         cp = -solv->rules[conr].w2;
1019       else if (s == s2 && s1->repo == solv->installed)
1020         cp = -solv->rules[conr].p;
1021       if (cp && s1->name != s2->name && s->repo != solv->installed)
1022         {
1023           Id p, pp;
1024           Rule *r = solv->rules + reqr;
1025           FOR_RULELITERALS(p, pp, r)
1026             if (p == cp)
1027               return conr;
1028         }
1029     }
1030   if (reqr)
1031     return reqr;        /* some requires */
1032   if (conr)
1033     return conr;        /* some conflict */
1034   if (sysr)
1035     return sysr;        /* an update rule */
1036   if (jobr)
1037     return jobr;        /* a user request */
1038   assert(0);
1039   return 0;
1040 }
1041
1042 /*-------------------------------------------------------------------*/
1043
1044 static void
1045 findallproblemrules_internal(Solver *solv, Id idx, Queue *rules, Map *rseen)
1046 {
1047   Id rid;
1048   while ((rid = solv->learnt_pool.elements[idx++]) != 0)
1049     {
1050       if (rid >= solv->learntrules)
1051         {
1052           if (MAPTST(rseen, rid - solv->learntrules))
1053             continue;
1054           MAPSET(rseen, rid - solv->learntrules);
1055           findallproblemrules_internal(solv, solv->learnt_why.elements[rid - solv->learntrules], rules, rseen);
1056           continue;
1057         }
1058       queue_pushunique(rules, rid);
1059     }
1060 }
1061
1062 /*
1063  * find all problem rule
1064  *
1065  * return all rules that lead to the problem. This gives the user
1066  * all of the information to understand the problem, but the result
1067  * can be a large number of rules.
1068  */
1069
1070 void
1071 solver_findallproblemrules(Solver *solv, Id problem, Queue *rules)
1072 {
1073   Map rseen;
1074   queue_empty(rules);
1075   map_init(&rseen, solv->learntrules ? solv->nrules - solv->learntrules : 0);
1076   findallproblemrules_internal(solv, solv->problems.elements[2 * problem - 2], rules, &rseen);
1077   map_free(&rseen);
1078 }
1079
1080 const char *
1081 solver_problemruleinfo2str(Solver *solv, SolverRuleinfo type, Id source, Id target, Id dep)
1082 {
1083   Pool *pool = solv->pool;
1084   char *s;
1085   Solvable *ss;
1086   switch (type)
1087     {
1088     case SOLVER_RULE_DISTUPGRADE:
1089       return pool_tmpjoin(pool, pool_solvid2str(pool, source), " does not belong to a distupgrade repository", 0);
1090     case SOLVER_RULE_INFARCH:
1091       return pool_tmpjoin(pool, pool_solvid2str(pool, source), " has inferior architecture", 0);
1092     case SOLVER_RULE_UPDATE:
1093       return pool_tmpjoin(pool, "problem with installed package ", pool_solvid2str(pool, source), 0);
1094     case SOLVER_RULE_JOB:
1095       return "conflicting requests";
1096     case SOLVER_RULE_JOB_UNSUPPORTED:
1097       return "unsupported request";
1098     case SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP:
1099       return pool_tmpjoin(pool, "nothing provides requested ", pool_dep2str(pool, dep), 0);
1100     case SOLVER_RULE_JOB_UNKNOWN_PACKAGE:
1101       return pool_tmpjoin(pool, "package ", pool_dep2str(pool, dep), " does not exist");
1102     case SOLVER_RULE_JOB_PROVIDED_BY_SYSTEM:
1103       return pool_tmpjoin(pool, pool_dep2str(pool, dep), " is provided by the system", 0);
1104     case SOLVER_RULE_PKG:
1105       return "some dependency problem";
1106     case SOLVER_RULE_BEST:
1107       if (source > 0)
1108         return pool_tmpjoin(pool, "cannot install the best update candidate for package ", pool_solvid2str(pool, source), 0);
1109      return "cannot install the best candidate for the job";
1110     case SOLVER_RULE_PKG_NOT_INSTALLABLE:
1111       ss = pool->solvables + source;
1112       if (pool_disabled_solvable(pool, ss))
1113         return pool_tmpjoin(pool, "package ", pool_solvid2str(pool, source), " is disabled");
1114       if (ss->arch && ss->arch != ARCH_SRC && ss->arch != ARCH_NOSRC &&
1115           pool->id2arch && (ss->arch > pool->lastarch || !pool->id2arch[ss->arch]))
1116         return pool_tmpjoin(pool, "package ", pool_solvid2str(pool, source), " does not have a compatible architecture");
1117       return pool_tmpjoin(pool, "package ", pool_solvid2str(pool, source), " is not installable");
1118     case SOLVER_RULE_PKG_NOTHING_PROVIDES_DEP:
1119       s = pool_tmpjoin(pool, "nothing provides ", pool_dep2str(pool, dep), 0);
1120       return pool_tmpappend(pool, s, " needed by ", pool_solvid2str(pool, source));
1121     case SOLVER_RULE_PKG_SAME_NAME:
1122       s = pool_tmpjoin(pool, "cannot install both ", pool_solvid2str(pool, source), 0);
1123       return pool_tmpappend(pool, s, " and ", pool_solvid2str(pool, target));
1124     case SOLVER_RULE_PKG_CONFLICTS:
1125       s = pool_tmpjoin(pool, "package ", pool_solvid2str(pool, source), 0);
1126       s = pool_tmpappend(pool, s, " conflicts with ", pool_dep2str(pool, dep));
1127       return pool_tmpappend(pool, s, " provided by ", pool_solvid2str(pool, target));
1128     case SOLVER_RULE_PKG_OBSOLETES:
1129       s = pool_tmpjoin(pool, "package ", pool_solvid2str(pool, source), 0);
1130       s = pool_tmpappend(pool, s, " obsoletes ", pool_dep2str(pool, dep));
1131       return pool_tmpappend(pool, s, " provided by ", pool_solvid2str(pool, target));
1132     case SOLVER_RULE_PKG_INSTALLED_OBSOLETES:
1133       s = pool_tmpjoin(pool, "installed package ", pool_solvid2str(pool, source), 0);
1134       s = pool_tmpappend(pool, s, " obsoletes ", pool_dep2str(pool, dep));
1135       return pool_tmpappend(pool, s, " provided by ", pool_solvid2str(pool, target));
1136     case SOLVER_RULE_PKG_IMPLICIT_OBSOLETES:
1137       s = pool_tmpjoin(pool, "package ", pool_solvid2str(pool, source), 0);
1138       s = pool_tmpappend(pool, s, " implicitly obsoletes ", pool_dep2str(pool, dep));
1139       return pool_tmpappend(pool, s, " provided by ", pool_solvid2str(pool, target));
1140     case SOLVER_RULE_PKG_REQUIRES:
1141       s = pool_tmpjoin(pool, "package ", pool_solvid2str(pool, source), " requires ");
1142       return pool_tmpappend(pool, s, pool_dep2str(pool, dep), ", but none of the providers can be installed");
1143     case SOLVER_RULE_PKG_SELF_CONFLICT:
1144       s = pool_tmpjoin(pool, "package ", pool_solvid2str(pool, source), " conflicts with ");
1145       return pool_tmpappend(pool, s, pool_dep2str(pool, dep), " provided by itself");
1146     case SOLVER_RULE_YUMOBS:
1147       s = pool_tmpjoin(pool, "both package ", pool_solvid2str(pool, source), " and ");
1148       s = pool_tmpjoin(pool, s, pool_solvid2str(pool, target), " obsolete ");
1149       return pool_tmpappend(pool, s, pool_dep2str(pool, dep), 0);
1150     default:
1151       return "bad problem rule type";
1152     }
1153 }
1154
1155 /* convenience function */
1156 const char *
1157 solver_problem2str(Solver *solv, Id problem)
1158 {
1159   Id type, source, target, dep;
1160   Id r = solver_findproblemrule(solv, problem);
1161   if (!r)
1162     return "no problem rule?";
1163   type = solver_ruleinfo(solv, r, &source, &target, &dep);
1164   return solver_problemruleinfo2str(solv, type, source, target, dep);
1165 }
1166
1167 const char *
1168 solver_solutionelement2str(Solver *solv, Id p, Id rp)
1169 {
1170   Pool *pool = solv->pool;
1171   if (p == SOLVER_SOLUTION_JOB || p == SOLVER_SOLUTION_POOLJOB)
1172     {
1173       Id how, what;
1174       if (p == SOLVER_SOLUTION_JOB)
1175         rp += solv->pooljobcnt;
1176       how = solv->job.elements[rp - 1];
1177       what = solv->job.elements[rp];
1178       return pool_tmpjoin(pool, "do not ask to ", pool_job2str(pool, how, what, 0), 0);
1179     }
1180   else if (p == SOLVER_SOLUTION_INFARCH)
1181     {
1182       Solvable *s = pool->solvables + rp;
1183       if (solv->installed && s->repo == solv->installed)
1184         return pool_tmpjoin(pool, "keep ", pool_solvable2str(pool, s), " despite the inferior architecture");
1185       else
1186         return pool_tmpjoin(pool, "install ", pool_solvable2str(pool, s), " despite the inferior architecture");
1187     }
1188   else if (p == SOLVER_SOLUTION_DISTUPGRADE)
1189     {
1190       Solvable *s = pool->solvables + rp;
1191       if (solv->installed && s->repo == solv->installed)
1192         return pool_tmpjoin(pool, "keep obsolete ", pool_solvable2str(pool, s), 0);
1193       else
1194         return pool_tmpjoin(pool, "install ", pool_solvable2str(pool, s), " from excluded repository");
1195     }
1196   else if (p == SOLVER_SOLUTION_BEST)
1197     {
1198       Solvable *s = pool->solvables + rp;
1199       if (solv->installed && s->repo == solv->installed)
1200         return pool_tmpjoin(pool, "keep old ", pool_solvable2str(pool, s), 0);
1201       else
1202         return pool_tmpjoin(pool, "install ", pool_solvable2str(pool, s), " despite the old version");
1203     }
1204   else if (p > 0 && rp == 0)
1205     return pool_tmpjoin(pool, "allow deinstallation of ", pool_solvid2str(pool, p), 0);
1206   else if (p > 0 && rp > 0)
1207     {
1208       const char *sp = pool_solvid2str(pool, p);
1209       const char *srp = pool_solvid2str(pool, rp);
1210       const char *str = pool_tmpjoin(pool, "allow replacement of ", sp, 0);
1211       return pool_tmpappend(pool, str, " with ", srp);
1212     }
1213   else
1214     return "bad solution element";
1215 }
1216