src/cleandeps.c

   1 /*
   2  * Copyright (c) 2017, SUSE Inc.
   3  *
   4  * This program is licensed under the BSD license, read LICENSE.BSD
   5  * for further information
   6  */
   7
   8 /*
   9  * cleandeps.c
  10  *
  11  * code to find and erase unneeded packages
  12  */
  13
  14 #include <stdio.h>
  15 #include <stdlib.h>
  16 #include <unistd.h>
  17 #include <string.h>
  18
  19 #include "solver.h"
  20 #include "solverdebug.h"
  21 #include "solver_private.h"
  22 #include "bitmap.h"
  23 #include "pool.h"
  24 #include "util.h"
  25 #include "policy.h"
  26 #include "cplxdeps.h"
  27
  28 #undef CLEANDEPSDEBUG
  29
  30 /*
  31  * This functions collects all packages that are looked at
  32  * when a dependency is checked. We need it to "pin" installed
  33  * packages when removing a supplemented package in createcleandepsmap.
  34  * Here's an not uncommon example:
  35  *   A contains "Supplements: packageand(B, C)"
  36  *   B contains "Requires: A"
  37  * Now if we remove C, the supplements is no longer true,
  38  * thus we also remove A. Without the dep_pkgcheck function, we
  39  * would now also remove B, but this is wrong, as adding back
  40  * C doesn't make the supplements true again. Thus we "pin" B
  41  * when we remove A.
  42  * There's probably a better way to do this, but I haven't come
  43  * up with it yet ;)
  44  */
  45 static void
  46 dep_pkgcheck_slow(Solver *solv, Id dep, Map *m, Queue *q)
  47 {
  48   Pool *pool = solv->pool;
  49   Id p, pp;
  50
  51   if (ISRELDEP(dep))
  52     {
  53       Reldep *rd = GETRELDEP(pool, dep);
  54       if (rd->flags >= 8)
  55         {
  56           if (rd->flags == REL_AND)
  57             {
  58               dep_pkgcheck_slow(solv, rd->name, m, q);
  59               dep_pkgcheck_slow(solv, rd->evr, m, q);
  60               return;
  61             }
  62           if (rd->flags == REL_COND || rd->flags == REL_UNLESS)
  63             {
  64               dep_pkgcheck_slow(solv, rd->name, m, q);
  65               if (ISRELDEP(rd->evr))
  66                 {
  67                   Reldep *rd2 = GETRELDEP(pool, rd->evr);
  68                   if (rd2->flags == REL_ELSE)
  69                     dep_pkgcheck_slow(solv, rd2->evr, m, q);
  70                 }
  71               return;
  72             }
  73           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
  74             return;
  75         }
  76     }
  77   FOR_PROVIDES(p, pp, dep)
  78     if (!m || MAPTST(m, p))
  79       queue_push(q, p);
  80 }
  81
  82 static inline void
  83 dep_pkgcheck(Solver *solv, Id dep, Map *m, Queue *q)
  84 {
  85   Pool *pool = solv->pool;
  86   Id p, pp;
  87
  88   if (!ISSIMPLEDEP(pool, dep))
  89     {
  90       dep_pkgcheck_slow(solv, dep, m, q);
  91       return;
  92     }
  93   FOR_PROVIDES(p, pp, dep)
  94     if (!m || MAPTST(m, p))
  95       queue_push(q, p);
  96 }
  97
  98 static int
  99 check_xsupp(Solver *solv, Queue *depq, Id dep)
 100 {
 101   Pool *pool = solv->pool;
 102   Id p, pp;
 103
 104   if (ISRELDEP(dep))
 105     {
 106       Reldep *rd = GETRELDEP(pool, dep);
 107       if (rd->flags >= 8)
 108         {
 109           if (rd->flags == REL_AND)
 110             {
 111               if (!check_xsupp(solv, depq, rd->name))
 112                 return 0;
 113               return check_xsupp(solv, depq, rd->evr);
 114             }
 115           if (rd->flags == REL_OR)
 116             {
 117               if (check_xsupp(solv, depq, rd->name))
 118                 return 1;
 119               return check_xsupp(solv, depq, rd->evr);
 120             }
 121           if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_SPLITPROVIDES)
 122             return 0;
 123           if (depq && rd->flags == REL_NAMESPACE)
 124             {
 125               int i;
 126               for (i = 0; i < depq->count; i++)
 127                 if (depq->elements[i] == dep || depq->elements[i] == rd->name)
 128                  return 1;
 129             }
 130         }
 131     }
 132   FOR_PROVIDES(p, pp, dep)
 133     if (p == SYSTEMSOLVABLE || pool->solvables[p].repo == solv->installed)
 134       return 1;
 135   return 0;
 136 }
 137
 138 struct trj_data {
 139   Queue *edges;
 140   Id *low;
 141   Id idx;
 142   Id nstack;
 143   Id firstidx;
 144 };
 145
 146 /* Tarjan's SCC algorithm, slightly modifed */
 147 static void
 148 trj_visit(struct trj_data *trj, Id node)
 149 {
 150   Id *low = trj->low;
 151   Queue *edges = trj->edges;
 152   Id nnode, myidx, stackstart;
 153   int i;
 154
 155   low[node] = myidx = trj->idx++;
 156   low[(stackstart = trj->nstack++)] = node;
 157   for (i = edges->elements[node]; (nnode = edges->elements[i]) != 0; i++)
 158     {
 159       Id l = low[nnode];
 160       if (!l)
 161         {
 162           if (!edges->elements[edges->elements[nnode]])
 163             {
 164               trj->idx++;
 165               low[nnode] = -1;
 166               continue;
 167             }
 168           trj_visit(trj, nnode);
 169           l = low[nnode];
 170         }
 171       if (l < 0)
 172         continue;
 173       if (l < trj->firstidx)
 174         {
 175           int k;
 176           for (k = l; low[low[k]] == l; k++)
 177             low[low[k]] = -1;
 178         }
 179       else if (l < low[node])
 180         low[node] = l;
 181     }
 182   if (low[node] == myidx)
 183     {
 184       if (myidx != trj->firstidx)
 185         myidx = -1;
 186       for (i = stackstart; i < trj->nstack; i++)
 187         low[low[i]] = myidx;
 188       trj->nstack = stackstart;
 189     }
 190 }
 191
 192 #ifdef ENABLE_COMPLEX_DEPS
 193 static void
 194 complex_filter_unneeded(Pool *pool, Id ip, Id req, Queue *edges, Map *cleandepsmap, Queue *unneededq)
 195 {
 196   int i, j;
 197   Queue dq;
 198   Id p;
 199
 200   queue_init(&dq);
 201   i = pool_normalize_complex_dep(pool, req, &dq, CPLXDEPS_EXPAND);
 202   if (i == 0 || i == 1)
 203     {
 204       queue_free(&dq);
 205       return;
 206     }
 207   for (i = 0; i < dq.count; i++)
 208     {
 209       for (; (p = dq.elements[i]) != 0; i++)
 210         {
 211           if (p < 0)
 212             {
 213               if (pool->solvables[-p].repo != pool->installed)
 214                 break;
 215               continue;
 216             }
 217           if (p == ip || pool->solvables[p].repo != pool->installed || !MAPTST(cleandepsmap, p - pool->installed->start))
 218             continue;
 219           for (j = 0; j < unneededq->count; j++)
 220             if (p == unneededq->elements[j])
 221               {
 222                 if (edges->elements[edges->count - 1] != j + 1)
 223                   queue_push(edges, j + 1);
 224                 break;
 225               }
 226         }
 227       while (dq.elements[i])
 228         i++;
 229     }
 230   queue_free(&dq);
 231 }
 232 #endif
 233
 234
 235 static void
 236 filter_unneeded(Solver *solv, Queue *unneededq, Map *unneededmap, int justone)
 237 {
 238   Pool *pool = solv->pool;
 239   Repo *installed = solv->installed;
 240   Queue edges;
 241   Id *nrequires;
 242   Map m, installedm;
 243   int i, j, pass, count = unneededq->count;
 244   Id *low;
 245
 246   if (unneededq->count < 2)
 247     return;
 248   map_init(&m, 0);
 249   if (!unneededmap)
 250     {
 251       unneededmap = &m;
 252       map_grow(unneededmap, installed->end - installed->start);
 253       for (i = 0; i < count; i++)
 254         MAPSET(unneededmap, unneededq->elements[i] - installed->start);
 255     }
 256   map_init(&installedm, pool->nsolvables);
 257   for (i = installed->start; i < installed->end; i++)
 258     if (pool->solvables[i].repo == installed)
 259       MAPSET(&installedm, i);
 260
 261   nrequires = solv_calloc(count, sizeof(Id));
 262   queue_init(&edges);
 263   queue_prealloc(&edges, count * 4 + 10);       /* pre-size */
 264
 265   /*
 266    * Go through the solvables in the nodes queue and create edges for
 267    * all requires/recommends/supplements between the nodes.
 268    * The edges are stored in the edges queue, we add 1 to the node
 269    * index so that nodes in the edges queue are != 0 and we can
 270    * terminate the edge list with 0.
 271    * Thus for node element 5, the edges are stored starting at
 272    * edges.elements[6] and are 0-terminated.
 273    */
 274   /* leave first element zero to make things easier */
 275   /* also add trailing zero */
 276   queue_insertn(&edges, 0, 1 + count + 1, 0);
 277
 278   /* first requires and recommends */
 279   for (i = 0; i < count; i++)
 280     {
 281       Solvable *s = pool->solvables + unneededq->elements[i];
 282       int oldcount = edges.count;
 283       edges.elements[i + 1] = oldcount;
 284       for (pass = 0; pass < 2; pass++)
 285         {
 286           unsigned int off = pass == 0 ? s->requires : s->recommends;
 287           Id p, pp, dep, *dp;
 288           if (off)
 289             for (dp = s->repo->idarraydata + off; (dep = *dp) != 0; dp++)
 290               {
 291 #ifdef ENABLE_COMPLEX_DEPS
 292                 if (pool_is_complex_dep(pool, dep))
 293                   {
 294                     complex_filter_unneeded(pool, s - pool->solvables, dep, &edges, unneededmap, unneededq);
 295                     continue;
 296                   }
 297 #endif
 298                 if (justone)
 299                   {
 300                     int count = 0;
 301                     FOR_PROVIDES(p, pp, dep)
 302                       {
 303                         Solvable *sp = pool->solvables + p;
 304                         if (s == sp || sp->repo != installed)
 305                           continue;
 306                         count++;
 307                       }
 308                     if (count != 1)
 309                       continue;
 310                   }
 311                 FOR_PROVIDES(p, pp, dep)
 312                   {
 313                     Solvable *sp = pool->solvables + p;
 314                     if (s == sp || sp->repo != installed || !MAPTST(unneededmap, p - installed->start))
 315                       continue;
 316                     for (j = 0; j < count; j++)
 317                       if (p == unneededq->elements[j])
 318                         {
 319                           if (edges.elements[edges.count - 1] != j + 1)
 320                             queue_push(&edges, j + 1);
 321                         }
 322                   }
 323               }
 324           if (pass == 0)
 325             nrequires[i] = edges.count - oldcount;
 326         }
 327       queue_push(&edges, 0);
 328     }
 329 #if 0
 330   printf("requires + recommends\n");
 331   for (i = 0; i < count; i++)
 332     {
 333       int j;
 334       printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
 335       for (j = edges.elements[i + 1]; edges.elements[j]; j++)
 336         printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
 337     }
 338 #endif
 339
 340   /* then add supplements */
 341   for (i = 0; i < count; i++)
 342     {
 343       Solvable *s = pool->solvables + unneededq->elements[i];
 344       if (s->supplements)
 345         {
 346           Id *dp;
 347           int k;
 348           for (dp = s->repo->idarraydata + s->supplements; *dp; dp++)
 349             if (solver_dep_possible(solv, *dp, &installedm))
 350               {
 351                 Queue iq;
 352                 Id iqbuf[16];
 353                 queue_init_buffer(&iq, iqbuf, sizeof(iqbuf)/sizeof(*iqbuf));
 354                 dep_pkgcheck(solv, *dp, 0, &iq);
 355                 if (justone && iq.count != 1)
 356                   {
 357                     queue_free(&iq);
 358                     continue;
 359                   }
 360                 for (k = 0; k < iq.count; k++)
 361                   {
 362                     Id p = iq.elements[k];
 363                     Solvable *sp = pool->solvables + p;
 364                     if (p == unneededq->elements[i] || sp->repo != installed || !MAPTST(unneededmap, p - installed->start))
 365                       continue;
 366                     for (j = 0; j < count; j++)
 367                       if (p == unneededq->elements[j])
 368                         break;
 369                     /* now add edge from j + 1 to i + 1 */
 370                     queue_insert(&edges, edges.elements[j + 1] + nrequires[j], i + 1);
 371                     /* addapt following edge pointers */
 372                     for (j = j + 2; j < count + 1; j++)
 373                       edges.elements[j]++;
 374                   }
 375                 queue_free(&iq);
 376               }
 377         }
 378     }
 379 #if 0
 380   /* print result */
 381   printf("+ supplements\n");
 382   for (i = 0; i < count; i++)
 383     {
 384       int j;
 385       printf("  %s (%d requires):\n", pool_solvid2str(pool, unneededq->elements[i]), nrequires[i]);
 386       for (j = edges.elements[i + 1]; edges.elements[j]; j++)
 387         printf("    - %s\n", pool_solvid2str(pool, unneededq->elements[edges.elements[j] - 1]));
 388     }
 389 #endif
 390   map_free(&installedm);
 391
 392   /* now run SCC algo two times, first with requires+recommends+supplements,
 393    * then again without the requires. We run it the second time to get rid
 394    * of packages that got dragged in via recommends/supplements */
 395   /*
 396    * low will contain the result of the SCC search.
 397    * it must be of at least size 2 * (count + 1) and
 398    * must be zero initialized.
 399    * The layout is:
 400    *    0  low low ... low stack stack ...stack 0
 401    *            count              count
 402    */
 403   low = solv_calloc(count + 1, 2 * sizeof(Id));
 404   for (pass = 0; pass < 2; pass++)
 405     {
 406       struct trj_data trj;
 407       if (pass)
 408         {
 409           memset(low, 0, (count + 1) * (2 * sizeof(Id)));
 410           for (i = 0; i < count; i++)
 411             {
 412               edges.elements[i + 1] += nrequires[i];
 413               if (!unneededq->elements[i])
 414                 low[i + 1] = -1;        /* ignore this node */
 415             }
 416         }
 417       trj.edges = &edges;
 418       trj.low = low;
 419       trj.idx = count + 1;      /* stack starts here */
 420       for (i = 1; i <= count; i++)
 421         {
 422           if (low[i])
 423             continue;
 424           if (edges.elements[edges.elements[i]])
 425             {
 426               trj.firstidx = trj.nstack = trj.idx;
 427               trj_visit(&trj, i);
 428             }
 429           else
 430             {
 431               Id myidx = trj.idx++;
 432               low[i] = myidx;
 433               low[myidx] = i;
 434             }
 435         }
 436       /* prune packages */
 437       for (i = 0; i < count; i++)
 438         if (low[i + 1] <= 0)
 439           unneededq->elements[i] = 0;
 440     }
 441   solv_free(low);
 442   solv_free(nrequires);
 443   queue_free(&edges);
 444
 445   /* finally remove all pruned entries from unneededq */
 446   for (i = j = 0; i < count; i++)
 447     if (unneededq->elements[i])
 448       unneededq->elements[j++] = unneededq->elements[i];
 449   queue_truncate(unneededq, j);
 450   map_free(&m);
 451 }
 452
 453
 454 #ifdef ENABLE_COMPLEX_DEPS
 455 static void
 456 complex_cleandeps_remove(Pool *pool, Id ip, Id req, Map *im, Map *installedm, Queue *iq)
 457 {
 458   int i;
 459   Queue dq;
 460   Id p;
 461
 462   queue_init(&dq);
 463   i = pool_normalize_complex_dep(pool, req, &dq, CPLXDEPS_EXPAND);
 464   if (i == 0 || i == 1)
 465     {
 466       queue_free(&dq);
 467       return;
 468     }
 469   for (i = 0; i < dq.count; i++)
 470     {
 471       for (; (p = dq.elements[i]) != 0; i++)
 472         {
 473           if (p < 0)
 474             {
 475               if (!MAPTST(installedm, -p))
 476                 break;
 477               continue;
 478             }
 479           if (p != SYSTEMSOLVABLE && MAPTST(im, p))
 480             {
 481 #ifdef CLEANDEPSDEBUG
 482               printf("%s requires/recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
 483 #endif
 484               queue_push(iq, p);
 485             }
 486         }
 487       while (dq.elements[i])
 488         i++;
 489     }
 490   queue_free(&dq);
 491 }
 492
 493 static void
 494 complex_cleandeps_addback(Pool *pool, Id ip, Id req, Map *im, Map *installedm, Queue *iq, Map *userinstalled)
 495 {
 496   int i, blk;
 497   Queue dq;
 498   Id p;
 499
 500   queue_init(&dq);
 501   i = pool_normalize_complex_dep(pool, req, &dq, CPLXDEPS_EXPAND);
 502   if (i == 0 || i == 1)
 503     {
 504       queue_free(&dq);
 505       return;
 506     }
 507   for (i = 0; i < dq.count; i++)
 508     {
 509       blk = i;
 510       for (; (p = dq.elements[i]) != 0; i++)
 511         {
 512           if (p < 0)
 513             {
 514               if (!MAPTST(installedm, -p))
 515                 break;
 516             }
 517           else if (p == ip)
 518             break;
 519         }
 520       if (!p)
 521         {
 522           for (i = blk; (p = dq.elements[i]) != 0; i++)
 523             {
 524               if (p < 0)
 525                 continue;
 526               if (MAPTST(im, p))
 527                 continue;
 528               if (!MAPTST(installedm, p))
 529                 continue;
 530               if (p == ip || MAPTST(userinstalled, p - pool->installed->start))
 531                 continue;
 532 #ifdef CLEANDEPSDEBUG
 533               printf("%s requires/recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
 534 #endif
 535               MAPSET(im, p);
 536               queue_push(iq, p);
 537             }
 538         }
 539       while (dq.elements[i])
 540         i++;
 541     }
 542   queue_free(&dq);
 543 }
 544
 545 #endif
 546
 547 static inline int
 548 queue_contains(Queue *q, Id id)
 549 {
 550   int i;
 551   for (i = 0; i < q->count; i++)
 552     if (q->elements[i] == id)
 553       return 1;
 554   return 0;
 555 }
 556
 557 static void
 558 find_update_seeds(Solver *solv, Queue *updatepkgs_filtered, Map *userinstalled)
 559 {
 560   Pool *pool = solv->pool;
 561   Repo *installed = solv->installed;
 562   Queue *cleandeps_updatepkgs = solv->cleandeps_updatepkgs;
 563   int i, j;
 564   Id p;
 565
 566   queue_prealloc(updatepkgs_filtered, cleandeps_updatepkgs->count);
 567   for (i = 0; i < cleandeps_updatepkgs->count; i++)
 568     {
 569       p = cleandeps_updatepkgs->elements[i];
 570       if (pool->solvables[p].repo == installed)
 571         {
 572 #ifdef ENABLE_LINKED_PKGS
 573           const char *name = pool_id2str(pool, pool->solvables[p].name);
 574           if (strncmp(name, "pattern:", 8) == 0 || strncmp(name, "application:", 12) == 0)
 575             continue;
 576 #endif
 577           queue_push(updatepkgs_filtered, p);
 578         }
 579     }
 580 #ifdef CLEANDEPSDEBUG
 581   printf("SEEDS IN (%d)\n", updatepkgs_filtered->count);
 582   for (i = 0; i < updatepkgs_filtered->count; i++)
 583     printf("  - %s\n", pool_solvid2str(pool, updatepkgs_filtered->elements[i]));
 584 #endif
 585   filter_unneeded(solv, updatepkgs_filtered, 0, 1);
 586 #ifdef CLEANDEPSDEBUG
 587   printf("SEEDS OUT (%d)\n", updatepkgs_filtered->count);
 588   for (i = 0; i < updatepkgs_filtered->count; i++)
 589     printf("  - %s\n", pool_solvid2str(pool, updatepkgs_filtered->elements[i]));
 590 #endif
 591   /* make sure userinstalled packages are in the seeds */
 592   for (i = j = 0; i < updatepkgs_filtered->count; i++)
 593     {
 594       p = updatepkgs_filtered->elements[i];
 595       if (!MAPTST(userinstalled, p - installed->start))
 596         updatepkgs_filtered->elements[j++] = p;
 597     }
 598   queue_truncate(updatepkgs_filtered, j);
 599   for (i = 0; i < cleandeps_updatepkgs->count; i++)
 600     {
 601       p = cleandeps_updatepkgs->elements[i];
 602       if (pool->solvables[p].repo == installed)
 603         {
 604 #ifdef ENABLE_LINKED_PKGS
 605           const char *name = pool_id2str(pool, pool->solvables[p].name);
 606           if (strncmp(name, "pattern:", 8) == 0 || strncmp(name, "application:", 12) == 0)
 607             {
 608               queue_push(updatepkgs_filtered, p);
 609               continue;
 610             }
 611 #endif
 612           if (MAPTST(userinstalled, p - installed->start))
 613             queue_push(updatepkgs_filtered, p);
 614         }
 615     }
 616 #ifdef CLEANDEPSDEBUG
 617   printf("SEEDS FINAL\n");
 618   for (i = 0; i < updatepkgs_filtered->count; i++)
 619     printf("  - %s\n", pool_solvid2str(pool, updatepkgs_filtered->elements[i]));
 620 #endif
 621 }
 622
 623 /*
 624  * Find all installed packages that are no longer
 625  * needed regarding the current solver job.
 626  *
 627  * The algorithm is:
 628  * - remove pass: remove all packages that could have
 629  *   been dragged in by the obsoleted packages.
 630  *   i.e. if package A is obsolete and contains "Requires: B",
 631  *   also remove B, as installing A will have pulled in B.
 632  *   after this pass, we have a set of still installed packages
 633  *   with broken dependencies.
 634  * - add back pass:
 635  *   now add back all packages that the still installed packages
 636  *   require.
 637  *
 638  * The cleandeps packages are the packages removed in the first
 639  * pass and not added back in the second pass.
 640  *
 641  * If we search for unneeded packages (unneeded is true), we
 642  * simply remove all packages except the userinstalled ones in
 643  * the first pass.
 644  */
 645 void
 646 solver_createcleandepsmap(Solver *solv, Map *cleandepsmap, int unneeded)
 647 {
 648   Pool *pool = solv->pool;
 649   Repo *installed = solv->installed;
 650   Queue *job = &solv->job;
 651   Map userinstalled;
 652   Map im;
 653   Map installedm;
 654   Rule *r;
 655   Id rid, how, what, select;
 656   Id p, pp, ip, jp;
 657   Id req, *reqp, sup, *supp;
 658   Solvable *s;
 659   Queue iq, iqcopy, xsuppq;
 660   Queue updatepkgs_filtered;
 661   int i;
 662
 663   map_empty(cleandepsmap);
 664   if (!installed || installed->end == installed->start)
 665     return;
 666   map_init(&userinstalled, installed->end - installed->start);
 667   map_init(&im, pool->nsolvables);
 668   map_init(&installedm, pool->nsolvables);
 669   queue_init(&iq);
 670   queue_init(&xsuppq);
 671
 672   for (i = 0; i < job->count; i += 2)
 673     {
 674       how = job->elements[i];
 675       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
 676         {
 677           what = job->elements[i + 1];
 678           select = how & SOLVER_SELECTMASK;
 679           if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
 680             {
 681               FOR_REPO_SOLVABLES(installed, p, s)
 682                 MAPSET(&userinstalled, p - installed->start);
 683             }
 684           FOR_JOB_SELECT(p, pp, select, what)
 685             if (pool->solvables[p].repo == installed)
 686               MAPSET(&userinstalled, p - installed->start);
 687         }
 688       if ((how & (SOLVER_JOBMASK | SOLVER_SELECTMASK)) == (SOLVER_ERASE | SOLVER_SOLVABLE_PROVIDES))
 689         {
 690           what = job->elements[i + 1];
 691           if (ISRELDEP(what))
 692             {
 693               Reldep *rd = GETRELDEP(pool, what);
 694               if (rd->flags != REL_NAMESPACE)
 695                 continue;
 696               if (rd->evr == 0)
 697                 {
 698                   queue_pushunique(&iq, rd->name);
 699                   continue;
 700                 }
 701               FOR_PROVIDES(p, pp, what)
 702                 if (p)
 703                   break;
 704               if (p)
 705                 continue;
 706               queue_pushunique(&iq, what);
 707             }
 708         }
 709     }
 710
 711   /* have special namespace cleandeps erases */
 712   if (iq.count)
 713     {
 714       for (ip = installed->start; ip < installed->end; ip++)
 715         {
 716           s = pool->solvables + ip;
 717           if (s->repo != installed)
 718             continue;
 719           if (!s->supplements)
 720             continue;
 721           supp = s->repo->idarraydata + s->supplements;
 722           while ((sup = *supp++) != 0)
 723             if (ISRELDEP(sup) && check_xsupp(solv, &iq, sup) && !check_xsupp(solv, 0, sup))
 724               {
 725 #ifdef CLEANDEPSDEBUG
 726                 printf("xsupp %s from %s\n", pool_dep2str(pool, sup), pool_solvid2str(pool, ip));
 727 #endif
 728                 queue_pushunique(&xsuppq, sup);
 729               }
 730         }
 731       queue_empty(&iq);
 732     }
 733
 734   /* also add visible patterns to userinstalled for openSUSE */
 735   if (1)
 736     {
 737       Dataiterator di;
 738       dataiterator_init(&di, pool, 0, 0, SOLVABLE_ISVISIBLE, 0, 0);
 739       while (dataiterator_step(&di))
 740         {
 741           Id *dp;
 742           if (di.solvid <= 0)
 743             continue;
 744           s = pool->solvables + di.solvid;
 745           if (!s->repo || !s->requires)
 746             continue;
 747           if (s->repo != installed && !pool_installable(pool, s))
 748             continue;
 749           if (strncmp(pool_id2str(pool, s->name), "pattern:", 8) != 0)
 750             continue;
 751           dp = s->repo->idarraydata + s->requires;
 752           for (dp = s->repo->idarraydata + s->requires; *dp; dp++)
 753             FOR_PROVIDES(p, pp, *dp)
 754               if (pool->solvables[p].repo == installed)
 755                 {
 756                   if (strncmp(pool_id2str(pool, pool->solvables[p].name), "pattern", 7) != 0)
 757                     continue;
 758                   MAPSET(&userinstalled, p - installed->start);
 759                 }
 760         }
 761       dataiterator_free(&di);
 762     }
 763   if (1)
 764     {
 765       /* all products and their buddies are userinstalled */
 766       for (p = installed->start; p < installed->end; p++)
 767         {
 768           Solvable *s = pool->solvables + p;
 769           if (s->repo != installed)
 770             continue;
 771           if (!strncmp("product:", pool_id2str(pool, s->name), 8))
 772             {
 773               MAPSET(&userinstalled, p - installed->start);
 774 #ifdef ENABLE_LINKED_PKGS
 775               if (solv->instbuddy && solv->instbuddy[p - installed->start] > 1)
 776                 {
 777                   Id buddy = solv->instbuddy[p - installed->start];
 778                   if (buddy >= installed->start && buddy < installed->end)
 779                     MAPSET(&userinstalled, buddy - installed->start);
 780                 }
 781 #endif
 782             }
 783         }
 784     }
 785
 786   /* add all positive elements (e.g. locks) to "userinstalled" */
 787   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
 788     {
 789       r = solv->rules + rid;
 790       if (r->d < 0)
 791         continue;
 792       i = solv->ruletojob.elements[rid - solv->jobrules];
 793       if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
 794         continue;
 795       FOR_RULELITERALS(p, jp, r)
 796         if (p > 0 && pool->solvables[p].repo == installed)
 797           MAPSET(&userinstalled, p - installed->start);
 798     }
 799
 800   /* add all cleandeps candidates to iq */
 801   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
 802     {
 803       r = solv->rules + rid;
 804       if (r->d < 0)                             /* disabled? */
 805         continue;
 806       if (r->d == 0 && r->p < 0 && r->w2 == 0)  /* negative assertion (erase job)? */
 807         {
 808           p = -r->p;
 809           if (pool->solvables[p].repo != installed)
 810             continue;
 811           MAPCLR(&userinstalled, p - installed->start);
 812           if (unneeded)
 813             continue;
 814           i = solv->ruletojob.elements[rid - solv->jobrules];
 815           how = job->elements[i];
 816           if ((how & (SOLVER_JOBMASK|SOLVER_CLEANDEPS)) == (SOLVER_ERASE|SOLVER_CLEANDEPS))
 817             queue_push(&iq, p);
 818         }
 819       else if (r->p > 0)                        /* install job */
 820         {
 821           if (unneeded)
 822             continue;
 823           i = solv->ruletojob.elements[rid - solv->jobrules];
 824           if ((job->elements[i] & SOLVER_CLEANDEPS) == SOLVER_CLEANDEPS)
 825             {
 826               /* check if the literals all obsolete some installed package */
 827               Map om;
 828               int iqstart;
 829
 830               /* just one installed literal */
 831               if (r->d == 0 && r->w2 == 0 && pool->solvables[r->p].repo == installed)
 832                 continue;
 833               /* multiversion is bad */
 834               if (solv->multiversion.size && !solv->keepexplicitobsoletes)
 835                 {
 836                   FOR_RULELITERALS(p, jp, r)
 837                     if (MAPTST(&solv->multiversion, p))
 838                       break;
 839                   if (p)
 840                     continue;
 841                 }
 842
 843               om.size = 0;
 844               iqstart = iq.count;
 845               FOR_RULELITERALS(p, jp, r)
 846                 {
 847                   if (p < 0)
 848                     {
 849                       queue_truncate(&iq, iqstart);     /* abort */
 850                       break;
 851                     }
 852                   if (pool->solvables[p].repo == installed)
 853                     {
 854                       if (iq.count == iqstart)
 855                         queue_push(&iq, p);
 856                       else
 857                         {
 858                           for (i = iqstart; i < iq.count; i++)
 859                             if (iq.elements[i] == p)
 860                               break;
 861                           queue_truncate(&iq, iqstart);
 862                           if (i < iq.count)
 863                             queue_push(&iq, p);
 864                         }
 865                     }
 866                   else
 867                     solver_intersect_obsoleted(solv, p, &iq, iqstart, &om);
 868                   if (iq.count == iqstart)
 869                     break;
 870                 }
 871               if (om.size)
 872                 map_free(&om);
 873             }
 874         }
 875     }
 876   queue_init_clone(&iqcopy, &iq);
 877
 878   if (!unneeded)
 879     {
 880       if (solv->cleandeps_updatepkgs)
 881         for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
 882           queue_push(&iq, solv->cleandeps_updatepkgs->elements[i]);
 883     }
 884
 885   if (unneeded)
 886     queue_empty(&iq);   /* just in case... */
 887
 888   /* clear userinstalled bit for the packages we really want to delete/update */
 889   for (i = 0; i < iq.count; i++)
 890     {
 891       p = iq.elements[i];
 892       if (pool->solvables[p].repo != installed)
 893         continue;
 894       MAPCLR(&userinstalled, p - installed->start);
 895     }
 896
 897   for (p = installed->start; p < installed->end; p++)
 898     {
 899       if (pool->solvables[p].repo != installed)
 900         continue;
 901       MAPSET(&installedm, p);
 902       if (pool->considered && !MAPTST(pool->considered, p))
 903         MAPSET(&userinstalled, p - installed->start);   /* we may not remove those */
 904       if (unneeded && !MAPTST(&userinstalled, p - installed->start))
 905         continue;
 906       MAPSET(&im, p);
 907     }
 908   MAPSET(&installedm, SYSTEMSOLVABLE);
 909   MAPSET(&im, SYSTEMSOLVABLE);
 910
 911   if (!unneeded && solv->cleandeps_updatepkgs)
 912     {
 913       /* find update "seeds" */
 914       queue_init(&updatepkgs_filtered);
 915       find_update_seeds(solv, &updatepkgs_filtered, &userinstalled);
 916     }
 917
 918 #ifdef CLEANDEPSDEBUG
 919   printf("REMOVE PASS\n");
 920 #endif
 921
 922   for (;;)
 923     {
 924       if (!iq.count)
 925         {
 926           if (unneeded)
 927             break;
 928           /* supplements pass */
 929           for (ip = installed->start; ip < installed->end; ip++)
 930             {
 931               if (!MAPTST(&installedm, ip))
 932                 continue;
 933               s = pool->solvables + ip;
 934               if (!s->supplements)
 935                 continue;
 936               if (!MAPTST(&im, ip))
 937                 continue;
 938               if (MAPTST(&userinstalled, ip - installed->start))
 939                 continue;
 940               supp = s->repo->idarraydata + s->supplements;
 941               while ((sup = *supp++) != 0)
 942                 if (solver_dep_possible(solv, sup, &im))
 943                   break;
 944               if (!sup)
 945                 {
 946                   supp = s->repo->idarraydata + s->supplements;
 947                   while ((sup = *supp++) != 0)
 948                     if (solver_dep_possible(solv, sup, &installedm) || (xsuppq.count && queue_contains(&xsuppq, sup)))
 949                       {
 950                         /* no longer supplemented, also erase */
 951                         int iqcount = iq.count;
 952                         /* pin packages, see comment above dep_pkgcheck */
 953                         dep_pkgcheck(solv, sup, &im, &iq);
 954                         for (i = iqcount; i < iq.count; i++)
 955                           {
 956                             Id pqp = iq.elements[i];
 957                             if (pool->solvables[pqp].repo == installed)
 958                               MAPSET(&userinstalled, pqp - installed->start);
 959                           }
 960                         queue_truncate(&iq, iqcount);
 961 #ifdef CLEANDEPSDEBUG
 962                         printf("%s supplemented [%s]\n", pool_solvid2str(pool, ip), pool_dep2str(pool, sup));
 963 #endif
 964                         queue_push(&iq, ip);
 965                       }
 966                 }
 967             }
 968           if (!iq.count)
 969             break;      /* no supplementing package found, we're done */
 970         }
 971       ip = queue_shift(&iq);
 972       s = pool->solvables + ip;
 973       if (!MAPTST(&im, ip))
 974         continue;
 975       if (!MAPTST(&installedm, ip))
 976         continue;
 977       if (s->repo == installed && MAPTST(&userinstalled, ip - installed->start))
 978         continue;
 979       MAPCLR(&im, ip);
 980 #ifdef CLEANDEPSDEBUG
 981       printf("removing %s\n", pool_solvable2str(pool, s));
 982 #endif
 983       if (s->requires)
 984         {
 985           reqp = s->repo->idarraydata + s->requires;
 986           while ((req = *reqp++) != 0)
 987             {
 988               if (req == SOLVABLE_PREREQMARKER)
 989                 continue;
 990 #ifdef ENABLE_COMPLEX_DEPS
 991               if (pool_is_complex_dep(pool, req))
 992                 {
 993                   complex_cleandeps_remove(pool, ip, req, &im, &installedm, &iq);
 994                   continue;
 995                 }
 996 #endif
 997               FOR_PROVIDES(p, pp, req)
 998                 {
 999                   if (p != SYSTEMSOLVABLE && MAPTST(&im, p))
1000                     {
1001 #ifdef CLEANDEPSDEBUG
1002                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
1003 #endif
1004                       queue_push(&iq, p);
1005                     }
1006                 }
1007             }
1008         }
1009       if (s->recommends)
1010         {
1011           reqp = s->repo->idarraydata + s->recommends;
1012           while ((req = *reqp++) != 0)
1013             {
1014 #ifdef ENABLE_COMPLEX_DEPS
1015               if (pool_is_complex_dep(pool, req))
1016                 {
1017                   complex_cleandeps_remove(pool, ip, req, &im, &installedm, &iq);
1018                   continue;
1019                 }
1020 #endif
1021               FOR_PROVIDES(p, pp, req)
1022                 {
1023                   if (p != SYSTEMSOLVABLE && MAPTST(&im, p))
1024                     {
1025 #ifdef CLEANDEPSDEBUG
1026                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
1027 #endif
1028                       queue_push(&iq, p);
1029                     }
1030                 }
1031             }
1032         }
1033     }
1034
1035   /* turn userinstalled into remove set for pruning */
1036   map_empty(&userinstalled);
1037   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
1038     {
1039       r = solv->rules + rid;
1040       if (r->p >= 0 || r->d != 0 || r->w2 != 0)
1041         continue;       /* disabled or not erase */
1042       p = -r->p;
1043       MAPCLR(&im, p);
1044       if (pool->solvables[p].repo == installed)
1045         MAPSET(&userinstalled, p - installed->start);
1046     }
1047   if (!unneeded && solv->cleandeps_updatepkgs)
1048     {
1049       for (i = 0; i < solv->cleandeps_updatepkgs->count; i++)
1050         {
1051           p = solv->cleandeps_updatepkgs->elements[i];
1052           if (pool->solvables[p].repo == installed)
1053             MAPSET(&userinstalled, p - installed->start);
1054         }
1055     }
1056   MAPSET(&im, SYSTEMSOLVABLE);  /* in case we cleared it above */
1057   for (p = installed->start; p < installed->end; p++)
1058     if (MAPTST(&im, p))
1059       queue_push(&iq, p);
1060   for (rid = solv->jobrules; rid < solv->jobrules_end; rid++)
1061     {
1062       r = solv->rules + rid;
1063       if (r->d < 0)
1064         continue;
1065       FOR_RULELITERALS(p, jp, r)
1066         if (p > 0)
1067           queue_push(&iq, p);
1068     }
1069   /* also put directly addressed packages on the install queue
1070    * so we can mark patterns as installed */
1071   for (i = 0; i < job->count; i += 2)
1072     {
1073       how = job->elements[i];
1074       if ((how & SOLVER_JOBMASK) == SOLVER_USERINSTALLED)
1075         {
1076           what = job->elements[i + 1];
1077           select = how & SOLVER_SELECTMASK;
1078           if (select == SOLVER_SOLVABLE && pool->solvables[what].repo != installed)
1079             queue_push(&iq, what);
1080         }
1081     }
1082
1083 #ifdef CLEANDEPSDEBUG
1084   printf("ADDBACK PASS\n");
1085 #endif
1086   for (;;)
1087     {
1088       if (!iq.count)
1089         {
1090           /* supplements pass */
1091           for (ip = installed->start; ip < installed->end; ip++)
1092             {
1093               if (!MAPTST(&installedm, ip))
1094                 continue;
1095               if (MAPTST(&userinstalled, ip - installed->start))
1096                 continue;
1097               s = pool->solvables + ip;
1098               if (!s->supplements)
1099                 continue;
1100               if (MAPTST(&im, ip))
1101                 continue;
1102               supp = s->repo->idarraydata + s->supplements;
1103               while ((sup = *supp++) != 0)
1104                 if (solver_dep_possible(solv, sup, &im))
1105                   break;
1106               if (sup)
1107                 {
1108 #ifdef CLEANDEPSDEBUG
1109                   printf("%s supplemented\n", pool_solvid2str(pool, ip));
1110 #endif
1111                   MAPSET(&im, ip);
1112                   queue_push(&iq, ip);
1113                 }
1114             }
1115           if (!iq.count)
1116             break;
1117         }
1118       ip = queue_shift(&iq);
1119       s = pool->solvables + ip;
1120 #ifdef CLEANDEPSDEBUG
1121       printf("adding back %s\n", pool_solvable2str(pool, s));
1122 #endif
1123       if (s->repo == installed && pool->implicitobsoleteusescolors)
1124         {
1125           unsigned int a, bestscore = 0;
1126           FOR_PROVIDES(p, pp, s->name)
1127             {
1128               Solvable *ps = pool->solvables + p;
1129               if (ps->name != s->name || ps->repo == installed)
1130                 continue;
1131               a = pool_arch2score(pool, ps->arch);
1132               if (a && a != 1 && (!bestscore || a < bestscore))
1133                 bestscore = a;
1134             }
1135           if (bestscore && pool_arch2score(pool, s->arch) != bestscore)
1136             {
1137               FOR_PROVIDES(p, pp, s->name)
1138                 {
1139                   Solvable *ps = pool->solvables + p;
1140                   if (ps->repo == installed && ps->name == s->name && ps->evr == s->evr && ps->arch != s->arch && pool_arch2score(pool, ps->arch) == bestscore)
1141                     if (!MAPTST(&im, p))
1142                       {
1143 #ifdef CLEANDEPSDEBUG
1144                         printf("%s lockstep %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
1145 #endif
1146                         MAPSET(&im, p);
1147                         queue_push(&iq, p);
1148                       }
1149                 }
1150             }
1151         }
1152       if (s->requires)
1153         {
1154           reqp = s->repo->idarraydata + s->requires;
1155           while ((req = *reqp++) != 0)
1156             {
1157 #ifdef ENABLE_COMPLEX_DEPS
1158               if (pool_is_complex_dep(pool, req))
1159                 {
1160                   complex_cleandeps_addback(pool, ip, req, &im, &installedm, &iq, &userinstalled);
1161                   continue;
1162                 }
1163 #endif
1164               FOR_PROVIDES(p, pp, req)
1165                 if (p == ip)
1166                   break;
1167               if (p)
1168                 continue;
1169               FOR_PROVIDES(p, pp, req)
1170                 {
1171                   if (MAPTST(&im, p))
1172                     continue;
1173                   if (MAPTST(&installedm, p))
1174                     {
1175                       if (p == ip)
1176                         continue;
1177                       if (MAPTST(&userinstalled, p - installed->start))
1178                         continue;
1179 #ifdef CLEANDEPSDEBUG
1180                       printf("%s requires %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
1181 #endif
1182                       MAPSET(&im, p);
1183                       queue_push(&iq, p);
1184                     }
1185                 }
1186             }
1187         }
1188       if (s->recommends)
1189         {
1190           reqp = s->repo->idarraydata + s->recommends;
1191           while ((req = *reqp++) != 0)
1192             {
1193 #ifdef ENABLE_COMPLEX_DEPS
1194               if (pool_is_complex_dep(pool, req))
1195                 {
1196                   complex_cleandeps_addback(pool, ip, req, &im, &installedm, &iq, &userinstalled);
1197                   continue;
1198                 }
1199 #endif
1200               FOR_PROVIDES(p, pp, req)
1201                 if (p == ip)
1202                   break;
1203               if (p)
1204                 continue;
1205               FOR_PROVIDES(p, pp, req)
1206                 {
1207                   if (MAPTST(&im, p))
1208                     continue;
1209                   if (MAPTST(&installedm, p))
1210                     {
1211                       if (p == ip)
1212                         continue;
1213                       if (MAPTST(&userinstalled, p - installed->start))
1214                         continue;
1215 #ifdef CLEANDEPSDEBUG
1216                       printf("%s recommends %s\n", pool_solvid2str(pool, ip), pool_solvid2str(pool, p));
1217 #endif
1218                       MAPSET(&im, p);
1219                       queue_push(&iq, p);
1220                     }
1221                 }
1222             }
1223         }
1224     }
1225
1226   queue_free(&iq);
1227   /* make sure the updatepkgs and mistakes are not in the cleandeps map */
1228   if (!unneeded && solv->cleandeps_updatepkgs)
1229     {
1230       for (i = 0; i < updatepkgs_filtered.count; i++)
1231         MAPSET(&im, updatepkgs_filtered.elements[i]);
1232       queue_free(&updatepkgs_filtered);
1233     }
1234   if (solv->cleandeps_mistakes)
1235     for (i = 0; i < solv->cleandeps_mistakes->count; i++)
1236       MAPSET(&im, solv->cleandeps_mistakes->elements[i]);
1237   /* also remove original iq packages */
1238   for (i = 0; i < iqcopy.count; i++)
1239     MAPSET(&im, iqcopy.elements[i]);
1240   queue_free(&iqcopy);
1241   for (p = installed->start; p < installed->end; p++)
1242     {
1243       if (pool->solvables[p].repo != installed)
1244         continue;
1245       if (pool->considered && !MAPTST(pool->considered, p))
1246           continue;
1247       if (!MAPTST(&im, p))
1248         MAPSET(cleandepsmap, p - installed->start);
1249     }
1250   map_free(&im);
1251   map_free(&installedm);
1252   map_free(&userinstalled);
1253   queue_free(&xsuppq);
1254 #ifdef CLEANDEPSDEBUG
1255   printf("=== final cleandeps map:\n");
1256   for (p = installed->start; p < installed->end; p++)
1257     if (MAPTST(cleandepsmap, p - installed->start))
1258       printf("  - %s\n", pool_solvid2str(pool, p));
1259 #endif
1260 }
1261
1262 void
1263 solver_get_unneeded(Solver *solv, Queue *unneededq, int filtered)
1264 {
1265   Repo *installed = solv->installed;
1266   int i;
1267   Map cleandepsmap;
1268
1269   queue_empty(unneededq);
1270   if (!installed || installed->end == installed->start)
1271     return;
1272
1273   map_init(&cleandepsmap, installed->end - installed->start);
1274   solver_createcleandepsmap(solv, &cleandepsmap, 1);
1275   for (i = installed->start; i < installed->end; i++)
1276     if (MAPTST(&cleandepsmap, i - installed->start))
1277       queue_push(unneededq, i);
1278
1279   if (filtered)
1280     filter_unneeded(solv, unneededq, &cleandepsmap, 0);
1281   map_free(&cleandepsmap);
1282 }
1283
1284 static void
1285 add_cleandeps_mistake(Solver *solv, Id p)
1286 {
1287  if (!solv->cleandeps_mistakes)
1288     {
1289       solv->cleandeps_mistakes = solv_calloc(1, sizeof(Queue));
1290       queue_init(solv->cleandeps_mistakes);
1291     }
1292   queue_push(solv->cleandeps_mistakes, p);
1293   MAPCLR(&solv->cleandepsmap, p - solv->installed->start);
1294   solver_reenablepolicyrules_cleandeps(solv, p);
1295 }
1296
1297 static inline int
1298 cleandeps_rule_is_true(Solver *solv, Rule *r)
1299 {
1300   Pool *pool = solv->pool;
1301   Id p, pp;
1302   FOR_RULELITERALS(p, pp, r)
1303     if (p > 0 && solv->decisionmap[p] > 0)
1304       return 1;
1305   return 0;
1306 }
1307
1308 int
1309 solver_check_cleandeps_mistakes(Solver *solv)
1310 {
1311   Pool *pool = solv->pool;
1312   Repo *installed = solv->installed;
1313   Rule *fr;
1314   int i, j, nj;
1315   int mademistake = 0;
1316
1317   if (!solv->cleandepsmap.size || !installed)
1318     return 0;
1319   /* check for mistakes */
1320   policy_update_recommendsmap(solv);
1321   for (i = installed->start; i < installed->end; i++)
1322     {
1323       if (pool->solvables[i].repo != installed)
1324         continue;
1325       if (solv->decisionmap[i] > 0)
1326         {
1327           Id req, *reqp;
1328           Solvable *s = pool->solvables + i;
1329           /* kept package, check requires. we need to do this for things like requires(pre) */
1330           reqp = s->repo->idarraydata + s->requires;
1331           while ((req = *reqp++) != 0)
1332             {
1333               Id p2, pp2;
1334               FOR_PROVIDES(p2, pp2, req)
1335                 {
1336                   if (pool->solvables[p2].repo != installed)
1337                     continue;
1338                   if (p2 == i || solv->decisionmap[p2] > 0)
1339                     continue;
1340                   if (!MAPTST(&solv->cleandepsmap, p2 - installed->start))
1341                     continue;
1342                   POOL_DEBUG(SOLV_DEBUG_SOLVER, "cleandeps requires mistake: %s %s %s\n", pool_solvid2str(pool, i), pool_dep2str(pool, req), pool_solvid2str(pool, p2));
1343                   add_cleandeps_mistake(solv, p2);
1344                   mademistake = 1;
1345                 }
1346             }
1347         }
1348       if (!MAPTST(&solv->cleandepsmap, i - installed->start))
1349         continue;
1350       /* a mistake is when the featurerule is true but the updaterule is false */
1351       fr = solv->rules + solv->featurerules + (i - installed->start);
1352       if (!fr->p)
1353         fr = solv->rules + solv->updaterules + (i - installed->start);
1354       if (!fr->p)
1355         continue;
1356       if (!cleandeps_rule_is_true(solv, fr))
1357         {
1358           /* feature rule is not true, thus we cleandeps erased the package */
1359           /* check if the package is recommended/supplemented. if yes, we made a mistake. */
1360           if (!MAPTST(&solv->recommendsmap, i) && !solver_is_supplementing(solv, pool->solvables + i))
1361             continue;   /* feature rule is not true */
1362           POOL_DEBUG(SOLV_DEBUG_SOLVER, "cleandeps recommends mistake: ");
1363           solver_printruleclass(solv, SOLV_DEBUG_SOLVER, fr);
1364         }
1365       else
1366         {
1367           Rule *r = solv->rules + solv->updaterules + (i - installed->start);
1368           if (!r->p || r == fr || cleandeps_rule_is_true(solv, r))
1369             {
1370               /* update rule is true, check best rules */
1371               if (!solv->bestrules_pkg)
1372                 continue;
1373               nj = solv->bestrules_end - solv->bestrules;
1374               for (j = 0; j < nj; j++)
1375                 if (solv->bestrules_pkg[j] == i)
1376                   {
1377                     r = solv->rules + solv->bestrules + j;
1378                     if (!cleandeps_rule_is_true(solv, r))
1379                       break;
1380                   }
1381               if (j == nj)
1382                 continue;
1383             }
1384           POOL_DEBUG(SOLV_DEBUG_SOLVER, "cleandeps mistake: ");
1385           solver_printruleclass(solv, SOLV_DEBUG_SOLVER, r);
1386           POOL_DEBUG(SOLV_DEBUG_SOLVER, "feature rule: ");
1387           solver_printruleclass(solv, SOLV_DEBUG_SOLVER, fr);
1388         }
1389       add_cleandeps_mistake(solv, i);
1390       mademistake = 1;
1391     }
1392   return mademistake;
1393 }