#include <math.h>
#include <errno.h>
+// The following #define must be here under "math.h".
+// This ifdef ensures that "__STDC_IEC_559__" is defined. If it is defined,
+// then we are guaranteed that the 'double' type is 64-bit. Otherwise, the
+// compilation of this file should fail because we are no longer guaranteed.
+#ifndef __STDC_IEC_559__
+#error "Requires IEEE 754 floating point!"
+#endif
+
#include "zigbee_wrapper.h"
#include "telegesis_wrapper.h"
#include "pluginlist.h"
#define ZB_ON_OFF_CLUSTER "0006"
#define ZB_ON_OFF_ATTRIBUTE_ID "0000"
#define ZB_IAS_ZONE_TYPE_ATTRIBUTE_ID "0001"
+#define ZB_COLOR_CONTROL_CLUSTER "0300"
+#define ZB_COLOR_TEMPERATURE_ATTRIBUTE_ID "0007"
-#define IAS_ZONE_TYPE_MOTION_SENSOR "000d"
+#define IAS_ZONE_TYPE_MOTION_SENSOR "000D"
#define IAS_ZONE_TYPE_CONTACT_SENSOR "0015"
-#define IAS_ZONE_TYPE_WATER_SENSOR "002a"
+#define IAS_ZONE_TYPE_WATER_SENSOR "002A"
#define ZB_DATA_TYPE_NULL "00"
#define ZB_DATA_TYPE_1_BYTE "08"
static const char* OIC_MOTION_SENSOR = "oic.r.sensor.motion";
static const char* OIC_WATER_SENSOR = "oic.r.sensor.water";
static const char* OIC_BINARY_SWITCH = "oic.r.switch.binary";
+static const char* OIC_CHROMA_LIGHT = "oic.r.colour.chroma";
static const char* OIC_TEMPERATURE_ATTRIBUTE = "temperature";
static const char* OIC_DIMMING_ATTRIBUTE = "dimmingSetting";
static const char* OIC_CONTACT_ATTRIBUTE = "value";
+static const char* OIC_WATER_ATTRIBUTE = "value";
+static const char* OIC_MOTION_ATTRIBUTE = "value";
static const char* OIC_ON_OFF_ATTRIBUTE = "value";
+static const char* OIC_COLOUR_TEMPERATURE_ATTRIBUTE = "colourspacevalue";
PIPlugin_Zigbee ** gPlugin = NULL;
const char * getResourceTypeForIASZoneType(TWDevice *device)
{
- if(!device)
+ if (!device)
{
return NULL;
}
if (ret != OC_STACK_OK || !IASZoneType)
{
- OC_LOG_V (ERROR, TAG, "Error %u getting IAS Zone Type", ret);
+ OC_LOG_V(ERROR, TAG, "Error %u getting IAS Zone Type", ret);
return NULL;
}
- if (strcmp (IASZoneType, IAS_ZONE_TYPE_CONTACT_SENSOR) == 0)
+ if (strcmp(IASZoneType, IAS_ZONE_TYPE_CONTACT_SENSOR) == 0)
{
resourceType = OIC_CONTACT_SENSOR;
}
- else if (strcmp (IASZoneType, IAS_ZONE_TYPE_MOTION_SENSOR) == 0)
+ else if (strcmp(IASZoneType, IAS_ZONE_TYPE_MOTION_SENSOR) == 0)
{
resourceType = OIC_MOTION_SENSOR;
}
- else if (strcmp (IASZoneType, IAS_ZONE_TYPE_WATER_SENSOR) == 0)
+ else if (strcmp(IASZoneType, IAS_ZONE_TYPE_WATER_SENSOR) == 0)
{
resourceType = OIC_WATER_SENSOR;
}
else
{
- OC_LOG_V (ERROR, TAG, "Unsupported Zone Type %s", IASZoneType);
+ OC_LOG_V(ERROR, TAG, "Unsupported Zone Type %s", IASZoneType);
resourceType = NULL;
}
const char * endpointId,
const char * clusterId)
{
- if(!output || !prefix || !nodeId || !endpointId || !clusterId)
+ if (!output || !prefix || !nodeId || !endpointId || !clusterId)
{
return OC_STACK_INVALID_PARAM;
}
if (!*output)
{
- OC_LOG (ERROR, TAG, "Out of memory");
+ OC_LOG(ERROR, TAG, "Out of memory");
return OC_STACK_NO_MEMORY;
}
char * temp = OICStrcpy(*output, newUriSize, prefix);
- if(temp != *output)
+ if (temp != *output)
{
goto exit;
}
temp = OICStrcat(*output, newUriSize, LEN_SEPARATOR);
- if(temp != *output)
+ if (temp != *output)
{
goto exit;
}
temp = OICStrcat(*output, newUriSize, nodeId);
- if(temp != *output)
+ if (temp != *output)
{
goto exit;
}
temp = OICStrcat(*output, newUriSize, LEN_SEPARATOR);
- if(temp != *output)
+ if (temp != *output)
{
goto exit;
}
temp = OICStrcat(*output, newUriSize, endpointId);
- if(temp != *output)
+ if (temp != *output)
{
goto exit;
}
temp = OICStrcat(*output, newUriSize, LEN_SEPARATOR);
- if(temp != *output)
+ if (temp != *output)
{
goto exit;
}
temp = OICStrcat(*output, newUriSize, clusterId);
- if(temp != *output)
+ if (temp != *output)
{
goto exit;
}
void foundZigbeeCallback(TWDevice *device)
{
- if(!device)
+ if (!device)
{
OC_LOG(ERROR, TAG, "foundZigbeeCallback: Invalid parameter.");
return;
}
int count = device->endpointOfInterest->clusterList->count;
- for(int i=0; i < count; i++)
+ for (int i=0; i < count; i++)
{
PIResource_Zigbee *piResource = (PIResource_Zigbee *) OICMalloc(sizeof(*piResource));
if (!piResource)
{
- OC_LOG (ERROR, TAG, "Out of memory");
+ OC_LOG(ERROR, TAG, "Out of memory");
return;
}
piResource->header.plugin = (PIPluginBase *)gPlugin;
device->endpointOfInterest->endpointId,
device->endpointOfInterest->clusterList->clusterIds[i].clusterId);
- if(result != OC_STACK_OK)
+ if (result != OC_STACK_OK)
{
OICFree(piResource);
return;
char * foundClusterID =
device->endpointOfInterest->clusterList->clusterIds[i].clusterId;
- if (strcmp (foundClusterID, ZB_IAS_ZONE_CLUSTER) == 0)
+ if (strcmp(foundClusterID, ZB_IAS_ZONE_CLUSTER) == 0)
{
piResource->header.piResource.resourceTypeName
- = getResourceTypeForIASZoneType (device);
+ = getResourceTypeForIASZoneType(device);
- OCStackResult ret = TWListenForStatusUpdates (device->nodeId,
+ OCStackResult ret = TWListenForStatusUpdates(device->nodeId,
device->endpointOfInterest->endpointId);
if (ret != OC_STACK_OK)
{
// Just log it and move on if this fails?
// or not create this resource at all?
- OC_LOG (ERROR, TAG, "Command to listen for status updates failed");
+ OC_LOG(ERROR, TAG, "Command to listen for status updates failed");
}
}
else
(char *) ZigBeeClusterIDToOICResourceType(foundClusterID);
}
- if(piResource->header.piResource.resourceTypeName == NULL)
+ if (piResource->header.piResource.resourceTypeName == NULL)
{
- OC_LOG_V (ERROR, TAG, "unsupported clusterId : %s",
+ OC_LOG_V(ERROR, TAG, "unsupported clusterId : %s",
device->endpointOfInterest->clusterList->clusterIds[i].clusterId);
OICFree(piResource->header.piResource.uri);
OICFree(piResource);
void zigbeeZoneStatusUpdate(TWUpdate * update)
{
- if(!update)
+ if (!update)
{
return;
}
update->nodeId,
update->endpoint,
ZB_IAS_ZONE_CLUSTER);
- if(result != OC_STACK_OK || !uri)
+ if (result != OC_STACK_OK || !uri)
{
OC_LOG_V(ERROR, TAG, "Failed to build URI with result: %d", result);
return;
PINewResourceFound newResourceCB,
PIObserveNotificationUpdate observeNotificationUpdate)
{
- if(!plugin)
+ if (!plugin)
{
return OC_STACK_INVALID_PARAM;
}
*plugin = (PIPlugin_Zigbee *) OICMalloc(sizeof(PIPlugin_Zigbee) + sizeof(PIPluginBase));
- if(!*plugin)
+ if (!*plugin)
{
return OC_STACK_NO_MEMORY;
}
gPlugin = plugin;
OCStackResult result = TWInitialize(comPort);
- if(result != OC_STACK_OK)
+ if (result != OC_STACK_OK)
{
return result;
}
(void)plugin;
TWSetDiscoveryCallback(foundZigbeeCallback);
result = TWDiscover(NULL);
- OC_LOG_V (DEBUG, TAG, "ZigbeeDiscover : Status = %d\n", result);
+ OC_LOG_V(DEBUG, TAG, "ZigbeeDiscover : Status = %d\n", result);
return result;
}
// NOTE: The returned string is NOT malloc'ed.
const char* ZigBeeClusterIDToOICResourceType(const char * clusterID) //Discovery/CreateResource
{
+ if (!clusterID)
+ {
+ return NULL;
+ }
if (strcmp(clusterID, ZB_TEMPERATURE_CLUSTER) == 0)
{
return OIC_TEMPERATURE_SENSOR;
{
return OIC_BINARY_SWITCH;
}
+ else if (strcmp(clusterID, ZB_COLOR_CONTROL_CLUSTER) == 0)
+ {
+ return OIC_CHROMA_LIGHT;
+ }
else
{
return NULL;
const char* OICResourceToZigBeeClusterID(char *oicResourceType)
{
+ if (!oicResourceType)
+ {
+ return NULL;
+ }
if (strcmp(oicResourceType, OIC_TEMPERATURE_SENSOR) == 0)
{
return ZB_TEMPERATURE_CLUSTER;
{
return ZB_INDICATOR_CLUSTER;
}
+ else if (strcmp(oicResourceType, OIC_CHROMA_LIGHT) == 0)
+ {
+ return ZB_COLOR_CONTROL_CLUSTER;
+ }
else
{
return NULL;
OCStackResult getZigBeeAttributesForOICResource(const char * OICResourceType,
AttributeList *attributeList) // GET
{
- if (strcmp (OICResourceType, OIC_TEMPERATURE_SENSOR) == 0)
+ if (!OICResourceType || !attributeList)
+ {
+ return OC_STACK_INVALID_PARAM;
+ }
+ if (strcmp(OICResourceType, OIC_TEMPERATURE_SENSOR) == 0)
{
attributeList->count = 1;
attributeList->list[0].oicAttribute = OICStrdup(OIC_TEMPERATURE_ATTRIBUTE);
attributeList->list[0].zigbeeType = ZB_16_SINT;
return OC_STACK_OK;
}
- else if (strcmp (OICResourceType, OIC_DIMMABLE_LIGHT) == 0)
+ else if (strcmp(OICResourceType, OIC_DIMMABLE_LIGHT) == 0)
{
attributeList->count = 1;
attributeList->list[0].oicAttribute = OICStrdup(OIC_DIMMING_ATTRIBUTE);
attributeList->list[0].zigbeeType = ZB_8_UINT;
return OC_STACK_OK;
}
- else if (strcmp (OICResourceType, OIC_CONTACT_SENSOR) == 0)
+ else if (strcmp(OICResourceType, OIC_CONTACT_SENSOR) == 0)
{
attributeList->count = 1;
attributeList->list[0].oicAttribute = OICStrdup(OIC_CONTACT_ATTRIBUTE);
attributeList->list[0].zigbeeType = ZB_BOOL;
return OC_STACK_OK;
}
- else if (strcmp (OICResourceType, OIC_BINARY_SWITCH) == 0)
+ else if (strcmp(OICResourceType, OIC_WATER_SENSOR) == 0)
+ {
+ attributeList->count = 1;
+ attributeList->list[0].oicAttribute = OICStrdup(OIC_WATER_ATTRIBUTE);
+ attributeList->list[0].zigBeeAttribute = ZB_IAS_ZONE_STATUS_ATTRIBUTE_ID;
+ attributeList->list[0].oicType = OIC_ATTR_BOOL;
+ attributeList->list[0].zigbeeType = ZB_BOOL;
+ return OC_STACK_OK;
+ }
+ else if (strcmp(OICResourceType, OIC_MOTION_SENSOR) == 0)
+ {
+ attributeList->count = 1;
+ attributeList->list[0].oicAttribute = OICStrdup(OIC_MOTION_ATTRIBUTE);
+ attributeList->list[0].zigBeeAttribute = ZB_IAS_ZONE_STATUS_ATTRIBUTE_ID;
+ attributeList->list[0].oicType = OIC_ATTR_BOOL;
+ attributeList->list[0].zigbeeType = ZB_BOOL;
+ return OC_STACK_OK;
+ }
+ else if (strcmp(OICResourceType, OIC_BINARY_SWITCH) == 0)
{
attributeList->count = 1;
attributeList->list[0].oicAttribute = OICStrdup(OIC_ON_OFF_ATTRIBUTE);
attributeList->list[0].zigbeeType = ZB_BOOL;
return OC_STACK_OK;
}
+ else if (strcmp(OICResourceType, OIC_CHROMA_LIGHT) == 0)
+ {
+ attributeList->count = 1;
+ attributeList->list[0].oicAttribute = OICStrdup(OIC_COLOUR_TEMPERATURE_ATTRIBUTE);
+ attributeList->list[0].zigBeeAttribute = ZB_COLOR_TEMPERATURE_ATTRIBUTE_ID;
+ attributeList->list[0].oicType = OIC_ATTR_INT;
+ attributeList->list[0].zigbeeType = ZB_16_UINT;
+ return OC_STACK_OK;
+ }
return OC_STACK_ERROR;
}
AttributeList *attributeList,
OCRepPayload *payload) // Put
{
- if(!OICResourceType)
+ if (!OICResourceType)
{
return false;
}
- if(strcmp(OICResourceType, OIC_TEMPERATURE_SENSOR) == 0)
+ if (strcmp(OICResourceType, OIC_TEMPERATURE_SENSOR) == 0)
{
// Cant really PUT on the temp sensor, but the code is still there.
int64_t temperature = 0;
// TODO: This if should only look for attributes it supports and ignore the rest
// or examine every attribute in the payload and complain about unsupported attributes?
- if(OCRepPayloadGetPropInt(payload, OIC_TEMPERATURE_ATTRIBUTE, &temperature))
+ if (OCRepPayloadGetPropInt(payload, OIC_TEMPERATURE_ATTRIBUTE, &temperature))
{
attributeList->count = 1;
attributeList->list[0].oicAttribute = OICStrdup(OIC_TEMPERATURE_ATTRIBUTE);
return true;
}
}
- else if (strcmp (OICResourceType, OIC_DIMMABLE_LIGHT) == 0)
+ else if (strcmp(OICResourceType, OIC_DIMMABLE_LIGHT) == 0)
{
int64_t onLevel = 0;
- if(OCRepPayloadGetPropInt(payload, OIC_DIMMING_ATTRIBUTE, &onLevel))
+ if (OCRepPayloadGetPropInt(payload, OIC_DIMMING_ATTRIBUTE, &onLevel))
{
attributeList->count = 1;
attributeList->list[0].oicAttribute = OICStrdup(OIC_DIMMING_ATTRIBUTE);
return true;
}
}
- else if (strcmp (OICResourceType, OIC_CONTACT_SENSOR) == 0)
+ else if (strcmp(OICResourceType, OIC_CONTACT_SENSOR) == 0)
{
int64_t value = 0;
- if(OCRepPayloadGetPropInt(payload, OIC_CONTACT_ATTRIBUTE, &value))
+ if (OCRepPayloadGetPropInt(payload, OIC_CONTACT_ATTRIBUTE, &value))
{
attributeList->count = 1;
attributeList->list[0].oicAttribute = OICStrdup(OIC_CONTACT_ATTRIBUTE);
return true;
}
}
- else if (strcmp (OICResourceType, OIC_BINARY_SWITCH) == 0)
+ else if (strcmp(OICResourceType, OIC_WATER_SENSOR) == 0)
+ {
+ int64_t value = 0;
+
+ if (OCRepPayloadGetPropInt(payload, OIC_WATER_ATTRIBUTE, &value))
+ {
+ attributeList->count = 1;
+ attributeList->list[0].oicAttribute = OICStrdup(OIC_WATER_ATTRIBUTE);
+ attributeList->list[0].zigBeeAttribute = ZB_IAS_ZONE_STATUS_ATTRIBUTE_ID;
+ attributeList->list[0].oicType = OIC_ATTR_BOOL;
+ attributeList->list[0].val.i = value;
+ attributeList->list[0].zigbeeType = ZB_BOOL;
+ attributeList->CIEMask = (CIECommandMask) 0;
+
+ return true;
+ }
+ }
+ else if (strcmp(OICResourceType, OIC_BINARY_SWITCH) == 0)
{
bool value = 0;
- if(OCRepPayloadGetPropBool(payload, OIC_ON_OFF_ATTRIBUTE, &value))
+ if (OCRepPayloadGetPropBool(payload, OIC_ON_OFF_ATTRIBUTE, &value))
{
attributeList->count = 1;
attributeList->list[0].oicAttribute = OICStrdup(OIC_ON_OFF_ATTRIBUTE);
return true;
}
}
+ else if (strcmp(OICResourceType, OIC_CHROMA_LIGHT) == 0)
+ {
+ char * value = 0;
+ if (OCRepPayloadGetPropString(payload, OIC_COLOUR_TEMPERATURE_ATTRIBUTE, &value))
+ {
+ attributeList->count = 1;
+ attributeList->list[0].oicAttribute = OICStrdup(OIC_COLOUR_TEMPERATURE_ATTRIBUTE);
+ attributeList->list[0].zigBeeAttribute = ZB_COLOR_TEMPERATURE_ATTRIBUTE_ID;
+ attributeList->list[0].oicType = OIC_ATTR_STRING;
+ attributeList->list[0].val.str = value;
+ attributeList->list[0].zigbeeType = ZB_16_UINT;
+ attributeList->CIEMask = (CIECommandMask) 0;
+
+ return true;
+ }
+ }
return false;
}
-OCEntityHandlerResult getDoubleValueFromString (const char *str, double *outDouble)
+OCEntityHandlerResult getDoubleValueFromString(const char *str, double *outDouble)
{
+ if (!str || !outDouble)
+ {
+ return OC_EH_ERROR;
+ }
size_t hexOutValSize = strlen(HexPrepend) + strlen(str) + 1;
char * hexOutVal = (char *) OICCalloc(1, hexOutValSize);
- if(!hexOutVal)
+ if (!hexOutVal)
{
return OC_EH_ERROR;
}
errno = 0;
double value = strtod(hexOutVal, &endPtr);
- if(errno != 0 || *endPtr != 0 || value == HUGE_VALF || value == HUGE_VALL)
+ if (errno != 0 || *endPtr != 0 || value == HUGE_VALF || value == HUGE_VALL)
{
OICFree(hexOutVal);
return OC_EH_ERROR;
}
-OCEntityHandlerResult processGetRequest (PIPluginBase * plugin,
+OCEntityHandlerResult getColourTemperatureFromString(const char* str, int64_t* outVal)
+{
+ if (!str || !outVal)
+ {
+ return OC_EH_ERROR;
+ }
+ // str comes in as "X,Y,T" where "T" is the colour temperature.
+ // Iterate 3 times to retrieve the last value.
+ char * strstr = OICStrdup(str);
+ char * savePtr = NULL;
+ char * temp = NULL;
+ for (int i=0; i<3; i++)
+ {
+ temp = strtok_r(strstr, ",", &savePtr);
+ if (!temp)
+ {
+ *outVal = 0;
+ OICFree(strstr);
+ return OC_EH_ERROR;
+ }
+ }
+ OCStackResult result = getDoubleValueFromString(temp, (double *)outVal);
+ OICFree(strstr);
+ return result;
+}
+
+OCEntityHandlerResult processGetRequest(PIPluginBase * plugin,
OCEntityHandlerRequest *ehRequest, OCRepPayload **payload)
{
if (!plugin || !ehRequest || !payload)
ehRequest->resource);
if (stackResult != OC_STACK_OK)
{
- OC_LOG (ERROR, TAG, "Failed to get resource from handle");
+ OC_LOG(ERROR, TAG, "Failed to get resource from handle");
return OC_EH_ERROR;
}
- stackResult = getZigBeeAttributesForOICResource (
+ stackResult = getZigBeeAttributesForOICResource(
piResource->header.piResource.resourceTypeName, &attributeList);
- if(stackResult != OC_STACK_OK)
+ if (stackResult != OC_STACK_OK)
{
- OC_LOG_V (ERROR, TAG, "Failed to fetch attributes for %s",
+ OC_LOG_V(ERROR, TAG, "Failed to fetch attributes for %s",
piResource->header.piResource.resourceTypeName);
return OC_EH_ERROR;
}
*payload = OCRepPayloadCreate();
- if(!payload)
+ if (!payload)
{
OC_LOG(ERROR, TAG, PCF("Failed to allocate Payload"));
return OC_EH_ERROR;
bool boolRes = OCRepPayloadSetUri(*payload, piResource->header.piResource.uri);
if (boolRes == false)
{
- OCRepPayloadDestroy (*payload);
+ OCRepPayloadDestroy(*payload);
return OC_EH_ERROR;
}
- for(uint32_t i = 0; i<attributeList.count; i++)
+ for
(uint32_t i = 0; i<attributeList.count; i++)
{
char * outVal = NULL;
uint8_t outValLength = 0;
if (stackResult != OC_STACK_OK || !outVal)
{
stackResult = OC_EH_ERROR;
- OCRepPayloadDestroy (*payload);
+ OCRepPayloadDestroy(*payload);
goto exit;
}
if (attributeList.list[i].oicType == OIC_ATTR_INT)
char *endPtr = NULL;
errno = 0;
// Third arg is 16 as outVal is a hex Number
- uint64_t value = strtol (outVal, &endPtr, 16);
+ uint64_t value = strtol(outVal, &endPtr, 16);
if (*endPtr != 0 || errno != 0)
{
return OC_EH_ERROR;
}
+ if (!attributeList.list[i].oicAttribute)
+ {
+ return OC_EH_ERROR;
+ }
if (strcmp(attributeList.list[i].oicAttribute, OIC_DIMMING_ATTRIBUTE) == 0)
{
// OIC Dimming operates between 0-100, while Zigbee operates
value = value / 2.54;
}
}
+ else if (strcmp(attributeList.list[i].oicAttribute, OIC_COLOUR_TEMPERATURE_ATTRIBUTE) == 0)
+ {
+ // OIC Chroma requires: Hue, Saturation, and ColorSpaceValue (color space value is
+ // "chromaX, chromaY, colourTemperature").
+ // ZigBee HA requires: "currentX", "currentY", while we're trying to map a specific
+ // device which goes against the HA spec and ONLY implements "ColorTemperature".
+ // Because of the misalignments between OIC Smart Home and ZigBee HA specs, the
+ // follow assumption is required:
+ // - *X and *Y will be zero, and therefore ignored (or passed as zero where
+ // applicable).
+ // OIC ColorTemperature operates between 0-1000 (degrees Kelvin) in string form,
+ // while ZigBee operates between 0-65279 (bits, with an operating range
+ // 15.32-1,000,000 (degrees Kelvin)).
+ // ZigBee HA states: ColorTemperature(bits) = 1,000,000/ColorTemperature(Kelvin)
+ // Invalid: ColorTemperature==0 || ColorTemperature==65535
+ // However the specific bulb we're mapping only operates between 2700-6500 (Kelvin)
+ // which equates to 0x0099-0x0172 (ie. 153-370; giving a resolution of 217 bits).
+ // Conversion from ZigBee HA specific bulb to OIC temporary mapping:
+ // OIC Value: 0-100 ZigBee Value: (0-217)+153
+ // OICValue = (ZigBeeValue-153)/2.17
+
+ value = (value-153)/2.17;
+ }
boolRes = OCRepPayloadSetPropInt(*payload,
attributeList.list[i].oicAttribute,
(uint64_t) value);
{
double value = 0;
- if (getDoubleValueFromString (outVal, &value) != OC_EH_OK)
+ if (getDoubleValueFromString(outVal, &value) != OC_EH_OK)
+ {
+ return OC_EH_ERROR;
+ }
+ if (!piResource->clusterId)
{
return OC_EH_ERROR;
}
char *endPtr = NULL;
errno = 0;
// Third arg is 16 as outVal is a hex Number
- uint64_t value = strtol (outVal, &endPtr, 16);
+ uint64_t value = strtol(outVal, &endPtr, 16);
if (errno != 0 || *endPtr != 0)
{
value);
}
- OICFree (outVal);
+ OICFree(outVal);
}
if (boolRes == false)
}
exit:
- for(; attributeListIndex < attributeList.count; attributeListIndex++)
+ for (; attributeListIndex < attributeList.count; attributeListIndex++)
{
OICFree(attributeList.list[attributeListIndex].oicAttribute);
}
ehRequest->resource);
if (stackResult != OC_STACK_OK)
{
- OC_LOG (ERROR, TAG, "Failed to get resource from handle");
+ OC_LOG(ERROR, TAG, "Failed to get resource from handle");
return OC_EH_ERROR;
}
- bool boolRes = getZigBeeAttributesIfValid (
+ bool boolRes = getZigBeeAttributesIfValid(
piResource->header.piResource.resourceTypeName,
&attributeList, *payload);
- if(boolRes == false)
+ if (boolRes == false)
{
- OC_LOG_V (ERROR, TAG, "Failed to fetch attributes for %s",
+ OC_LOG_V(ERROR, TAG, "Failed to fetch attributes for %s",
piResource->header.piResource.resourceTypeName);
return OC_EH_ERROR;
}
uint32_t i = 0;
- for(; i<attributeList.count; i++)
+ for
(; i<attributeList.count; i++)
{
if (attributeList.list[i].oicType == OIC_ATTR_INT)
{
}
if (rangeDiff <= 0xFE)
{
- snprintf(value, sizeof(value), "%02x", (unsigned int) rangeDiff);
+ errno = 0;
+ int strRet = snprintf(value, sizeof(value), "%02x", (unsigned int) rangeDiff);
+ if (strRet <= 0)
+ {
+ OC_LOG_V(ERROR, TAG, "Failed to parse string due to errno: %d", errno);
+ return OC_EH_ERROR;
+ }
}
stackResult = TWMoveToLevel(piResource->nodeId, piResource->endpointId,
DEFAULT_MOVETOLEVEL_MODE, value, DEFAULT_TRANS_TIME);
}
else
{
- snprintf(value, sizeof(value), "%"PRId64, attributeList.list[i].val.i);
+ errno = 0;
+ int strRet = snprintf(value,
+ sizeof(value),
+ "%"PRId64,
+ attributeList.list[i].val.i);
+ if (strRet <= 0)
+ {
+ OC_LOG_V(ERROR, TAG, "Failed to parse string due to errno: %d", errno);
+ return OC_EH_ERROR;
+ }
stackResult = TWSetAttribute(piResource->eui,
piResource->nodeId, piResource->endpointId,
piResource->clusterId, attributeList.list[i].zigBeeAttribute,
else if (attributeList.list[i].oicType == OIC_ATTR_DOUBLE)
{
char value[MAX_STRLEN_DOUBLE] = {};
- snprintf(value, sizeof(value), "%f", attributeList.list[i].val.d);
+ errno = 0;
+ int strRet = snprintf(value, sizeof(value), "%f", attributeList.list[i].val.d);
+ if (strRet <= 0)
+ {
+ OC_LOG_V(ERROR, TAG, "Failed to parse string due to errno: %d", errno);
+ return OC_EH_ERROR;
+ }
stackResult = TWSetAttribute(piResource->eui,
piResource->nodeId, piResource->endpointId,
piResource->clusterId, attributeList.list[i].zigBeeAttribute,
}
else if (attributeList.list[i].oicType == OIC_ATTR_STRING)
{
- stackResult = TWSetAttribute(piResource->eui,
- piResource->nodeId, piResource->endpointId,
- piResource->clusterId, attributeList.list[i].zigBeeAttribute,
- getZBDataTypeString(attributeList.list[i].zigbeeType),
- attributeList.list[i].val.str);
+ if (strcmp(attributeList.list[i].oicAttribute, OIC_COLOUR_TEMPERATURE_ATTRIBUTE) == 0)
+ {
+ char *endPtr = NULL;
+ uint16_t zbVal = (uint16_t)strtod(attributeList.list[i].val.str, &endPtr);
+ zbVal = (zbVal*2.17)+153;
+ char value[5] = {0};
+ errno = 0;
+ int strRet = snprintf(value, sizeof(value), "%04x", zbVal);
+ if (strRet <= 0)
+ {
+ OC_LOG_V(ERROR, TAG, "Failed to parse string due to errno: %d", errno);
+ return OC_EH_ERROR;
+ }
+ stackResult =
+ TWColorMoveToColorTemperature(piResource->nodeId, piResource->endpointId,
+ value, DEFAULT_TRANS_TIME);
+ }
+ else
+ {
+ stackResult = TWSetAttribute(piResource->eui,
+ piResource->nodeId, piResource->endpointId,
+ piResource->clusterId, attributeList.list[i].zigBeeAttribute,
+ getZBDataTypeString(attributeList.list[i].zigbeeType),
+ attributeList.list[i].val.str);
+ }
if (stackResult != OC_STACK_OK)
{
return OC_EH_ERROR;
OCEntityHandlerResult ProcessEHRequest(PIPluginBase * plugin,
OCEntityHandlerRequest *ehRequest, OCRepPayload **payload)
{
- if(!ehRequest || !payload)
+ if (!ehRequest || !payload)
{
return OC_EH_ERROR;
}
- if(ehRequest->method == OC_REST_GET)
+ if (ehRequest->method == OC_REST_GET)
{
return processGetRequest(plugin, ehRequest, payload);
}
- else if(ehRequest->method == OC_REST_PUT)
+ else if (ehRequest->method == OC_REST_PUT)
{
return processPutRequest(plugin, ehRequest, payload);
}
projects / platform / upstream / iotivity.git / commitdiff