ges: validate: Use correct types when getting structure values
authorDoug Nazar <nazard@nazar.ca>
Sat, 1 May 2021 20:52:22 +0000 (16:52 -0400)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Tue, 18 Jul 2023 11:43:52 +0000 (11:43 +0000)
From https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/247

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5055>

subprojects/gst-editing-services/ges/ges-validate.c

index 3b666ed..7d76986 100644 (file)
@@ -367,11 +367,15 @@ GES_START_VALIDATE_ACTION (_edit)
   REPORT_UNLESS (element, beach, "Could not find element %s", element_name);
 
   if (!_get_clocktime (action->structure, "position", &position, &fposition)) {
-    fposition = 0;
-    if (!gst_structure_get_int (action->structure, "source-frame",
-            (gint *) & fposition)
-        && !gst_structure_get_int64 (action->structure, "source-frame",
-            &fposition)) {
+    gint pos;
+    gint64 pos64;
+
+    if (gst_structure_get_int (action->structure, "source-frame", &pos)) {
+      fposition = pos;
+    } else if (gst_structure_get_int64 (action->structure, "source-frame",
+            &pos64)) {
+      fposition = pos64;
+    } else {
       gchar *structstr = gst_structure_to_string (action->structure);
 
       GST_VALIDATE_REPORT_ACTION (scenario, action,