projects
/
platform
/
upstream
/
gstreamer.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e6f5580
)
tee: Lock mutex before reading the removed flag of the pads
author
Sebastian Dröge
<sebastian@centricular.com>
Thu, 24 Oct 2019 22:39:05 +0000
(
01:39
+0300)
committer
Tim-Philipp Müller
<tim@centricular.com>
Sat, 26 Oct 2019 19:56:19 +0000
(20:56 +0100)
Otherwise we're not guaranteed to read the very latest value that
another thread might've written in there when the pad was released, and
could instead work with an old value.
plugins/elements/gsttee.c
patch
|
blob
|
history
diff --git
a/plugins/elements/gsttee.c
b/plugins/elements/gsttee.c
index
f933509
..
5b33125
100644
(file)
--- a/
plugins/elements/gsttee.c
+++ b/
plugins/elements/gsttee.c
@@
-899,12
+899,14
@@
gst_tee_handle_data (GstTee * tee, gpointer data, gboolean is_list)
ret = gst_pad_push (pad, GST_BUFFER_CAST (data));
}
+ GST_OBJECT_LOCK (tee);
if (GST_TEE_PAD_CAST (pad)->removed)
ret = GST_FLOW_NOT_LINKED;
if (ret == GST_FLOW_NOT_LINKED && tee->allow_not_linked) {
ret = GST_FLOW_OK;
}
+ GST_OBJECT_UNLOCK (tee);
gst_object_unref (pad);