Revert "webrtc/nice: support consent-freshness RFC7675"
authorTim-Philipp Müller <tim@centricular.com>
Tue, 16 May 2023 15:17:05 +0000 (16:17 +0100)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Wed, 17 May 2023 07:53:16 +0000 (07:53 +0000)
This reverts commit 0161687505156f54ff38b976668804ac2763a863.

This causes problems when the connection is congested because
libnice uses a too agressive timeout contrary to the spec, so
it's easy for consent to lapse and streaming to stop if there's
packet loss.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4649>

subprojects/gst-plugins-bad/gst-libs/gst/webrtc/nice/nice.c

index a59f578..f62eb91 100644 (file)
@@ -1583,7 +1583,6 @@ gst_webrtc_nice_constructed (GObject * object)
 
   options |= NICE_AGENT_OPTION_ICE_TRICKLE;
   options |= NICE_AGENT_OPTION_REGULAR_NOMINATION;
-  options |= NICE_AGENT_OPTION_CONSENT_FRESHNESS;
 
   ice->priv->nice_agent = nice_agent_new_full (ice->priv->main_context,
       NICE_COMPATIBILITY_RFC5245, options);