playbin3: Fix coverity issue (Missing unlock)
authorGilbok Lee <gilbok.lee@samsung.com>
Tue, 15 Sep 2020 07:15:31 +0000 (16:15 +0900)
committerGilbok Lee <gilbok.lee@samsung.com>
Wed, 16 Sep 2020 00:40:29 +0000 (09:40 +0900)
Change-Id: I93dcc031ac75de8e6fff716cd7e7a689f9f9b23e

gst/playback/gstplaybin3.c
packaging/gst-plugins-base.spec

index 8c23a97..197b5e6 100644 (file)
@@ -3109,7 +3109,14 @@ pad_removed_cb (GstElement * decodebin, GstPad * pad, GstSourceGroup * group)
   else if (g_str_has_prefix (GST_PAD_NAME (pad), "text"))
     combine = &playbin->combiner[PLAYBIN_STREAM_TEXT];
   else
+#ifdef TIZEN_FEATURE_PLAYBIN3_MODIFICATION
+  {
+    GST_PLAY_BIN3_UNLOCK (playbin);
+    return;
+  }
+#else
     return;
+#endif
 
   combiner_release_pad (playbin, combine, pad);
   release_source_pad (playbin, group, pad);
index b3ded69..c5093a6 100644 (file)
@@ -5,7 +5,7 @@
 
 Name:           gst-plugins-base
 Version:        1.16.2
-Release:        7
+Release:        8
 License:        LGPL-2.0+
 Summary:        GStreamer Streaming-Media Framework Plug-Ins
 Url:            http://gstreamer.freedesktop.org/
@@ -94,6 +94,7 @@ export CFLAGS="%{optflags} -fno-strict-aliasing\
  -DTIZEN_FEATURE_VOLUME_MODIFICATION\
  -DTIZEN_FEATURE_FORCE_SW_DECODER\
  -DTIZEN_FEATURE_U3_AVOID_DEADLOCK\
+ -DTIZEN_FEATURE_PLAYBIN3_MODIFICATION\
 %if "%{tizen_profile_name}" == "tv"
  -DTIZEN_PROFILE_TV\
  -DTIZEN_FEATURE_TRUSTZONE\