vaapipostproc: don't let tmp_rect go out of scope.
authorSimon Farnsworth <simon.farnsworth@onelan.co.uk>
Fri, 27 Jun 2014 10:57:11 +0000 (11:57 +0100)
committerGwenole Beauchesne <gwenole.beauchesne@intel.com>
Thu, 3 Jul 2014 20:59:36 +0000 (22:59 +0200)
A compiler change showed me that tmp_rect went out of scope before
it was used. Move it to the beginning of the function instead.

https://bugzilla.gnome.org/show_bug.cgi?id=726363

Signed-off-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
[added guards for GStreamer 0.10 builds]
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
gst/vaapi/gstvaapipostproc.c

index aa0cb98..e692f54 100644 (file)
@@ -448,6 +448,9 @@ gst_vaapipostproc_process_vpp(GstBaseTransform *trans, GstBuffer *inbuf,
     guint flags, deint_flags;
     gboolean tff, deint, deint_refs, deint_changed;
     GstVaapiRectangle *crop_rect = NULL;
+#if GST_CHECK_VERSION(1,0,0)
+    GstVaapiRectangle tmp_rect;
+#endif
 
     /* Validate filters */
     if ((postproc->flags & GST_VAAPI_POSTPROC_FLAG_FORMAT) &&
@@ -493,7 +496,6 @@ gst_vaapipostproc_process_vpp(GstBaseTransform *trans, GstBuffer *inbuf,
     GstVideoCropMeta * const crop_meta =
         gst_buffer_get_video_crop_meta(inbuf);
     if (crop_meta) {
-        GstVaapiRectangle tmp_rect;
         crop_rect = &tmp_rect;
         crop_rect->x = crop_meta->x;
         crop_rect->y = crop_meta->y;