ges-launcher: do not set rendering details too early
authorMathieu Duponchelle <mathieu@centricular.com>
Fri, 29 Jan 2021 19:42:26 +0000 (20:42 +0100)
committerMathieu Duponchelle <mathieu@centricular.com>
Fri, 29 Jan 2021 19:42:26 +0000 (20:42 +0100)
It looks like the _set_rendering_details call is superfluous
in _startup(), as it will get called in run_pipeline.

The problem with calling it before timeline_set_user_options
is that we are going to fail creating a smart profile if
the user selected eg --track-types=video, as the get_smart_profile
method compares the tracks in the asset with those on the timeline.

Reproduce with a video-only clip:

ges-launch-1.0 --track-types=video +clip file://$PWD/jelly.mp4 \
inpoint=15.0 -o foo.mp4 --smart-rendering

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/228>

tools/ges-launcher.c

index cf56b83..f0a6de2 100644 (file)
@@ -1450,9 +1450,6 @@ _startup (GApplication * application)
   if (!_set_playback_details (self))
     goto failure;
 
-  if (!_set_rendering_details (self))
-    goto failure;
-
   if (!_run_pipeline (self))
     goto failure;