xml-formatter: Properly report error parsing restriction caps
authorThibault Saunier <tsaunier@igalia.com>
Tue, 19 Jan 2021 13:29:09 +0000 (10:29 -0300)
committerThibault Saunier <tsaunier@igalia.com>
Wed, 10 Feb 2021 19:14:47 +0000 (16:14 -0300)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/227>

ges/ges-xml-formatter.c

index cfbddcc..409c554 100644 (file)
@@ -434,6 +434,8 @@ _parse_track (GMarkupParseContext * context, const gchar * element_name,
 
   if (properties) {
     props = gst_structure_from_string (properties, NULL);
+    if (!props)
+      goto wrong_properties;
   }
 
   ges_base_xml_formatter_add_track (GES_BASE_XML_FORMATTER (self), track_type,
@@ -460,6 +462,13 @@ convertion_failed:
       g_strerror (errno));
   return;
 
+wrong_properties:
+  gst_clear_caps (&caps);
+  g_set_error (error, G_MARKUP_ERROR,
+      G_MARKUP_ERROR_INVALID_CONTENT,
+      "element '%s', Can not create properties: %s'", element_name, properties);
+  return;
+
 }
 
 static inline void