Guard AppleClang linker options
authorJeremy Hayes <jeremy@lunarg.com>
Thu, 8 Dec 2022 23:41:03 +0000 (16:41 -0700)
committerJeremy Hayes <jeremy@lunarg.com>
Thu, 8 Dec 2022 23:57:43 +0000 (16:57 -0700)
Fix #3073

CMakeLists.txt

index b581c84..b6fd306 100644 (file)
@@ -192,10 +192,10 @@ elseif(${CMAKE_CXX_COMPILER_ID} MATCHES "Clang" AND NOT MSVC)
         # Error if there's symbols that are not found at link time.
         # add_link_options() was added in CMake 3.13 - if using an earlier
         # version don't set this - it should be caught by presubmits anyway.
-        if (WIN32)
-            add_link_options("-Wl,--no-undefined")
-        else()
+        if (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
             add_link_options("-Wl,-undefined,error")
+        else()
+            add_link_options("-Wl,--no-undefined")
         endif()
     endif()
 elseif(MSVC)
@@ -402,4 +402,4 @@ if(ENABLE_GLSLANG_INSTALL)
         DESTINATION
             "${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}"
     )
-endif()
\ No newline at end of file
+endif()