Always append closing quote in log command

Patch suggested by Tomas Hoger <thoger@redhat.com>

diff --git a/bus/connection.c b/bus/connection.c
index ab99fa5..9159c89 100644 (file)
--- a/bus/connection.c
+++ b/bus/connection.c
@@ -575,12 +575,11 @@ cache_peer_loginfo_string (BusConnectionData *d,
         }
       if (!_dbus_string_append_printf (&loginfo_buf, "pid=%ld comm=\"", pid))
         goto oom;
-      /* Ignore errors here */
-      if (_dbus_command_for_pid (pid, &loginfo_buf, MAX_LOG_COMMAND_LEN, NULL))
-        {
-          if (!_dbus_string_append_byte (&loginfo_buf, '"'))
-            goto oom;
-        }
+      /* Ignore errors here; we may not have permissions to read the
+       * proc file. */
+      _dbus_command_for_pid (pid, &loginfo_buf, MAX_LOG_COMMAND_LEN, NULL);
+      if (!_dbus_string_append_byte (&loginfo_buf, '"'))
+        goto oom;
     }
 
   if (dbus_connection_get_windows_user (connection, &windows_sid))