tool: Fixed incorrect return code when setting HTTP request fails
authorSteve Holme <steve_holme@hotmail.com>
Sat, 22 Feb 2014 18:14:33 +0000 (18:14 +0000)
committerSteve Holme <steve_holme@hotmail.com>
Sat, 22 Feb 2014 18:14:33 +0000 (18:14 +0000)
During initialisation SetHTTPrequest() may fail and cURL would return
PARAM_BAD_USE, which is equivalent to CURLE_NOT_BUILT_IN in cURL error
terms.

Instead, return CURLE_FAILED_INIT as we do for other functions that may
fail during initialisation.

src/tool_operate.c

index 398cd81..b77411b 100644 (file)
@@ -314,13 +314,13 @@ static int operate_do(struct Configurable *config)
       if(SetHTTPrequest(config,
                         (config->no_body?HTTPREQ_HEAD:HTTPREQ_GET),
                         &config->httpreq)) {
-        res = PARAM_BAD_USE;
+        res = CURLE_FAILED_INIT;
         goto quit_curl;
       }
     }
     else {
       if(SetHTTPrequest(config, HTTPREQ_SIMPLEPOST, &config->httpreq)) {
-        res = PARAM_BAD_USE;
+        res = CURLE_FAILED_INIT;
         goto quit_curl;
       }
     }