tool_getparam: Moved tool_version_info() call into operate()
authorSteve Holme <steve_holme@hotmail.com>
Sun, 23 Feb 2014 10:16:36 +0000 (10:16 +0000)
committerSteve Holme <steve_holme@hotmail.com>
Sun, 23 Feb 2014 11:10:01 +0000 (11:10 +0000)
src/tool_getparam.c
src/tool_getparam.h
src/tool_operate.c
src/tool_parsecfg.c

index 05dd648..a38cbc2 100644 (file)
@@ -1701,10 +1701,8 @@ ParameterError getparameter(char *flag,    /* f or -long-flag */
         config->tracetype = TRACE_NONE;
       break;
     case 'V':
-      if(toggle) {  /* --no-version yields no output! */
-        tool_version_info();
-        return PARAM_HELP_REQUESTED;
-      }
+      if(toggle)    /* --no-version yields no output! */
+        return PARAM_VERSION_INFO_REQUESTED;
       break;
 
     case 'w':
@@ -1866,6 +1864,7 @@ ParameterError parse_args(struct Configurable *config, int argc,
   }
 
   if(result && result != PARAM_HELP_REQUESTED &&
+     result != PARAM_VERSION_INFO_REQUESTED &&
      result != PARAM_ENGINES_REQUESTED) {
     const char *reason = param2text(result);
 
index 1fac8da..ac55d0b 100644 (file)
@@ -30,6 +30,7 @@ typedef enum {
   PARAM_REQUIRES_PARAMETER,
   PARAM_BAD_USE,
   PARAM_HELP_REQUESTED,
+  PARAM_VERSION_INFO_REQUESTED,
   PARAM_ENGINES_REQUESTED,
   PARAM_GOT_EXTRA_PARAMETER,
   PARAM_BAD_NUMERIC,
index f6ebf5f..bf10b81 100644 (file)
@@ -1828,6 +1828,9 @@ CURLcode operate(struct Configurable *config, int argc, argv_item_t argv[])
     if(res) {
       result = CURLE_OK;
 
+      /* Check if we were asked for the version information */
+      if(res == PARAM_VERSION_INFO_REQUESTED)
+        tool_version_info();
       /* Check if we were asked to list the SSL engines */
       if(res == PARAM_ENGINES_REQUESTED)
         tool_list_engines(config->easy);
index 44d7001..9115a05 100644 (file)
@@ -231,6 +231,7 @@ int parseconfig(const char *filename,
           filename = (char *)"<stdin>";
         }
         if(res != PARAM_HELP_REQUESTED &&
+           res != PARAM_VERSION_INFO_REQUESTED &&
            res != PARAM_ENGINES_REQUESTED) {
           const char *reason = param2text(res);
           warnf(config, "%s:%d: warning: '%s' %s\n",