sasl: Fixed missing qop in the client's challenge-response message
authorSteve Holme <steve_holme@hotmail.com>
Sun, 11 May 2014 14:03:16 +0000 (15:03 +0100)
committerSteve Holme <steve_holme@hotmail.com>
Sun, 11 May 2014 13:48:28 +0000 (14:48 +0100)
Whilst the qop directive isn't required to be present in a client's
response, as servers should assume a qop of "auth" if it isn't
specified, some may return authentication failure if it is missing.

lib/curl_sasl.c

index d877eff..8a6b522 100644 (file)
@@ -533,9 +533,11 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
 
   /* Generate the response */
   response = aprintf("username=\"%s\",realm=\"%s\",nonce=\"%s\","
-                     "cnonce=\"%s\",nc=\"%s\",digest-uri=\"%s\",response=%s",
+                     "cnonce=\"%s\",nc=\"%s\",digest-uri=\"%s\",response=%s,"
+                     "qop=%s",
                      userp, realm, nonce,
-                     cnonce, nonceCount, uri, resp_hash_hex);
+                     cnonce, nonceCount, uri, resp_hash_hex,
+                     qop);
   if(!response)
     return CURLE_OUT_OF_MEMORY;