netrc: treat failure to find home dir same as missing netrc file
authorDan Fandrich <dan@coneharvesters.com>
Sat, 12 Jul 2014 18:19:34 +0000 (20:19 +0200)
committerDan Fandrich <dan@coneharvesters.com>
Sat, 12 Jul 2014 18:22:09 +0000 (20:22 +0200)
This previously caused a fatal error (with a confusing error code, at
that).

Reported by: Glen A Johnson Jr.

RELEASE-NOTES
lib/netrc.c

index cc50d41..bb4bcac 100644 (file)
@@ -57,6 +57,7 @@ This release includes the following bugfixes:
  o gnutls: fixed compilation against versions < 2.12.0
  o build: Fixed overridden compiler PDB settings in VC7 to VC12
  o ntlm_wb: Fixed buffer size not being large enough for NTLMv2 sessions [11]
+ o netrc: don't abort if home dir cannot be found
 
 This release includes the following known bugs:
 
index a1b00b2..a7a7101 100644 (file)
@@ -88,7 +88,7 @@ int Curl_parsenetrc(const char *host,
     }
 
     if(!home)
-      return -1;
+      return retcode; /* no home directory found (or possibly out of memory) */
 
     netrcfile = curl_maprintf("%s%s%s", home, DIR_CHAR, NETRC);
     if(home_alloc)