Kyungwook Tak [Tue, 5 Jul 2016 04:09:15 +0000 (13:09 +0900)]
Refine scan app delta
1) Logging more precisely
2) Add missing cases e.g., worse riskiest when history is exist and no new
malware detected and worse case exists
3) Remove useless param on judge stage: jHistory
jHistory is always same to history.
4) Insert worst when history riskiest case either because existing
history(worst) needs to be updated when the file is modified and
malware is detected samely.
5) Delete db row whenever the file is newly scanned regardless of new
malware detection from the file. It's for refreshing db row when file
is newly scanned.
Change-Id: Iba88c3e0ed96bd8413a10fcd9aa556edc7129f60
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 5 Jul 2016 06:52:37 +0000 (15:52 +0900)]
Merge branch 'sandbox/kwon/transaction' into devel
Change-Id: I5207e7e1a33a00c0ea47582b6456e2e35a9b8a43
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 5 Jul 2016 06:15:16 +0000 (15:15 +0900)]
Handle exception when open dir top dir in fs visitor
Change-Id: Ia9fc53a10ade30cfc64bf1c1ff861281c7d908d8
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 5 Jul 2016 04:58:19 +0000 (13:58 +0900)]
Ignore permission related exception on async scan
Change-Id: Ia2d1cbab672bf8d40b352a523bd902d4372a28ce
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 4 Jul 2016 09:18:59 +0000 (18:18 +0900)]
Handle cancel event not to be printed as error
Change-Id: Iabc4fd9abf7ceb52ce04f00d6688599e29c92d1c
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 4 Jul 2016 08:45:48 +0000 (17:45 +0900)]
Add cancel checker in scan app delta
For canceling faster while big app scanning
Change-Id: I935e2fa79c4ce213b2679aef4024c2bc0fc1109d
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 27 Jun 2016 06:30:53 +0000 (15:30 +0900)]
client-server conversation arch for async scan
Async operation process
AS-IS
1) getting scannable file list from server
2) dispatch scan file operation per item in list
TO-BE
1) dispatch async scanning with files/dirs list by client
2) Client receives event only when malware detected by server
unless file scanned callback is registered.
IPC time is much more lower than before because IPC isn't needed
for file scanned without malware when callback isn't registered.
Memory usage on client side is much less than before because client
doesn't receive a bunch of scannable file list.
Client only receives event when callback call needed or operation completed.
Change-Id: I0c913a2fbdf75c2abe99cdf6d757fdb0f264145d
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Fri, 24 Jun 2016 05:17:12 +0000 (14:17 +0900)]
Add transacion on database
Change-Id: Ie752f3cba3dd88d917a4f08b75cfa9b124533dcc
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>
Kyungwook Tak [Fri, 1 Jul 2016 05:47:31 +0000 (14:47 +0900)]
Fix bug in file visitor target handler
Continue for loop without call recursive for target
Change-Id: Ibda767ddecfe6582cb02fbc9585cacc35f87894d
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Fri, 1 Jul 2016 01:49:15 +0000 (10:49 +0900)]
Don't check malware history before scan single file
Overhead to check db for all scan request is bigger than scan file. So
we check history for getting ignored flag only when file scan finished
and it has detected malware.
Change-Id: Iac391e33069cbff46cd94588837d1f0ceb813c05
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Fri, 1 Jul 2016 01:48:31 +0000 (10:48 +0900)]
Fix insert name query not to replace
Change-Id: I546649837c647cda53ddab97904be5ebf8c43ae9
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Tue, 28 Jun 2016 07:57:16 +0000 (16:57 +0900)]
Refactor scanAppDelta on cs-logic
Change-Id: Iacbc2504b763e754df8b6cff666e4677089a03bf
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>
Kyungwook Tak [Thu, 30 Jun 2016 08:43:45 +0000 (17:43 +0900)]
Upgrade version to 2.1.1
Change-Id: I3ac0a00d2dd239101828bd10289e5d9372aca664
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Wed, 29 Jun 2016 08:31:59 +0000 (17:31 +0900)]
Change file visitor to dfs style not to have queue
Change-Id: I2bb154ce573468cbaab8fb0d32aae8f0e746ef20
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 28 Jun 2016 10:18:14 +0000 (19:18 +0900)]
Refactor file & file visitor classes
Remove duplicated call of checking file's status e.g.,
pkgmgr_is_preloaded, ::stat(), regex...
And Make flag for file visitor to turn on and off of visiting inside of
package path
Change-Id: Ib80a2145f27d9951168951043ef600efcd2e1b87
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Wed, 22 Jun 2016 08:45:33 +0000 (17:45 +0900)]
Add cache to database for consistent
Change-Id: I75e5ecb82d0165210e48e35825f3812426e57c0c
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>
Kyungwook Tak [Tue, 28 Jun 2016 00:55:21 +0000 (09:55 +0900)]
Checks Service idle with client connection
Change-Id: Iba6c0d725e98d5c5e8e81252873923278bd0d194
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 27 Jun 2016 10:05:54 +0000 (19:05 +0900)]
Restore data_version usage from db schema
Change-Id: I6677a821eb1ecf545b902f4f872790d76807e728
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 27 Jun 2016 04:23:55 +0000 (13:23 +0900)]
Malware data deprecation
Data deprecation based on engine latest update time which is provided by
engine API(csre_cs_engine_latest_update_time)
Change-Id: I8f2b9a2118a2b575493b786c149e70bd93ba9e48
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Fri, 24 Jun 2016 08:24:45 +0000 (17:24 +0900)]
Check dir exist before mkdir
Change-Id: I192598839997327d468d5285745aacd6f2f6da4b
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>
Kyungwook Tak [Fri, 24 Jun 2016 06:41:47 +0000 (15:41 +0900)]
Fix svace defects
dead code on db manager
dereferencing nullable pointer on cs logic
Change-Id: Iec1b9f9f9fb329566a4b6d96e4cd129e87c70087
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Fri, 24 Jun 2016 05:39:37 +0000 (14:39 +0900)]
Turn on with_sample_engine build flag
On platform, test program is based on sample engine and it's included in
test rpm so real binary isn't affected
Change-Id: Icec4fcddb7270139ff3e42d4477f15c07eef2950
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Fri, 24 Jun 2016 06:06:14 +0000 (15:06 +0900)]
Change assertion order in ASSERT_CALLBACK
Not to misunderstand callback counts mismatch.
Order it on importance.
Change-Id: I75c5756bf40a03a01f1bcb4c964837653fba834c
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Fri, 24 Jun 2016 06:16:19 +0000 (15:16 +0900)]
Add did on popup-string
Change-Id: Icbc7449981f46c1a535596625781ddb9f5cab491
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>
sangwan.kwon [Fri, 24 Jun 2016 05:18:59 +0000 (14:18 +0900)]
Additional cancel operation check on client
Change-Id: Ia0525972e026ad0f0dc08a17872542982a43592d
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>
Kyungwook Tak [Fri, 24 Jun 2016 02:17:10 +0000 (11:17 +0900)]
Cancel async operation on both of server/client side
Change-Id: I5c5ee328c2ef7e18287b0ab298620cc3df97d4c7
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 23 Jun 2016 01:24:12 +0000 (10:24 +0900)]
Upgrade version to 2.1.0
Change-Id: I979832de47a0835d2ea05ac6a13593bed35210f4
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Dongsun Lee [Thu, 23 Jun 2016 01:09:56 +0000 (10:09 +0900)]
change module name from csr-framework to csr in doxygen
Change-Id: Id732b7adc973307f8775d85a22f8b11061fa18ef
Signed-off-by: Dongsun Lee <ds73.lee@samsung.com>
Kyungwook Tak [Wed, 22 Jun 2016 10:23:59 +0000 (19:23 +0900)]
Make thread-safe of hasPermission() with cynara
cynara is not thread-safe so locking mechanism is needed on our side.
Change-Id: Ica0105dc74a9bd3d76e73339d82831181c1469db
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Wed, 22 Jun 2016 09:42:59 +0000 (18:42 +0900)]
Make more log levels on exception
Change-Id: Idad383a7b0f757f263138efb7bf601d66d67b2b8
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Wed, 22 Jun 2016 05:26:13 +0000 (14:26 +0900)]
Handle pre-loaded app in file-unit
Change-Id: Id3d4973448f3f27aa3fb9beb31bb05868c9fe4b8
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 21 Jun 2016 05:45:54 +0000 (14:45 +0900)]
Separate install/upgarde case on %post
Change-Id: If31d22c00cf26f1ad5e6e98142c370d1312f3030
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Tue, 21 Jun 2016 04:06:35 +0000 (13:06 +0900)]
Set popup failed return value as negative number
Change-Id: Ia9dcf4d1d28cf821aa225f5c4c122d297716e32c
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>
Kyungwook Tak [Tue, 21 Jun 2016 04:14:04 +0000 (13:14 +0900)]
Add description for CSR_ERROR_USER_RESPONSE_FAILED
Change-Id: I963881ec783e2cca2aae015a2c2fef17ddaa4f7a
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 21 Jun 2016 00:07:31 +0000 (09:07 +0900)]
Add smack rules for scanning more files
Change-Id: I7acf5f03002674a7a3a35984060e457fcefd6ade
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 21 Jun 2016 01:50:22 +0000 (10:50 +0900)]
[CAPI Changed] Add ec for getting user response failed
Change-Id: I5b9b66a0a07a54469ba77631f59553a28760ade6
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 21 Jun 2016 00:58:42 +0000 (09:58 +0900)]
Clean up csr db before start service
Change-Id: Ie69c009af831a18bd5de21c96faae1e8e014ee7a
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Tue, 21 Jun 2016 00:46:57 +0000 (09:46 +0900)]
Grab the home key event
* If home key pressed, popup should exit.
Change-Id: I20b3fb316bd1930284565bc9f683f17a83dbedcd
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>
sangwan.kwon [Mon, 20 Jun 2016 08:25:24 +0000 (17:25 +0900)]
Enable popup to rotate
* If window manger support rotation, enable popup to rotate
Change-Id: I37d0baa20c1d623970949bd0685b3dd8923d1804
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>
Kyungwook Tak [Fri, 17 Jun 2016 10:59:55 +0000 (19:59 +0900)]
Add test case for multiple async simultaneously
Change-Id: I5de084beca6698591913ee905ebb09187593f030
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Fri, 17 Jun 2016 10:31:53 +0000 (19:31 +0900)]
Make thread-safe for db manager functions
Change-Id: I175c7be11fb98502a57dc7c81bbfc9ee1bb8527d
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Fri, 17 Jun 2016 06:33:15 +0000 (15:33 +0900)]
Assertion changed for added test malware file
Change-Id: I90a7893272b0e9c4fa536554227ee41943fd4d17
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Fri, 17 Jun 2016 06:04:25 +0000 (15:04 +0900)]
Change thread-pool to static for stability
Change-Id: I0ace06b0cefcdbbcf97d23e31893a870fb300ee1
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Wed, 15 Jun 2016 08:49:28 +0000 (17:49 +0900)]
Adjust multilingual resource
* This is for supporting different languages.
Change-Id: Ia5ffd15712f84e207c43f6c51060dc7f7b07e889
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>
Kyungwook Tak [Thu, 16 Jun 2016 10:08:40 +0000 (19:08 +0900)]
Return detected handle when remove failed
Change-Id: Ie8c8f5adec67769336a55532940c9014770214fb
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Thu, 16 Jun 2016 02:26:45 +0000 (11:26 +0900)]
Fix layout for resolution independent
Change-Id: I7647cd41233427572f6e149ff93b9f2015b3bdaa
Kyungwook Tak [Thu, 16 Jun 2016 05:50:57 +0000 (14:50 +0900)]
Remove useless stopped lamda registering in async-client
No custom isStopped() lamda will be registered at all so this
functionality isn't needed.
Change-Id: Iade85a824a72e36ff4f2a4a4c9a1e838611d1697
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 16 Jun 2016 05:25:46 +0000 (14:25 +0900)]
Move async test lock into ASSERT_CALLBACK
Not to miss to wait async operation.
Change-Id: I44571a33afa7d6d64636259c108a27cf3e038ccf
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 14 Jun 2016 02:16:18 +0000 (11:16 +0900)]
Handling history detected by scan on cloud
Add table to db schema to manage separately to ordinary app scanning.
It's for giving detected/ignored/judge malwares because those work based
on history in db.
Change-Id: I78fec4b61ed7838298ec156dc2452ed7c4e64c6c
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 16 Jun 2016 04:48:46 +0000 (13:48 +0900)]
Fix assert check on delta scan test
To exclude probability of other file changed in the directory case,
checking scanned count more precisely.
Change-Id: If050ddf2b6eb6a1e453b8fa678a88357bf29e2b3
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Wed, 15 Jun 2016 07:22:04 +0000 (16:22 +0900)]
Fix test-resource and permissions on platform v3.0
Change-Id: Ifc41778f138b7cebf981cda662279434878daf28
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Wed, 15 Jun 2016 07:20:10 +0000 (16:20 +0900)]
Change db schema of package_info table
pkg_id cannot be used as primary key because the case of symlink exist
in package path. On symlink existing case, pkg id will be same on both
of symlink path and original path(resolved path) so it could be conflict
on package_info table with same pkg_id.
Change-Id: Iaf9580c5979ad6bcb32170743d47c34602295c16
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 14 Jun 2016 08:08:28 +0000 (17:08 +0900)]
File readable check by ::fopen instead of ::access
To adjust CAP_DAC_READ_SEARCH capability for scanning app directory in
platform v3.0, we cannot use ::access. Because the capability isn't
giving permission to force out all of DAC checking, but it just bypass
to check it. So if it's checked explicitly by ::access, we cannot
bypass. So we use ::fopen with "rb" mode instead.
Change-Id: If9c79f28978ab95b607f4bffbb605f57b8b51fa9
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 14 Jun 2016 07:43:48 +0000 (16:43 +0900)]
Multi user aware when getting pkg info handle
Change-Id: Ia3746304891954471d8981ed2bea2479c1967aaa
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Dongsun Lee [Tue, 14 Jun 2016 06:43:01 +0000 (15:43 +0900)]
change a malware file in app packaging to eicar.txt
Change-Id: I57ef5162cb0e752028ae412dced30b0d4e13874f
Signed-off-by: Dongsun Lee <ds73.lee@samsung.com>
Kyungwook Tak [Mon, 13 Jun 2016 11:15:59 +0000 (20:15 +0900)]
Remove useless sleeps in async cancel test
Change-Id: Icd60ef7c1e599182ea4d9d184d25febdc5961962
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 13 Jun 2016 08:38:58 +0000 (17:38 +0900)]
Add "/smack" to dir blacklist
/smack/cipso occurs unknown error from engine
Change-Id: Id0b55ceb768b6a71c65e88438e91411ad30ffcb7
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 13 Jun 2016 08:22:02 +0000 (17:22 +0900)]
Built in engine error exception converter to iloader
to convert engine internal error to string(by loaded symbol), engine
error exception converter need to loader instance so it's better to be
built in iloader virtual function for being used by both of cs / wp
loaders.
Change-Id: I382344d0b787f2863ca7e2853eb72601bae8b76a
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 13 Jun 2016 06:41:37 +0000 (15:41 +0900)]
Tracking tizen version by rpm spec macro
Change-Id: Ia115b1e800e42d25a4f2158431012620686d84f2
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Mon, 13 Jun 2016 06:54:56 +0000 (15:54 +0900)]
Add anchor attribute at hypertext
This is for launching browser when hypertext clicked.
Change-Id: I49cc34379ab59d8ff3d5793b5b43046d92fc7e76
Kyungwook Tak [Mon, 13 Jun 2016 06:13:19 +0000 (15:13 +0900)]
Change assert to warn on init state on test
Change-Id: Iccbdb614c48ef1036a7cf8bd1b439a0a162a6103
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 13 Jun 2016 06:13:58 +0000 (15:13 +0900)]
FixBug: error handling in async logics in content-screening.cpp
After error, exception should be thrown. If async task returned
normally, it's considered as success case and completed callback called.
Change-Id: I929ccc8c1e5ee124f74a8588a927b07f453b673a
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 13 Jun 2016 05:42:37 +0000 (14:42 +0900)]
Wait to start async client subthread until api returned
For robust calling registered callbacks, wait to start async client
subthread until api returned, controlled by handle-ext mutex lock.
Some client gets undefined behavior when registered callback called
earlier than returning async API...
Change-Id: I31ac4596cb43d2b67b9fe8095ed2a4c98779e17e
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 13 Jun 2016 05:03:05 +0000 (14:03 +0900)]
Don't allocate/construct additional std::string
file visitor is one of the most frequently running part of program so it
needed to being downsized is highly recommended
Change-Id: Ib317b9420329b1ad25b4db6310d3cce53b39f95f
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Mon, 13 Jun 2016 05:06:20 +0000 (14:06 +0900)]
Add dir blacklist which are excluded from scanning
Some files (procfs, sysfs) can occur undefined behavior when file
opened. Like sensor device file, it's blocked when file just opened.
File opening/reading could be differently implemented by engine in lower
layer of csr daemon so we cannot control all of them.
Change-Id: I157e3c21bb8e1c9e3b0afe9fbe65f97ad6eefefb
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Mon, 13 Jun 2016 02:48:58 +0000 (11:48 +0900)]
Delete only parent obejct in popup destructor
* In efl, if parent object deleted then child objects also deleted
automatically.
Change-Id: I21d8a6084fadb0a9c5b8293b1ee5f562bb9c2ffe
sangwan.kwon [Fri, 10 Jun 2016 09:09:17 +0000 (18:09 +0900)]
Refine label layout for multi-line
Change-Id: Id55fec0bb1c9d6d780f05a51aaa754955ea6acdd
Kyungwook Tak [Fri, 10 Jun 2016 08:04:03 +0000 (17:04 +0900)]
Add file io error handling in sample engine
Change-Id: I7dcf87abad15983444ca1595bce306612849f7d6
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Fri, 10 Jun 2016 07:57:14 +0000 (16:57 +0900)]
Skip errored directory on file system visitor
Silently skip unable to read directory stream to reduce side-effect to
whole other directories.
Change-Id: Ied216e0efcb0598251f5f7fad8d7f9abdabd17b6
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Thu, 9 Jun 2016 15:17:37 +0000 (00:17 +0900)]
Add webview when "More information" pressed
Change-Id: If0995f5652e791ae41b90a7f6f8ec9dd8341ffb6
Kyungwook Tak [Fri, 10 Jun 2016 05:54:21 +0000 (14:54 +0900)]
Disable test resources reset function
service cannot be restarted on both of platform v 2.4 and 3.0.
On 2.4, there's undefined behaviour when systemctl restart called.
On 3.0, test program should be run as "owner" user but it doesn't have
permission to restart system service.
Change-Id: I233a78fb81b1fc5a3835d7c013391e91c106d6b3
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Fri, 10 Jun 2016 05:51:52 +0000 (14:51 +0900)]
Use std::string on test function param
resource paths could be converted to std::string to support both of
platform v 2.4 & 3.0 by generate paths dynamically.
For this, test assertion functions need to receive std::string() param
for not to use '.c_str()' member function of std::string to all of
callers.
Change-Id: I3780673a757204fea7be1846726e8f15f14c449b
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Fri, 10 Jun 2016 04:47:09 +0000 (13:47 +0900)]
Don't check whether file is removable
Client will get remove failed error code from csr_cs_judge_detected_malware
if the target is unremovable
Change-Id: Ic73ea49459afcc0407766a1d065dd92f262a3155
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Fri, 10 Jun 2016 02:17:06 +0000 (11:17 +0900)]
Don't return malware handle when the file removed
Change-Id: I61aadc3b3a8db53bf57fedd131548429c51b2ac3
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 9 Jun 2016 10:55:46 +0000 (19:55 +0900)]
Add smack rule for accessing sd card
Change-Id: I1da30843d179ffc84e47cf7a819de5f539ff6265
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 9 Jun 2016 05:00:48 +0000 (14:00 +0900)]
Add warn_if on test
Change-Id: I7a066ad8509bdeb1f0afe4afd5a8ff6b3b39d80a
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 9 Jun 2016 09:12:06 +0000 (18:12 +0900)]
Add TC on content screening async
Change-Id: Id72a3f05730b603e64c827393e92e6f4417db0cc
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 9 Jun 2016 09:06:59 +0000 (18:06 +0900)]
Call callbacks only when callable on async client
Change-Id: Iadb78263064e8ef71cccfebf607a55341275d06e
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 9 Jun 2016 06:26:19 +0000 (15:26 +0900)]
Support test app management on tizen v 3.0
Change-Id: Ib5b99dcbc3ae021ca5c1bee53b78be88f6b654e8
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 9 Jun 2016 07:56:49 +0000 (16:56 +0900)]
Define pie option for ASLR properly
link flags cannot be defined on source's property setter
Change-Id: I32e8cb7e25f54ddd13149902ec7ae695e7125cc6
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Wed, 8 Jun 2016 08:38:06 +0000 (17:38 +0900)]
Move test resource pkgs to give floor label
Change-Id: Ic815a2b3b4fda4a818c996af493b4962b1bd86a1
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 9 Jun 2016 06:16:52 +0000 (15:16 +0900)]
Connection on onMessageProcess captured as copy
Connection can be abnormally closed by the peer and with
std::shared_ptr<Connection> &, it's hardly guarantee validity of the
reference. So we capture std::shared_ptr<Connection> as copy so
increment shared pointer's reference so as to guarantee validity of
connection. Catch exceptions when using connection in process of
onMessageProcess because the connection could be already closed by the
peer.
Change-Id: I391bae78cf663b875b96124f8356d27a38a97dc6
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 9 Jun 2016 06:20:39 +0000 (15:20 +0900)]
Fix order of params in ASSERT_IF
expected value should follows actual value
Change-Id: Icdc2dfca7f4ebdafd0f23349d8b31f24a7abc78b
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 9 Jun 2016 04:06:34 +0000 (13:06 +0900)]
Fix malware file to standard virus signature
Change-Id: If9a29eb9c90ce22ea9c5f734874c5a41106dad83
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Thu, 9 Jun 2016 02:20:26 +0000 (11:20 +0900)]
Add smack rule for dbus
Change-Id: Ia1d48b6c587489d92798e6a50a6fd674962d1f1f
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Dongsun Lee [Thu, 9 Jun 2016 00:03:02 +0000 (09:03 +0900)]
Sample engine build featuring
Change-Id: If874c62e3cb6de543a14b9fe37c5900b5d91f149
Signed-off-by: Dongsun Lee <ds73.lee@samsung.com>
Kyungwook Tak [Wed, 8 Jun 2016 08:00:54 +0000 (17:00 +0900)]
User-aware when detect app on platform v 3.0
Change-Id: I95456b49727481578a29230ea0fa2da09bb5a1a3
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Wed, 8 Jun 2016 07:27:52 +0000 (16:27 +0900)]
Canonicalize paths on db history getters
Change-Id: Icdf4a1487df644ac662469d1af4729766c17c739
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Dongsun Lee [Wed, 8 Jun 2016 22:55:48 +0000 (07:55 +0900)]
add smack rules for system::use_internet
Change-Id: I3741686846d046c45afff8228043f948a06d1104
Signed-off-by: Dongsun Lee <ds73.lee@samsung.com>
Dongsun Lee [Wed, 8 Jun 2016 13:25:49 +0000 (22:25 +0900)]
set CSR_STATE_ENABLE as a default value
Change-Id: I800d2ab47eb60c4a6f79b279f6b1cbd16a372339
Signed-off-by: Dongsun Lee <ds73.lee@samsung.com>
Kyungwook Tak [Wed, 8 Jun 2016 05:27:42 +0000 (14:27 +0900)]
Exclude symbol of mainloop/socket from common lib
Mainloop class and Socket class is used only as private member in other
classes in common lib so it could be hidden symbol.
Change-Id: Id32237cb00a9115fc84d95294e1846e3ddc341da
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Wed, 8 Jun 2016 04:50:58 +0000 (13:50 +0900)]
Fix not-following tizen coding rule cases
Checked by cpplint_tizen_160418.py
Change-Id: Ib33fd5aa3146df7b011061153df843ef884ff43c
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Wed, 8 Jun 2016 04:25:07 +0000 (13:25 +0900)]
Use custom resolvePath() instead of ::realpath()
::realpath() expands all symbolic links. When getting scannable file, we
have to focus on symbolic link itself because we cannot remove every
symbolic links when it comes to the regular file in scannable list even
though symbolic link path is in parameter.
Change-Id: If0d69419d9103a6ecff9ea56afdaa21b7e03613f
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Wed, 8 Jun 2016 02:17:51 +0000 (11:17 +0900)]
Fix bug: File read permission check is missed
when get stat of file, file read permission should be checked
additionally. ::stat() function doesn't require permission on the file
itself but require all permissions of the directories in path that lead
to the file.
Change-Id: Ia91c188fe20a90784ebad8109930ff3726f5ca72
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Wed, 8 Jun 2016 01:44:26 +0000 (10:44 +0900)]
Remove additional callback on new/close callback
On lower version of Tizen 3.0, crash occured here if callback not
callable(nullptr). We don't use this additional callback so for now just
remove this feature.
Change-Id: Ib378566b6f803749fe7735fb315474f5bd2c71b3
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 7 Jun 2016 06:58:29 +0000 (15:58 +0900)]
Check connection validation before write response
If client disconnect connection while server is handling the client's
request, server could write response to invalid connection by
connection->send() and crash occured. To prevent it, (client's abnormal
operation affect server) connection validation check is performed before
write on it.
Change-Id: I4c02fb0b40a6fd3a50e715a619334a3e290957f0
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 7 Jun 2016 08:08:00 +0000 (17:08 +0900)]
[CAPI description changed] The @a -> @a
Change-Id: Ie7664b6d92fb5774b7aae2ea186b11a117777756
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 7 Jun 2016 06:27:44 +0000 (15:27 +0900)]
Check & Clean all TODOs.
Socket::create added to divided domain socket creation and client socket
connection easily.
Mutex locks in mainloop and service are not needed because callback
add/erase are done by single thread (main thread) only.
Change-Id: I56a18cb81218908f79e130186c11ec206955240c
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
Kyungwook Tak [Tue, 7 Jun 2016 05:51:51 +0000 (14:51 +0900)]
Hide symbol of common lib
Change-Id: I8fd63c172b13380ccf8e810fee7c25ebafef0813
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
sangwan.kwon [Tue, 7 Jun 2016 07:32:48 +0000 (16:32 +0900)]
Fix bug : popup does not show as proper size
[bug]
- CMakeList ADD_DEFINITION visibility problem
- It just add definition to source not CMakeList
[solve]
- change ADD_DEFINITION to SET
Change-Id: I9ef8e59b932c997f0030d261a5ec9d5c476e8a57
projects / platform / upstream / csr-framework.git / log