platform/upstream/coreclr.git
3 years agoFix TPA map hash calculation. (#288) tizen_5.5_tv
Mikhail Kurinnoi/AI Compiler Lab /SRR/Staff Engineer/Samsung Electronics [Thu, 25 Jun 2020 22:30:09 +0000 (01:30 +0300)]
Fix TPA map hash calculation. (#288)

* Fix TPA map hash calculation.

The point of issue is "the Turkish-I Problem". After locale changed, towupper() provide another result for "i" and different hash are calculated in case if file name have "i" letter.

* Regression test for #37910

4 years ago[Tizen] Reduce arm_phdr_cb call overhead accepted/tizen/5.5/unified/20200207.122745 submit/tizen_5.5/20200207.005700
JUNG DONG-HEON [Thu, 9 Jan 2020 07:38:00 +0000 (16:38 +0900)]
[Tizen] Reduce arm_phdr_cb call overhead

- Too many calls to arm_phdr_cb even though it get the same data.
- It caches an ARM_CB_DATA for libcoreclr.so, then reuse.

4 years agoFix GC heap corruption on ARM. (#1389) accepted/tizen/5.5/unified/20200121.031421 submit/tizen_5.5/20200120.050447
Anton Lapounov [Wed, 8 Jan 2020 10:12:25 +0000 (02:12 -0800)]
Fix GC heap corruption on ARM. (#1389)

The allocate_in_free code path in allocate_in_expanded_heap incorrectly calculated the large (double) alignment padding size when limiting the plug size (SHORT_PLUGS) if set_padding_on_saved_p was true:

    set_padding_in_expand (old_loc, set_padding_on_saved_p, pinned_plug_entry); // Sets the padding flag on the saved plug
    ...
    pad += switch_alignment_size (is_plug_padded (old_loc)); // Reads the padding flag from the old (different!) plug

That caused access violation during a later heap walk since the g_gc_pFreeObjectMethodTable pointer marking the gap was not placed at the right address.

Change-Id: I10a5fa443b3f5a614909983cd3c06d5420d22858

4 years ago[Tizen] RPM version of Tizen will be upgrade to 4.14.1.
Woongsuk Cho [Tue, 31 Dec 2019 04:59:26 +0000 (13:59 +0900)]
[Tizen] RPM version of Tizen will be upgrade to 4.14.1.

4 years agoChange bIsFree check in DacValidateMethodTable (#1086)
Dong-Heon Jung [Mon, 23 Dec 2019 19:11:43 +0000 (04:11 +0900)]
Change bIsFree check in DacValidateMethodTable (#1086)

Some commands of SOS validate a method table in DacValidateMethodTable.
In the function, it checks whether a method table is FreeObjectMethodTable or not with GetClass() value.
However, GetClass() should not be NULL. (There is an assert in GetClass())
In this patch, it compares pMT address with g_pFreeObjectMethodTable address only.

4 years ago[Tizen] add pie linker option to createdump
Woongsuk Cho [Thu, 12 Dec 2019 11:41:39 +0000 (20:41 +0900)]
[Tizen] add pie linker option to createdump

4 years agoHandle glibc sys/sysctl.h deprecation (#27048)
Omair Majid [Wed, 16 Oct 2019 09:25:29 +0000 (05:25 -0400)]
Handle glibc sys/sysctl.h deprecation (#27048)

glibc has deprecated sys/sysctl.h:

    In file included from /coreclr/src/pal/src/misc/sysinfo.cpp:32:
    /usr/include/sys/sysctl.h:21:2: error: "The <sys/sysctl.h> header is deprecated and will be removed." [-Werror,-W#warnings]
    #warning "The <sys/sysctl.h> header is deprecated and will be removed."
     ^
    1 error generated.

Fix that by preferring sysconf and only including sys/sysctl.h if
HAVE_SYSCONF is not true. This mirrors the order of the implementation
code in this file (sysinfo.cpp) which checks for HAVE_SYSCONF
before HAVE_SYSCTL.

Fixes #27008

4 years ago[Tizen] Use -mstackrealign to sync up with Tizen build changes accepted/tizen/5.5/unified/20191209.050154 accepted/tizen/unified/20191209.033621 submit/tizen/20191208.235929 submit/tizen_5.5/20191209.000009
Mikhail Kashkarov [Fri, 6 Dec 2019 15:57:11 +0000 (18:57 +0300)]
[Tizen] Use -mstackrealign to sync up with Tizen build changes

Tizen i586 now builds with -mstackrealign by default:

    "Realign the stack at entry. On the x86, the -mstackrealign option
    generates an alternate prologue and epilogue that realigns the
    run-time stack if necessary. This supports mixing legacy codes that
    keep 4-byte stack alignment with modern codes that keep 16-byte
    stack alignment for SSE compatibility. ..."

Change-Id: I36afd18998829f897c6b2b48687c4ae1d172b84b
Signed-off-by: Mikhail Kashkarov <m.kashkarov@partner.samsung.com>
4 years agoEnable NGEN for methods marked with AggressiveOptimization (#27259)
Dong-Heon Jung [Fri, 18 Oct 2019 00:23:51 +0000 (09:23 +0900)]
Enable NGEN for methods marked with AggressiveOptimization (#27259)

- Methods marked with AggressiveOptimization are not NGENed at all.
- The methods are compiled during the runtime with high JITC overhead.
- It makes launching time slower over 6% in our embedded systems.

4 years agoMark Relocation Section as NotNeeded (#25715)
Dong-Heon Jung [Fri, 30 Aug 2019 21:05:53 +0000 (06:05 +0900)]
Mark Relocation Section as NotNeeded (#25715)

- After relocation, relocation section in zap image is not necessary.
- Mark the section as NotNeeded by giving advice(madvise with MADV_DONTNEED)
- It reduces 120~150KB PSS in tizen sample apps.

4 years ago[Tizen] Use PTRACE_GETREGSET for any arch when creating dump accepted/tizen/unified/20191121.073401 submit/tizen/20191120.225954
Swift Kim [Mon, 18 Nov 2019 07:38:56 +0000 (16:38 +0900)]
[Tizen] Use PTRACE_GETREGSET for any arch when creating dump

Also ignore ptrace NT_FPREGSET failures for arm processes on aarch64
kernels. Fixes #25707.

4 years ago[Tizen] Add createdump to build output accepted/tizen/unified/20191120.034525 submit/tizen/20191119.101028
Sangwook Kim [Mon, 18 Nov 2019 01:20:57 +0000 (10:20 +0900)]
[Tizen] Add createdump to build output

4 years ago[Tizen] Add coreclr_preload_assembly to CoreCLR host API accepted/tizen/5.5/unified/20191031.004944 accepted/tizen/5.5/unified/mobile/hotfix/20201027.061818 accepted/tizen/unified/20191015.012049 submit/tizen/20191014.221258 submit/tizen_5.5/20191031.000006 submit/tizen_5.5_mobile_hotfix/20201026.185106 tizen_5.5.m2_release
Konstantin Baladurin [Fri, 5 Jul 2019 16:36:28 +0000 (19:36 +0300)]
[Tizen] Add coreclr_preload_assembly to CoreCLR host API

4 years ago[Tizen] mscorlib postscript to remove System.Private.CoreLib.dll.Backup accepted/tizen/unified/20191011.080124 submit/tizen/20191010.235421
Hyungju Lee [Thu, 10 Oct 2019 23:32:00 +0000 (08:32 +0900)]
[Tizen] mscorlib postscript to remove System.Private.CoreLib.dll.Backup

Change-Id: Ia495a61aa6495c3cf52cac167b34823ec90d3d9b

4 years ago[Tizen] Enable Tizen ASan runtime support
Vyacheslav Cherkashin [Fri, 19 Jul 2019 12:05:47 +0000 (15:05 +0300)]
[Tizen] Enable Tizen ASan runtime support

Enable libasansi.so support (libasan.so with switchable interceptors).

Change-Id: I9ee9b47b7beab55f036ffc0697ffab2583e9701c
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
4 years ago[Tizen] Implement ASan wrapper for Linux AMD64
Vyacheslav Cherkashin [Mon, 29 Jul 2019 16:02:37 +0000 (19:02 +0300)]
[Tizen] Implement ASan wrapper for Linux AMD64

Change-Id: I48446ce7c8771a4c75149512bb7d8a8cb3fae8e5
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
4 years ago[Tizen] Implement ASan wrapper for Linux ARM32
Vyacheslav Cherkashin [Mon, 22 Jul 2019 10:40:47 +0000 (13:40 +0300)]
[Tizen] Implement ASan wrapper for Linux ARM32

This commit implements wrappers that allow interception transitions
from managed to external unmanaged code (CIL -> native) and back
(native -> CIL). This allows enable/disable ASan during transitions.
Due to this, we sanitize only external code, which allows us to
achieve acceptable performance.

Change-Id: I53ecdc14d28f7210cd9e7f5bd4db0c8ef5ed81fc
Signed-off-by: Vyacheslav Cherkashin <v.cherkashin@samsung.com>
4 years ago[Tizen] Implement detecting of sanitized libraries
Andrey Drobyshev [Tue, 16 Jul 2019 12:23:18 +0000 (15:23 +0300)]
[Tizen] Implement detecting of sanitized libraries

Parse ".dynamic" section (ELF dynamic array tags) of the module being
added, find ".rel(a).plt" section and search it for presence of
'__asan_init' symbol.

Change-Id: Ie7cc4c818b791b5f00713b42ba15131325b8152c
Signed-off-by: Andrey Drobyshev <a.drobyshev@samsung.com>
4 years agoRemove VolatileLoad from code already under lock
Fadi Hanna [Wed, 2 Oct 2019 23:23:59 +0000 (16:23 -0700)]
Remove VolatileLoad from code already under lock

4 years agoUse VolaiteLoad to read counter
Fadi Hanna [Wed, 2 Oct 2019 18:52:09 +0000 (11:52 -0700)]
Use VolaiteLoad to read counter

4 years agoFix read ordering bug between buckets pointer and counter
Fadi Hanna [Wed, 2 Oct 2019 18:06:04 +0000 (11:06 -0700)]
Fix read ordering bug between buckets pointer and counter

4 years agoPrevent freeing of the profiler on process shutdown.
David Mason [Wed, 18 Sep 2019 20:19:36 +0000 (13:19 -0700)]
Prevent freeing of the profiler on process shutdown.

4 years agoRevert "bail if profiler is terminated"
David Mason [Wed, 18 Sep 2019 20:10:59 +0000 (13:10 -0700)]
Revert "bail if profiler is terminated"

This reverts commit a5339ba00e94b8cd0c85b67fa66944eabc4ec7ad.

4 years agobail if profiler is terminated
David Mason [Wed, 18 Sep 2019 09:57:27 +0000 (02:57 -0700)]
bail if profiler is terminated

4 years ago[Tizen] skip dotnet specific arguments in corerun
Konstantin Baladurin [Fri, 4 Oct 2019 16:45:44 +0000 (19:45 +0300)]
[Tizen] skip dotnet specific arguments in corerun

Now we use corerun to run corefx tests instead of dotnet, because last
one isn't available for Tizen/armel. So we need to skip dotnet specific
arguments, we patch corerun for it because Microsoft.DotNet.RemoteExecutor
tries to execute binary that it gets from /proc/self/maps, so we need a
binary that will behave like dotnet.

4 years agoBuild error fix on FEATURE_PREJIT=true
Swift Kim [Fri, 12 Jul 2019 06:50:08 +0000 (15:50 +0900)]
Build error fix on FEATURE_PREJIT=true

This fix is to update usages of SetupGcCoverage() under
FEATURE_PREJIT aligned to the signature change in #25261.

4 years ago[Linux/x86] Use ebp from current context during unwinding (#26789)
Konstantin Baladurin [Thu, 26 Sep 2019 17:06:57 +0000 (20:06 +0300)]
[Linux/x86] Use ebp from current context during unwinding (#26789)

pCurrentContextPointers in REGDISPLAY can contain NULLs so we need to use
ebp value from pCurrentContext. This patch contains following changes:

- GetRegdisplayFP returns ebp from pCurrentContext
- GetRegdisplayFP is used instead of *GetEbpLocation()
- Set##reg##Location also updates register value in pCurrentContext

4 years ago[Tizen] Add unsupported tests for arm
Konstantin Baladurin [Fri, 4 Oct 2019 16:22:07 +0000 (19:22 +0300)]
[Tizen] Add unsupported tests for arm

tracing/tracevalidation/tracelogging/tracelogging/tracelogging.sh

see tests/issues.targets

4 years ago[JIT/x86] Fix LinearScan::allocateRegisters (#26649)
Konstantin Baladurin [Fri, 13 Sep 2019 17:28:08 +0000 (20:28 +0300)]
[JIT/x86] Fix LinearScan::allocateRegisters (#26649)

Check for `lvLRACandidate` instead of `!lvDoNotEnregister` when checking whether `this` may be enregistered and has an Interval.

4 years agoLinux/x86: fix build (#26594)
Konstantin Baladurin [Mon, 9 Sep 2019 15:40:14 +0000 (00:40 +0900)]
Linux/x86: fix build (#26594)

4 years ago[Tizen] Pack test libs to coreclr-test
Gleb Balykov [Wed, 11 Sep 2019 13:53:14 +0000 (16:53 +0300)]
[Tizen] Pack test libs to coreclr-test

4 years ago[Tizen] PrecompileCommonGenerics to false
Hyungju Lee [Mon, 2 Sep 2019 04:11:37 +0000 (13:11 +0900)]
[Tizen] PrecompileCommonGenerics to false

Change-Id: I74b3686bf0caad35c2c7519f8e4ee4d8ad0412f3

4 years ago[Tizen] Disable missing test, which requires libhostpolicy.so to be missing
Gleb Balykov [Wed, 21 Aug 2019 15:51:08 +0000 (18:51 +0300)]
[Tizen] Disable missing test, which requires libhostpolicy.so to be missing

4 years ago[Tizen] Add unsupported tests: see tests/issues.targets
Gleb Balykov [Thu, 8 Aug 2019 15:35:27 +0000 (18:35 +0300)]
[Tizen] Add unsupported tests: see tests/issues.targets

4 years ago[Tizen] Replace new runtest.sh, which calls dotnet internally, with old runtest.sh
Gleb Balykov [Wed, 21 Aug 2019 16:47:37 +0000 (19:47 +0300)]
[Tizen] Replace new runtest.sh, which calls dotnet internally, with old runtest.sh

4 years ago[Tizen] Partially revert a6292a6.
Mikhail Kurinnoi [Mon, 19 Aug 2019 12:06:58 +0000 (15:06 +0300)]
[Tizen] Partially revert a6292a6.

NetcoreDBG depends from PAL functions.
Instead of SOS plugin, that use PAL static libs, debugger should be able
to operate with any runtime version and can't be statically linked to PAL.

4 years ago[Tizen] Update openssl-64bit version to 1.1
Hyungju Lee [Thu, 8 Aug 2019 00:26:45 +0000 (09:26 +0900)]
[Tizen] Update openssl-64bit version to 1.1

Change-Id: Icc69aa049a77c3adb961b00571765905d3494c70

4 years ago[Tizen] Enable IBCLogger
Hyungju Lee [Wed, 14 Aug 2019 00:41:44 +0000 (09:41 +0900)]
[Tizen] Enable IBCLogger

Change-Id: I39f7a8c07d7760493d2aae08750abce6139103c4

4 years agoadd access(2) call before dlopening files
Yaroslav Yamshchikov [Thu, 18 Jul 2019 10:14:14 +0000 (13:14 +0300)]
add access(2) call before dlopening files

4 years ago[Tizen] Precompile frequently used generic methods.
Kirill Frolov [Wed, 24 Jul 2019 10:39:34 +0000 (13:39 +0300)]
[Tizen] Precompile frequently used generic methods.

4 years agocorbbtprof: set byte alignment for CORBBTPROF structures (#25816)
Konstantin Baladurin [Tue, 23 Jul 2019 04:01:22 +0000 (07:01 +0300)]
corbbtprof: set byte alignment for CORBBTPROF structures (#25816)

Fix patch fixes SIGBUG that occurs due to unaligned read/write

4 years agoFail to explicitly tail call on x86 unix. (#25032)
Jarret Shook [Fri, 19 Jul 2019 04:07:08 +0000 (21:07 -0700)]
Fail to explicitly tail call on x86 unix. (#25032)

* Fail to explicitly tail call on x86 unix.

* Correctly return 100

* Correct return value

* Add noway assert in morphTailCall to avoid morphing slow tail calls on unix.

* Address feedback

4 years ago[Tizen] Disable jithost arena cache
Gleb Balykov [Fri, 2 Aug 2019 14:28:27 +0000 (17:28 +0300)]
[Tizen] Disable jithost arena cache

4 years ago[Tizen] Disable IBC Logger as a default
DongHeon Jung [Thu, 18 Jul 2019 08:28:55 +0000 (17:28 +0900)]
[Tizen] Disable IBC Logger as a default

- Profile information is collected by ibc logger.
  Hower it is not used and saved into profile file.
- The patch disables IBC logger which is enabled by default.
- It disables IBC logger only with ibclogger.h file.
  IBCLOGGER_ENABLED definition is only used in ibclogger files.

4 years agoFix a build error when IBCLOGGER_ENABLED is not defined (#25691)
Dong-Heon Jung [Wed, 17 Jul 2019 03:09:40 +0000 (12:09 +0900)]
Fix a build error when IBCLOGGER_ENABLED is not defined (#25691)

- Even if DACCESS_COMPILE or CROSSGEN_COMPILE is defined,
  coreclr can be built without IBCLOGGER_ENABLED definition.

4 years ago[Tizen] Define -DHAS_ADDRESS_SANITIZER for ASan build
Slava Barinov [Thu, 11 Jul 2019 13:25:46 +0000 (16:25 +0300)]
[Tizen] Define -DHAS_ADDRESS_SANITIZER for ASan build

This define turns on new and delete operators compatibility mode for build with
Address Sanitizer. It allows Tizen libasan to intercept operators and prevents
alloc-dealloc-mismatch errors.

Change-Id: If72b1d42dd99eaaf11d3cb1232006ee0e2e411c3
Signed-off-by: Slava Barinov <v.barinov@samsung.com>
4 years ago[Tizen] Remove -DFEATURE_GDBJIT=TRUE from spec file
Hyungju Lee [Wed, 3 Jul 2019 11:00:57 +0000 (20:00 +0900)]
[Tizen] Remove -DFEATURE_GDBJIT=TRUE from spec file

Change-Id: Ic0b8bfc8ab45284ecda5ab99e683224368e607f5

4 years ago[Tizen] Update Openssl version 1.0 to 1.1
Hyungju Lee [Mon, 17 Jun 2019 11:25:37 +0000 (20:25 +0900)]
[Tizen] Update Openssl version 1.0 to 1.1

Change-Id: Id37364dd5dec17ab5a7b60e14df78a4967b3f3b8

4 years ago[Tizen] Enable PGO for Linux/arm
Konstantin Baladurin [Thu, 18 Apr 2019 09:29:56 +0000 (12:29 +0300)]
[Tizen] Enable PGO for Linux/arm

4 years ago[Tizen] seperate PIC and PIE to fix x86_64 build error
Woongsuk Cho [Thu, 9 May 2019 09:02:22 +0000 (18:02 +0900)]
[Tizen] seperate PIC and PIE to fix x86_64 build error

4 years ago[Tizen] Add a library to retrieve memory regions for a coredump
Mateusz Moscicki [Wed, 10 Apr 2019 09:40:33 +0000 (11:40 +0200)]
[Tizen] Add a library to retrieve memory regions for a coredump

This is needed to save a minicoredump of .NET applications to allows
reconstruct managed stack by lldb and SOS plugin.

4 years ago[Tizen] update cscope files to be ignored
Hyungju Lee [Wed, 13 Mar 2019 00:28:54 +0000 (09:28 +0900)]
[Tizen] update cscope files to be ignored

Change-Id: Ia0e1c6aa651c4fd88dc58b901729896a7a27681d

4 years ago[Tizen] Change paths to ilasm/ildasm
swift.kim [Mon, 12 Nov 2018 08:26:48 +0000 (17:26 +0900)]
[Tizen] Change paths to ilasm/ildasm

4 years ago[Tizen] Rearrange executables among rpm pkgs
Hyungju Lee [Fri, 12 Oct 2018 02:13:04 +0000 (11:13 +0900)]
[Tizen] Rearrange executables among rpm pkgs

- `corerun` and `coreconsole` to `devel` pkg
- remove `extra` pkg and move symlinks in it.

Change-Id: I99cd26121d3c83242caf6f2418d686b3ffcc2828

4 years ago[Tizen] Enable RELRO protection
junghyuk.park [Wed, 25 Jul 2018 09:26:25 +0000 (18:26 +0900)]
[Tizen] Enable RELRO protection

4 years ago[Tizen] Add crossgen and coreconsole to coreclr package
junghyuk.park [Tue, 24 Jul 2018 04:21:26 +0000 (13:21 +0900)]
[Tizen] Add crossgen and coreconsole to coreclr package

- The coreclr-extra package is going to be eliminated soon.
- Symlinks to crossgen and coreconsole are created temporarily for graceful migration

4 years ago[Tizen] Provide symlinks to .NET version for compatibility
junghyuk.park [Thu, 12 Jul 2018 23:19:24 +0000 (08:19 +0900)]
[Tizen] Provide symlinks to .NET version for compatibility

This commit will be reverted soon when all dependent modules watch the symlink at '/usr/share/dotnet.tizen/netcoreapp'.

Change-Id: Ib2ebf62a5788e225a9e3354f53fadde282708700

4 years ago[Tizen] Add skipped testcase: superpmi
Hyeongseok Oh [Mon, 26 Jun 2017 07:12:08 +0000 (16:12 +0900)]
[Tizen] Add skipped testcase: superpmi

Skip JIT/superpmi/superpmicollect/superpmicollect.sh

4 years ago[Tizen] Add skipped testcase on TM1
Jiyoung Yun [Tue, 20 Jun 2017 06:09:10 +0000 (15:09 +0900)]
[Tizen] Add skipped testcase on TM1

Lists:
JIT.jit64.opt.cse.hugeSimpleExpr1.hugeSimpleExpr1
GC.Regressions.v2.0-rtm.494226.494226.494226
GC.Scenarios.ServerModel.servermodel.servermodel
JIT.jit64.opt.cse.HugeField1.HugeField1
JIT.jit64.opt.cse.HugeField2.HugeField2
JIT.jit64.opt.cse.hugeexpr1.hugeexpr1

4 years agoFix OOPStackUnwinderX86::Unwind crash when Eip is invalid
Igor Kulaychuk [Wed, 25 Apr 2018 18:31:59 +0000 (21:31 +0300)]
Fix OOPStackUnwinderX86::Unwind crash when Eip is invalid

4 years agoFix EECodeManager::GetAmbientSP on x86/Linux
Igor Kulaychuk [Fri, 20 Apr 2018 20:52:57 +0000 (23:52 +0300)]
Fix EECodeManager::GetAmbientSP on x86/Linux

4 years ago[Tizen] Provide a symlink to installed Microsoft.NETCore.App version
junghyuk.park [Wed, 4 Jul 2018 23:08:50 +0000 (08:08 +0900)]
[Tizen] Provide a symlink to installed Microsoft.NETCore.App version

The symlink is added to provide consistent access to installed Microsoft.NETCore.App version.
'/usr/share/dotnet.tizen/netcoreapp' is linked to '/usr/share/dotnet/shared/Microsoft.NETCore.App/2.1.0'.

4 years ago[Tizen] Add -pie to linker option
Hyungju Lee [Mon, 2 Jul 2018 00:28:08 +0000 (09:28 +0900)]
[Tizen] Add -pie to linker option

There have been no -pie linker option.
This patch adds -pie linker option into crossgen(for tizen)

This originates from 0024-Add-pie-to-linker-option.patch

4 years ago[Tizen] Enable -O3 optimization in clang 3.8
junghyuk.park [Mon, 25 Jun 2018 10:01:00 +0000 (19:01 +0900)]
[Tizen] Enable -O3 optimization in clang 3.8

4 years ago[Tizen] Add support for GBS
junghyuk.park [Mon, 25 Jun 2018 09:47:41 +0000 (18:47 +0900)]
[Tizen] Add support for GBS

4 years ago[Tizen] Add BuildTools v3.0.0
Konstantin Baladurin [Mon, 23 Sep 2019 18:46:25 +0000 (21:46 +0300)]
[Tizen] Add BuildTools v3.0.0

4 years ago[Tizen] Add prebuilt libicu-57.1 libraries
junghyuk.park [Mon, 25 Jun 2018 07:03:57 +0000 (16:03 +0900)]
[Tizen] Add prebuilt libicu-57.1 libraries

4 years agoFix watson bucketing/broken triage dumps (#26670)
Mike McLaughlin [Thu, 12 Sep 2019 22:39:39 +0000 (15:39 -0700)]
Fix watson bucketing/broken triage dumps (#26670)

Fix watson bucketing/broken triage dumps

The DAC EnumMemoryRegions needs to include some missing code version
manager memory.

4 years agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Thu, 12 Sep 2019 14:37:27 +0000 (14:37 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190912.1 (#26681)

- optimization.IBC.CoreCLR - 99.99.99-master-20190912.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190912.1

4 years agoUpdate dependencies from https://github.com/dotnet/corefx build 20190911.13 (#26680)
dotnet-maestro[bot] [Thu, 12 Sep 2019 14:30:47 +0000 (14:30 +0000)]
Update dependencies from https://github.com/dotnet/corefx build 20190911.13 (#26680)

- Microsoft.NETCore.Platforms - 3.0.0-rc2.19461.13
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc2.19461.13

4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190911.7 (#26679)
dotnet-maestro[bot] [Thu, 12 Sep 2019 14:15:05 +0000 (14:15 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20190911.7 (#26679)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19461.7
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19461.7
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19461.7
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19461.7

4 years agoUpdate dependencies from https://github.com/dotnet/core-setup build 20190910.02 ...
dotnet-maestro[bot] [Wed, 11 Sep 2019 16:44:04 +0000 (16:44 +0000)]
Update dependencies from https://github.com/dotnet/core-setup build 20190910.02 (#26655)

- Microsoft.NETCore.App - 3.0.0-rc2-19460-02

4 years agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Wed, 11 Sep 2019 16:23:39 +0000 (16:23 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190911.1 (#26654)

- optimization.IBC.CoreCLR - 99.99.99-master-20190911.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190911.1

4 years agoUpdate dependencies from https://github.com/dotnet/corefx build 20190910.22 (#26653)
dotnet-maestro[bot] [Wed, 11 Sep 2019 14:32:11 +0000 (14:32 +0000)]
Update dependencies from https://github.com/dotnet/corefx build 20190910.22 (#26653)

- Microsoft.NETCore.Platforms - 3.0.0-rc2.19460.22
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc2.19460.22

4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190910.3 (#26622)
dotnet-maestro[bot] [Wed, 11 Sep 2019 00:41:31 +0000 (00:41 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20190910.3 (#26622)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19460.3
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19460.3
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19460.3
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19460.3

4 years ago[release/3.0] Update dependencies from dotnet/core-setup (#26563)
dotnet-maestro[bot] [Tue, 10 Sep 2019 19:31:04 +0000 (19:31 +0000)]
[release/3.0] Update dependencies from dotnet/core-setup (#26563)

* Update dependencies from https://github.com/dotnet/core-setup build 20190905.28

- Microsoft.NETCore.App - 3.0.0-rc2-19455-28

* Update dependencies from https://github.com/dotnet/core-setup build 20190907.02

- Microsoft.NETCore.App - 3.0.0-rc2-19457-02

* Update dependencies from https://github.com/dotnet/core-setup build 20190907.15

- Microsoft.NETCore.App - 3.0.0-rc2-19457-15

* Update dependencies from https://github.com/dotnet/core-setup build 20190908.11

- Microsoft.NETCore.App - 3.0.0-rc2-19458-11

* Update dependencies from https://github.com/dotnet/core-setup build 20190909.40

- Microsoft.NETCore.App - 3.0.0-rc2-19459-40

4 years agoUpdate dependencies from https://github.com/dotnet/corefx build 20190910.1 (#26616)
dotnet-maestro[bot] [Tue, 10 Sep 2019 19:13:53 +0000 (19:13 +0000)]
Update dependencies from https://github.com/dotnet/corefx build 20190910.1 (#26616)

- Microsoft.NETCore.Platforms - 3.0.0-rc2.19460.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc2.19460.1

4 years agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Tue, 10 Sep 2019 18:59:49 +0000 (18:59 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190910.1 (#26617)

- optimization.IBC.CoreCLR - 99.99.99-master-20190910.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190910.1

4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190909.10 (#26615)
dotnet-maestro[bot] [Tue, 10 Sep 2019 14:04:47 +0000 (14:04 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20190909.10 (#26615)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19459.10
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19459.10
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19459.10
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19459.10

4 years ago[release/3.0] Update dependencies from dotnet/arcade (#26560)
dotnet-maestro[bot] [Mon, 9 Sep 2019 17:13:03 +0000 (10:13 -0700)]
[release/3.0] Update dependencies from dotnet/arcade (#26560)

* Update dependencies from https://github.com/dotnet/arcade build 20190905.21

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19455.21
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19455.21
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19455.21
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19455.21

* Update dependencies from https://github.com/dotnet/arcade build 20190906.10

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19456.10
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19456.10
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19456.10
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19456.10

* Update dependencies from https://github.com/dotnet/arcade build 20190907.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19457.1
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19457.1
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19457.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19457.1

* Update dependencies from https://github.com/dotnet/arcade build 20190908.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19458.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19458.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19458.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19458.2

4 years ago[release/3.0] Update dependencies from dotnet/corefx (#26561)
dotnet-maestro[bot] [Mon, 9 Sep 2019 17:12:38 +0000 (10:12 -0700)]
[release/3.0] Update dependencies from dotnet/corefx (#26561)

* Update dependencies from https://github.com/dotnet/corefx build 20190906.1

- Microsoft.NETCore.Platforms - 3.0.0-rc2.19456.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc2.19456.1

* Update dependencies from https://github.com/dotnet/corefx build 20190907.2

- Microsoft.NETCore.Platforms - 3.0.0-rc2.19457.2
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc2.19457.2

* Update dependencies from https://github.com/dotnet/corefx build 20190907.8

- Microsoft.NETCore.Platforms - 3.0.0-rc2.19457.8
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc2.19457.8

* Update dependencies from https://github.com/dotnet/corefx build 20190908.3

- Microsoft.NETCore.Platforms - 3.0.0-rc2.19458.3
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc2.19458.3

4 years ago[release/3.0] Update dependencies from dnceng/internal/dotnet-optimization (#26588)
dotnet-maestro[bot] [Mon, 9 Sep 2019 17:10:33 +0000 (10:10 -0700)]
[release/3.0] Update dependencies from dnceng/internal/dotnet-optimization (#26588)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190908.1

- optimization.IBC.CoreCLR - 99.99.99-master-20190908.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190908.1

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190909.1

- optimization.IBC.CoreCLR - 99.99.99-master-20190909.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190909.1

4 years agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Fri, 6 Sep 2019 01:12:40 +0000 (01:12 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190905.1 (#26528)

- optimization.IBC.CoreCLR - 99.99.99-master-20190905.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190905.1

4 years agorc2 version updated (#26548)
Anirudh Agnihotry [Thu, 5 Sep 2019 23:36:54 +0000 (16:36 -0700)]
rc2 version updated (#26548)

4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190904.31 (#26526)
dotnet-maestro[bot] [Thu, 5 Sep 2019 20:38:10 +0000 (20:38 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20190904.31 (#26526)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19454.31
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19454.31
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19454.31
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19454.31

4 years agoUpdate dependencies from https://github.com/dotnet/core-setup build 20190905.02 ...
dotnet-maestro[bot] [Thu, 5 Sep 2019 15:01:02 +0000 (15:01 +0000)]
Update dependencies from https://github.com/dotnet/core-setup build 20190905.02 (#26529)

- Microsoft.NETCore.App - 3.0.0-rc1-19455-02

4 years agoUpdate dependencies from https://github.com/dotnet/corefx build 20190904.13 (#26527)
dotnet-maestro[bot] [Thu, 5 Sep 2019 14:49:24 +0000 (14:49 +0000)]
Update dependencies from https://github.com/dotnet/corefx build 20190904.13 (#26527)

- Microsoft.NETCore.Platforms - 3.0.0-rc1.19454.13
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc1.19454.13

4 years ago[release/3.0] Update dependencies from dotnet/core-setup (#26464)
dotnet-maestro[bot] [Wed, 4 Sep 2019 18:27:39 +0000 (18:27 +0000)]
[release/3.0] Update dependencies from dotnet/core-setup (#26464)

* Update dependencies from https://github.com/dotnet/core-setup build 20190830.09

- Microsoft.NETCore.App - 3.0.0-rc1-19430-09

* Update dependencies from https://github.com/dotnet/core-setup build 20190903.06

- Microsoft.NETCore.App - 3.0.0-rc1-19453-06

4 years ago[release/3.0] Update dependencies from dotnet/arcade (#26448)
dotnet-maestro[bot] [Wed, 4 Sep 2019 18:09:06 +0000 (18:09 +0000)]
[release/3.0] Update dependencies from dotnet/arcade (#26448)

* Update dependencies from https://github.com/dotnet/arcade build 20190829.16

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19429.16
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19429.16
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19429.16
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19429.16

* Update dependencies from https://github.com/dotnet/arcade build 20190830.3

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19430.3
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19430.3
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19430.3
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19430.3

* Update dependencies from https://github.com/dotnet/arcade build 20190903.5

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19453.5
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19453.5
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19453.5
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19453.5

4 years ago[release/3.0] Update dependencies from dotnet/corefx (#26328)
dotnet-maestro[bot] [Wed, 4 Sep 2019 14:19:29 +0000 (14:19 +0000)]
[release/3.0] Update dependencies from dotnet/corefx (#26328)

* Update dependencies from https://github.com/dotnet/corefx build 20190822.11

- Microsoft.NETCore.Platforms - 3.0.0-rc1.19422.11
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc1.19422.11

* Update dependencies from https://github.com/dotnet/corefx build 20190823.9

- Microsoft.NETCore.Platforms - 3.0.0-rc1.19423.9
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc1.19423.9

* Update dependencies from https://github.com/dotnet/corefx build 20190824.3

- Microsoft.NETCore.Platforms - 3.0.0-rc1.19424.3
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc1.19424.3

* Update dependencies from https://github.com/dotnet/corefx build 20190825.2

- Microsoft.NETCore.Platforms - 3.0.0-rc1.19425.2
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc1.19425.2

* Update dependencies from https://github.com/dotnet/corefx build 20190826.11

- Microsoft.NETCore.Platforms - 3.0.0-rc1.19426.11
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc1.19426.11

* Update dependencies from https://github.com/dotnet/corefx build 20190827.14

- Microsoft.NETCore.Platforms - 3.0.0-rc1.19427.14
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc1.19427.14

* Update dependencies from https://github.com/dotnet/corefx build 20190828.2

- Microsoft.NETCore.Platforms - 3.0.0-rc1.19428.2
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc1.19428.2

* Update dependencies from https://github.com/dotnet/corefx build 20190903.4

- Microsoft.NETCore.Platforms - 3.0.0-rc1.19453.4
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-rc1.19453.4

4 years ago[release/3.0] Update dependencies from dnceng/internal/dotnet-optimization (#26463)
dotnet-maestro[bot] [Mon, 2 Sep 2019 13:32:35 +0000 (13:32 +0000)]
[release/3.0] Update dependencies from dnceng/internal/dotnet-optimization (#26463)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190831.1

- optimization.IBC.CoreCLR - 99.99.99-master-20190831.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190831.1

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190902.1

- optimization.IBC.CoreCLR - 99.99.99-master-20190902.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190902.1

4 years agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Fri, 30 Aug 2019 14:16:05 +0000 (14:16 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190830.1 (#26449)

- optimization.IBC.CoreCLR - 99.99.99-master-20190830.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190830.1

4 years agoUpdate dependencies from https://github.com/dotnet/core-setup build 20190829.07 ...
dotnet-maestro[bot] [Fri, 30 Aug 2019 14:10:44 +0000 (14:10 +0000)]
Update dependencies from https://github.com/dotnet/core-setup build 20190829.07 (#26450)

- Microsoft.NETCore.App - 3.0.0-rc1-19429-07

4 years agoEmit RVA Instead of File Offset by Default in Native Image PerfMap Files (#26423)
Brian Robbins [Thu, 29 Aug 2019 17:06:48 +0000 (10:06 -0700)]
Emit RVA Instead of File Offset by Default in Native Image PerfMap Files (#26423)

4 years agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Thu, 29 Aug 2019 14:52:24 +0000 (14:52 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190829.1 (#26433)

- optimization.IBC.CoreCLR - 99.99.99-master-20190829.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190829.1

4 years ago[release/3.0] Update dependencies from dotnet/core-setup (#26414)
dotnet-maestro[bot] [Thu, 29 Aug 2019 14:47:17 +0000 (14:47 +0000)]
[release/3.0] Update dependencies from dotnet/core-setup (#26414)

* Update dependencies from https://github.com/dotnet/core-setup build 20190827.13

- Microsoft.NETCore.App - 3.0.0-rc1-19427-13

* Update dependencies from https://github.com/dotnet/core-setup build 20190828.14

- Microsoft.NETCore.App - 3.0.0-rc1-19428-14

4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20190828.9 (#26432)
dotnet-maestro[bot] [Thu, 29 Aug 2019 14:40:04 +0000 (14:40 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20190828.9 (#26432)

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19428.9
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19428.9
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19428.9
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19428.9

4 years agoUpdate dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimizati...
dotnet-maestro[bot] [Wed, 28 Aug 2019 23:41:49 +0000 (23:41 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20190828.1 (#26413)

- optimization.IBC.CoreCLR - 99.99.99-master-20190828.1
- optimization.PGO.CoreCLR - 99.99.99-master-20190828.1

4 years ago[release/3.0] Update dependencies from dotnet/arcade (#26327)
dotnet-maestro[bot] [Wed, 28 Aug 2019 16:03:51 +0000 (09:03 -0700)]
[release/3.0] Update dependencies from dotnet/arcade (#26327)

* Update dependencies from https://github.com/dotnet/arcade build 20190822.24

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19422.24
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19422.24
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19422.24
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19422.24

* Update dependencies from https://github.com/dotnet/arcade build 20190823.6

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19423.6
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19423.6
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19423.6
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19423.6

* Update dependencies from https://github.com/dotnet/arcade build 20190824.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19424.1
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19424.1
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19424.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19424.1

* Update dependencies from https://github.com/dotnet/arcade build 20190825.1

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19425.1
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19425.1
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19425.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19425.1

* Update dependencies from https://github.com/dotnet/arcade build 20190826.12

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19426.12
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19426.12
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19426.12
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19426.12

* Update dependencies from https://github.com/dotnet/arcade build 20190827.8

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19427.8
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19427.8
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19427.8
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19427.8

4 years agoReplace Ubuntu 1404 platforms with 1604 (#26302) (#26399)
Fadi Hanna [Tue, 27 Aug 2019 22:26:52 +0000 (15:26 -0700)]
Replace Ubuntu 1404 platforms with 1604 (#26302) (#26399)

Replace Ubuntu 1404 platforms with 1604 (#26302) (#26399)