dnsproxy: safely access server_list_sec for removing a list node

Safely access g_list, server_list_sec, by finding the next list
node before removing a list node from g_slist with g_list_remove().

Change-Id: Ia60a129605b53995726c98b945936d2b87dcb97a
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>

diff --git a/src/dnsproxy.c b/src/dnsproxy.c
index a84693e..8e3ce97 100755 (executable)
--- a/src/dnsproxy.c
+++ b/src/dnsproxy.c
@@ -2344,8 +2344,10 @@ static gboolean udp_server_event(GIOChannel *channel, GIOCondition condition,
 #if defined TIZEN_EXT
        GSList *list;
 
-       for (list = server_list_sec; list; list = list->next) {
+       list = server_list_sec;
+       while (list) {
                struct server_data *new_data = list->data;
+               list = list->next;
 
                if (new_data == data) {
                        destroy_server_sec(data);
@@ -2725,8 +2727,10 @@ static void destroy_all_server_sec()
 
        DBG("remove all dns server");
 
-       for (list = server_list_sec; list; list = list->next) {
+       list = server_list_sec;
+       while (list) {
                struct server_data *server = list->data;
+               list = list->next;
                destroy_server_sec(server);
        }
        server_list_sec = NULL;