service: A preferred service in state ready is good enough

Simplify the preferred service selection such that a connected
service is good enough, especially since a connecting service
will also terminate the search for the current preferred one.

diff --git a/src/service.c b/src/service.c
index 5dee4cd..712aa9a 100644 (file)
--- a/src/service.c
+++ b/src/service.c
@@ -3408,12 +3408,8 @@ static connman_bool_t auto_connect_service(GSequenceIter* iter,
                        return FALSE;
                }
 
-               if (is_connected(service) == TRUE) {
-                       if (preferred == TRUE && service->state !=
-                                       CONNMAN_SERVICE_STATE_ONLINE)
-                               goto next_service;
+               if (is_connected(service) == TRUE)
                        return TRUE;
-               }
 
                if (is_ignore(service) == FALSE && service->state ==
                                CONNMAN_SERVICE_STATE_IDLE)