Error checking in passphrase decryption method. 03/252403/1
authorNiraj Kumar Goit <niraj.g@samsung.com>
Wed, 27 Jan 2021 13:44:08 +0000 (19:14 +0530)
committerNiraj Kumar Goit <niraj.g@samsung.com>
Wed, 27 Jan 2021 13:48:42 +0000 (19:18 +0530)
If Dbus fails to append argument in dbus-message,
do not call a dbus method to decrypt passphrase.

Change-Id: Ic3b63ea9e6827ca1bf3753d750026119ec1bfd1a
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
gsupplicant/supplicant.c
packaging/connman.spec

index 02e6a62..cfdb183 100755 (executable)
@@ -7485,8 +7485,16 @@ static int send_decryption_request(const char *passphrase,
        if (!msg)
                return -EINVAL;
 
+#if defined TIZEN_EXT
+       if (!dbus_message_append_args(msg, DBUS_TYPE_STRING, &passphrase,
+                                                       DBUS_TYPE_INVALID)) {
+               SUPPLICANT_DBG("Could not fulfill decryption request");
+               return -ENOMEM;
+       }
+#else
        dbus_message_append_args(msg, DBUS_TYPE_STRING, &passphrase,
                                                        DBUS_TYPE_INVALID);
+#endif
 
        if (!dbus_connection_send_with_reply(connection, msg,
                                &call, DBUS_TIMEOUT_USE_DEFAULT)) {
index f1a29fa..aa1cfbb 100644 (file)
@@ -6,7 +6,7 @@
 
 Name:           connman
 Version:        1.38
-Release:        3
+Release:        4
 License:        GPL-2.0+
 Summary:        Connection Manager
 Url:            http://connman.net