service: Update service order when changing the favorite flag

If the service order is not changed at the same time as the favorite
status, the service may stay on top of the service list despite not
being a favorite anymore.

Patch based on an initial fix from Danny Jeongseok Seo <s.seo@samsung.com>.

diff --git a/src/service.c b/src/service.c
index dc89078..c135f42 100644 (file)
--- a/src/service.c
+++ b/src/service.c
@@ -3797,6 +3797,7 @@ int __connman_service_set_favorite(struct connman_service *service,
                return -EALREADY;
 
        service->favorite = favorite;
+       service->order = __connman_service_get_order(service);
 
        favorite_changed(service);