Tizen: Check some telephony flags before active context
authorguoqiang.liu <guoqiang.liu@archermind.com>
Fri, 27 Dec 2013 06:22:52 +0000 (14:22 +0800)
committerZhang zhengguang <zhengguang.zhang@intel.com>
Thu, 31 Jul 2014 07:51:57 +0000 (15:51 +0800)
Telephony active maybe fail if data_allowed or ps_attached is false,
so check it before actived.

When data_allowed is false, if connman starts to auto connect 3G
service, it will result in 3G service auto connected fail, which
leads to it will not be auto connected next time.

Change-Id: Ibdd9c34fee7a612c1788a364c69550c4f7e79123
Signed-off-by: guoqiang.liu <guoqiang.liu@archermind.com>
plugins/telephony.c

index 63e7f6e..ea0bf65 100644 (file)
@@ -323,6 +323,7 @@ static int __network_connect(struct connman_network *network)
 {
        struct connman_device *device;
        struct telephony_modem *modem;
+       struct telephony_service *service;
 
        DBG("network %p", network);
 
@@ -334,9 +335,16 @@ static int __network_connect(struct connman_network *network)
        if (modem == NULL)
                return -ENODEV;
 
+       service = modem->s_service;
+       if (service == NULL)
+               return -ENOLINK;
+
        if (modem->powered == FALSE)
                return -ENOLINK;
 
+       if (modem->data_allowed == FALSE || service->ps_attached == FALSE)
+               return -ENOLINK;
+
        return __request_network_activate(network);
 }