dbind: remove call to atspi_dbus_connection_setup_with_g_main
authorMike Gorse <mgorse@suse.com>
Thu, 5 Sep 2013 23:58:44 +0000 (18:58 -0500)
committerMike Gorse <mgorse@suse.com>
Thu, 5 Sep 2013 23:58:44 +0000 (18:58 -0500)
dbind isn't currently running a GMainLoop, so it shouldn't call
atspi_dbus_connection_setup_with_g_main, and calling this is harmful if
it is being called from a context other than the default context, since
D-Bus messages will no longer be delivered.

https://bugzilla.gnome.org/show_bug.cgi?id=707218

dbind/dbind.c

index d85a9e5..98467e6 100644 (file)
@@ -86,7 +86,6 @@ dbind_send_and_allow_reentry (DBusConnection * bus, DBusMessage * message, DBusE
 
   closure = g_new0 (SpiReentrantCallClosure, 1);
   closure->reply = NULL;
-  atspi_dbus_connection_setup_with_g_main(bus, NULL);
   if (!dbus_connection_send_with_reply (bus, message, &pending, dbind_timeout)
       || !pending)
     {