Piotr Byszewski [Fri, 17 Mar 2023 09:13:19 +0000 (10:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I4eba9295f92ef2d97d4ab84a00859e8434135ca7
Slawomir Cygan [Fri, 17 Feb 2023 11:58:04 +0000 (12:58 +0100)]
Do not check framework-provided VK1.3.robustImageAccess feature
In
f7a8ccc2 the value of robustImageAccess reported and requested by the
framework was forced to be always-FALSE, as it had potential overhead
on some implementations.
However, the extension support check for VK_EXT_image_robustness
extension was still relying on it, so related tests are now unrunnable
- they always return not supported.
As related tests seem to do own feature checks and custom device creation,
it looks safe to remove checking for feature from extension support check.
VK-GL-CTS Issue: 4241
Components: Vulkan, Framework
Affects:
dEQP-VK.robustness.pipeline_robustness.image_robustness.*
dEQP-VK.robustness.image_robustness.*
dEQP-VK.*
Change-Id: I3f9f9c09ce271a965e2a8625ce010b9efd1abc34
Trevor David Black [Fri, 3 Mar 2023 07:06:29 +0000 (07:06 +0000)]
Add RISC-V 64 bit support
Android is adding RISC-V support to AOSP, but only for 64-bit RISC-V.
(We've only added the 32-bit constants for completeness, should others
want them.)
Signed-off-by: Mao Han <han_mao@linux.alibaba.com>
Components: Framework, Vulkan, AOSP
Google bug:
262585507
Change-Id: Ib818315bb3aa0fe6ebcf82fac846be9a60198e04
Piotr Byszewski [Thu, 16 Mar 2023 18:05:34 +0000 (19:05 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I45f0854b2c181a82ba3755012effd9dfd6a54a4b
Piotr Byszewski [Thu, 16 Mar 2023 17:20:06 +0000 (18:20 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I358abfad8a9129de0a9c13f1d58aac8e28ed873a
Ricardo Garcia [Thu, 23 Feb 2023 15:03:25 +0000 (16:03 +0100)]
Check conservativeRasterizationPostDepthCoverage in affected tests
When using both conservative rasterization and post depth coverage, the
conservative rasterization property mentioned above indicates if the
functionality for both can be combined.
Affects:
dEQP-VK.pipeline.*multisample*.conservative*post_depth_coverage*
VK-GL-CTS issue: 4298
Components: Vulkan
Change-Id: I988a5f44956ab9ba40ab734bf2c078b73686d5a8
ziga-lunarg [Mon, 6 Mar 2023 14:07:02 +0000 (15:07 +0100)]
Fix shader interface mismatch in pipeline cache tests
Geometry shaders declared gl_PerVertex input, but the vertex shader does
not have such an output
Components: Vulkan
VK-GL-CTS issue: 4320
Affected tests:
dEQP-VK.pipeline.cache.*
Change-Id: Iaf5d567295f6216848663a28696f8b7dddb71020
ziga-lunarg [Sun, 5 Mar 2023 22:05:53 +0000 (23:05 +0100)]
Fix access mask in pipeline barriers in ray tracing tests
The dstAccessMask of pMemoryBarriers must only include access flags that
are supported by the pipeline stages in dstStageMask
Components: Vulkan
VK-GL-CTS issue: 4319
Affected tests:
dEQP-VK.ray_tracing_pipeline.large_shader_set.*
Change-Id: I633404e9fccd5651ddf4d838961bddd7cc60c32f
ziga-lunarg [Sun, 5 Mar 2023 13:38:25 +0000 (14:38 +0100)]
Fix stencil op in render pass stencil read only tests
If depth stencil attachment is in a read-only layout for the stencil
aspect and stencil test is enabled, all stencil ops must be
KV_STENCIL_OP_KEEP
Components: Vulkan
VK-GL-CTS issue: 4317
Affected tests:
dEQP-VK.renderpass.*
Change-Id: I1ba6dcb11525c600d42e1653b0aa347e67117adf
Piotr Byszewski [Fri, 10 Mar 2023 09:04:31 +0000 (10:04 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Id91e63c7348a5b4d868286bd2a80d6b155a81772
ziga-lunarg [Mon, 27 Feb 2023 15:01:56 +0000 (16:01 +0100)]
Fix global priority tests
Extensions VK_KHR_global_priority and VK_EXT_global_priority behave
differently, this test was once changed to fix the test using the
KHR extension, but it broke the test using EXT
The structs from global priority query must only be used with the KHR
version of the test
Components: Vulkan
VK-GL-CTS issue: 3898
Affected tests:
dEQP-VK.api.device_init.create_device_global_priority*
Change-Id: I906d8f9d7593f49533eb73c8faac4920dc9ce0c8
Piotr Byszewski [Fri, 10 Mar 2023 08:35:41 +0000 (09:35 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I67d7c74c40ab4c824c1841d64b601f1c2e1ed5a1
Piotr Byszewski [Thu, 9 Mar 2023 18:04:52 +0000 (19:04 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I0e58080147d67fd4b4dc8c6ce699fcf0975462fa
ziga-lunarg [Sun, 19 Feb 2023 12:27:26 +0000 (13:27 +0100)]
Fix checking support in texture filtering tests
The tests use mipmaps even if the test parameter for mipmaps is false
and the check support function does not do that
Components: Vulkan
VK-GL-CTS issue: 4294
Affected tests:
dEQP-VK.texture.filtering.2d_array.*
Change-Id: Iabd33803fc952f3ea4c7598674fd9f58b53070d4
Marcin Kańtoch [Thu, 16 Feb 2023 16:45:33 +0000 (17:45 +0100)]
Wrong assumption in robustness tests
Accept cases, such as <0.0f, 123.0f>, <123.0f, 0.0f>
for out of bounds memory, as those can be correctly
generated by the compiler.
VK-GL-CTS issue: 4288
Components: Vulkan
Affects:
dEQP-VK.robustness.robustness2.*
Change-Id: If54aedf4277d93b404056274e397e7f73c05872b
Matthew Netsch [Fri, 24 Feb 2023 16:18:56 +0000 (08:18 -0800)]
Fix timeout case in vktSynchronizationTimelineSemaphoreTests
Loop was inverted and race condition on error status.
Components: Vulkan
VK-GL-CTS Issue: 4282
Affects:
dEQP-VK.synchronization*.timeline_semaphore.wait.poll*
Change-Id: I8811dbcbdc34130c8bf4ced7e4e3013ca411da05
Piotr Byszewski [Fri, 3 Mar 2023 13:31:56 +0000 (14:31 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Iafc6fd04ac57cd732c62958dc372bd94128572b1
Piotr Byszewski [Fri, 3 Mar 2023 12:37:25 +0000 (13:37 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Idd791399ad26c7817670c730f215978cdaf0831f
Piotr Byszewski [Fri, 3 Mar 2023 12:06:59 +0000 (13:06 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I2cdda0aa78f3796624c037050f5fad0cbf757575
Piotr Byszewski [Fri, 24 Feb 2023 11:08:48 +0000 (12:08 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I0b02b4d8d1527d7a67ef6bd20cc85247a74f14d3
aitor_lunarg [Mon, 16 Jan 2023 22:59:34 +0000 (23:59 +0100)]
Fix query_present_modes_surfaceless tests
Tests expected to have same values for null surface and non-null
surfaces when retrieving present modes which is not correct.
When retrieving present modes with null surfaces, retrieved modes
will be a subset of all modes present in all surfaces for version 1.
For version 2, they can either be FIFO_KHR, SHARED_DEMAND_REFRESH_KHR
and SHARED_CONTINUOUS_REFRESH_KHR.
Affects:
dEQP-VK.wsi.*.surface.query_present_modes_surfaceless
Components: Vulkan
VK-GL-CTS issue: 4221
Change-Id: I79be6e8537184572ab164a7216e65d7e2f60bc42
Ricardo Garcia [Fri, 17 Feb 2023 08:33:39 +0000 (09:33 +0100)]
Fix overlapping mutable descriptor types
Some mutable decriptor test variants create pools with several mutable
descriptor entries with overlapping types, which is forbidden by the
spec and results in VUID-VkDescriptorPoolCreateInfo-pPoolSizes-04787.
Affects:
dEQP-VK.binding_model.mutable_descriptor.single_and_array.*
Components: Vulkan
VK-GL-CTS issue: 4289
Change-Id: Ia4274a6f13c52257c0e84e8711a8d883dab0cc36
Hyunjun Ko [Wed, 1 Feb 2023 06:25:19 +0000 (15:25 +0900)]
Pass fragment shading rate info to pre rasterization shader state
[Note]
This is a backporting patch, that landed already on the branch 1.3.4
and main. But the issue still exist on the branch 1.3.2/1.3.3, so I
create this CL that needs to propagate only to 1.3.3.
Fragment shading rate info needs to be passed both as part of the
pre-rasterization shader state and as part of the fragment shader state
when creating pipelines, and it needs to be consistent in both cases.
The graphics pipeline library utilities were only passing that
information as part of the fragment shader state.
Affects:
dEQP-VK.fragment_shading_rate.*.misc_tests.*
dEQP-VK.fragment_shading_rate.*.basic.*
dEQP-VK.pipeline.*.mixed_attachment_samples.*
dEQP-VK.*.sample_locations_ext.*
dEQP-VK.pipeline.*.multisample_with_fragment_shading_rate.*
Components: Vulkan
VK-GL-CTS issue: 4006
Change-Id: I4c01a7836ed45f513f166e787d1e709c9a612018
Piotr Byszewski [Mon, 13 Feb 2023 09:02:13 +0000 (10:02 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Ic16c14e074d2cab860c5b07bc9c2b4131e0ef749
James Fitzpatrick [Thu, 19 Jan 2023 15:29:58 +0000 (15:29 +0000)]
Disable image robustness by default
Image robustness was being disabled on the default device due to
robustness potentially having
However, when VK_EXT_image_robustness was promoted into Vulkan 1.3
the feature was also added to the 1.3 rollup structure
(VkPhysicalDeviceVulkan1p3Features).
The feature in the 1.3 rollup structure was not being disabled, leading
to robustImageAccess being enabled on any device supporting 1.3
Affects: dEQP-VK.*
Components: vulkan, framework
VK-GL-CTS issue: 4241
Change-Id: I2910fab278a3fd56233db0cee754e9be8372df82
Piotr Byszewski [Fri, 10 Feb 2023 17:47:44 +0000 (18:47 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ib344bfdf712d93068f83173623ab06d6824699a7
Piotr Byszewski [Fri, 10 Feb 2023 17:28:43 +0000 (18:28 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ie5e02bf822672fab279d37c028fb66ced1aeae48
Maciej Jurga [Wed, 25 Jan 2023 08:36:52 +0000 (09:36 +0100)]
Change HLSL to avoid nested runtimeArray in SPIR-V
Replace a structure used in RWStructuredBuffer by HLSL tessellation
evaluation shader with two RWStructuredBuffers of a basic type.
Old structure had a dynamic length array member, that caused glslang to
produce invalid SPIR-V with nested runtimeArray decoration.
Components: Vulkan
VK-GL-CTS issue: 2697
Affected tests:
dEQP-VK.tessellation.fractional_spacing.*
Change-Id: I4b55ca3688289b6ca22fa642972dc28e11a5659f
Hyunjun Ko [Mon, 30 Jan 2023 07:51:43 +0000 (16:51 +0900)]
Fix a bunch of validation errors of pipeline library tests.
Fixes:
VUID-VkGraphicsPipelineCreateInfo-flags-06608
VUID-VkGraphicsPipelineLibraryCreateInfoEXT-flags-requiredbitmask
VUID-VkGraphicsPipelineCreateInfo-renderpass-06631
VUID-vkCmdPipelineBarrier-srcAccessMask-02815
VUID-vkCmdPipelineBarrier-dstAccessMask-02816
UNASSIGNED-CoreValidation-Shader-InputNotProduced
VUID-vkCmdDraw-None-04007
VUID-vkCmdDraw-None-02721
Also removes 2 tests, trying to create a pipeline library with all
pipeline states, which violates VUID-VkGraphicsPipelineCreateInfo-flags-06608.
Affects:
dEQP-VK.pipeline.pipeline_library.graphics_library.*
Removed tests:
dEQP-VK.pipeline.pipeline_library.graphics_library.fast.0_1_1_1_1
dEQP-VK.pipeline.pipeline_library.graphics_library.optimize.0_1_1_1_1
VK-GL-CTS Issue: 4255
Components: Vulkan
Change-Id: I0ed2fa28cc5626aeee60f08527a7467428354d4a
Piotr Byszewski [Fri, 3 Feb 2023 06:14:37 +0000 (07:14 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I2f773b33feb6c9c55e4f2692c800d846280e0e90
Piotr Byszewski [Thu, 2 Feb 2023 19:26:04 +0000 (20:26 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ic7b88eb0135468ea8b013fff65e216a0bc945a6b
Piotr Byszewski [Thu, 2 Feb 2023 18:23:39 +0000 (19:23 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I4ec95db96541e01f4e47d3fe1abdd3f9e305adbb
Joe Withers [Mon, 30 Jan 2023 17:32:24 +0000 (17:32 +0000)]
Fix tolerance values when VK_COMPONENT_SWIZZLE_ONE is in use
Tolerance values were being increased unnecessarily for tests using
VK_COMPONENT_SWIZZLE_ONE.
This change overwrites any SWIZZLE_ONE with SWIZZLE_ZERO when applying
a swizzle to the threshold values, to maintain a strict tolerance.
Affects: dEQP-VK.pipeline.sampler.border_swizzle.*
Components: Vulkan
Change-Id: Ie72e4a97e502bdbb74ea412951f5a9481434d489
Charles Johnston [Thu, 19 Jan 2023 15:58:04 +0000 (10:58 -0500)]
Enable CTS log files to exceed 2GB on 32-bit Linux build
Components: Framework
VK-GL-CTS issue: 4238
Change-Id: Ie9c58364f0bb44c3b2a15a71585d4801d0b12063
Charlie Turner [Mon, 23 Jan 2023 13:35:26 +0000 (13:35 +0000)]
Prevent warnings from Amber failing the CTS build
With clang++-16, I'm seeing lots of cases like,
/home/cturner/src/vk-gl-cts/external/amber/src/src/float16_helper.cc:66:42: error: unchecked operation on raw buffer in expression [-Werror,-Wunsafe-buffer-usage]
uint32_t sign = (static_cast<uint32_t>(value[1]) & 0x80) << 24U;
Inhibit all warning messages for Clang, GCC & MSVC.
Components: Framework, Vulkan
Change-Id: I1910780048d8828a61733a5f5f36404f8a8184b0
ziga-lunarg [Tue, 17 Jan 2023 11:31:56 +0000 (12:31 +0100)]
Fix colorAttachmentCount mismatch in stencil tests
pColorBlendState::attachmentCount must match colorAttachmentCount of the
subpass used in the pipeline
Components: Vulkan
VK-GL-CTS issue: 4229
Affected tests:
dEQP-VK.pipeline.*.stencil.*
Change-Id: I1656cda0af45ae3df65c25790e360a17863273d4
Piotr Byszewski [Fri, 27 Jan 2023 11:58:28 +0000 (12:58 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Ib94de3bf6ded8ac215a706e0005631d397fce704
Piotr Byszewski [Fri, 27 Jan 2023 10:30:35 +0000 (11:30 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ic6015e95ad8e7d411948ec7ef1ccaf33081212f7
ziga-lunarg [Fri, 6 Jan 2023 17:09:46 +0000 (18:09 +0100)]
Fix rgba10x6 feature check in texture filtering tests
If VK_IMAGE_USAGE_SAMPLED_BIT is used when creating the image
VkSamplerYcbcrConversionInfo is required in the pNext chain, if format
is VK_FORMAT_R10XgG10X6B10X6A10X6_UNORM_4PACK16 and
formatRgba10x6WithoutYCbCrSampler feature is not enabled
Components: Vulkan
VK-GL-CTS issue: 4206
Affected tests:
dEQP-VK.texture.filtering.*
Change-Id: I296ac69902f87b301f4e2930d28b171e8ce02a13
ziga-lunarg [Fri, 6 Jan 2023 16:34:34 +0000 (17:34 +0100)]
Add missing support check in texture filtering with rgba10x6 format
Feature formatRgba10x6WithoutYCbCrSampler must be enabled when
VK_FORMAT_R10X6G10X6B10X6A10X6_UNORM_4PACK16 is used in these tests,
because more than 1 mip level is used and only formats which do not
require sampler YCbCR conversion can be used
Components: Vulkan
VK-GL-CTS issue: 4205
Affected tests:
dEQP-VK.texture.filtering.cube.*
Change-Id: I3bdd286af2d0f2c19443e5d64304c69e43a43095
Piotr Byszewski [Fri, 27 Jan 2023 08:48:28 +0000 (09:48 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I29ea16db0e7ddc2b374888f41ed07523b233aedb
ziga-lunarg [Sun, 15 Jan 2023 11:47:18 +0000 (12:47 +0100)]
Fix image barrier in ray tracing pipeline build tests
Use the correct combination of access mask and pipeline stage
Components: Vulkan
VK-GL-CTS issue: 4202
Affected tests:
dEQP-VK.ray_tracing_pipeline.build.*
Change-Id: I185c3787b6bfa24c79f5fbd063fc041d000ae0f4
Hyunjun Ko [Fri, 20 Jan 2023 02:11:02 +0000 (11:11 +0900)]
Do not allow to call vkSetEvent after submission, which is invalid.
The spec says:
"If a command buffer submission waits for any events to be signaled,
the application must ensure that command buffer submissions will be
able to complete without any subsequent operations by the application.
Events signaled by the host must be signaled before the command buffer
waits on those events."
This means it's not valid to signal an event on the host after submission
of a command buffer containing a wait for the event. Also it forces the
command buffer to stop for an unknown amount of time, as much as the time
needed for the host to signal the event with vkSetEvent.
However there were some CTS tests doing like this, which should be
fixed.
For vktApiExternalMemoryTests.cpp,
There was a vkSetEvent call after submission to hold a command to be
executed before signaling to get a native file descriptor, which is
not valid. So the tests should allow to get -1. Also we do an atomic calculation
to avoid singalling right after submit when trying to get a native fd.
The simple atomic calculation is evaluated to take about 10ms.
For vktApiExternalMemoryTests.cpp and vktMemoryExternalMemoryHostTests.cpp,
replace vkSetEvent with timeline semaphore to signal from the host.
Affects:
dEQP-VK.api.external.semaphore.*
dEQP-VK.api.external.fence.*
dEQP-VK.api.command_buffers.secondary_execute_twice
dEQP-VK.memory.external_memory_host.synchronization.synchronization
VK-GL-CTS Issue: 4075
Components: Vulkan
Change-Id: I5544bb15a418bbbbd6552ca04bec673a56ca3109
Sviatoslav Peleshko [Thu, 5 Jan 2023 23:40:46 +0000 (01:40 +0200)]
Add missing buffer memory flush
We do a memcpy to the buffer, but don't flush it. If we don't use
host-coherent memory for this buffer it might sometimes lead to
corruption (when we later invalidate the buffer's memory to get
results from the shader).
Components: Vulkan
Affected tests:
dEQP-VK.query_pool.statistics_query.compute_shader_invocations.*
dEQP-VK.query_pool.statistics_query.*.compute_shader_invocations.*
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Change-Id: I2f9491d6cacf39fe6a00d7624e2aa474615421ce
Connor Abbott [Tue, 29 Nov 2022 11:17:17 +0000 (12:17 +0100)]
Use correct extent for 1D compute texel_view_compatible tests
We weren't sanitizing the size in the parameters, resulting in
copyDataToImage() passing an extent with a non-1 height to when
uploading to a 1D image. Sanitize fullSize, and remove a case where
where we were workaround it not being sanitized.
Components: Vulkan
Affects: dEQP-VK.image.texel_view_compatible.compute.basic.1d_image.*
VK-GL-CTS Issue: 4143
Change-Id: Icdb50c09137a947f47b1afc7426e53e73c31f689
James Fitzpatrick [Mon, 9 Jan 2023 15:22:38 +0000 (15:22 +0000)]
Allow sample mask test after sample counting
After vulkan!5640 it is now legal for sample mask test to be executed
after sample counting when Early Fragment Tests is enabled.
Update the early fragment tests with sample counting to allow for this
behaviour by reporting a Quality Warning if the sample mask is ignored
when calcuating the returned sample count.
Affects: dEQP-VK.fragment_operations.early_fragment.sample_count_early_fragment_tests_depth_*
Components: vulkan
VK-GL-CTS issue: 4218
Change-Id: I61ca28f6570e1835b19c03ae1b1d93cad0228190
Piotr Byszewski [Fri, 20 Jan 2023 16:05:14 +0000 (17:05 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Ie8b2a9e9b203ff93bd2c6f30c796bf6f560a9c40
Piotr Byszewski [Fri, 20 Jan 2023 12:48:26 +0000 (13:48 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Iaa91df30fc4231c3a428fef1c74c8d9aa72720ba
Piotr Byszewski [Fri, 20 Jan 2023 10:18:18 +0000 (11:18 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I40db0dabbedb2e8245c3597bec80832a47f1658d
Slawomir Cygan [Thu, 12 Jan 2023 15:27:44 +0000 (16:27 +0100)]
Fix merge error in FSR srlayered tests
Reapply last chunk from
853897a8722 which seems to
have been broken in a merge: layercount value was passed
instead of viewFormatCount.
This is fixes a regression introduced by 10618, which was exposed
after being promoted to vulkan-cts-1.2.8+.
Components: Vulkan
VK-GL-CTS Issue: 4224
VK-GL-CTS Issue: 4226
Affects: dEQP-VK.fragment_shading_rate.*
Change-Id: Ib8f5b180368fe9bf3c32f349c2475a4932f30fbf
Piotr Byszewski [Thu, 19 Jan 2023 17:59:29 +0000 (18:59 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Iaae2490f0ec3069759a7660dee175cfdc3668622
Aitor Camacho [Tue, 3 Jan 2023 18:25:23 +0000 (19:25 +0100)]
Update scripts for Android build
- Use d8 instead of dx due to deprecation
- Use apksigner instead of jarsigner for signature scheme v2 required by newer SDKs
- Move apk signing to be last step (required for signature scheme v2)
- Force uncompressed arsc files (required for SDK versions 30 and up)
- Add '--tool-api' argument for selecting build tools version
- Add permission for reading external storage in manifest
VK-GL-CTS Issue: 4163
Components: Framework
Change-Id: Iea4429f861148168ffe680cdf9a497cb467b8d6a
Piotr Byszewski [Tue, 17 Jan 2023 09:43:42 +0000 (10:43 +0100)]
Fix merge mistake related to android/*/*.txt files
In recent merge from 1.3.1 to 1.3.2 branch a mistake was made
that affected five android related txt files. This change
restores those files to content before the merge.
Components: Vulkan
VK-GL-CTS issue: 4228
Removed tests:
dEQP-VK.*
Change-Id: I51cb8a3869883621edd8e3af4c2863adfd8739ba
Ricardo Garcia [Tue, 10 Jan 2023 11:01:08 +0000 (12:01 +0100)]
Fix color blend state in multisample mixed count tests
Some test variants were passing a null color blend attachment state on
pipeline creation, when the subpass was being created with one color
attachment.
Affects:
dEQP-VK.pipeline.*.multisample.mixed_count.*
VK-GL-CTS issue: 4208
Components: Vulkan
Change-Id: I9e0c7a5be907baef3c2b7bb6286d92eaa6749a66
Piotr Byszewski [Sun, 15 Jan 2023 10:43:24 +0000 (11:43 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I8ca4c0773084ff7b66bf7378ee9b610c693f15c6
Dae Kim [Fri, 16 Dec 2022 11:43:24 +0000 (11:43 +0000)]
Fix bind-transfer synchronization in sparse texture tests
The copyBufferToImage() utility function submits a command buffer with a
copy-buffer-to-image transfer operation. The caller can optionally pass
a semaphore for the transfer to wait on, but the semaphore's wait flags
are set to VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT, which does not include
transfer operations.
As a consequence of this, the transfer operation may ignore the wait
semaphore. In the affected test set this means that the transfer may
happen before sparse bind operations are completed.
Affects: dEQP-VK.texture.*sparse*
Components: Vulkan
VK-GL-CTS issue: 4183
Change-Id: Ia0f0c721e492703301440dbfcf07ed6495fddb1e
Piotr Byszewski [Fri, 13 Jan 2023 18:24:46 +0000 (19:24 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Icc5dc1c0cbfd798e6df0e7b88d4830e1549a4126
Piotr Byszewski [Fri, 13 Jan 2023 16:21:02 +0000 (17:21 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I2142832024febea1baee33b1df04af6921edb846
Piotr Byszewski [Fri, 13 Jan 2023 12:34:18 +0000 (13:34 +0100)]
Remove duplicated test groups
While adding support for dynamic rendering to renderpass group
a mistake was made that added 3 groups with the same tests to both
renderpass2 group and legacy renderpass group.
This mistake was fixed on 1.3.1 branch but is present on 1.2.8
and 1.3.0. There is no need to execute same tests twice - this
change removes duplicates. This fix should be propagated only to
1.3.0.
Components: Vulkan
VK-GL-CTS issue: 4225
Removed tests:
dEQP-VK.renderpass.depth_stencil_resolve.*
dEQP-VK.renderpass.fragment_density_map.*
dEQP-VK.renderpass2.multiple_subpasses_multiple_command_buffers.test
Change-Id: I571e499ead038acf1744c356b884f2be966e3c15
ziga-lunarg [Thu, 22 Dec 2022 12:52:24 +0000 (13:52 +0100)]
Fix oldLayout in image barriers in copy and blit tests
The same barriers are used twice, but the oldLayout is not updated
Components: Vulkan
VK-GL-CTS issue: 4054
Affected tests:
dEQP-VK.api.copy_and_blit.*
Change-Id: I8fd622846a2c9ce840ec6bfb5a431ae66a5af06f
Piotr Byszewski [Fri, 13 Jan 2023 10:11:20 +0000 (11:11 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I1139cfa0a1d27a08bd6d3c72b2d65fd754edc886
ziga-lunarg [Fri, 16 Dec 2022 16:31:54 +0000 (17:31 +0100)]
Remove invalid separate_layouts tests on older branches
These tests were fixed, but only on 1.3.2 newer, they should be removed
on older branches
Components: Vulkan
VK-GL-CTS issue: 3527
Removed tests:
dEQP-VK.renderpass2.depth_stencil_resolve.*separate_layouts.*
Change-Id: I467ea14cc5c2eb26723cc9e2453ea5a11a1556b9
Amber [Tue, 3 Jan 2023 13:58:15 +0000 (14:58 +0100)]
Make depth_bias_triangle_list_point write to PointSize
VK-GL-CTS Issue: 4197
Components: Vulkan
Affect tests:
dEQP-VK.draw.renderpass.depth_bias.depth_bias_triangle_list_point
Change-Id: I21c223ff1e986c48fc90f97d21d472cfa713abdf
Piotr Byszewski [Sat, 7 Jan 2023 13:27:45 +0000 (14:27 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I1ed2965c43158b0131f340237dbebfcf5b2aaf5f
Piotr Byszewski [Sat, 7 Jan 2023 12:15:11 +0000 (13:15 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Ie8e4ee5b77cbea1aa87664a38a074f2381d2ea15
Piotr Byszewski [Sat, 7 Jan 2023 11:05:29 +0000 (12:05 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I7507fe1cee9b7bccdbfc4883f0ee6937c116b30a
Piotr Byszewski [Thu, 5 Jan 2023 18:12:20 +0000 (19:12 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Iea24c631e95fad0dbf694e67f141c243fda3a3d9
ziga-lunarg [Sat, 19 Nov 2022 22:46:51 +0000 (23:46 +0100)]
Fix 2d image views in fragment shading rate tests
If viewType is VK_IMAGE_VIEW_TYPE_2D then subresourceRange.layerCount
must be 1
Components: Vulkan
VK-GL-CTS issue: 4124
Affected tests:
dEQP-VK.fragment_shading_rate.*
Change-Id: I32db55ce0785a2d91c391625bfed312d5e7371f0
Slawomir Cygan [Mon, 14 Nov 2022 16:28:10 +0000 (17:28 +0100)]
Add randomized constants to shaders in compare_link_times test
Add some randomization to shaders in compare_link_times test
to get reproductible compilation times.
VK-GL-CTS Issue: 4109
Components: Vulkan
Affects:
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.timing.compare_link_times
Change-Id: Idbd38d611edc955916b2c756115702cccd16a7d8
ziga-lunarg [Sat, 10 Dec 2022 22:09:31 +0000 (23:09 +0100)]
Fix invalid framebuffer in compressed texture 3D tests
Framebuffer attachments must be created with viewType not equal to
VK_IMAGE_VIEW_TYPE_3D
Components: Vulkan
VK-GL-CTS issue: 4118
Affected tests:
dEQP-VK.texture.compressed_3D.*
Change-Id: I221fcc033266f8c344079f9ee9b1fa70c56d9dd9
ziga-lunarg [Mon, 5 Dec 2022 14:12:06 +0000 (15:12 +0100)]
Fix stencil op in depth bounds tests
If stencil attachment is in a read only layout and stencil test is
enabled, the stencil ops in VkPipelineDepthStencilStateCreateInfo must
be VK_STENCIL_OP_KEEP
Components: Vulkan
VK-GL-CTS issue: 4155
Affected tests:
dEQP-VK.dynamic_state.*.ds_state.depth_bounds_2*
Change-Id: Ifeb2ddca71e5cbd60afebd8d8b6dd77b5e7f2e9b
Friedrich Vock [Mon, 5 Dec 2022 08:13:06 +0000 (09:13 +0100)]
Fix result image format in RT pipeline flags test
Tests were using an rgba32i format (VK_FORMAT_R32G32B32A32_SINT) but
declaring it in the shader as r32i.
Affects:
dEQP-VK.ray_tracing_pipeline.pipeline_no_null_shaders_flag.*
Components: Vulkan
VK-GL-CTS issue: 4151
VK-GL-CTS public issue: 365
Change-Id: Ia9dbd97544fce8a29a4fe7270fc617981648032f
Charlie Turner [Wed, 23 Nov 2022 21:35:05 +0000 (21:35 +0000)]
Adds missing multisample state structs.
When compiling a fragment shader pipeline library, the fragment shader
state is defined by, among other state, the
VkPipelineMultisampleStateCreateInfo if sample shading is enabled.
In the affected tests, a fragment shader module was being compiled
which accessed builtins decorated with SampleId. This in turn enabled
sample shading, and in such cases, the
VkPipelineMultisampleStateCreateInfo is potentially required by
drivers for their internal logic. For this reason the spec mandates
the struct's inclusion in the fragment shader state when sample
shading is enabled.
Unfortunately it's not simple to change the GraphicsPipelineWrapper to
avoid this erroneous configuration, since in general it would require
parsing the SPIR-V to check if the fragment shader is accessing any
input builtins with the problematic decorations.
Instead a validation run was done over
dEQP-VK.pipeline.pipeline_library.* to ensure there aren't other
callsites falling into this trap, and no other cases were found.
Components: Vulkan
Affects:
dEQP-VK.pipeline.pipeline_library.multisample.*
VK-GL-CTS issue: 3975
Change-Id: I33a6b391af800eb6c23d846b70a4aac2387a74e3
Piotr Byszewski [Fri, 16 Dec 2022 14:13:57 +0000 (15:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I2d8979c34c4b9a18509e5c00ba123fa2a7520451
Andrew Fobel [Mon, 5 Dec 2022 21:16:01 +0000 (16:16 -0500)]
Fix VK_KHR_global_priority tests
Use enabledExtensions to properly enable VK_EXT_global_priority_query
along with passing the globalPriorityQueryFeatures struct.
Components: Vulkan
VK-GL-CTS issue: 4157
Affected tests:
dEQP-VK.api.device_init.create_device_global_priority*
Change-Id: Ib024f187f835914bbcb94e42a40d60a32fed0f99
Piers Daniell [Mon, 5 Dec 2022 22:01:43 +0000 (15:01 -0700)]
Work around deArraySizeHelper deficiency with multi-dimension arrays
This fixes a compilation issue with some compilers with deArraySizeHelper
and implicitly sized multi-dimensional arrays.
Affects:
Compilation only.
Components: Framework, Vulkan
VK-GL-CTS issue: 4158
Change-Id: Ie200647f34096b54544aff7f8d82b1eefabbd586
Piotr Byszewski [Fri, 16 Dec 2022 12:35:27 +0000 (13:35 +0100)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Id3cf5e258bce8b7aec13bc44abdada774159136b
Piotr Byszewski [Fri, 16 Dec 2022 11:15:18 +0000 (12:15 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ifdc6f7c08ccb5f65d44e406a7dc6ea6866102ad5
Piotr Byszewski [Fri, 16 Dec 2022 08:42:48 +0000 (09:42 +0100)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Ib14adccc08aa0dd8767e6dea0199e021885d292d
ziga-lunarg [Sat, 19 Nov 2022 13:02:59 +0000 (14:02 +0100)]
Fix errors in sparse resources tests
VK_EXT_shader_image_atomic_int64 extension must be enabled on the device
if used
Feature structs from non-enabled extensions must not be passed to
VkDeviceCreateInfo pNext
Checks if image formats are supported are missing
Components: Vulkan
VK-GL-CTS issue: 4122
Affected tests:
dEQP-VK.sparse_resources.shader_intrinsics.*
Change-Id: I4fcac8eae1d53826d5ef5f8a7dcc04bfe95f7360
ziga-lunarg [Fri, 18 Nov 2022 18:49:35 +0000 (19:49 +0100)]
Fix subpass dependency dstStageMask in shader_fragment_mask tests
Stage VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUT_BIT must be included if
access mask is VK_ACCESS_COLOR_ATTACHMENT_READ_BIT
Components: Vulkan
VK-GL-CTS issue: 4120
Affected tests:
dEQP-VK.pipeline.*.shader_fragment_mask.*
Change-Id: Iea2a62ff5781c50ad39d707a8eb0f1f4ce344f48
Yun Shu [Mon, 5 Dec 2022 08:20:43 +0000 (16:20 +0800)]
Set correct pipeline barrier between clear image and trace ray
The image is cleared with fixed value, then used as write destination
in ray tracing shaders. The pipeline barrier set for the image is
incorrect between clear command and trace ray command.
Affects:
dEQP-VK.ray_tracing_pipeline.large_shader_set.*
Components: Vulkan
VK-GL-CTS issue: 4137
Change-Id: I41dd55d51ea995c4c878e053f6d617b2e38ba5b1
Amber [Mon, 21 Nov 2022 10:54:07 +0000 (11:54 +0100)]
Add check for the return value of vkGetPhysicalDeviceImageFormatProperties2
Also do not attempt to create images for depth/stencil usage using color formats.
Components: Vulkan
VK-GL-CTS issue: 4125
Affected tests:
dEQP-VK.api.external.memory.dma_buf.suballocated.image.info
Change-Id: If1f41b967d03f1b862c85277d6fe30b20ab1a110
Hyunjun Ko [Tue, 29 Nov 2022 05:09:41 +0000 (14:09 +0900)]
Fix to get supported depth format instead of using VK_FORMAT_D32_SFLOAT
always.
Affets:
dEQP-VK.pipeline.pipeline_library.graphics_library.*
VK-GL-CTS Issue: 4142
Components: Vulkan
Change-Id: Ia8cb48061acd4813aecabb050c775a27ce1b4926
Matthew Netsch [Thu, 8 Dec 2022 19:57:31 +0000 (19:57 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I193ea9253a0d2d405e25d951ba1564f5ad805f3b
Matthew Netsch [Thu, 8 Dec 2022 18:58:13 +0000 (18:58 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Icc350abe29e7c1545a65d99884a281cd63239fc4
Matthew Netsch [Thu, 8 Dec 2022 18:30:33 +0000 (18:30 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ibfc5624676bae49d9630978494cdfdc660a0fba4
Matthew Netsch [Thu, 8 Dec 2022 18:01:39 +0000 (18:01 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: If5512ea90e2442bc7304502d78cc3b1333f53479
ziga-lunarg [Sun, 4 Dec 2022 20:48:26 +0000 (21:48 +0100)]
Write gl_PointSize in depth tests
Some depth tests use VK_PRIMITIVE_TOPOLOGY_POINT_LIST but the shaders
don't write the point size
Components: Vulkan
VK-GL-CTS issue: 4153
Affected tests:
dEQP-VK.pipeline.*.depth.*
Change-Id: Idaa9ea65f7c43ca02d7780d1825d4558b712a133
ziga-lunarg [Mon, 5 Dec 2022 15:34:50 +0000 (16:34 +0100)]
Add check if format is supported in external memory host tests
Format properties for format used for color attachment must contain
VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT
Components: Vulkan
VK-GL-CTS issue: 4156
Affected tests:
dEQP-VK.memory.external_memory_host.bind_image_memory_and_render.*
Change-Id: Ib0346cbc849b94a5af67e5645cc057ca392f9b2f
ziga-lunarg [Fri, 18 Nov 2022 18:11:56 +0000 (19:11 +0100)]
Fix invalid framebuffer in compressed texture 3D tests
Framebuffer attachments must be created with viewType not equal to
VK_IMAGE_VIEW_TYPE_3D
Components: Vulkan
VK-GL-CTS issue: 4118
Affected tests:
dEQP-VK.texture.compressed_3D.*
Change-Id: I9ae036d02daa3579567bf514c70bf623a0bc9aa9
ziga-lunarg [Sat, 19 Nov 2022 19:06:44 +0000 (20:06 +0100)]
Fix flushing memory range in memory model shared tests
Each size of pMemRanges in vkFlushMappedMemoryRanges must be either a
multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or equal to the
size of memory
Components: Vulkan
VK-GL-CTS issue: 4123
Affected tests:
dEQP-VK.memory_model.shared.*
Change-Id: I0f3ea96736aa73eb92c7809c04297923d84e348c
Slawomir Cygan [Thu, 10 Nov 2022 16:12:05 +0000 (17:12 +0100)]
Use pipeline layout alongside with fragment shader stage
In pipeline libraries, pipeline layout is requried if fragment
shader is present in the pipeline.
Affects: dEQP-VK.pipeline.pipeline_library.graphics_library.misc.bind_null_descriptor_set.*
VK-GL-CTS Issue: 4096
Components: Vulkan
Change-Id: Ia70b0f18f497e2e9102e7748c87ea5e5092098bc
ziga-lunarg [Sat, 12 Nov 2022 00:13:43 +0000 (01:13 +0100)]
Fix color blend state color attachments in depth tests
The number of color attachment in pColorBLendState must match the number
of color attachment in the subpass when creating the pipeline
Components: Vulkan
VK-GL-CTS issue: 4058
Affected tests:
dEQP-VK.pipeline.*.depth.*
Change-Id: Ibce5ff044c0804218d56d452eea7973c4c3a2990
Matthew Netsch [Thu, 1 Dec 2022 18:29:04 +0000 (18:29 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I699095999ad69b1ce79e50c3db6a06410005bdb5
Matthew Netsch [Thu, 1 Dec 2022 17:33:11 +0000 (17:33 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Iacdc3192254c41c569dbad94d8025b936f93cc25
Matthew Netsch [Thu, 1 Dec 2022 17:05:02 +0000 (17:05 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I7a7605b2dffeaedac543e32d97f13f552d6ab68f
ziga-lunarg [Fri, 4 Nov 2022 22:56:17 +0000 (23:56 +0100)]
Re-add texture filtering tests with rgba10x6 format
These tests were removed when only the check for
formatRgba10x6WithoutYCbCrSampler feature was missing
Components: Vulkan
VK-GL-CTS issue: 3646
New tests:
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_linear
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_linear
Change-Id: Ida3cb9f1abd95f57908b9540c65605cbb1b40fa3
Matthew Netsch [Thu, 1 Dec 2022 16:37:27 +0000 (16:37 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I36f8b8142517f82d581ee2bc365a97ff37a63dc8
Hyunjun Ko [Wed, 23 Nov 2022 08:46:24 +0000 (17:46 +0900)]
Fix invalid usage of descriptorCount for inline uniform
blocks.
Affects:
dEQP-VK.binding_model.descriptorset_random.*.iublimit*
VK-GL-CTS Issue: 4115
Components: Vulkan
Change-Id: I649d86b859ca642b47c1fda4aa915e1d6616c898