Fix existing viewport_array bugs
authorDaniel Koch <dkoch@nvidia.com>
Mon, 12 Dec 2016 07:34:26 +0000 (02:34 -0500)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Tue, 13 Dec 2016 18:44:24 +0000 (13:44 -0500)
- was querying viewport instead of scissor box
- was requiring upper viewport bounds range of 32768

(these were pointed out by jputsman in previous review)

Affects tests: *.viewport_array.queries

Change-Id: I1914fd51cad1870ba91ef3380088aa20757ce29d

external/openglcts/modules/common/glcViewportArrayTests.cpp

index 92dd4e5..a3170a7 100644 (file)
@@ -1442,7 +1442,7 @@ tcu::TestNode::IterateResult Queries::iterate()
 
                for (GLint i = 0; i < max_viewports; ++i)
                {
-                       gl.getIntegeri_v(GL_VIEWPORT, i, &data[i * 4]);
+                       gl.getIntegeri_v(GL_SCISSOR_BOX, i, &data[i * 4]);
                        GLU_EXPECT_NO_ERROR(gl.getError(), "getIntegeri_v");
                }
 
@@ -1512,11 +1512,11 @@ tcu::TestNode::IterateResult Queries::iterate()
         *   at least [-32768, 32767];
         */
        {
-               if ((-32768.0f < viewport_bounds_range[0]) || (32768.0f > viewport_bounds_range[1]))
+               if ((-32768.0f < viewport_bounds_range[0]) || (32767.0f > viewport_bounds_range[1]))
                {
                        m_context.getTestContext().getLog()
                                << tcu::TestLog::Message << "Invalid VIEWPORT_BOUNDS_RANGE: " << viewport_bounds_range[0] << " : "
-                               << viewport_bounds_range[1] << " expected at least: -32768.0f : 32768.0f" << tcu::TestLog::EndMessage;
+                               << viewport_bounds_range[1] << " expected at least: -32768.0f : 32767.0f" << tcu::TestLog::EndMessage;
 
                        test_result = false;
                }