tools: env: fw_env: Fix unused-result warning
authorJaehoon Chung <jh80.chung@samsung.com>
Thu, 13 Oct 2022 08:41:21 +0000 (17:41 +0900)
committerTom Rini <trini@konsulko.com>
Thu, 8 Dec 2022 14:25:44 +0000 (09:25 -0500)
Fix unused-result warning about fread.

tools/env/fw_env.c: In function ‘find_nvmem_device’:
tools/env/fw_env.c:1751:3: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result]
 1751 |   fread(buf, sizeof(buf), 1, fp);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
tools/env/fw_env.c

index c251e2e..c9a8774 100644 (file)
@@ -1733,6 +1733,7 @@ static int find_nvmem_device(void)
 
        while (!nvmem && (dent = readdir(dir))) {
                FILE *fp;
+               size_t size;
 
                if (!strcmp(dent->d_name, ".") || !strcmp(dent->d_name, "..")) {
                        continue;
@@ -1748,7 +1749,14 @@ static int find_nvmem_device(void)
                        continue;
                }
 
-               fread(buf, sizeof(buf), 1, fp);
+               size = fread(buf, sizeof(buf), 1, fp);
+               if (size != 1) {
+                       fprintf(stderr,
+                               "read failed about %s\n", comp);
+                       fclose(fp);
+                       return -EIO;
+               }
+
 
                if (!strcmp(buf, "u-boot,env")) {
                        bytes = asprintf(&nvmem, "%s/%s/nvmem", path, dent->d_name);